* [PATCH] drm/i915: Check visibility in icl_build_plane_wm
@ 2019-06-14 10:39 Maarten Lankhorst
2019-06-14 11:58 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Maarten Lankhorst @ 2019-06-14 10:39 UTC (permalink / raw)
To: intel-gfx
When a planar YUV plane is configured, but the crtc is
marked inactive, we can end up with a linked plane without
visibility. Handle this by checking for visibility early,
instead of doing a WARN.
<4> [201.742919] ------------[ cut here ]------------
<4> [201.742920] WARN_ON(!intel_wm_plane_visible(crtc_state, plane_state))
<4> [201.742947] WARNING: CPU: 7 PID: 1268 at drivers/gpu/drm/i915/intel_pm.c:5068 skl_compute_wm+0x2be/0x10a0 [i915]
<4> [201.742948] Modules linked in: snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic i915 x86_pkg_temp_thermal snd_hda_intel coretemp snd_hda_codec mei_hdcp snd_hwdep snd_hda_core crct10dif_pclmul cdc_ether usbnet crc32_pclmul mii snd_pcm ghash_clmulni_intel mei_me mei prime_numbers
<4> [201.742958] CPU: 7 PID: 1268 Comm: kms_chamelium Tainted: G U 5.2.0-rc3-CI-CI_DRM_6216+ #1
<4> [201.742960] Hardware name: Intel Corporation Ice Lake Client Platform/IceLake U DDR4 SODIMM PD RVP TLC, BIOS ICLSFWR1.R00.3183.A00.1905020411 05/02/2019
<4> [201.742978] RIP: 0010:skl_compute_wm+0x2be/0x10a0 [i915]
<4> [201.742980] Code: 24 10 8b 92 fc 02 00 00 0f 85 ba 04 00 00 48 c7 c6 e0 38 2e a0 48 c7 c7 93 99 31 a0 89 54 24 20 48 89 44 24 08 e8 82 a2 f5 e0 <0f> 0b 8b 54 24 20 48 8b 44 24 08 48 8b 40 48 80 78 12 00 0f 85 76
<4> [201.742981] RSP: 0018:ffffc9000064f9a8 EFLAGS: 00010282
<4> [201.742983] RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000007
<4> [201.742984] RDX: 000000000000175c RSI: ffff8884934d48e0 RDI: ffffffff8212df49
<4> [201.742985] RBP: ffff888493408558 R08: 00000000b56dab44 R09: 0000000000000000
<4> [201.742986] R10: ffff88848be00000 R11: 0000000000000000 R12: ffff88849afd89f8
<4> [201.742987] R13: ffff88847eaf67e8 R14: ffff88848c344a88 R15: ffff88848be00000
<4> [201.742988] FS: 00007f4d9b60b700(0000) GS:ffff88849ff80000(0000) knlGS:0000000000000000
<4> [201.742989] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
<4> [201.742991] CR2: 00007f4d9b609ff8 CR3: 000000048c326006 CR4: 0000000000760ee0
<4> [201.742992] PKRU: 55555554
<4> [201.742993] Call Trace:
<4> [201.743021] ? intel_atomic_check+0x7b2/0x1440 [i915]
<4> [201.743026] ? __mutex_unlock_slowpath+0x46/0x2b0
<4> [201.743052] intel_atomic_check+0x7ca/0x1440 [i915]
<4> [201.743060] drm_atomic_check_only+0x55a/0x7f0
<4> [201.743064] drm_atomic_commit+0xe/0x50
<4> [201.743067] drm_atomic_connector_commit_dpms+0xe0/0xf0
<4> [201.743069] set_property_atomic+0xba/0x140
<4> [201.743075] drm_mode_obj_set_property_ioctl+0x111/0x1d0
<4> [201.743077] ? drm_dev_exit+0x8/0x40
<4> [201.743080] ? drm_connector_set_obj_prop+0x70/0x70
<4> [201.743082] drm_connector_property_set_ioctl+0x39/0x60
<4> [201.743084] drm_ioctl_kernel+0x83/0xf0
<4> [201.743087] drm_ioctl+0x2f3/0x3b0
<4> [201.743090] ? drm_connector_set_obj_prop+0x70/0x70
<4> [201.743096] ? lock_acquire+0xa6/0x1c0
<4> [201.743100] do_vfs_ioctl+0xa0/0x6e0
<4> [201.743103] ? __fget+0x10f/0x200
<4> [201.743105] ksys_ioctl+0x35/0x60
<4> [201.743108] __x64_sys_ioctl+0x11/0x20
<4> [201.743110] do_syscall_64+0x55/0x1c0
<4> [201.743112] entry_SYSCALL_64_after_hwframe+0x49/0xbe
<4> [201.743114] RIP: 0033:0x7f4da6c8d5d7
<4> [201.743115] Code: b3 66 90 48 8b 05 b1 48 2d 00 64 c7 00 26 00 00 00 48 c7 c0 ff ff ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 b8 10 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 81 48 2d 00 f7 d8 64 89 01 48
<4> [201.743116] RSP: 002b:00007f4d9b60aba8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
<4> [201.743118] RAX: ffffffffffffffda RBX: 00007f4d94001ac0 RCX: 00007f4da6c8d5d7
<4> [201.743119] RDX: 00007f4d9b60abe0 RSI: 00000000c01064ab RDI: 0000000000000005
<4> [201.743120] RBP: 00007f4d9b60abe0 R08: 00007f4d940015c0 R09: 00007f4d940015f0
<4> [201.743121] R10: 0000000000000055 R11: 0000000000000246 R12: 00000000c01064ab
<4> [201.743122] R13: 0000000000000005 R14: 0000000000000005 R15: 00007f4da7a2c0c7
<4> [201.743156] irq event stamp: 362
<4> [201.743162] hardirqs last enabled at (361): [<ffffffff8112862c>] vprintk_emit+0xcc/0x340
<4> [201.743168] hardirqs last disabled at (362): [<ffffffff810019e0>] trace_hardirqs_off_thunk+0x1a/0x1c
<4> [201.743174] softirqs last enabled at (0): [<ffffffff810abf78>] copy_process.part.6+0x4e8/0x1dc0
<4> [201.743178] softirqs last disabled at (0): [<0000000000000000>] 0x0
<4> [201.743243] WARNING: CPU: 7 PID: 1268 at drivers/gpu/drm/i915/intel_pm.c:5068 skl_compute_wm+0x2be/0x10a0 [i915]
<4> [201.743246] ---[ end trace 33e6703087376efa ]---
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110895
Testcase: kms_chamelium@hdmi-cmp-nv12
---
drivers/gpu/drm/i915/intel_pm.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 4e52dad84d64..e0e57de22388 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -5060,15 +5060,15 @@ static int icl_build_plane_wm(struct intel_crtc_state *crtc_state,
enum plane_id plane_id = to_intel_plane(plane_state->base.plane)->id;
int ret;
- /* Watermarks calculated in master */
- if (plane_state->slave)
+ /* Watermarks are calculated in master */
+ if (plane_state->slave ||
+ !intel_wm_plane_visible(crtc_state, plane_state))
return 0;
if (plane_state->linked_plane) {
const struct drm_framebuffer *fb = plane_state->base.fb;
enum plane_id y_plane_id = plane_state->linked_plane->id;
- WARN_ON(!intel_wm_plane_visible(crtc_state, plane_state));
WARN_ON(!fb->format->is_yuv ||
fb->format->num_planes == 1);
@@ -5081,7 +5081,7 @@ static int icl_build_plane_wm(struct intel_crtc_state *crtc_state,
plane_id, 1);
if (ret)
return ret;
- } else if (intel_wm_plane_visible(crtc_state, plane_state)) {
+ } else {
ret = skl_build_plane_wm_single(crtc_state, plane_state,
plane_id, 0);
if (ret)
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Check visibility in icl_build_plane_wm
2019-06-14 10:39 [PATCH] drm/i915: Check visibility in icl_build_plane_wm Maarten Lankhorst
@ 2019-06-14 11:58 ` Patchwork
2019-06-14 23:54 ` ✓ Fi.CI.BAT: success " Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2019-06-14 11:58 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Check visibility in icl_build_plane_wm
URL : https://patchwork.freedesktop.org/series/62098/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
534240f724bc drm/i915: Check visibility in icl_build_plane_wm
-:13: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#13:
<4> [201.742947] WARNING: CPU: 7 PID: 1268 at drivers/gpu/drm/i915/intel_pm.c:5068 skl_compute_wm+0x2be/0x10a0 [i915]
total: 0 errors, 1 warnings, 0 checks, 26 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Check visibility in icl_build_plane_wm
2019-06-14 10:39 [PATCH] drm/i915: Check visibility in icl_build_plane_wm Maarten Lankhorst
2019-06-14 11:58 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2019-06-14 23:54 ` Patchwork
2019-06-15 17:45 ` ✓ Fi.CI.IGT: " Patchwork
2019-06-17 12:34 ` [PATCH] " Ville Syrjälä
3 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2019-06-14 23:54 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Check visibility in icl_build_plane_wm
URL : https://patchwork.freedesktop.org/series/62098/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6271 -> Patchwork_13284
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13284/
Known issues
------------
Here are the changes found in Patchwork_13284 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_switch@basic-default:
- fi-icl-guc: [PASS][1] -> [INCOMPLETE][2] ([fdo#107713] / [fdo#108569])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6271/fi-icl-guc/igt@gem_ctx_switch@basic-default.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13284/fi-icl-guc/igt@gem_ctx_switch@basic-default.html
* igt@i915_selftest@live_contexts:
- fi-bdw-gvtdvm: [PASS][3] -> [DMESG-FAIL][4] ([fdo#110235])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6271/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13284/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html
#### Possible fixes ####
* igt@gem_exec_fence@basic-wait-default:
- fi-icl-u3: [DMESG-WARN][5] ([fdo#107724]) -> [PASS][6] +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6271/fi-icl-u3/igt@gem_exec_fence@basic-wait-default.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13284/fi-icl-u3/igt@gem_exec_fence@basic-wait-default.html
* igt@i915_module_load@reload:
- fi-blb-e6850: [INCOMPLETE][7] ([fdo#107718]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6271/fi-blb-e6850/igt@i915_module_load@reload.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13284/fi-blb-e6850/igt@i915_module_load@reload.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][9] ([fdo#109485]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6271/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13284/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485
[fdo#110235]: https://bugs.freedesktop.org/show_bug.cgi?id=110235
Participating hosts (53 -> 44)
------------------------------
Additional (1): fi-cml-u2
Missing (10): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-kbl-guc fi-ctg-p8600 fi-bdw-samus fi-byt-clapper fi-skl-6600u
Build changes
-------------
* Linux: CI_DRM_6271 -> Patchwork_13284
CI_DRM_6271: 7564ad5c5922b117e250665a5caf7c4a530dcf5f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5056: c7b717f0126374a02fc86de5eb5fb1f3e7b3335b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13284: 534240f724bc01b7e1e9252ca335510a757ba94c @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
534240f724bc drm/i915: Check visibility in icl_build_plane_wm
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13284/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: Check visibility in icl_build_plane_wm
2019-06-14 10:39 [PATCH] drm/i915: Check visibility in icl_build_plane_wm Maarten Lankhorst
2019-06-14 11:58 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-06-14 23:54 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2019-06-15 17:45 ` Patchwork
2019-06-17 12:34 ` [PATCH] " Ville Syrjälä
3 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2019-06-15 17:45 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Check visibility in icl_build_plane_wm
URL : https://patchwork.freedesktop.org/series/62098/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6271_full -> Patchwork_13284_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_13284_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@rcs0-s3:
- shard-kbl: [PASS][1] -> [DMESG-WARN][2] ([fdo#108566]) +4 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6271/shard-kbl2/igt@gem_ctx_isolation@rcs0-s3.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13284/shard-kbl2/igt@gem_ctx_isolation@rcs0-s3.html
- shard-apl: [PASS][3] -> [DMESG-WARN][4] ([fdo#108566]) +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6271/shard-apl2/igt@gem_ctx_isolation@rcs0-s3.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13284/shard-apl6/igt@gem_ctx_isolation@rcs0-s3.html
* igt@gem_eio@in-flight-external:
- shard-glk: [PASS][5] -> [DMESG-WARN][6] ([fdo#110913 ]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6271/shard-glk7/igt@gem_eio@in-flight-external.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13284/shard-glk6/igt@gem_eio@in-flight-external.html
* igt@gem_eio@suspend:
- shard-apl: [PASS][7] -> [DMESG-WARN][8] ([fdo#110913 ]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6271/shard-apl3/igt@gem_eio@suspend.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13284/shard-apl8/igt@gem_eio@suspend.html
* igt@gem_eio@wait-10ms:
- shard-kbl: [PASS][9] -> [DMESG-WARN][10] ([fdo#110913 ]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6271/shard-kbl6/igt@gem_eio@wait-10ms.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13284/shard-kbl6/igt@gem_eio@wait-10ms.html
* igt@gem_persistent_relocs@forked-faulting-reloc-thrashing:
- shard-skl: [PASS][11] -> [DMESG-WARN][12] ([fdo#110913 ]) +2 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6271/shard-skl1/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13284/shard-skl10/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
- shard-hsw: [PASS][13] -> [DMESG-WARN][14] ([fdo#110789] / [fdo#110913 ])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6271/shard-hsw5/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13284/shard-hsw5/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
* igt@gem_persistent_relocs@forked-interruptible-thrash-inactive:
- shard-iclb: [PASS][15] -> [INCOMPLETE][16] ([fdo#107713] / [fdo#109100])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6271/shard-iclb3/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13284/shard-iclb1/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html
* igt@gem_persistent_relocs@forked-interruptible-thrashing:
- shard-snb: [PASS][17] -> [DMESG-WARN][18] ([fdo#110789] / [fdo#110913 ]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6271/shard-snb1/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13284/shard-snb6/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
* igt@kms_atomic_interruptible@legacy-dpms:
- shard-hsw: [PASS][19] -> [INCOMPLETE][20] ([fdo#103540]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6271/shard-hsw2/igt@kms_atomic_interruptible@legacy-dpms.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13284/shard-hsw5/igt@kms_atomic_interruptible@legacy-dpms.html
* igt@kms_flip@flip-vs-suspend:
- shard-snb: [PASS][21] -> [INCOMPLETE][22] ([fdo#105411])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6271/shard-snb2/igt@kms_flip@flip-vs-suspend.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13284/shard-snb1/igt@kms_flip@flip-vs-suspend.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-skl: [PASS][23] -> [INCOMPLETE][24] ([fdo#109507])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6271/shard-skl4/igt@kms_flip@flip-vs-suspend-interruptible.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13284/shard-skl7/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite:
- shard-iclb: [PASS][25] -> [FAIL][26] ([fdo#103167]) +3 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6271/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13284/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [PASS][27] -> [SKIP][28] ([fdo#109642])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6271/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13284/shard-iclb1/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][29] -> [SKIP][30] ([fdo#109441]) +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6271/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13284/shard-iclb7/igt@kms_psr@psr2_sprite_plane_move.html
#### Possible fixes ####
* igt@gem_eio@in-flight-1us:
- shard-kbl: [DMESG-WARN][31] ([fdo#110913 ]) -> [PASS][32] +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6271/shard-kbl7/igt@gem_eio@in-flight-1us.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13284/shard-kbl1/igt@gem_eio@in-flight-1us.html
* igt@gem_eio@in-flight-suspend:
- shard-glk: [FAIL][33] ([fdo#110667]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6271/shard-glk3/igt@gem_eio@in-flight-suspend.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13284/shard-glk4/igt@gem_eio@in-flight-suspend.html
* igt@gem_eio@suspend:
- shard-skl: [DMESG-WARN][35] ([fdo#110913 ]) -> [PASS][36] +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6271/shard-skl1/igt@gem_eio@suspend.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13284/shard-skl10/igt@gem_eio@suspend.html
* igt@gem_eio@wait-wedge-1us:
- shard-apl: [DMESG-WARN][37] ([fdo#110913 ]) -> [PASS][38] +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6271/shard-apl3/igt@gem_eio@wait-wedge-1us.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13284/shard-apl7/igt@gem_eio@wait-wedge-1us.html
* igt@gem_persistent_relocs@forked-faulting-reloc-thrashing:
- shard-snb: [DMESG-WARN][39] ([fdo#110789] / [fdo#110913 ]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6271/shard-snb6/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13284/shard-snb2/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
* igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing:
- shard-glk: [DMESG-WARN][41] ([fdo#110913 ]) -> [PASS][42] +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6271/shard-glk5/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13284/shard-glk4/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
- shard-snb: [DMESG-WARN][43] ([fdo#110913 ]) -> [PASS][44] +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6271/shard-snb1/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13284/shard-snb6/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
* igt@i915_pm_rc6_residency@rc6-accuracy:
- shard-snb: [SKIP][45] ([fdo#109271]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6271/shard-snb7/igt@i915_pm_rc6_residency@rc6-accuracy.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13284/shard-snb5/igt@i915_pm_rc6_residency@rc6-accuracy.html
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-c:
- shard-hsw: [DMESG-WARN][47] ([fdo#110222] / [fdo#110913 ]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6271/shard-hsw5/igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-c.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13284/shard-hsw2/igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-c.html
* igt@kms_cursor_crc@pipe-b-cursor-256x256-onscreen:
- shard-apl: [INCOMPLETE][49] ([fdo#103927]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6271/shard-apl4/igt@kms_cursor_crc@pipe-b-cursor-256x256-onscreen.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13284/shard-apl3/igt@kms_cursor_crc@pipe-b-cursor-256x256-onscreen.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-skl: [FAIL][51] ([fdo#105363]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6271/shard-skl10/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13284/shard-skl8/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-move:
- shard-hsw: [SKIP][53] ([fdo#109271]) -> [PASS][54] +12 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6271/shard-hsw1/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-move.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13284/shard-hsw2/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-move.html
* igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite:
- shard-iclb: [FAIL][55] ([fdo#103167]) -> [PASS][56] +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6271/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13284/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite.html
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- shard-skl: [FAIL][57] ([fdo#108145]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6271/shard-skl4/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13284/shard-skl10/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
* igt@kms_plane_lowres@pipe-a-tiling-y:
- shard-iclb: [FAIL][59] ([fdo#103166]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6271/shard-iclb6/igt@kms_plane_lowres@pipe-a-tiling-y.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13284/shard-iclb8/igt@kms_plane_lowres@pipe-a-tiling-y.html
* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-iclb: [SKIP][61] ([fdo#109441]) -> [PASS][62] +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6271/shard-iclb8/igt@kms_psr@psr2_cursor_plane_onoff.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13284/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html
* igt@kms_setmode@basic:
- shard-hsw: [FAIL][63] ([fdo#99912]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6271/shard-hsw2/igt@kms_setmode@basic.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13284/shard-hsw7/igt@kms_setmode@basic.html
* igt@kms_sysfs_edid_timing:
- shard-iclb: [FAIL][65] ([fdo#100047]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6271/shard-iclb3/igt@kms_sysfs_edid_timing.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13284/shard-iclb7/igt@kms_sysfs_edid_timing.html
- shard-hsw: [FAIL][67] ([fdo#100047]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6271/shard-hsw1/igt@kms_sysfs_edid_timing.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13284/shard-hsw8/igt@kms_sysfs_edid_timing.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-apl: [DMESG-WARN][69] ([fdo#108566]) -> [PASS][70] +2 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6271/shard-apl1/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13284/shard-apl4/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
#### Warnings ####
* igt@gem_exec_schedule@semaphore-resolve:
- shard-glk: [DMESG-FAIL][71] -> [FAIL][72] ([fdo#110519])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6271/shard-glk1/igt@gem_exec_schedule@semaphore-resolve.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13284/shard-glk2/igt@gem_exec_schedule@semaphore-resolve.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-skl: [FAIL][73] ([fdo#103167]) -> [FAIL][74] ([fdo#108040])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6271/shard-skl8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-gtt.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13284/shard-skl3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-gtt.html
[fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108040]: https://bugs.freedesktop.org/show_bug.cgi?id=108040
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109507]: https://bugs.freedesktop.org/show_bug.cgi?id=109507
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110222]: https://bugs.freedesktop.org/show_bug.cgi?id=110222
[fdo#110519]: https://bugs.freedesktop.org/show_bug.cgi?id=110519
[fdo#110667]: https://bugs.freedesktop.org/show_bug.cgi?id=110667
[fdo#110789]: https://bugs.freedesktop.org/show_bug.cgi?id=110789
[fdo#110913 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110913
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_6271 -> Patchwork_13284
CI_DRM_6271: 7564ad5c5922b117e250665a5caf7c4a530dcf5f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5056: c7b717f0126374a02fc86de5eb5fb1f3e7b3335b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13284: 534240f724bc01b7e1e9252ca335510a757ba94c @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13284/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/i915: Check visibility in icl_build_plane_wm
2019-06-14 10:39 [PATCH] drm/i915: Check visibility in icl_build_plane_wm Maarten Lankhorst
` (2 preceding siblings ...)
2019-06-15 17:45 ` ✓ Fi.CI.IGT: " Patchwork
@ 2019-06-17 12:34 ` Ville Syrjälä
2019-06-18 9:16 ` Maarten Lankhorst
3 siblings, 1 reply; 8+ messages in thread
From: Ville Syrjälä @ 2019-06-17 12:34 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: intel-gfx
On Fri, Jun 14, 2019 at 12:39:41PM +0200, Maarten Lankhorst wrote:
> When a planar YUV plane is configured, but the crtc is
> marked inactive, we can end up with a linked plane without
> visibility.
How is that possible? I don't think we should be adding the slave plane
if the master is not visible.
> Handle this by checking for visibility early,
> instead of doing a WARN.
>
> <4> [201.742919] ------------[ cut here ]------------
> <4> [201.742920] WARN_ON(!intel_wm_plane_visible(crtc_state, plane_state))
> <4> [201.742947] WARNING: CPU: 7 PID: 1268 at drivers/gpu/drm/i915/intel_pm.c:5068 skl_compute_wm+0x2be/0x10a0 [i915]
> <4> [201.742948] Modules linked in: snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic i915 x86_pkg_temp_thermal snd_hda_intel coretemp snd_hda_codec mei_hdcp snd_hwdep snd_hda_core crct10dif_pclmul cdc_ether usbnet crc32_pclmul mii snd_pcm ghash_clmulni_intel mei_me mei prime_numbers
> <4> [201.742958] CPU: 7 PID: 1268 Comm: kms_chamelium Tainted: G U 5.2.0-rc3-CI-CI_DRM_6216+ #1
> <4> [201.742960] Hardware name: Intel Corporation Ice Lake Client Platform/IceLake U DDR4 SODIMM PD RVP TLC, BIOS ICLSFWR1.R00.3183.A00.1905020411 05/02/2019
> <4> [201.742978] RIP: 0010:skl_compute_wm+0x2be/0x10a0 [i915]
> <4> [201.742980] Code: 24 10 8b 92 fc 02 00 00 0f 85 ba 04 00 00 48 c7 c6 e0 38 2e a0 48 c7 c7 93 99 31 a0 89 54 24 20 48 89 44 24 08 e8 82 a2 f5 e0 <0f> 0b 8b 54 24 20 48 8b 44 24 08 48 8b 40 48 80 78 12 00 0f 85 76
> <4> [201.742981] RSP: 0018:ffffc9000064f9a8 EFLAGS: 00010282
> <4> [201.742983] RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000007
> <4> [201.742984] RDX: 000000000000175c RSI: ffff8884934d48e0 RDI: ffffffff8212df49
> <4> [201.742985] RBP: ffff888493408558 R08: 00000000b56dab44 R09: 0000000000000000
> <4> [201.742986] R10: ffff88848be00000 R11: 0000000000000000 R12: ffff88849afd89f8
> <4> [201.742987] R13: ffff88847eaf67e8 R14: ffff88848c344a88 R15: ffff88848be00000
> <4> [201.742988] FS: 00007f4d9b60b700(0000) GS:ffff88849ff80000(0000) knlGS:0000000000000000
> <4> [201.742989] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> <4> [201.742991] CR2: 00007f4d9b609ff8 CR3: 000000048c326006 CR4: 0000000000760ee0
> <4> [201.742992] PKRU: 55555554
> <4> [201.742993] Call Trace:
> <4> [201.743021] ? intel_atomic_check+0x7b2/0x1440 [i915]
> <4> [201.743026] ? __mutex_unlock_slowpath+0x46/0x2b0
> <4> [201.743052] intel_atomic_check+0x7ca/0x1440 [i915]
> <4> [201.743060] drm_atomic_check_only+0x55a/0x7f0
> <4> [201.743064] drm_atomic_commit+0xe/0x50
> <4> [201.743067] drm_atomic_connector_commit_dpms+0xe0/0xf0
> <4> [201.743069] set_property_atomic+0xba/0x140
> <4> [201.743075] drm_mode_obj_set_property_ioctl+0x111/0x1d0
> <4> [201.743077] ? drm_dev_exit+0x8/0x40
> <4> [201.743080] ? drm_connector_set_obj_prop+0x70/0x70
> <4> [201.743082] drm_connector_property_set_ioctl+0x39/0x60
> <4> [201.743084] drm_ioctl_kernel+0x83/0xf0
> <4> [201.743087] drm_ioctl+0x2f3/0x3b0
> <4> [201.743090] ? drm_connector_set_obj_prop+0x70/0x70
> <4> [201.743096] ? lock_acquire+0xa6/0x1c0
> <4> [201.743100] do_vfs_ioctl+0xa0/0x6e0
> <4> [201.743103] ? __fget+0x10f/0x200
> <4> [201.743105] ksys_ioctl+0x35/0x60
> <4> [201.743108] __x64_sys_ioctl+0x11/0x20
> <4> [201.743110] do_syscall_64+0x55/0x1c0
> <4> [201.743112] entry_SYSCALL_64_after_hwframe+0x49/0xbe
> <4> [201.743114] RIP: 0033:0x7f4da6c8d5d7
> <4> [201.743115] Code: b3 66 90 48 8b 05 b1 48 2d 00 64 c7 00 26 00 00 00 48 c7 c0 ff ff ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 b8 10 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 81 48 2d 00 f7 d8 64 89 01 48
> <4> [201.743116] RSP: 002b:00007f4d9b60aba8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
> <4> [201.743118] RAX: ffffffffffffffda RBX: 00007f4d94001ac0 RCX: 00007f4da6c8d5d7
> <4> [201.743119] RDX: 00007f4d9b60abe0 RSI: 00000000c01064ab RDI: 0000000000000005
> <4> [201.743120] RBP: 00007f4d9b60abe0 R08: 00007f4d940015c0 R09: 00007f4d940015f0
> <4> [201.743121] R10: 0000000000000055 R11: 0000000000000246 R12: 00000000c01064ab
> <4> [201.743122] R13: 0000000000000005 R14: 0000000000000005 R15: 00007f4da7a2c0c7
> <4> [201.743156] irq event stamp: 362
> <4> [201.743162] hardirqs last enabled at (361): [<ffffffff8112862c>] vprintk_emit+0xcc/0x340
> <4> [201.743168] hardirqs last disabled at (362): [<ffffffff810019e0>] trace_hardirqs_off_thunk+0x1a/0x1c
> <4> [201.743174] softirqs last enabled at (0): [<ffffffff810abf78>] copy_process.part.6+0x4e8/0x1dc0
> <4> [201.743178] softirqs last disabled at (0): [<0000000000000000>] 0x0
> <4> [201.743243] WARNING: CPU: 7 PID: 1268 at drivers/gpu/drm/i915/intel_pm.c:5068 skl_compute_wm+0x2be/0x10a0 [i915]
> <4> [201.743246] ---[ end trace 33e6703087376efa ]---
>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110895
> Testcase: kms_chamelium@hdmi-cmp-nv12
> ---
> drivers/gpu/drm/i915/intel_pm.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 4e52dad84d64..e0e57de22388 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -5060,15 +5060,15 @@ static int icl_build_plane_wm(struct intel_crtc_state *crtc_state,
> enum plane_id plane_id = to_intel_plane(plane_state->base.plane)->id;
> int ret;
>
> - /* Watermarks calculated in master */
> - if (plane_state->slave)
> + /* Watermarks are calculated in master */
> + if (plane_state->slave ||
> + !intel_wm_plane_visible(crtc_state, plane_state))
> return 0;
>
> if (plane_state->linked_plane) {
> const struct drm_framebuffer *fb = plane_state->base.fb;
> enum plane_id y_plane_id = plane_state->linked_plane->id;
>
> - WARN_ON(!intel_wm_plane_visible(crtc_state, plane_state));
> WARN_ON(!fb->format->is_yuv ||
> fb->format->num_planes == 1);
>
> @@ -5081,7 +5081,7 @@ static int icl_build_plane_wm(struct intel_crtc_state *crtc_state,
> plane_id, 1);
> if (ret)
> return ret;
> - } else if (intel_wm_plane_visible(crtc_state, plane_state)) {
> + } else {
> ret = skl_build_plane_wm_single(crtc_state, plane_state,
> plane_id, 0);
> if (ret)
> --
> 2.20.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/i915: Check visibility in icl_build_plane_wm
2019-06-17 12:34 ` [PATCH] " Ville Syrjälä
@ 2019-06-18 9:16 ` Maarten Lankhorst
2019-06-18 11:44 ` Ville Syrjälä
0 siblings, 1 reply; 8+ messages in thread
From: Maarten Lankhorst @ 2019-06-18 9:16 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
Op 17-06-2019 om 14:34 schreef Ville Syrjälä:
> On Fri, Jun 14, 2019 at 12:39:41PM +0200, Maarten Lankhorst wrote:
>> When a planar YUV plane is configured, but the crtc is
>> marked inactive, we can end up with a linked plane without
>> visibility.
> How is that possible? I don't think we should be adding the slave plane
> if the master is not visible.
DPMS off, we calculate the various fields as if the CRTC is on, then disable visibility.
crtc_state->nv12_planes etc still get set, so it works as if the crtc is on.
It's a way of not allowing an invalid result when dpms is off, then breaking on crtc enable.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/i915: Check visibility in icl_build_plane_wm
2019-06-18 9:16 ` Maarten Lankhorst
@ 2019-06-18 11:44 ` Ville Syrjälä
2019-06-18 11:59 ` Ville Syrjälä
0 siblings, 1 reply; 8+ messages in thread
From: Ville Syrjälä @ 2019-06-18 11:44 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: intel-gfx
On Tue, Jun 18, 2019 at 11:16:41AM +0200, Maarten Lankhorst wrote:
> Op 17-06-2019 om 14:34 schreef Ville Syrjälä:
> > On Fri, Jun 14, 2019 at 12:39:41PM +0200, Maarten Lankhorst wrote:
> >> When a planar YUV plane is configured, but the crtc is
> >> marked inactive, we can end up with a linked plane without
> >> visibility.
> > How is that possible? I don't think we should be adding the slave plane
> > if the master is not visible.
>
>
> DPMS off, we calculate the various fields as if the CRTC is on, then disable visibility.
>
> crtc_state->nv12_planes etc still get set, so it works as if the crtc is on.
>
> It's a way of not allowing an invalid result when dpms is off, then breaking on crtc enable.
Hmm. I wonder when we started to do that. If we're already doing this
much then I wonder how far we are from just dealing with the FIXME in
intel_wm_plane_visible() instead?
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/i915: Check visibility in icl_build_plane_wm
2019-06-18 11:44 ` Ville Syrjälä
@ 2019-06-18 11:59 ` Ville Syrjälä
0 siblings, 0 replies; 8+ messages in thread
From: Ville Syrjälä @ 2019-06-18 11:59 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: intel-gfx
On Tue, Jun 18, 2019 at 02:44:00PM +0300, Ville Syrjälä wrote:
> On Tue, Jun 18, 2019 at 11:16:41AM +0200, Maarten Lankhorst wrote:
> > Op 17-06-2019 om 14:34 schreef Ville Syrjälä:
> > > On Fri, Jun 14, 2019 at 12:39:41PM +0200, Maarten Lankhorst wrote:
> > >> When a planar YUV plane is configured, but the crtc is
> > >> marked inactive, we can end up with a linked plane without
> > >> visibility.
> > > How is that possible? I don't think we should be adding the slave plane
> > > if the master is not visible.
> >
> >
> > DPMS off, we calculate the various fields as if the CRTC is on, then disable visibility.
> >
> > crtc_state->nv12_planes etc still get set, so it works as if the crtc is on.
> >
> > It's a way of not allowing an invalid result when dpms is off, then breaking on crtc enable.
>
> Hmm. I wonder when we started to do that. If we're already doing this
> much then I wonder how far we are from just dealing with the FIXME in
> intel_wm_plane_visible() instead?
Still far I guess. Would potentially need to do some surgery on
the pipe ddb allocation as well.
This whole thing is a bit borked. We clear active_planes but still
use it when allocating the Y plane. Hence dpms on could just fail
anyway due to not having a free Y plane (as well as due to
insufficient watermarks).
So if we want to make the Y plane allocation robust I guess we would
also need to move clearing the plane visibility to happen after the
crtc .atomic_check().
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-06-18 11:59 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-14 10:39 [PATCH] drm/i915: Check visibility in icl_build_plane_wm Maarten Lankhorst
2019-06-14 11:58 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-06-14 23:54 ` ✓ Fi.CI.BAT: success " Patchwork
2019-06-15 17:45 ` ✓ Fi.CI.IGT: " Patchwork
2019-06-17 12:34 ` [PATCH] " Ville Syrjälä
2019-06-18 9:16 ` Maarten Lankhorst
2019-06-18 11:44 ` Ville Syrjälä
2019-06-18 11:59 ` Ville Syrjälä
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.