From: Dalon L Westergreen <dalon.westergreen@linux.intel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RESEND PATCH v3 2/2] ARM: socfpga: stratix10: Remove CONFIG_OF_EMBED
Date: Wed, 09 Oct 2019 05:56:17 -0700 [thread overview]
Message-ID: <9ae7203d0b21e72eb6f05599c8d1ac3e9f971238.camel@linux.intel.com> (raw)
In-Reply-To: <f11ad9f5-2ae2-09a0-f079-b52f3598e65a@gmail.com>
On Sat, 2019-10-05 at 21:41 +0200, Simon Goldschmidt wrote:
> Am 27.09.2019 um 20:27 schrieb Dalon Westergreen:
> > From: Dalon Westergreen <dalon.westergreen@intel.com>
> > CONFIG_OF_EMBED was primarily enabled to support the stratix10spl hex file
> > requirements. Since this option now produces awarning during build, and the
> > spl hex can be created usingalternate methods, CONFIG_OF_EMBED is no longer
> > needed.
> > Signed-off-by: Dalon Westergreen <dalon.westergreen@intel.com>
> > --- configs/socfpga_stratix10_defconfig | 1
> > - include/configs/socfpga_stratix10_socdk.h | 2 +- 2 files changed, 1
> > insertion(+), 2 deletions(-)
> > diff --git a/configs/socfpga_stratix10_defconfig
> > b/configs/socfpga_stratix10_defconfigindex 5ae53a4db9..ae1b9bead1 100644---
> > a/configs/socfpga_stratix10_defconfig+++
> > b/configs/socfpga_stratix10_defconfig@@ -27,7 +27,6 @@
> > CONFIG_CMD_CACHE=y CONFIG_CMD_EXT4=y CONFIG_CMD_FAT=y CONFIG_CMD_FS_GENER
> > IC=y-
> > CONFIG_OF_EMBED=y CONFIG_DEFAULT_DEVICE_TREE="socfpga_stratix10_socdk" CON
> > FIG_ENV_IS_IN_MMC=y CONFIG_NET_RANDOM_ETHADDR=ydiff --git
> > a/include/configs/socfpga_stratix10_socdk.h
> > b/include/configs/socfpga_stratix10_socdk.hindex 7b55dd14da..f9ecf9d2df
> > 100644--- a/include/configs/socfpga_stratix10_socdk.h+++
> > b/include/configs/socfpga_stratix10_socdk.h@@ -204,6 +204,6 @@ unsigned int
> > cm_get_l4_sys_free_clk_hz(void); /* SPL SDMMC boot support */ #define
> > CONFIG_SYS_MMCSD_FS_BOOT_PARTITION 1-#define
> > CONFIG_SPL_FS_LOAD_PAYLOAD_NAME "u-boot.img"+#define
> > CONFIG_SPL_FS_LOAD_PAYLOAD_NAME "u-boot-dtb.img"
>
> Didn't we have this before? The payload name "u-boot.img" is correct for all
> configurations. Without CONFIG_OF_EMBED the two above are the same, but
> changing the name should not be necessary.
> Regards,Simon
Correct, but it seems convention is to just use u-boot.img and i would like all
the socfpga devicesto do the same thing.
--dalon
> > #endif /* __CONFIG_H */
next prev parent reply other threads:[~2019-10-09 12:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-27 18:27 [U-Boot] [RESEND PATCH v3 1/2] Makefile: Add target to generate hex output for combined spl and dtb Dalon Westergreen
2019-09-27 18:27 ` [U-Boot] [RESEND PATCH v3 2/2] ARM: socfpga: stratix10: Remove CONFIG_OF_EMBED Dalon Westergreen
2019-10-05 19:41 ` Simon Goldschmidt
2019-10-09 12:56 ` Dalon L Westergreen [this message]
2019-10-09 13:32 ` Simon Goldschmidt
2019-10-04 13:54 ` [U-Boot] [RESEND PATCH v3 1/2] Makefile: Add target to generate hex output for combined spl and dtb Tom Rini
2019-10-05 19:40 ` Simon Goldschmidt
2019-10-09 12:57 ` Dalon L Westergreen
2019-10-09 13:34 ` Simon Goldschmidt
-- strict thread matches above, loose matches on Subject: below --
2019-08-07 14:44 Dalon Westergreen
2019-08-07 14:44 ` [U-Boot] [RESEND PATCH v3 2/2] ARM: socfpga: stratix10: Remove CONFIG_OF_EMBED Dalon Westergreen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ae7203d0b21e72eb6f05599c8d1ac3e9f971238.camel@linux.intel.com \
--to=dalon.westergreen@linux.intel.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.