All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] net: phy: dp83640: Drop unused PAGE0 define
@ 2021-09-16 19:50 Guenter Roeck
  2021-09-16 20:10 ` Guenter Roeck
  0 siblings, 1 reply; 2+ messages in thread
From: Guenter Roeck @ 2021-09-16 19:50 UTC (permalink / raw)
  To: Richard Cochran
  Cc: Andrew Lunn, Heiner Kallweit, Russell King, David S . Miller,
	Jakub Kicinski, netdev, linux-kernel, Guenter Roeck

parisc:allmodconfig fails to build with the following error.

In file included from drivers/net/phy/dp83640.c:23:
drivers/net/phy/dp83640_reg.h:8: error: "PAGE0" redefined

The dp83640 driver does not use this define, so just remove it.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 drivers/net/phy/dp83640_reg.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/phy/dp83640_reg.h b/drivers/net/phy/dp83640_reg.h
index 21aa24c741b9..601e8d107723 100644
--- a/drivers/net/phy/dp83640_reg.h
+++ b/drivers/net/phy/dp83640_reg.h
@@ -5,7 +5,6 @@
 #ifndef HAVE_DP83640_REGISTERS
 #define HAVE_DP83640_REGISTERS
 
-#define PAGE0                     0x0000
 #define PHYCR2                    0x001c /* PHY Control Register 2 */
 
 #define PAGE4                     0x0004
-- 
2.33.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] net: phy: dp83640: Drop unused PAGE0 define
  2021-09-16 19:50 [PATCH] net: phy: dp83640: Drop unused PAGE0 define Guenter Roeck
@ 2021-09-16 20:10 ` Guenter Roeck
  0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2021-09-16 20:10 UTC (permalink / raw)
  To: Richard Cochran
  Cc: Andrew Lunn, Heiner Kallweit, Russell King, David S . Miller,
	Jakub Kicinski, netdev, linux-kernel

On 9/16/21 12:50 PM, Guenter Roeck wrote:
> parisc:allmodconfig fails to build with the following error.
> 
> In file included from drivers/net/phy/dp83640.c:23:
> drivers/net/phy/dp83640_reg.h:8: error: "PAGE0" redefined
> 
> The dp83640 driver does not use this define, so just remove it.
> 
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
>   drivers/net/phy/dp83640_reg.h | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/phy/dp83640_reg.h b/drivers/net/phy/dp83640_reg.h
> index 21aa24c741b9..601e8d107723 100644
> --- a/drivers/net/phy/dp83640_reg.h
> +++ b/drivers/net/phy/dp83640_reg.h
> @@ -5,7 +5,6 @@
>   #ifndef HAVE_DP83640_REGISTERS
>   #define HAVE_DP83640_REGISTERS
>   
> -#define PAGE0                     0x0000
>   #define PHYCR2                    0x001c /* PHY Control Register 2 */
>   
>   #define PAGE4                     0x0004
> 

Sorry for the noise. I just learned that the problem is already fixed.

Guenter

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-09-16 20:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-16 19:50 [PATCH] net: phy: dp83640: Drop unused PAGE0 define Guenter Roeck
2021-09-16 20:10 ` Guenter Roeck

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.