OV5640 with 12MHz xclk

OV5640 with 12MHz xclk

[Samuel Bobrowicz]

Can anyone verify if the OV5640 driver works with input clocks other
than the typical 24MHz? The driver suggests anything from 6MHz-24MHz
is acceptable, but I am running into issues while bringing up a module
that uses a 12MHz oscillator. I'd expect that different xclk's would
necessitate different register settings for the various resolutions
(PLL settings, PCLK width, etc.), however the driver does not seem to
modify nearly enough based on the frequency of xclk.

Sam

Re: OV5640 with 12MHz xclk

[Hans Verkuil]

On 04/16/2018 03:39 AM, Samuel Bobrowicz wrote:
> Can anyone verify if the OV5640 driver works with input clocks other
> than the typical 24MHz? The driver suggests anything from 6MHz-24MHz
> is acceptable, but I am running into issues while bringing up a module
> that uses a 12MHz oscillator. I'd expect that different xclk's would
> necessitate different register settings for the various resolutions
> (PLL settings, PCLK width, etc.), however the driver does not seem to
> modify nearly enough based on the frequency of xclk.
> 
> Sam
> 

I'm pretty sure it has never been tested with 12 MHz. The i.MX SabreLite
seems to use 22 MHz, and I can't tell from the code what the SabreSD uses
(probably 22 or 24 MHz). Steve will probably know.

Regards,

	Hans

Re: OV5640 with 12MHz xclk

[Philipp Zabel]

On Sun, 2018-04-15 at 18:39 -0700, Samuel Bobrowicz wrote:
> Can anyone verify if the OV5640 driver works with input clocks other
> than the typical 24MHz? The driver suggests anything from 6MHz-24MHz
> is acceptable, but I am running into issues while bringing up a module
> that uses a 12MHz oscillator. I'd expect that different xclk's would
> necessitate different register settings for the various resolutions
> (PLL settings, PCLK width, etc.), however the driver does not seem to
> modify nearly enough based on the frequency of xclk.
> 
> Sam
> 

Have you seen Maxime's recent "media: ov5640: Misc cleanup and
improvements" series, especially patch 08/12 ("media: ov5640: Adjust the
clock based on the expected rate")? That seems to be something you'd
need.

regards
Philipp

Re: OV5640 with 12MHz xclk

[Steve Longerbeam]

Hi Sam,

On 04/16/2018 05:26 AM, Hans Verkuil wrote:
> On 04/16/2018 03:39 AM, Samuel Bobrowicz wrote:
>> Can anyone verify if the OV5640 driver works with input clocks other
>> than the typical 24MHz? The driver suggests anything from 6MHz-24MHz
>> is acceptable, but I am running into issues while bringing up a module
>> that uses a 12MHz oscillator. I'd expect that different xclk's would
>> necessitate different register settings for the various resolutions
>> (PLL settings, PCLK width, etc.), however the driver does not seem to
>> modify nearly enough based on the frequency of xclk.
>>
>> Sam
>>
> I'm pretty sure it has never been tested with 12 MHz. The i.MX SabreLite
> seems to use 22 MHz, and I can't tell from the code what the SabreSD uses
> (probably 22 or 24 MHz). Steve will probably know.

On i.MX6, the sabrelite uses the PWM3 clock at 22MHz for the OV5640 xclk.
The SabreSD uses the i.MX6 CKO clock, which is default sourced from the
24 MHz oscillator.

I wouldn't be surprised that there are issues with a 12MHz xclk in the
ov5640 driver. There's probably some assumptions made about the
xclk range in the hardcoded values in those huge register tables. Sorry
I don't have the time to look into it more.

Steve

Re: OV5640 with 12MHz xclk

[Samuel Bobrowicz]

Thanks all, that's what I was expecting. It clears some things up.

I'm going to check out Maxime's recent patches and see if those do the
trick, otherwise I'll get cracking on some patches myself.

Sam
-----------------------
Sam Bobrowicz
Elite Embedded Consulting LLC
elite-embedded.com


On Mon, Apr 16, 2018 at 11:44 AM, Steve Longerbeam
<slongerbeam@gmail.com> wrote:
> Hi Sam,
>
> On 04/16/2018 05:26 AM, Hans Verkuil wrote:
>>
>> On 04/16/2018 03:39 AM, Samuel Bobrowicz wrote:
>>>
>>> Can anyone verify if the OV5640 driver works with input clocks other
>>> than the typical 24MHz? The driver suggests anything from 6MHz-24MHz
>>> is acceptable, but I am running into issues while bringing up a module
>>> that uses a 12MHz oscillator. I'd expect that different xclk's would
>>> necessitate different register settings for the various resolutions
>>> (PLL settings, PCLK width, etc.), however the driver does not seem to
>>> modify nearly enough based on the frequency of xclk.
>>>
>>> Sam
>>>
>> I'm pretty sure it has never been tested with 12 MHz. The i.MX SabreLite
>> seems to use 22 MHz, and I can't tell from the code what the SabreSD uses
>> (probably 22 or 24 MHz). Steve will probably know.
>
>
> On i.MX6, the sabrelite uses the PWM3 clock at 22MHz for the OV5640 xclk.
> The SabreSD uses the i.MX6 CKO clock, which is default sourced from the
> 24 MHz oscillator.
>
> I wouldn't be surprised that there are issues with a 12MHz xclk in the
> ov5640 driver. There's probably some assumptions made about the
> xclk range in the hardcoded values in those huge register tables. Sorry
> I don't have the time to look into it more.
>
> Steve
>