[meta-java][PATCH 0/2] master-next: fix OpenJDK 8 build

[meta-java][PATCH 0/2] master-next: fix OpenJDK 8 build

[Richard Leitner]

OpenJDK 8 in our master-next branch fails to build with current
oe-core/YoctoProject branches. This series fixes the build again.

Richard Leitner (2):
  openjdk-8: fix build for gcc8.x
  ca-certificates-java: update SRC_URI

 .../ca-certificates-java_20170930.bb                |  2 +-
 recipes-core/openjdk/openjdk-8-release-16xbyy.inc   |  1 +
 .../patches-openjdk-8/hotspot_fix_gcc8x_build.patch | 21 +++++++++++++++++++++
 3 files changed, 23 insertions(+), 1 deletion(-)
 create mode 100644 recipes-core/openjdk/patches-openjdk-8/hotspot_fix_gcc8x_build.patch

-- 
2.11.0

[meta-java][PATCH 1/2] openjdk-8: fix build for gcc8.x

[Richard Leitner]

Currently oe-core/YoctoProject migrated to gcc8.x. This update broke our
openjdk-8 and openjre-8 build. This patch avoids this problem by disabling
the problematic gcc warnings and errors.

Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
---
 recipes-core/openjdk/openjdk-8-release-16xbyy.inc   |  1 +
 .../patches-openjdk-8/hotspot_fix_gcc8x_build.patch | 21 +++++++++++++++++++++
 2 files changed, 22 insertions(+)
 create mode 100644 recipes-core/openjdk/patches-openjdk-8/hotspot_fix_gcc8x_build.patch

diff --git a/recipes-core/openjdk/openjdk-8-release-16xbyy.inc b/recipes-core/openjdk/openjdk-8-release-16xbyy.inc
index bd4a349..7ca0997 100644
--- a/recipes-core/openjdk/openjdk-8-release-16xbyy.inc
+++ b/recipes-core/openjdk/openjdk-8-release-16xbyy.inc
@@ -16,6 +16,7 @@ PATCHES_URI = "\
     file://0008-jdk-use-correct-include-for-signal.patch \
     file://0009-jdk-disable-backtrace-musl-build-fix.patch \
     file://0010-build-fix-build-on-as-needed-toolchains-generic.patch \
+    file://hotspot_fix_gcc8x_build.patch \
 "
 # some patches extracted from http://cr.openjdk.java.net/~rkennke/shark-build-hotspot/webrev.01/hotspot.patch
 # reported via http://mail.openjdk.java.net/pipermail/build-dev/2015-January/013972.html
diff --git a/recipes-core/openjdk/patches-openjdk-8/hotspot_fix_gcc8x_build.patch b/recipes-core/openjdk/patches-openjdk-8/hotspot_fix_gcc8x_build.patch
new file mode 100644
index 0000000..1a406f2
--- /dev/null
+++ b/recipes-core/openjdk/patches-openjdk-8/hotspot_fix_gcc8x_build.patch
@@ -0,0 +1,21 @@
+From: Richard Leitner <richard.leitner@skidata.com>
+Date: Thu, 14 Jun 2018 23:42:11 +0200
+Subject: [PATCH] openjdk-8: hotspot: fix gcc8 compilation
+
+As oe-core/yocto-project master migrated to gcc8.x we need to support this.
+Therefore disable following gcc warnings/errors which caused the build to fail:
+  + stringop-overflow
+  + return-type
+---
+
+--- a/hotspot/make/linux/makefiles/gcc.make
++++ b/hotspot/make/linux/makefiles/gcc.make
+@@ -197,7 +197,7 @@
+ endif
+ 
+ # Compiler warnings are treated as errors
+-WARNINGS_ARE_ERRORS = -Werror
++WARNINGS_ARE_ERRORS = -Werror -Wno-stringop-overflow -Wno-error=return-type
+ 
+ ifeq ($(USE_CLANG), true)
+   # However we need to clean the code up before we can unrestrictedly enable this option with Clang
-- 
2.11.0

[meta-java][PATCH 2/2] ca-certificates-java: update SRC_URI

[Richard Leitner]

Debian changed the URI of the ca-certificates-java repository, therfore
use the new one.

Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
---
 recipes-core/ca-certificates-java/ca-certificates-java_20170930.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/recipes-core/ca-certificates-java/ca-certificates-java_20170930.bb b/recipes-core/ca-certificates-java/ca-certificates-java_20170930.bb
index 0b149d2..35e2c16 100644
--- a/recipes-core/ca-certificates-java/ca-certificates-java_20170930.bb
+++ b/recipes-core/ca-certificates-java/ca-certificates-java_20170930.bb
@@ -17,7 +17,7 @@ DEPENDS = "virtual/javac-native fastjar-native"
 PACKAGE_WRITE_DEPS += "openjdk-8-native"
 
 SRC_URI = "\
-	git://anonscm.debian.org/pkg-java/ca-certificates-java.git \
+	git://salsa.debian.org/java-team/ca-certificates-java.git \
 	file://0001-UpdateCertificates-handle-SYSROOT-environment-variab.patch \
 	file://${BPN}.hook.in \
 "
-- 
2.11.0

Re: [meta-java][PATCH 1/2] openjdk-8: fix build for gcc8.x

[Richard Leitner]

Hi,
this is a note to let you know that I've just added this patch to the
master-next branch of the meta-java repository at
	git://git.yoctoproject.org/meta-java

As soon as it has gone through some more testing it will likely be
merged to the master branch.

If you have any questions, please let me know.

regards;Richard.L

On 06/15/2018 12:49 AM, Richard Leitner wrote:
> Currently oe-core/YoctoProject migrated to gcc8.x. This update broke our
> openjdk-8 and openjre-8 build. This patch avoids this problem by disabling
> the problematic gcc warnings and errors.
> 
> Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
> ---
>  recipes-core/openjdk/openjdk-8-release-16xbyy.inc   |  1 +
>  .../patches-openjdk-8/hotspot_fix_gcc8x_build.patch | 21 +++++++++++++++++++++
>  2 files changed, 22 insertions(+)
>  create mode 100644 recipes-core/openjdk/patches-openjdk-8/hotspot_fix_gcc8x_build.patch
> 
> diff --git a/recipes-core/openjdk/openjdk-8-release-16xbyy.inc b/recipes-core/openjdk/openjdk-8-release-16xbyy.inc
> index bd4a349..7ca0997 100644
> --- a/recipes-core/openjdk/openjdk-8-release-16xbyy.inc
> +++ b/recipes-core/openjdk/openjdk-8-release-16xbyy.inc
> @@ -16,6 +16,7 @@ PATCHES_URI = "\
>      file://0008-jdk-use-correct-include-for-signal.patch \
>      file://0009-jdk-disable-backtrace-musl-build-fix.patch \
>      file://0010-build-fix-build-on-as-needed-toolchains-generic.patch \
> +    file://hotspot_fix_gcc8x_build.patch \
>  "
>  # some patches extracted from http://cr.openjdk.java.net/~rkennke/shark-build-hotspot/webrev.01/hotspot.patch
>  # reported via http://mail.openjdk.java.net/pipermail/build-dev/2015-January/013972.html
> diff --git a/recipes-core/openjdk/patches-openjdk-8/hotspot_fix_gcc8x_build.patch b/recipes-core/openjdk/patches-openjdk-8/hotspot_fix_gcc8x_build.patch
> new file mode 100644
> index 0000000..1a406f2
> --- /dev/null
> +++ b/recipes-core/openjdk/patches-openjdk-8/hotspot_fix_gcc8x_build.patch
> @@ -0,0 +1,21 @@
> +From: Richard Leitner <richard.leitner@skidata.com>
> +Date: Thu, 14 Jun 2018 23:42:11 +0200
> +Subject: [PATCH] openjdk-8: hotspot: fix gcc8 compilation
> +
> +As oe-core/yocto-project master migrated to gcc8.x we need to support this.
> +Therefore disable following gcc warnings/errors which caused the build to fail:
> +  + stringop-overflow
> +  + return-type
> +---
> +
> +--- a/hotspot/make/linux/makefiles/gcc.make
> ++++ b/hotspot/make/linux/makefiles/gcc.make
> +@@ -197,7 +197,7 @@
> + endif
> + 
> + # Compiler warnings are treated as errors
> +-WARNINGS_ARE_ERRORS = -Werror
> ++WARNINGS_ARE_ERRORS = -Werror -Wno-stringop-overflow -Wno-error=return-type
> + 
> + ifeq ($(USE_CLANG), true)
> +   # However we need to clean the code up before we can unrestrictedly enable this option with Clang
> 

Re: [meta-java][PATCH 2/2] ca-certificates-java: update SRC_URI

[Richard Leitner]

Hi,
this is a note to let you know that I've just added this patch to the
master-next branch of the meta-java repository at
	git://git.yoctoproject.org/meta-java

As soon as it has gone through some more testing it will likely be
merged to the master branch.

If you have any questions, please let me know.

regards;Richard.L

On 06/15/2018 12:49 AM, Richard Leitner wrote:
> Debian changed the URI of the ca-certificates-java repository, therfore
> use the new one.
> 
> Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
> ---
>  recipes-core/ca-certificates-java/ca-certificates-java_20170930.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/recipes-core/ca-certificates-java/ca-certificates-java_20170930.bb b/recipes-core/ca-certificates-java/ca-certificates-java_20170930.bb
> index 0b149d2..35e2c16 100644
> --- a/recipes-core/ca-certificates-java/ca-certificates-java_20170930.bb
> +++ b/recipes-core/ca-certificates-java/ca-certificates-java_20170930.bb
> @@ -17,7 +17,7 @@ DEPENDS = "virtual/javac-native fastjar-native"
>  PACKAGE_WRITE_DEPS += "openjdk-8-native"
>  
>  SRC_URI = "\
> -	git://anonscm.debian.org/pkg-java/ca-certificates-java.git \
> +	git://salsa.debian.org/java-team/ca-certificates-java.git \
>  	file://0001-UpdateCertificates-handle-SYSROOT-environment-variab.patch \
>  	file://${BPN}.hook.in \
>  "
> 

Re: [meta-java][PATCH 1/2] openjdk-8: fix build for gcc8.x

[André Draszik]

Hi,

It appears that this patch has broken native builds with gcc 6:

| At global scope:
| cc1plus: error: unrecognized command line option ‘-Wno-stringop-overflow’ [-Werror]

Might be better to add a patch to address the warning, rather than trying to
silence gcc with an option that not all versions support.


Cheers,
Andre'


On Fri, 2018-06-15 at 10:45 +0200, Richard Leitner wrote:
> Hi,
> this is a note to let you know that I've just added this patch to the
> master-next branch of the meta-java repository at
> 	git://git.yoctoproject.org/meta-java
> 
> As soon as it has gone through some more testing it will likely be
> merged to the master branch.
> 
> If you have any questions, please let me know.
> 
> regards;Richard.L
> 
> On 06/15/2018 12:49 AM, Richard Leitner wrote:
> > Currently oe-core/YoctoProject migrated to gcc8.x. This update broke our
> > openjdk-8 and openjre-8 build. This patch avoids this problem by
> > disabling
> > the problematic gcc warnings and errors.
> > 
> > Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
> > ---
> >  recipes-core/openjdk/openjdk-8-release-16xbyy.inc   |  1 +
> >  .../patches-openjdk-8/hotspot_fix_gcc8x_build.patch | 21
> > +++++++++++++++++++++
> >  2 files changed, 22 insertions(+)
> >  create mode 100644 recipes-core/openjdk/patches-openjdk-
> > 8/hotspot_fix_gcc8x_build.patch
> > 
> > diff --git a/recipes-core/openjdk/openjdk-8-release-16xbyy.inc
> > b/recipes-core/openjdk/openjdk-8-release-16xbyy.inc
> > index bd4a349..7ca0997 100644
> > --- a/recipes-core/openjdk/openjdk-8-release-16xbyy.inc
> > +++ b/recipes-core/openjdk/openjdk-8-release-16xbyy.inc
> > @@ -16,6 +16,7 @@ PATCHES_URI = "\
> >      file://0008-jdk-use-correct-include-for-signal.patch \
> >      file://0009-jdk-disable-backtrace-musl-build-fix.patch \
> >      file://0010-build-fix-build-on-as-needed-toolchains-generic.patch \
> > +    file://hotspot_fix_gcc8x_build.patch \
> >  "
> >  # some patches extracted from http://cr.openjdk.java.net/~rkennke/shark
> > -build-hotspot/webrev.01/hotspot.patch
> >  # reported via http://mail.openjdk.java.net/pipermail/build-dev/2015-Ja
> > nuary/013972.html
> > diff --git a/recipes-core/openjdk/patches-openjdk-
> > 8/hotspot_fix_gcc8x_build.patch b/recipes-core/openjdk/patches-openjdk-
> > 8/hotspot_fix_gcc8x_build.patch
> > new file mode 100644
> > index 0000000..1a406f2
> > --- /dev/null
> > +++ b/recipes-core/openjdk/patches-openjdk-
> > 8/hotspot_fix_gcc8x_build.patch
> > @@ -0,0 +1,21 @@
> > +From: Richard Leitner <richard.leitner@skidata.com>
> > +Date: Thu, 14 Jun 2018 23:42:11 +0200
> > +Subject: [PATCH] openjdk-8: hotspot: fix gcc8 compilation
> > +
> > +As oe-core/yocto-project master migrated to gcc8.x we need to support
> > this.
> > +Therefore disable following gcc warnings/errors which caused the build
> > to fail:
> > +  + stringop-overflow
> > +  + return-type
> > +---
> > +
> > +--- a/hotspot/make/linux/makefiles/gcc.make
> > ++++ b/hotspot/make/linux/makefiles/gcc.make
> > +@@ -197,7 +197,7 @@
> > + endif
> > + 
> > + # Compiler warnings are treated as errors
> > +-WARNINGS_ARE_ERRORS = -Werror
> > ++WARNINGS_ARE_ERRORS = -Werror -Wno-stringop-overflow -Wno-
> > error=return-type
> > + 
> > + ifeq ($(USE_CLANG), true)
> > +   # However we need to clean the code up before we can unrestrictedly
> > enable this option with Clang
> >