All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] drm/i915: Fix PSR2 selective update corruption after PSR1 setup
@ 2019-03-14 23:01 José Roberto de Souza
  2019-03-15  0:26 ` ✓ Fi.CI.BAT: success for drm/i915: Fix PSR2 selective update corruption after PSR1 setup (rev3) Patchwork
                   ` (5 more replies)
  0 siblings, 6 replies; 9+ messages in thread
From: José Roberto de Souza @ 2019-03-14 23:01 UTC (permalink / raw)
  To: intel-gfx; +Cc: Dhinakaran Pandiyan

There is probably a issue in DMC firmwares(icl_dmc_ver1_07.bin and
kbl_dmc_ver1_04.bin at least) that causes PSR2 SU to fail after
exiting DC6 if EDP_PSR_TP1_TP3_SEL is kept in PSR_CTL, so for now
lets workaround the issue by cleaning PSR_CTL before enable PSR2.

v2:
- Updated commit description and comment to state that it may be
a DMC firmware issue (Rodrigo)
- No need to RMW, let's write 0 to PSR_CTL(Dhinakaran)

Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 drivers/gpu/drm/i915/intel_psr.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c
index 7d570a45fc17..10bf70e521b6 100644
--- a/drivers/gpu/drm/i915/intel_psr.c
+++ b/drivers/gpu/drm/i915/intel_psr.c
@@ -531,6 +531,14 @@ static void hsw_activate_psr2(struct intel_dp *intel_dp)
 	else
 		val |= EDP_PSR2_TP2_TIME_2500us;
 
+	/*
+	 * FIXME: There is probably a issue in DMC firmwares(icl_dmc_ver1_07.bin
+	 * and kbl_dmc_ver1_04.bin at least) that causes PSR2 SU to fail after
+	 * exiting DC6 if EDP_PSR_TP1_TP3_SEL is kept in PSR_CTL, so for now
+	 * lets workaround the issue by cleaning PSR_CTL before enable PSR2.
+	 */
+	I915_WRITE(EDP_PSR_CTL, 0);
+
 	I915_WRITE(EDP_PSR2_CTL, val);
 }
 
-- 
2.21.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2019-03-19 20:50 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-14 23:01 [PATCH v2] drm/i915: Fix PSR2 selective update corruption after PSR1 setup José Roberto de Souza
2019-03-15  0:26 ` ✓ Fi.CI.BAT: success for drm/i915: Fix PSR2 selective update corruption after PSR1 setup (rev3) Patchwork
2019-03-15 16:37 ` [PATCH v2] drm/i915: Fix PSR2 selective update corruption after PSR1 setup Rodrigo Vivi
2019-03-15 21:56 ` Dhinakaran Pandiyan
2019-03-15 22:28 ` ✗ Fi.CI.BAT: failure for drm/i915: Fix PSR2 selective update corruption after PSR1 setup (rev4) Patchwork
2019-03-19  0:07 ` ✓ Fi.CI.BAT: success for drm/i915: Fix PSR2 selective update corruption after PSR1 setup (rev5) Patchwork
2019-03-19 14:06 ` ✓ Fi.CI.IGT: " Patchwork
2019-03-19 19:55   ` Souza, Jose
2019-03-19 20:50     ` Dhinakaran Pandiyan

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.