Re: [Qemu-devel] [PATCH 2/7] s390x/pci: rework PCI STORE

From: Yi Min Zhao <zyimin@linux.vnet.ibm.com>
To: Cornelia Huck <cohuck@redhat.com>,
	Pierre Morel <pmorel@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, agraf@suse.de, borntraeger@de.ibm.com,
	pasic@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH 2/7] s390x/pci: rework PCI STORE
Date: Fri, 10 Nov 2017 17:22:26 +0800	[thread overview]
Message-ID: <9bd199cf-bc49-3030-5623-4f11a205429a@linux.vnet.ibm.com> (raw)
In-Reply-To: <20171109175018.1c2f1b60.cohuck@redhat.com>


在 2017/11/10 上午12:50, Cornelia Huck 写道:
> On Tue,  7 Nov 2017 18:24:34 +0100
> Pierre Morel <pmorel@linux.vnet.ibm.com> wrote:
>
>> Enhance the fault detection, correction of the fault reporting.
>>
>> Signed-off-by: Pierre Morel <pmorel@linux.vnet.ibm.com>
>> Reviewed-by: Yi Min Zhao <zyimin@linux.vnet.ibm.com>
>> ---
>>   hw/s390x/s390-pci-inst.c | 41 ++++++++++++++++++++++++-----------------
>>   1 file changed, 24 insertions(+), 17 deletions(-)
>>
>> diff --git a/hw/s390x/s390-pci-inst.c b/hw/s390x/s390-pci-inst.c
>> index 8fcb02d..4a2f996 100644
>> --- a/hw/s390x/s390-pci-inst.c
>> +++ b/hw/s390x/s390-pci-inst.c
>> @@ -469,6 +469,12 @@ int pcistg_service_call(S390CPU *cpu, uint8_t r1, uint8_t r2)
>>       pcias = (env->regs[r2] >> 16) & 0xf;
>>       len = env->regs[r2] & 0xf;
>>       offset = env->regs[r2 + 1];
>> +    data = env->regs[r1];
>> +
>> +    if (!(fh & FH_MASK_ENABLE)) {
> This covers the reserved/standby/disabled states, right?
yes

[...]