* [PATCH v3] docs: make sphinx-build be quiet by default
@ 2021-08-12 10:24 Daniel P. Berrangé
2021-08-12 10:26 ` Philippe Mathieu-Daudé
2021-08-12 10:41 ` Marc-André Lureau
0 siblings, 2 replies; 3+ messages in thread
From: Daniel P. Berrangé @ 2021-08-12 10:24 UTC (permalink / raw)
To: qemu-devel; +Cc: Daniel P. Berrangé
The sphinx-build is fairly verbose spitting out pages of output to the
console, which causes errors from other build commands to be scrolled
off the top of the terminal. This can leave the mistaken impression that
the build passed, when in fact there was a failure.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
In v3:
- Just set -q flag once in common arg list
docs/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/meson.build b/docs/meson.build
index 300b134329..cffe1ecf1d 100644
--- a/docs/meson.build
+++ b/docs/meson.build
@@ -9,7 +9,7 @@ endif
# Check if tools are available to build documentation.
build_docs = false
if sphinx_build.found()
- SPHINX_ARGS = ['env', 'CONFDIR=' + qemu_confdir, sphinx_build]
+ SPHINX_ARGS = ['env', 'CONFDIR=' + qemu_confdir, sphinx_build, '-q']
# If we're making warnings fatal, apply this to Sphinx runs as well
if get_option('werror')
SPHINX_ARGS += [ '-W' ]
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3] docs: make sphinx-build be quiet by default
2021-08-12 10:24 [PATCH v3] docs: make sphinx-build be quiet by default Daniel P. Berrangé
@ 2021-08-12 10:26 ` Philippe Mathieu-Daudé
2021-08-12 10:41 ` Marc-André Lureau
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-08-12 10:26 UTC (permalink / raw)
To: Daniel P. Berrangé, qemu-devel; +Cc: Thomas Huth
On 8/12/21 12:24 PM, Daniel P. Berrangé wrote:
> The sphinx-build is fairly verbose spitting out pages of output to the
> console, which causes errors from other build commands to be scrolled
> off the top of the terminal. This can leave the mistaken impression that
> the build passed, when in fact there was a failure.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>
> In v3:
>
> - Just set -q flag once in common arg list
>
> docs/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/docs/meson.build b/docs/meson.build
> index 300b134329..cffe1ecf1d 100644
> --- a/docs/meson.build
> +++ b/docs/meson.build
> @@ -9,7 +9,7 @@ endif
> # Check if tools are available to build documentation.
> build_docs = false
> if sphinx_build.found()
> - SPHINX_ARGS = ['env', 'CONFDIR=' + qemu_confdir, sphinx_build]
> + SPHINX_ARGS = ['env', 'CONFDIR=' + qemu_confdir, sphinx_build, '-q']
> # If we're making warnings fatal, apply this to Sphinx runs as well
> if get_option('werror')
> SPHINX_ARGS += [ '-W' ]
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] docs: make sphinx-build be quiet by default
2021-08-12 10:24 [PATCH v3] docs: make sphinx-build be quiet by default Daniel P. Berrangé
2021-08-12 10:26 ` Philippe Mathieu-Daudé
@ 2021-08-12 10:41 ` Marc-André Lureau
1 sibling, 0 replies; 3+ messages in thread
From: Marc-André Lureau @ 2021-08-12 10:41 UTC (permalink / raw)
To: Daniel P. Berrangé; +Cc: QEMU
[-- Attachment #1: Type: text/plain, Size: 1272 bytes --]
On Thu, Aug 12, 2021 at 2:25 PM Daniel P. Berrangé <berrange@redhat.com>
wrote:
> The sphinx-build is fairly verbose spitting out pages of output to the
> console, which causes errors from other build commands to be scrolled
> off the top of the terminal. This can leave the mistaken impression that
> the build passed, when in fact there was a failure.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
>
much welcome
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
>
> In v3:
>
> - Just set -q flag once in common arg list
>
> docs/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/docs/meson.build b/docs/meson.build
> index 300b134329..cffe1ecf1d 100644
> --- a/docs/meson.build
> +++ b/docs/meson.build
> @@ -9,7 +9,7 @@ endif
> # Check if tools are available to build documentation.
> build_docs = false
> if sphinx_build.found()
> - SPHINX_ARGS = ['env', 'CONFDIR=' + qemu_confdir, sphinx_build]
> + SPHINX_ARGS = ['env', 'CONFDIR=' + qemu_confdir, sphinx_build, '-q']
> # If we're making warnings fatal, apply this to Sphinx runs as well
> if get_option('werror')
> SPHINX_ARGS += [ '-W' ]
> --
> 2.31.1
>
>
>
--
Marc-André Lureau
[-- Attachment #2: Type: text/html, Size: 2081 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-12 10:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-12 10:24 [PATCH v3] docs: make sphinx-build be quiet by default Daniel P. Berrangé
2021-08-12 10:26 ` Philippe Mathieu-Daudé
2021-08-12 10:41 ` Marc-André Lureau
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.