* [PATCH net] bnxt_en: fix kernel doc warnings in bnxt_hwrm.c
@ 2021-09-01 18:53 Edwin Peer
2021-09-01 20:46 ` Florian Fainelli
2021-09-01 23:30 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Edwin Peer @ 2021-09-01 18:53 UTC (permalink / raw)
To: netdev; +Cc: michael.chan, andrew.gospodarek, davem, kuba, Edwin Peer
[-- Attachment #1: Type: text/plain, Size: 2416 bytes --]
Parameter names in the comments did not match the function arguments.
Fixes: 213808170840 ("bnxt_en: add support for HWRM request slices")
Signed-off-by: Edwin Peer <edwin.peer@broadcom.com>
Reported-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Michael Chan <michael.chan@broadcom.com>
---
drivers/net/ethernet/broadcom/bnxt/bnxt_hwrm.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_hwrm.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_hwrm.c
index acef61abe35d..bb7327b82d0b 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_hwrm.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_hwrm.c
@@ -145,11 +145,11 @@ void hwrm_req_timeout(struct bnxt *bp, void *req, unsigned int timeout)
* @bp: The driver context.
* @req: The request for which calls to hwrm_req_dma_slice() will have altered
* allocation flags.
- * @flags: A bitmask of GFP flags. These flags are passed to
- * dma_alloc_coherent() whenever it is used to allocate backing memory
- * for slices. Note that calls to hwrm_req_dma_slice() will not always
- * result in new allocations, however, memory suballocated from the
- * request buffer is already __GFP_ZERO.
+ * @gfp: A bitmask of GFP flags. These flags are passed to dma_alloc_coherent()
+ * whenever it is used to allocate backing memory for slices. Note that
+ * calls to hwrm_req_dma_slice() will not always result in new allocations,
+ * however, memory suballocated from the request buffer is already
+ * __GFP_ZERO.
*
* Sets the GFP allocation flags associated with the request for subsequent
* calls to hwrm_req_dma_slice(). This can be useful for specifying __GFP_ZERO
@@ -698,8 +698,8 @@ int hwrm_req_send_silent(struct bnxt *bp, void *req)
* @bp: The driver context.
* @req: The request for which indirect data will be associated.
* @size: The size of the allocation.
- * @dma: The bus address associated with the allocation. The HWRM API has no
- * knowledge about the type of the request and so cannot infer how the
+ * @dma_handle: The bus address associated with the allocation. The HWRM API has
+ * no knowledge about the type of the request and so cannot infer how the
* caller intends to use the indirect data. Thus, the caller is
* responsible for configuring the request object appropriately to
* point to the associated indirect memory. Note, DMA handle has the
--
2.33.0
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4203 bytes --]
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] bnxt_en: fix kernel doc warnings in bnxt_hwrm.c
2021-09-01 18:53 [PATCH net] bnxt_en: fix kernel doc warnings in bnxt_hwrm.c Edwin Peer
@ 2021-09-01 20:46 ` Florian Fainelli
2021-09-01 23:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2021-09-01 20:46 UTC (permalink / raw)
To: Edwin Peer, netdev; +Cc: michael.chan, andrew.gospodarek, davem, kuba
On 9/1/2021 11:53 AM, Edwin Peer wrote:
> Parameter names in the comments did not match the function arguments.
>
> Fixes: 213808170840 ("bnxt_en: add support for HWRM request slices")
> Signed-off-by: Edwin Peer <edwin.peer@broadcom.com>
> Reported-by: Jakub Kicinski <kuba@kernel.org>
> Reviewed-by: Michael Chan <michael.chan@broadcom.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
# Just because you copied me internally ;)
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] bnxt_en: fix kernel doc warnings in bnxt_hwrm.c
2021-09-01 18:53 [PATCH net] bnxt_en: fix kernel doc warnings in bnxt_hwrm.c Edwin Peer
2021-09-01 20:46 ` Florian Fainelli
@ 2021-09-01 23:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-09-01 23:30 UTC (permalink / raw)
To: Edwin Peer; +Cc: netdev, michael.chan, andrew.gospodarek, davem, kuba
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Wed, 1 Sep 2021 11:53:15 -0700 you wrote:
> Parameter names in the comments did not match the function arguments.
>
> Fixes: 213808170840 ("bnxt_en: add support for HWRM request slices")
> Signed-off-by: Edwin Peer <edwin.peer@broadcom.com>
> Reported-by: Jakub Kicinski <kuba@kernel.org>
> Reviewed-by: Michael Chan <michael.chan@broadcom.com>
>
> [...]
Here is the summary with links:
- [net] bnxt_en: fix kernel doc warnings in bnxt_hwrm.c
https://git.kernel.org/netdev/net/c/5240118f08a0
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-01 23:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-01 18:53 [PATCH net] bnxt_en: fix kernel doc warnings in bnxt_hwrm.c Edwin Peer
2021-09-01 20:46 ` Florian Fainelli
2021-09-01 23:30 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.