From: Jeff Layton <jlayton@kernel.org>
To: David Howells <dhowells@redhat.com>
Cc: Matthew Wilcox <willy@infradead.org>,
ceph-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/3] ceph: Uninline the data on a file opened for writing
Date: Mon, 17 Jan 2022 10:45:04 -0500 [thread overview]
Message-ID: <9c1fac5b5a11b5960b291f44f2c6baf56965b301.camel@kernel.org> (raw)
In-Reply-To: <2807617.1642433067@warthog.procyon.org.uk>
On Mon, 2022-01-17 at 15:24 +0000, David Howells wrote:
> Jeff Layton <jlayton@kernel.org> wrote:
>
> > On Mon, 2022-01-17 at 13:47 +0000, Matthew Wilcox wrote:
> > > This all falls very much under "doing it the hard way", and quite
> > > possibly under the "actively buggy with races" category.
> > >
> > > read_mapping_folio() does what you want, as long as you pass 'filp'
> > > as your 'void *data'. I should fix that type ...
>
>
> How much do we care about the case where we don't have either the
> CEPH_CAP_FILE_CACHE or the CEPH_CAP_FILE_LAZYIO caps? Is it possible just to
> shove the page into the pagecache whatever we do? At the moment there are two
> threads, both of which get a page - one attached to the page cache, one not.
> The rest is then common because from that point on, it doesn't matter where
> the folio resides.
>
Well, the protocol says that if you don't have CEPH_CAP_FILE_CACHE (Fc)
then you're not allowed to do reads from the cache. I wouldn't care if
we stuffed the page into the mapping anyway, but that could potentially
affect mmap readers at the same time.
OTOH, mmap reads when we don't have Fc is somewhat racy anyway. Maybe it
doesn't matter...
--
Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2022-01-17 15:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-17 12:44 [PATCH 1/3] ceph: Uninline the data on a file opened for writing David Howells
2022-01-17 12:44 ` [PATCH 2/3] ceph: Remove some other inline-setting bits David Howells
2022-01-17 12:44 ` [PATCH 3/3] ceph: Make ceph_netfs_issue_op() handle inlined data (untested) David Howells
2022-01-17 13:47 ` [PATCH 1/3] ceph: Uninline the data on a file opened for writing Matthew Wilcox
2022-01-17 14:11 ` Jeff Layton
2022-01-17 14:27 ` David Howells
2022-01-17 14:30 ` Jeff Layton
2022-01-17 15:24 ` David Howells
2022-01-17 15:45 ` Jeff Layton [this message]
2022-01-17 15:57 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c1fac5b5a11b5960b291f44f2c6baf56965b301.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=ceph-devel@vger.kernel.org \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.