From: Matthew Wilcox <willy@infradead.org>
To: David Howells <dhowells@redhat.com>
Cc: ceph-devel@vger.kernel.org, jlayton@kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/3] ceph: Uninline the data on a file opened for writing
Date: Mon, 17 Jan 2022 13:47:17 +0000 [thread overview]
Message-ID: <YeVzZZLcsX5Krcjh@casper.infradead.org> (raw)
In-Reply-To: <164242347319.2763588.2514920080375140879.stgit@warthog.procyon.org.uk>
On Mon, Jan 17, 2022 at 12:44:33PM +0000, David Howells wrote:
> + if (ceph_caps_issued(ci) & (CEPH_CAP_FILE_CACHE|CEPH_CAP_FILE_LAZYIO)) {
> + folio = filemap_get_folio(inode->i_mapping, 0);
> + if (folio) {
> + if (folio_test_uptodate(folio)) {
> from_pagecache = true;
> - lock_page(page);
> + folio_lock(folio);
> } else {
> - put_page(page);
> - page = NULL;
> + folio_put(folio);
> + folio = NULL;
This all falls very much under "doing it the hard way", and quite
possibly under the "actively buggy with races" category.
read_mapping_folio() does what you want, as long as you pass 'filp'
as your 'void *data'. I should fix that type ...
next prev parent reply other threads:[~2022-01-17 13:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-17 12:44 [PATCH 1/3] ceph: Uninline the data on a file opened for writing David Howells
2022-01-17 12:44 ` [PATCH 2/3] ceph: Remove some other inline-setting bits David Howells
2022-01-17 12:44 ` [PATCH 3/3] ceph: Make ceph_netfs_issue_op() handle inlined data (untested) David Howells
2022-01-17 13:47 ` Matthew Wilcox [this message]
2022-01-17 14:11 ` [PATCH 1/3] ceph: Uninline the data on a file opened for writing Jeff Layton
2022-01-17 14:27 ` David Howells
2022-01-17 14:30 ` Jeff Layton
2022-01-17 15:24 ` David Howells
2022-01-17 15:45 ` Jeff Layton
2022-01-17 15:57 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YeVzZZLcsX5Krcjh@casper.infradead.org \
--to=willy@infradead.org \
--cc=ceph-devel@vger.kernel.org \
--cc=dhowells@redhat.com \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.