* [Buildroot] [PATCH] package/sentry-native: new package
@ 2020-09-08 22:24 Joseph Kogut
2020-09-15 19:37 ` [Buildroot] [PATCH v2] " Joseph Kogut
0 siblings, 1 reply; 6+ messages in thread
From: Joseph Kogut @ 2020-09-08 22:24 UTC (permalink / raw)
To: buildroot
Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
---
DEVELOPERS | 1 +
package/Config.in | 1 +
.../0001-sentry.h-include-ucontext.h.patch | 28 +++++++++++++++++++
package/sentry-native/Config.in | 25 +++++++++++++++++
package/sentry-native/sentry-native.hash | 3 ++
package/sentry-native/sentry-native.mk | 18 ++++++++++++
6 files changed, 76 insertions(+)
create mode 100644 package/sentry-native/0001-sentry.h-include-ucontext.h.patch
create mode 100644 package/sentry-native/Config.in
create mode 100644 package/sentry-native/sentry-native.hash
create mode 100644 package/sentry-native/sentry-native.mk
diff --git a/DEVELOPERS b/DEVELOPERS
index 3c3dcda859..342eefc368 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1392,6 +1392,7 @@ F: package/python-schedule/
F: package/python-sentry-sdk/
F: package/python-websockets/
F: package/python-xlib/
+F: package/sentry-native/
F: package/unclutter-xfixes/
N: Joshua Henderson <joshua.henderson@microchip.com>
diff --git a/package/Config.in b/package/Config.in
index d7e79f4795..365d274c57 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -129,6 +129,7 @@ menu "Debugging, profiling and benchmark"
source "package/ramspeed/Config.in"
source "package/rt-tests/Config.in"
source "package/spidev_test/Config.in"
+ source "package/sentry-native/Config.in"
source "package/strace/Config.in"
source "package/stress/Config.in"
source "package/stress-ng/Config.in"
diff --git a/package/sentry-native/0001-sentry.h-include-ucontext.h.patch b/package/sentry-native/0001-sentry.h-include-ucontext.h.patch
new file mode 100644
index 0000000000..b4a427072c
--- /dev/null
+++ b/package/sentry-native/0001-sentry.h-include-ucontext.h.patch
@@ -0,0 +1,28 @@
+From 6a3b7b28f34c91c72d8b849903d93de2997b82f1 Mon Sep 17 00:00:00 2001
+From: Joseph Kogut <joseph.kogut@gmail.com>
+Date: Tue, 8 Sep 2020 11:40:01 -0700
+Subject: [PATCH] sentry.h: include ucontext.h
+
+This is included by signal.h in newer versions of GCC, but results in an
+unknown type name error in older versions.
+
+Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
+---
+ include/sentry.h | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/include/sentry.h b/include/sentry.h
+index 25754d9..a55cc00 100644
+--- a/include/sentry.h
++++ b/include/sentry.h
+@@ -78,6 +78,7 @@ extern "C" {
+ # include <wtypes.h>
+ #else
+ # include <signal.h>
++# include <ucontext.h>
+ #endif
+
+ /**
+--
+2.28.0
+
diff --git a/package/sentry-native/Config.in b/package/sentry-native/Config.in
new file mode 100644
index 0000000000..a65aca5155
--- /dev/null
+++ b/package/sentry-native/Config.in
@@ -0,0 +1,25 @@
+config BR2_PACKAGE_SENTRY_NATIVE
+ bool "sentry-native"
+ depends on BR2_INSTALL_LIBSTDCPP
+ depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
+ depends on BR2_USE_WCHAR
+ depends on BR2_TOOLCHAIN_HAS_THREADS
+ depends on BR2_TOOLCHAIN_USES_GLIBC
+ depends on BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS
+ depends on BR2_PACKAGE_HOST_GOOGLE_BREAKPAD_ARCH_SUPPORTS
+ select BR2_PACKAGE_GOOGLE_BREAKPAD
+ select BR2_PACKAGE_LIBCURL
+ help
+ The Sentry Native SDK is an error and crash
+ reporting client for native applications,
+ optimized for C and C++.
+
+ https://github.com/getsentry/sentry-native
+
+comment "sentry-native needs a glibc toolchain with w/ wchar, thread, C++, gcc >= 4.8"
+ depends on BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS
+ depends on BR2_PACKAGE_HOST_GOOGLE_BREAKPAD_ARCH_SUPPORTS
+ depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
+ !BR2_TOOLCHAIN_HAS_THREADS || \
+ !BR2_TOOLCHAIN_USES_GLIBC || \
+ !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
diff --git a/package/sentry-native/sentry-native.hash b/package/sentry-native/sentry-native.hash
new file mode 100644
index 0000000000..dffc7aeca3
--- /dev/null
+++ b/package/sentry-native/sentry-native.hash
@@ -0,0 +1,3 @@
+# locally calculated
+sha256 a7d04fe9b9175c30a58ce20ae23b510595045a66884a447dd21ff2d0c749751b sentry-native-0.4.1.tar.gz
+sha256 5ef07a3d95f1f779c1597c0fbaecbb7ba242128ff0587ed1e3214c7ac6154523 LICENSE
diff --git a/package/sentry-native/sentry-native.mk b/package/sentry-native/sentry-native.mk
new file mode 100644
index 0000000000..aaaeee1e43
--- /dev/null
+++ b/package/sentry-native/sentry-native.mk
@@ -0,0 +1,18 @@
+################################################################################
+#
+# sentry-native
+#
+################################################################################
+
+SENTRY_NATIVE_VERSION = 0.4.1
+SENTRY_NATIVE_SITE = $(call github,getsentry,sentry-native,$(SENTRY_NATIVE_VERSION))
+SENTRY_NATIVE_INSTALL_TARGET = NO
+SENTRY_NATIVE_INSTALL_STAGING = YES
+SENTRY_NATIVE_LICENSE = MIT
+SENTRY_NATIVE_LICENSE_FILES = LICENSE
+SENTRY_NATIVE_DEPENDENCIES = libcurl google-breakpad linux-syscall-support
+
+# Use the built system breakpad client instead of bundling
+SENTRY_NATIVE_CONF_OPTS += -DSENTRY_BREAKPAD_SYSTEM=ON
+
+$(eval $(cmake-package))
--
2.28.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2] package/sentry-native: new package
2020-09-08 22:24 [Buildroot] [PATCH] package/sentry-native: new package Joseph Kogut
@ 2020-09-15 19:37 ` Joseph Kogut
2020-09-15 20:51 ` Titouan Christophe
0 siblings, 1 reply; 6+ messages in thread
From: Joseph Kogut @ 2020-09-15 19:37 UTC (permalink / raw)
To: buildroot
Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
---
Changes v1 -> v2:
- Install libsentry to target
DEVELOPERS | 1 +
package/Config.in | 1 +
.../0001-sentry.h-include-ucontext.h.patch | 27 +++++++++++++++++++
package/sentry-native/Config.in | 25 +++++++++++++++++
package/sentry-native/sentry-native.hash | 3 +++
package/sentry-native/sentry-native.mk | 22 +++++++++++++++
6 files changed, 79 insertions(+)
create mode 100644 package/sentry-native/0001-sentry.h-include-ucontext.h.patch
create mode 100644 package/sentry-native/Config.in
create mode 100644 package/sentry-native/sentry-native.hash
create mode 100644 package/sentry-native/sentry-native.mk
diff --git a/DEVELOPERS b/DEVELOPERS
index d59d538e42..931f3a35f2 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1422,6 +1422,7 @@ F: package/python-schedule/
F: package/python-sentry-sdk/
F: package/python-websockets/
F: package/python-xlib/
+F: package/sentry-native/
F: package/unclutter-xfixes/
N: Joshua Henderson <joshua.henderson@microchip.com>
diff --git a/package/Config.in b/package/Config.in
index 1cf36fa28a..3672ad1f06 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -130,6 +130,7 @@ menu "Debugging, profiling and benchmark"
source "package/ramspeed/Config.in"
source "package/rt-tests/Config.in"
source "package/spidev_test/Config.in"
+ source "package/sentry-native/Config.in"
source "package/strace/Config.in"
source "package/stress/Config.in"
source "package/stress-ng/Config.in"
diff --git a/package/sentry-native/0001-sentry.h-include-ucontext.h.patch b/package/sentry-native/0001-sentry.h-include-ucontext.h.patch
new file mode 100644
index 0000000000..9505787245
--- /dev/null
+++ b/package/sentry-native/0001-sentry.h-include-ucontext.h.patch
@@ -0,0 +1,27 @@
+From 6a3b7b28f34c91c72d8b849903d93de2997b82f1 Mon Sep 17 00:00:00 2001
+From: Joseph Kogut <joseph.kogut@gmail.com>
+Date: Tue, 8 Sep 2020 11:40:01 -0700
+Subject: [PATCH] sentry.h: include ucontext.h
+
+This is included by signal.h in newer versions of GCC, but results in an
+unknown type name error in older versions.
+
+Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
+---
+ include/sentry.h | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/include/sentry.h b/include/sentry.h
+index 25754d9..a55cc00 100644
+--- a/include/sentry.h
++++ b/include/sentry.h
+@@ -78,6 +78,7 @@ extern "C" {
+ # include <wtypes.h>
+ #else
+ # include <signal.h>
++# include <ucontext.h>
+ #endif
+
+ /**
+--
+2.28.0
diff --git a/package/sentry-native/Config.in b/package/sentry-native/Config.in
new file mode 100644
index 0000000000..a65aca5155
--- /dev/null
+++ b/package/sentry-native/Config.in
@@ -0,0 +1,25 @@
+config BR2_PACKAGE_SENTRY_NATIVE
+ bool "sentry-native"
+ depends on BR2_INSTALL_LIBSTDCPP
+ depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
+ depends on BR2_USE_WCHAR
+ depends on BR2_TOOLCHAIN_HAS_THREADS
+ depends on BR2_TOOLCHAIN_USES_GLIBC
+ depends on BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS
+ depends on BR2_PACKAGE_HOST_GOOGLE_BREAKPAD_ARCH_SUPPORTS
+ select BR2_PACKAGE_GOOGLE_BREAKPAD
+ select BR2_PACKAGE_LIBCURL
+ help
+ The Sentry Native SDK is an error and crash
+ reporting client for native applications,
+ optimized for C and C++.
+
+ https://github.com/getsentry/sentry-native
+
+comment "sentry-native needs a glibc toolchain with w/ wchar, thread, C++, gcc >= 4.8"
+ depends on BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS
+ depends on BR2_PACKAGE_HOST_GOOGLE_BREAKPAD_ARCH_SUPPORTS
+ depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
+ !BR2_TOOLCHAIN_HAS_THREADS || \
+ !BR2_TOOLCHAIN_USES_GLIBC || \
+ !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
diff --git a/package/sentry-native/sentry-native.hash b/package/sentry-native/sentry-native.hash
new file mode 100644
index 0000000000..dffc7aeca3
--- /dev/null
+++ b/package/sentry-native/sentry-native.hash
@@ -0,0 +1,3 @@
+# locally calculated
+sha256 a7d04fe9b9175c30a58ce20ae23b510595045a66884a447dd21ff2d0c749751b sentry-native-0.4.1.tar.gz
+sha256 5ef07a3d95f1f779c1597c0fbaecbb7ba242128ff0587ed1e3214c7ac6154523 LICENSE
diff --git a/package/sentry-native/sentry-native.mk b/package/sentry-native/sentry-native.mk
new file mode 100644
index 0000000000..dcfdc1cee5
--- /dev/null
+++ b/package/sentry-native/sentry-native.mk
@@ -0,0 +1,22 @@
+################################################################################
+#
+# sentry-native
+#
+################################################################################
+
+SENTRY_NATIVE_VERSION = 0.4.1
+SENTRY_NATIVE_SITE = $(call github,getsentry,sentry-native,$(SENTRY_NATIVE_VERSION))
+SENTRY_NATIVE_INSTALL_STAGING = YES
+SENTRY_NATIVE_LICENSE = MIT
+SENTRY_NATIVE_LICENSE_FILES = LICENSE
+SENTRY_NATIVE_DEPENDENCIES = libcurl google-breakpad linux-syscall-support
+
+# Use the built system breakpad client instead of bundling
+SENTRY_NATIVE_CONF_OPTS += -DSENTRY_BREAKPAD_SYSTEM=ON
+
+define SENTRY_NATIVE_INSTALL_TARGET_CMDS
+ $(INSTALL) -m755 -t $(TARGET_DIR)/usr/lib/ \
+ $(@D)/libsentry.so
+endef
+
+$(eval $(cmake-package))
--
2.28.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2] package/sentry-native: new package
2020-09-15 19:37 ` [Buildroot] [PATCH v2] " Joseph Kogut
@ 2020-09-15 20:51 ` Titouan Christophe
2020-09-15 21:01 ` [Buildroot] [PATCH v3] " Joseph Kogut
0 siblings, 1 reply; 6+ messages in thread
From: Titouan Christophe @ 2020-09-15 20:51 UTC (permalink / raw)
To: buildroot
Hello Joseph and all,
On 15/09/20 21:37, Joseph Kogut wrote:
> Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
>
> ---
> Changes v1 -> v2:
> - Install libsentry to target
>
> DEVELOPERS | 1 +
> package/Config.in | 1 +
> .../0001-sentry.h-include-ucontext.h.patch | 27 +++++++++++++++++++
> package/sentry-native/Config.in | 25 +++++++++++++++++
> package/sentry-native/sentry-native.hash | 3 +++
> package/sentry-native/sentry-native.mk | 22 +++++++++++++++
> 6 files changed, 79 insertions(+)
> create mode 100644 package/sentry-native/0001-sentry.h-include-ucontext.h.patch
> create mode 100644 package/sentry-native/Config.in
> create mode 100644 package/sentry-native/sentry-native.hash
> create mode 100644 package/sentry-native/sentry-native.mk
>
> diff --git a/DEVELOPERS b/DEVELOPERS
> index d59d538e42..931f3a35f2 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -1422,6 +1422,7 @@ F: package/python-schedule/
> F: package/python-sentry-sdk/
> F: package/python-websockets/
> F: package/python-xlib/
> +F: package/sentry-native/
> F: package/unclutter-xfixes/
>
> N: Joshua Henderson <joshua.henderson@microchip.com>
> diff --git a/package/Config.in b/package/Config.in
> index 1cf36fa28a..3672ad1f06 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -130,6 +130,7 @@ menu "Debugging, profiling and benchmark"
> source "package/ramspeed/Config.in"
> source "package/rt-tests/Config.in"
> source "package/spidev_test/Config.in"
> + source "package/sentry-native/Config.in"
You should place this one line above to maintain the alphabetic order.
Besides this cosmetic comment,
Tested-by: Titouan Christophe <titouan.christophe@railnova.eu>
Cheers,
Titouan
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v3] package/sentry-native: new package
2020-09-15 20:51 ` Titouan Christophe
@ 2020-09-15 21:01 ` Joseph Kogut
2020-09-15 21:27 ` Titouan Christophe
2020-09-19 21:21 ` Thomas Petazzoni
0 siblings, 2 replies; 6+ messages in thread
From: Joseph Kogut @ 2020-09-15 21:01 UTC (permalink / raw)
To: buildroot
Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
---
Changes v2 -> v3:
- Fix order of Config.in entry (suggested by Titouan)
Changes v1 -> v2:
- Install libsentry to target
DEVELOPERS | 1 +
package/Config.in | 1 +
.../0001-sentry.h-include-ucontext.h.patch | 27 +++++++++++++++++++
package/sentry-native/Config.in | 25 +++++++++++++++++
package/sentry-native/sentry-native.hash | 3 +++
package/sentry-native/sentry-native.mk | 22 +++++++++++++++
6 files changed, 79 insertions(+)
create mode 100644 package/sentry-native/0001-sentry.h-include-ucontext.h.patch
create mode 100644 package/sentry-native/Config.in
create mode 100644 package/sentry-native/sentry-native.hash
create mode 100644 package/sentry-native/sentry-native.mk
diff --git a/DEVELOPERS b/DEVELOPERS
index d59d538e42..931f3a35f2 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1422,6 +1422,7 @@ F: package/python-schedule/
F: package/python-sentry-sdk/
F: package/python-websockets/
F: package/python-xlib/
+F: package/sentry-native/
F: package/unclutter-xfixes/
N: Joshua Henderson <joshua.henderson@microchip.com>
diff --git a/package/Config.in b/package/Config.in
index 1cf36fa28a..6b2a2eb48c 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -129,6 +129,7 @@ menu "Debugging, profiling and benchmark"
source "package/ramsmp/Config.in"
source "package/ramspeed/Config.in"
source "package/rt-tests/Config.in"
+ source "package/sentry-native/Config.in"
source "package/spidev_test/Config.in"
source "package/strace/Config.in"
source "package/stress/Config.in"
diff --git a/package/sentry-native/0001-sentry.h-include-ucontext.h.patch b/package/sentry-native/0001-sentry.h-include-ucontext.h.patch
new file mode 100644
index 0000000000..9505787245
--- /dev/null
+++ b/package/sentry-native/0001-sentry.h-include-ucontext.h.patch
@@ -0,0 +1,27 @@
+From 6a3b7b28f34c91c72d8b849903d93de2997b82f1 Mon Sep 17 00:00:00 2001
+From: Joseph Kogut <joseph.kogut@gmail.com>
+Date: Tue, 8 Sep 2020 11:40:01 -0700
+Subject: [PATCH] sentry.h: include ucontext.h
+
+This is included by signal.h in newer versions of GCC, but results in an
+unknown type name error in older versions.
+
+Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
+---
+ include/sentry.h | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/include/sentry.h b/include/sentry.h
+index 25754d9..a55cc00 100644
+--- a/include/sentry.h
++++ b/include/sentry.h
+@@ -78,6 +78,7 @@ extern "C" {
+ # include <wtypes.h>
+ #else
+ # include <signal.h>
++# include <ucontext.h>
+ #endif
+
+ /**
+--
+2.28.0
diff --git a/package/sentry-native/Config.in b/package/sentry-native/Config.in
new file mode 100644
index 0000000000..a65aca5155
--- /dev/null
+++ b/package/sentry-native/Config.in
@@ -0,0 +1,25 @@
+config BR2_PACKAGE_SENTRY_NATIVE
+ bool "sentry-native"
+ depends on BR2_INSTALL_LIBSTDCPP
+ depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
+ depends on BR2_USE_WCHAR
+ depends on BR2_TOOLCHAIN_HAS_THREADS
+ depends on BR2_TOOLCHAIN_USES_GLIBC
+ depends on BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS
+ depends on BR2_PACKAGE_HOST_GOOGLE_BREAKPAD_ARCH_SUPPORTS
+ select BR2_PACKAGE_GOOGLE_BREAKPAD
+ select BR2_PACKAGE_LIBCURL
+ help
+ The Sentry Native SDK is an error and crash
+ reporting client for native applications,
+ optimized for C and C++.
+
+ https://github.com/getsentry/sentry-native
+
+comment "sentry-native needs a glibc toolchain with w/ wchar, thread, C++, gcc >= 4.8"
+ depends on BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS
+ depends on BR2_PACKAGE_HOST_GOOGLE_BREAKPAD_ARCH_SUPPORTS
+ depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
+ !BR2_TOOLCHAIN_HAS_THREADS || \
+ !BR2_TOOLCHAIN_USES_GLIBC || \
+ !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
diff --git a/package/sentry-native/sentry-native.hash b/package/sentry-native/sentry-native.hash
new file mode 100644
index 0000000000..dffc7aeca3
--- /dev/null
+++ b/package/sentry-native/sentry-native.hash
@@ -0,0 +1,3 @@
+# locally calculated
+sha256 a7d04fe9b9175c30a58ce20ae23b510595045a66884a447dd21ff2d0c749751b sentry-native-0.4.1.tar.gz
+sha256 5ef07a3d95f1f779c1597c0fbaecbb7ba242128ff0587ed1e3214c7ac6154523 LICENSE
diff --git a/package/sentry-native/sentry-native.mk b/package/sentry-native/sentry-native.mk
new file mode 100644
index 0000000000..dcfdc1cee5
--- /dev/null
+++ b/package/sentry-native/sentry-native.mk
@@ -0,0 +1,22 @@
+################################################################################
+#
+# sentry-native
+#
+################################################################################
+
+SENTRY_NATIVE_VERSION = 0.4.1
+SENTRY_NATIVE_SITE = $(call github,getsentry,sentry-native,$(SENTRY_NATIVE_VERSION))
+SENTRY_NATIVE_INSTALL_STAGING = YES
+SENTRY_NATIVE_LICENSE = MIT
+SENTRY_NATIVE_LICENSE_FILES = LICENSE
+SENTRY_NATIVE_DEPENDENCIES = libcurl google-breakpad linux-syscall-support
+
+# Use the built system breakpad client instead of bundling
+SENTRY_NATIVE_CONF_OPTS += -DSENTRY_BREAKPAD_SYSTEM=ON
+
+define SENTRY_NATIVE_INSTALL_TARGET_CMDS
+ $(INSTALL) -m755 -t $(TARGET_DIR)/usr/lib/ \
+ $(@D)/libsentry.so
+endef
+
+$(eval $(cmake-package))
--
2.28.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v3] package/sentry-native: new package
2020-09-15 21:01 ` [Buildroot] [PATCH v3] " Joseph Kogut
@ 2020-09-15 21:27 ` Titouan Christophe
2020-09-19 21:21 ` Thomas Petazzoni
1 sibling, 0 replies; 6+ messages in thread
From: Titouan Christophe @ 2020-09-15 21:27 UTC (permalink / raw)
To: buildroot
Hello,
On 15/09/20 23:01, Joseph Kogut wrote:
> Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
Tested-by: Titouan Christophe <titouan.christophe@railnova.eu>
Reviewed-by: Titouan Christophe <titouan.christophe@railnova.eu>
Regards,
Titouan
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v3] package/sentry-native: new package
2020-09-15 21:01 ` [Buildroot] [PATCH v3] " Joseph Kogut
2020-09-15 21:27 ` Titouan Christophe
@ 2020-09-19 21:21 ` Thomas Petazzoni
1 sibling, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2020-09-19 21:21 UTC (permalink / raw)
To: buildroot
Hello,
On Tue, 15 Sep 2020 14:01:22 -0700
Joseph Kogut <joseph.kogut@gmail.com> wrote:
> Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
I've applied, with some changes, see below.
> diff --git a/package/sentry-native/0001-sentry.h-include-ucontext.h.patch b/package/sentry-native/0001-sentry.h-include-ucontext.h.patch
> new file mode 100644
> index 0000000000..9505787245
> --- /dev/null
> +++ b/package/sentry-native/0001-sentry.h-include-ucontext.h.patch
> @@ -0,0 +1,27 @@
> +From 6a3b7b28f34c91c72d8b849903d93de2997b82f1 Mon Sep 17 00:00:00 2001
> +From: Joseph Kogut <joseph.kogut@gmail.com>
> +Date: Tue, 8 Sep 2020 11:40:01 -0700
> +Subject: [PATCH] sentry.h: include ucontext.h
> +
> +This is included by signal.h in newer versions of GCC, but results in an
signal.h is not from GCC, but from the C library (in this case, glibc).
> diff --git a/package/sentry-native/sentry-native.hash b/package/sentry-native/sentry-native.hash
> new file mode 100644
> index 0000000000..dffc7aeca3
> --- /dev/null
> +++ b/package/sentry-native/sentry-native.hash
> @@ -0,0 +1,3 @@
> +# locally calculated
> +sha256 a7d04fe9b9175c30a58ce20ae23b510595045a66884a447dd21ff2d0c749751b sentry-native-0.4.1.tar.gz
> +sha256 5ef07a3d95f1f779c1597c0fbaecbb7ba242128ff0587ed1e3214c7ac6154523 LICENSE
> diff --git a/package/sentry-native/sentry-native.mk b/package/sentry-native/sentry-native.mk
> new file mode 100644
> index 0000000000..dcfdc1cee5
> --- /dev/null
> +++ b/package/sentry-native/sentry-native.mk
> @@ -0,0 +1,22 @@
> +################################################################################
> +#
> +# sentry-native
> +#
> +################################################################################
> +
> +SENTRY_NATIVE_VERSION = 0.4.1
> +SENTRY_NATIVE_SITE = $(call github,getsentry,sentry-native,$(SENTRY_NATIVE_VERSION))
> +SENTRY_NATIVE_INSTALL_STAGING = YES
> +SENTRY_NATIVE_LICENSE = MIT
> +SENTRY_NATIVE_LICENSE_FILES = LICENSE
> +SENTRY_NATIVE_DEPENDENCIES = libcurl google-breakpad linux-syscall-support
sentry-native does not use linux-syscall-support directly as far as I
can see, and you were anyway not selecting this package in your
Config.in file, so I dropped this.
I've added SENTRY_NATIVE_INSTALL_STAGING = YES, because sentry-native
is essentially a library... so if you don't have it in staging, no
other package can link against it.
> +define SENTRY_NATIVE_INSTALL_TARGET_CMDS
> + $(INSTALL) -m755 -t $(TARGET_DIR)/usr/lib/ \
> + $(@D)/libsentry.so
> +endef
This was not needed, the default "make install" does the right thing
already, so I dropped that.
As said: applied with those various issues fixed. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-09-19 21:21 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-08 22:24 [Buildroot] [PATCH] package/sentry-native: new package Joseph Kogut
2020-09-15 19:37 ` [Buildroot] [PATCH v2] " Joseph Kogut
2020-09-15 20:51 ` Titouan Christophe
2020-09-15 21:01 ` [Buildroot] [PATCH v3] " Joseph Kogut
2020-09-15 21:27 ` Titouan Christophe
2020-09-19 21:21 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.