Re: [PATCH 6/6] ARM: dts: omap4-droid4: Add LCD

[Tomi Valkeinen <tomi.valkeinen-l0cyMroinI0@public.gmane.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1743 bytes --]

On 20/03/17 00:55, Sebastian Reichel wrote:
> Hi,
> 
> On Sun, Mar 19, 2017 at 09:10:30AM -0700, Tony Lindgren wrote:
>> * Sebastian Reichel <sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> [170318 18:31]:
>>> Hi,
>>>
>>> On Sat, Mar 04, 2017 at 09:43:59PM -0800, Tony Lindgren wrote:
>>>> The LCD panel on droid 4 is a command mode LCD. The binding follows
>>>> the standard omapdrm binding and the changes needed for omapdrm command
>>>> mode panels are posted separately.
>>>>
>>>> Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>>>> Cc: Marcel Partap <mpartap-hi6Y0CQ0nG0@public.gmane.org>
>>>> Cc: Michael Scott <michael.scott-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>>>> Cc: Sebastian Reichel <sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
>>>> Cc: Tomi Valkeinen <tomi.valkeinen-l0cyMroinI0@public.gmane.org>
>>>> Signed-off-by: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
>>>
>>> Tested-By: Sebastian Reichel <sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
>>>
>>> With a non-modular kernel lcd is not working with omapdrm if HDMI
>>> is enabled. After dropping HDMI in droid4's dts file everything
>>> worked as expected. I assume both work properly with a modular
>>> kernel?
>>
>> Yes with loadable modules both work just fine. If things do not
>> work properly as built-in, chances are there's some unhandled
>> dependency that needs -EPROBE_DEFER somewhere for a regulator
>> or a clock.
> 
> I think that would also result in problems with disabled HDMI.
> I guess the problem is, that omapdrm is initialized too early.
> AFAIK omapdrm is not hotplug-capable.

It shouldn't matter when omapdrm is initialized. omapdrm should wait
until it has all the displays.

 Tomi


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]