All of lore.kernel.org
 help / color / mirror / Atom feed
* [RESEND PATCH v2 0/1] drm/msm/adreno: Add support for SM7150
@ 2024-02-18 19:50 Danila Tikhonov
  2024-02-18 19:50 ` [RESEND PATCH v2 1/1] drm/msm/adreno: Add support for SM7150 SoC machine Danila Tikhonov
  0 siblings, 1 reply; 3+ messages in thread
From: Danila Tikhonov @ 2024-02-18 19:50 UTC (permalink / raw)
  To: robdclark, quic_abhinavk, dmitry.baryshkov, sean, marijn.suijten,
	airlied, daniel, konrad.dybcio, johan+linaro, quic_bjorande
  Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel, Danila Tikhonov

This patch adds support for SM7150 SoC machine.

Reason for RESEND:
The discussion was resolved. As far as I understand, everything remains
unchanged. Let's make a RESEND for the patch so it doesn't get lost.
- Link to v2:
https://lore.kernel.org/all/20230926174243.161422-1-danila@jiaxyga.com/

Changes in v2:
- Use a630_gmu.bin instead of a618_gmu.bin.
- Use squashed version of a615_zap (.mbn).
- Drop .revn.
- Link to v1:
https://lore.kernel.org/all/20230913191957.26537-1-danila@jiaxyga.com/

Danila Tikhonov (1):
  drm/msm/adreno: Add support for SM7150 SoC machine

 drivers/gpu/drm/msm/adreno/adreno_device.c | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

-- 
2.43.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [RESEND PATCH v2 1/1] drm/msm/adreno: Add support for SM7150 SoC machine
  2024-02-18 19:50 [RESEND PATCH v2 0/1] drm/msm/adreno: Add support for SM7150 Danila Tikhonov
@ 2024-02-18 19:50 ` Danila Tikhonov
  2024-02-19 10:43   ` Konrad Dybcio
  0 siblings, 1 reply; 3+ messages in thread
From: Danila Tikhonov @ 2024-02-18 19:50 UTC (permalink / raw)
  To: robdclark, quic_abhinavk, dmitry.baryshkov, sean, marijn.suijten,
	airlied, daniel, konrad.dybcio, johan+linaro, quic_bjorande
  Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel, Danila Tikhonov

SM7150 has 5 power levels which correspond to 5 speed-bin values: 0,
128, 146, 167, 172. Speed-bin value is calulated as FMAX/4.8MHz round up
to zero decimal places.

Also a618 on SM7150 uses a615 zapfw. Add a squashed version (.mbn).

Add this as machine = "qcom,sm7150", because speed-bin values are
different from atoll (sc7180/sm7125).

Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
---
 drivers/gpu/drm/msm/adreno/adreno_device.c | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/msm/adreno/adreno_device.c
index 2ce7d7b1690d..b81f90fb4257 100644
--- a/drivers/gpu/drm/msm/adreno/adreno_device.c
+++ b/drivers/gpu/drm/msm/adreno/adreno_device.c
@@ -293,6 +293,27 @@ static const struct adreno_info gpulist[] = {
 			{ 157, 3 },
 			{ 127, 4 },
 		),
+	}, {
+		.machine = "qcom,sm7150",
+		.chip_ids = ADRENO_CHIP_IDS(0x06010800),
+		.family = ADRENO_6XX_GEN1,
+		.fw = {
+			[ADRENO_FW_SQE] = "a630_sqe.fw",
+			[ADRENO_FW_GMU] = "a630_gmu.bin",
+		},
+		.gmem = SZ_512K,
+		.inactive_period = DRM_MSM_INACTIVE_PERIOD,
+		.quirks = ADRENO_QUIRK_HAS_CACHED_COHERENT,
+		.init = a6xx_gpu_init,
+		.zapfw = "a615_zap.mbn",
+		.hwcg = a615_hwcg,
+		.speedbins = ADRENO_SPEEDBINS(
+			{ 0,   0 },
+			{ 128, 1 },
+			{ 146, 2 },
+			{ 167, 3 },
+			{ 172, 4 },
+		),
 	}, {
 		.chip_ids = ADRENO_CHIP_IDS(0x06010800),
 		.family = ADRENO_6XX_GEN1,
@@ -539,6 +560,7 @@ MODULE_FIRMWARE("qcom/a530_zap.b00");
 MODULE_FIRMWARE("qcom/a530_zap.b01");
 MODULE_FIRMWARE("qcom/a530_zap.b02");
 MODULE_FIRMWARE("qcom/a540_gpmu.fw2");
+MODULE_FIRMWARE("qcom/a615_zap.mbn");
 MODULE_FIRMWARE("qcom/a619_gmu.bin");
 MODULE_FIRMWARE("qcom/a630_sqe.fw");
 MODULE_FIRMWARE("qcom/a630_gmu.bin");
-- 
2.43.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [RESEND PATCH v2 1/1] drm/msm/adreno: Add support for SM7150 SoC machine
  2024-02-18 19:50 ` [RESEND PATCH v2 1/1] drm/msm/adreno: Add support for SM7150 SoC machine Danila Tikhonov
@ 2024-02-19 10:43   ` Konrad Dybcio
  0 siblings, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2024-02-19 10:43 UTC (permalink / raw)
  To: Danila Tikhonov, robdclark, quic_abhinavk, dmitry.baryshkov,
	sean, marijn.suijten, airlied, daniel, johan+linaro,
	quic_bjorande
  Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel

On 18.02.2024 20:50, Danila Tikhonov wrote:
> SM7150 has 5 power levels which correspond to 5 speed-bin values: 0,
> 128, 146, 167, 172. Speed-bin value is calulated as FMAX/4.8MHz round up
> to zero decimal places.
> 
> Also a618 on SM7150 uses a615 zapfw. Add a squashed version (.mbn).
> 
> Add this as machine = "qcom,sm7150", because speed-bin values are
> different from atoll (sc7180/sm7125).
> 
> Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
> ---

Sorry for the mess on the previous thread!

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-02-19 10:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-18 19:50 [RESEND PATCH v2 0/1] drm/msm/adreno: Add support for SM7150 Danila Tikhonov
2024-02-18 19:50 ` [RESEND PATCH v2 1/1] drm/msm/adreno: Add support for SM7150 SoC machine Danila Tikhonov
2024-02-19 10:43   ` Konrad Dybcio

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.