All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Olaf Hering <olaf@aepfle.de>,
	The development of GNU GRUB <grub-devel@gnu.org>
Cc: Daniel Kiper <daniel.kiper@oracle.com>
Subject: Re: [PATCH 1/4] Add new "version" command
Date: Thu, 29 Mar 2018 16:57:09 +0200	[thread overview]
Message-ID: <9c6f5546-9513-8e77-403f-1e306398c8bc@redhat.com> (raw)
In-Reply-To: <20180329075302.GB28579@aepfle.de>

Hi,

On 29-03-18 09:53, Olaf Hering wrote:
> On Wed, Mar 28, Hans de Goede wrote:
> 
>> +  grub_printf ("%s, build %s %s\n", PACKAGE_STRING, __DATE__, __TIME__);
> 
> NACK.
> 
> Debian sells something what they call "reproducible build". Check their
> website why usage of __DATE__ and __TIME__ is a bad thing.
> SUSE does not want to republish an otherwise unchanged grub2 package
> just because there was a need to rebuild the package.

Good point, lets drop this patch then, as without the date
I don't think there is much value in it and I don't feel
like spending time on this to come up with another solution.

Regards,

Hans




  parent reply	other threads:[~2018-03-29 14:57 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-28 14:50 [PATCH 0/4] Make hidden menu really hidden Hans de Goede
2018-03-28 14:50 ` [PATCH 1/4] Add new "version" command Hans de Goede
2018-03-29  7:53   ` Olaf Hering
2018-03-29  8:37     ` Thomas Schmitt
2018-03-29 14:57     ` Hans de Goede [this message]
2018-03-29 15:02       ` Olaf Hering
2018-04-05 11:41   ` Daniel Kiper
2018-03-28 14:50 ` [PATCH 2/4] Accept Both ESC and F8 as user interrupt keys Hans de Goede
2018-03-28 14:56   ` Lennart Sorensen
2018-03-28 15:06     ` Hans de Goede
2018-03-28 15:11       ` Lennart Sorensen
2018-03-28 15:58         ` Hans de Goede
2018-04-05 11:47           ` Daniel Kiper
2018-03-28 14:50 ` [PATCH 3/4] Optionally print less messages at boot Hans de Goede
2018-04-05 12:12   ` Daniel Kiper
2018-04-05 17:53     ` Hans de Goede
2018-04-06 11:41       ` Daniel Kiper
2018-03-28 14:50 ` [PATCH 4/4] EFI: Do not set text-mode until we actually need it Hans de Goede
2018-04-05 12:34   ` Daniel Kiper
2018-04-05 18:05     ` Hans de Goede
2018-04-06 11:44       ` Daniel Kiper
2018-03-28 15:04 ` [PATCH 0/4] Make hidden menu really hidden Daniel Kiper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9c6f5546-9513-8e77-403f-1e306398c8bc@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=daniel.kiper@oracle.com \
    --cc=grub-devel@gnu.org \
    --cc=olaf@aepfle.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.