All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ALSA: hda: Add Clevo W65_67SB the power_save blacklist
@ 2020-01-25 18:10 ` Hans de Goede
  0 siblings, 0 replies; 7+ messages in thread
From: Hans de Goede @ 2020-01-25 18:10 UTC (permalink / raw)
  To: Takashi Iwai, Jaroslav Kysela; +Cc: Hans de Goede, alsa-devel, stable

Using HDA power-saving on the Clevo W65_67SB causes the first 0.5
seconds of audio to be missing every time audio starts playing.

This commit adds the Clevo W65_67SB the power_save blacklist to avoid
this issue.

Cc: stable@vger.kernel.org
BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1525104
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 sound/pci/hda/hda_intel.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index 5b92f290cbb0..54d9ea1750f9 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -2185,6 +2185,8 @@ static struct snd_pci_quirk power_save_blacklist[] = {
 	/* https://bugzilla.redhat.com/show_bug.cgi?id=1581607 */
 	SND_PCI_QUIRK(0x1558, 0x3501, "Clevo W35xSS_370SS", 0),
 	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
+	SND_PCI_QUIRK(0x1558, 0x6504, "Clevo W65_67SB", 0),
+	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
 	SND_PCI_QUIRK(0x1028, 0x0497, "Dell Precision T3600", 0),
 	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
 	/* Note the P55A-UD3 and Z87-D3HP share the subsys id for the HDA dev */
-- 
2.23.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [alsa-devel] [PATCH] ALSA: hda: Add Clevo W65_67SB the power_save blacklist
@ 2020-01-25 18:10 ` Hans de Goede
  0 siblings, 0 replies; 7+ messages in thread
From: Hans de Goede @ 2020-01-25 18:10 UTC (permalink / raw)
  To: Takashi Iwai, Jaroslav Kysela; +Cc: Hans de Goede, alsa-devel, stable

Using HDA power-saving on the Clevo W65_67SB causes the first 0.5
seconds of audio to be missing every time audio starts playing.

This commit adds the Clevo W65_67SB the power_save blacklist to avoid
this issue.

Cc: stable@vger.kernel.org
BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1525104
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 sound/pci/hda/hda_intel.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index 5b92f290cbb0..54d9ea1750f9 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -2185,6 +2185,8 @@ static struct snd_pci_quirk power_save_blacklist[] = {
 	/* https://bugzilla.redhat.com/show_bug.cgi?id=1581607 */
 	SND_PCI_QUIRK(0x1558, 0x3501, "Clevo W35xSS_370SS", 0),
 	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
+	SND_PCI_QUIRK(0x1558, 0x6504, "Clevo W65_67SB", 0),
+	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
 	SND_PCI_QUIRK(0x1028, 0x0497, "Dell Precision T3600", 0),
 	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
 	/* Note the P55A-UD3 and Z87-D3HP share the subsys id for the HDA dev */
-- 
2.23.0

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [alsa-devel] [PATCH] ALSA: hda: Add Clevo W65_67SB the power_save blacklist
  2020-01-25 18:10 ` [alsa-devel] " Hans de Goede
  (?)
@ 2020-01-26  1:38 ` Sasha Levin
  2020-01-26 13:21     ` [alsa-devel] " Hans de Goede
  -1 siblings, 1 reply; 7+ messages in thread
From: Sasha Levin @ 2020-01-26  1:38 UTC (permalink / raw)
  To: Sasha Levin, Hans de Goede, Takashi Iwai, Jaroslav Kysela
  Cc: , Hans de Goede, alsa-devel, stable

Hi,

[This is an automated email]

This commit has been processed because it contains a -stable tag.
The stable tag indicates that it's relevant for the following trees: all

The bot has tested the following trees: v5.4.14, v4.19.98, v4.14.167, v4.9.211, v4.4.211.

v5.4.14: Build OK!
v4.19.98: Build OK!
v4.14.167: Failed to apply! Possible dependencies:
    38d9c12c0a6d ("ALSA: hda: Add Gigabyte P55A-UD3 and Z87-D3HP to the power_save blacklist")
    5cb6b5fc013e ("ALSA: hda: Add 2 more models to the power_save blacklist")
    b529ef2464ad ("ALSA: hda: Add Clevo W35xSS_370SS to the power_save blacklist")
    dd6dd5365404 ("ALSA: hda: Add Intel NUC7i3BNB to the power_save blacklist")
    f91f1806530d ("ALSA: hda: Add Intel NUC5i7RY to the power_save blacklist")

v4.9.211: Failed to apply! Possible dependencies:
    38d9c12c0a6d ("ALSA: hda: Add Gigabyte P55A-UD3 and Z87-D3HP to the power_save blacklist")
    5cb6b5fc013e ("ALSA: hda: Add 2 more models to the power_save blacklist")
    b529ef2464ad ("ALSA: hda: Add Clevo W35xSS_370SS to the power_save blacklist")
    dd6dd5365404 ("ALSA: hda: Add Intel NUC7i3BNB to the power_save blacklist")
    f91f1806530d ("ALSA: hda: Add Intel NUC5i7RY to the power_save blacklist")

v4.4.211: Failed to apply! Possible dependencies:
    38d9c12c0a6d ("ALSA: hda: Add Gigabyte P55A-UD3 and Z87-D3HP to the power_save blacklist")
    5cb6b5fc013e ("ALSA: hda: Add 2 more models to the power_save blacklist")
    b529ef2464ad ("ALSA: hda: Add Clevo W35xSS_370SS to the power_save blacklist")
    dd6dd5365404 ("ALSA: hda: Add Intel NUC7i3BNB to the power_save blacklist")
    f91f1806530d ("ALSA: hda: Add Intel NUC5i7RY to the power_save blacklist")


NOTE: The patch will not be queued to stable trees until it is upstream.

How should we proceed with this patch?

-- 
Thanks,
Sasha
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] ALSA: hda: Add Clevo W65_67SB the power_save blacklist
  2020-01-25 18:10 ` [alsa-devel] " Hans de Goede
@ 2020-01-26  8:29   ` Takashi Iwai
  -1 siblings, 0 replies; 7+ messages in thread
From: Takashi Iwai @ 2020-01-26  8:29 UTC (permalink / raw)
  To: Hans de Goede; +Cc: Takashi Iwai, Jaroslav Kysela, alsa-devel, stable

On Sat, 25 Jan 2020 19:10:21 +0100,
Hans de Goede wrote:
> 
> Using HDA power-saving on the Clevo W65_67SB causes the first 0.5
> seconds of audio to be missing every time audio starts playing.
> 
> This commit adds the Clevo W65_67SB the power_save blacklist to avoid
> this issue.
> 
> Cc: stable@vger.kernel.org
> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1525104
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Applied, thanks.


Takashi

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [alsa-devel] [PATCH] ALSA: hda: Add Clevo W65_67SB the power_save blacklist
@ 2020-01-26  8:29   ` Takashi Iwai
  0 siblings, 0 replies; 7+ messages in thread
From: Takashi Iwai @ 2020-01-26  8:29 UTC (permalink / raw)
  To: Hans de Goede; +Cc: alsa-devel, Takashi Iwai, stable

On Sat, 25 Jan 2020 19:10:21 +0100,
Hans de Goede wrote:
> 
> Using HDA power-saving on the Clevo W65_67SB causes the first 0.5
> seconds of audio to be missing every time audio starts playing.
> 
> This commit adds the Clevo W65_67SB the power_save blacklist to avoid
> this issue.
> 
> Cc: stable@vger.kernel.org
> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1525104
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Applied, thanks.


Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] ALSA: hda: Add Clevo W65_67SB the power_save blacklist
  2020-01-26  1:38 ` Sasha Levin
@ 2020-01-26 13:21     ` Hans de Goede
  0 siblings, 0 replies; 7+ messages in thread
From: Hans de Goede @ 2020-01-26 13:21 UTC (permalink / raw)
  To: Sasha Levin, Takashi Iwai, Jaroslav Kysela; +Cc: alsa-devel, stable

Hi,

On 26-01-2020 02:38, Sasha Levin wrote:
> Hi,
> 
> [This is an automated email]
> 
> This commit has been processed because it contains a -stable tag.
> The stable tag indicates that it's relevant for the following trees: all
> 
> The bot has tested the following trees: v5.4.14, v4.19.98, v4.14.167, v4.9.211, v4.4.211.
> 
> v5.4.14: Build OK!
> v4.19.98: Build OK!
> v4.14.167: Failed to apply! Possible dependencies:
>      38d9c12c0a6d ("ALSA: hda: Add Gigabyte P55A-UD3 and Z87-D3HP to the power_save blacklist")
>      5cb6b5fc013e ("ALSA: hda: Add 2 more models to the power_save blacklist")
>      b529ef2464ad ("ALSA: hda: Add Clevo W35xSS_370SS to the power_save blacklist")
>      dd6dd5365404 ("ALSA: hda: Add Intel NUC7i3BNB to the power_save blacklist")
>      f91f1806530d ("ALSA: hda: Add Intel NUC5i7RY to the power_save blacklist")
> 
> v4.9.211: Failed to apply! Possible dependencies:
>      38d9c12c0a6d ("ALSA: hda: Add Gigabyte P55A-UD3 and Z87-D3HP to the power_save blacklist")
>      5cb6b5fc013e ("ALSA: hda: Add 2 more models to the power_save blacklist")
>      b529ef2464ad ("ALSA: hda: Add Clevo W35xSS_370SS to the power_save blacklist")
>      dd6dd5365404 ("ALSA: hda: Add Intel NUC7i3BNB to the power_save blacklist")
>      f91f1806530d ("ALSA: hda: Add Intel NUC5i7RY to the power_save blacklist")
> 
> v4.4.211: Failed to apply! Possible dependencies:
>      38d9c12c0a6d ("ALSA: hda: Add Gigabyte P55A-UD3 and Z87-D3HP to the power_save blacklist")
>      5cb6b5fc013e ("ALSA: hda: Add 2 more models to the power_save blacklist")
>      b529ef2464ad ("ALSA: hda: Add Clevo W35xSS_370SS to the power_save blacklist")
>      dd6dd5365404 ("ALSA: hda: Add Intel NUC7i3BNB to the power_save blacklist")
>      f91f1806530d ("ALSA: hda: Add Intel NUC5i7RY to the power_save blacklist")
> 
> 
> NOTE: The patch will not be queued to stable trees until it is upstream.
> 
> How should we proceed with this patch?

Just adding it to 4.19.98 and 5.4 (and 5.5) is fine.
Regards,

Hans


^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [alsa-devel] [PATCH] ALSA: hda: Add Clevo W65_67SB the power_save blacklist
@ 2020-01-26 13:21     ` Hans de Goede
  0 siblings, 0 replies; 7+ messages in thread
From: Hans de Goede @ 2020-01-26 13:21 UTC (permalink / raw)
  To: Sasha Levin, Takashi Iwai, Jaroslav Kysela; +Cc: alsa-devel, stable

Hi,

On 26-01-2020 02:38, Sasha Levin wrote:
> Hi,
> 
> [This is an automated email]
> 
> This commit has been processed because it contains a -stable tag.
> The stable tag indicates that it's relevant for the following trees: all
> 
> The bot has tested the following trees: v5.4.14, v4.19.98, v4.14.167, v4.9.211, v4.4.211.
> 
> v5.4.14: Build OK!
> v4.19.98: Build OK!
> v4.14.167: Failed to apply! Possible dependencies:
>      38d9c12c0a6d ("ALSA: hda: Add Gigabyte P55A-UD3 and Z87-D3HP to the power_save blacklist")
>      5cb6b5fc013e ("ALSA: hda: Add 2 more models to the power_save blacklist")
>      b529ef2464ad ("ALSA: hda: Add Clevo W35xSS_370SS to the power_save blacklist")
>      dd6dd5365404 ("ALSA: hda: Add Intel NUC7i3BNB to the power_save blacklist")
>      f91f1806530d ("ALSA: hda: Add Intel NUC5i7RY to the power_save blacklist")
> 
> v4.9.211: Failed to apply! Possible dependencies:
>      38d9c12c0a6d ("ALSA: hda: Add Gigabyte P55A-UD3 and Z87-D3HP to the power_save blacklist")
>      5cb6b5fc013e ("ALSA: hda: Add 2 more models to the power_save blacklist")
>      b529ef2464ad ("ALSA: hda: Add Clevo W35xSS_370SS to the power_save blacklist")
>      dd6dd5365404 ("ALSA: hda: Add Intel NUC7i3BNB to the power_save blacklist")
>      f91f1806530d ("ALSA: hda: Add Intel NUC5i7RY to the power_save blacklist")
> 
> v4.4.211: Failed to apply! Possible dependencies:
>      38d9c12c0a6d ("ALSA: hda: Add Gigabyte P55A-UD3 and Z87-D3HP to the power_save blacklist")
>      5cb6b5fc013e ("ALSA: hda: Add 2 more models to the power_save blacklist")
>      b529ef2464ad ("ALSA: hda: Add Clevo W35xSS_370SS to the power_save blacklist")
>      dd6dd5365404 ("ALSA: hda: Add Intel NUC7i3BNB to the power_save blacklist")
>      f91f1806530d ("ALSA: hda: Add Intel NUC5i7RY to the power_save blacklist")
> 
> 
> NOTE: The patch will not be queued to stable trees until it is upstream.
> 
> How should we proceed with this patch?

Just adding it to 4.19.98 and 5.4 (and 5.5) is fine.
Regards,

Hans

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-01-26 13:22 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-25 18:10 [PATCH] ALSA: hda: Add Clevo W65_67SB the power_save blacklist Hans de Goede
2020-01-25 18:10 ` [alsa-devel] " Hans de Goede
2020-01-26  1:38 ` Sasha Levin
2020-01-26 13:21   ` Hans de Goede
2020-01-26 13:21     ` [alsa-devel] " Hans de Goede
2020-01-26  8:29 ` Takashi Iwai
2020-01-26  8:29   ` [alsa-devel] " Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.