Re: [Qemu-devel] [PATCHv2 02/04] colo-compare: Processpactkets in the IOThreadofthe primary

Re: [Qemu-devel] [PATCHv2 02/04] colo-compare: Processpactkets in the IOThreadofthe primary

[wang.yong155]

>On 24/07/2017 12:38, wang.yong155@zte.com.cn wrote:

>> finally use g_main_loop_run to replace aio_poll  in the

>> iothread_run function.

>

>That would make the performance of virtio-blk with iothreads worse,

>unfortunately.  aio_poll is much more optimized than g_main_loop_run.

Hi Paolo,

Any other good idea to achieve this?




Thanks




>

>Paolo

>

>> After that IOThread

>> runs the GMainContext event loop,chardev and IOThread can work together.

>> 

>> How about it? If feasible, I will try to submit 












原始邮件



发件人： <pbonzini@redhat.com>
收件人：王勇10170530 <stefanha@redhat.com> <jasowang@redhat.com> <marcandre.lureau@gmail.com>
抄送人： <zhang.zhanghailiang@huawei.com> <zhangchen.fnst@cn.fujitsu.com> <lizhijian@cn.fujitsu.com> <qemu-devel@nongnu.org>王广10165992
日 期 ：2017年07月24日 19:59
主 题 ：Re: [PATCHv2 02/04] colo-compare: Processpactkets in the IOThreadofthe primary





On 24/07/2017 12:38, wang.yong155@zte.com.cn wrote:
> finally use g_main_loop_run to replace aio_poll  in the
> iothread_run function.

That would make the performance of virtio-blk with iothreads worse,
unfortunately.  aio_poll is much more optimized than g_main_loop_run.

Paolo

> After that IOThread
> runs the GMainContext event loop,chardev and IOThread can work together.
> 
> How about it? If feasible, I will try to submit a patch.

Re: [Qemu-devel] [PATCHv2 02/04] colo-compare: Processpactkets in the IOThreadofthe primary

[Zhang Chen]

CC. Fam and David.

Any idea about it?


Thanks

Zhang Chen


On 07/25/2017 09:02 AM, wang.yong155@zte.com.cn wrote:
>
> >On 24/07/2017 12:38, wang.yong155@zte.com.cn wrote:
>
> >> finally use g_main_loop_run to replace aio_poll  in the
>
> >> iothread_run function.
>
> >
>
> >That would make the performance of virtio-blk with iothreads worse,
>
> >unfortunately.  aio_poll is much more optimized than g_main_loop_run.
>
> Hi Paolo,
>
> Any other good idea to achieve this?
>
>
> Thanks
>
>
> >
>
> >Paolo
>
> >
>
> >> After that IOThread
>
> >> runs the GMainContext event loop,chardev and IOThread can work 
> together.
>
> >>
>
> >> How about it? If feasible, I will try to submit
>
>
>
>
> 原始邮件
> *发件人：*<pbonzini@redhat.com>;
> *收件人：*王勇10170530;<stefanha@redhat.com>;<jasowang@redhat.com>;<marcandre.lureau@gmail.com>;
> *抄送人：*<zhang.zhanghailiang@huawei.com>;<zhangchen.fnst@cn.fujitsu.com>;<lizhijian@cn.fujitsu.com>;<qemu-devel@nongnu.org>;王广10165992;
> *日 期 ：*2017年07月24日 19:59
> *主 题 ：**Re: [PATCHv2 02/04] colo-compare: Processpactkets in the 
> IOThreadofthe primary*
>
>
> On 24/07/2017 12:38, wang.yong155@zte.com.cn wrote:
> > finally use g_main_loop_run to replace aio_poll  in the
> > iothread_run function.
>
> That would make the performance of virtio-blk with iothreads worse,
> unfortunately.  aio_poll is much more optimized than g_main_loop_run.
>
> Paolo
>
> > After that IOThread
> > runs the GMainContext event loop,chardev and IOThread can work together.
> >
> > How about it? If feasible, I will try to submit a patch.
>
>
>

-- 
Thanks
Zhang Chen

Re: [Qemu-devel] [PATCHv2 02/04] colo-compare: Processpactkets in the IOThreadofthe primary

[Fam Zheng]

On Thu, 07/27 15:47, Zhang Chen wrote:
> CC. Fam and David.
> 
> Any idea about it?

Is it possible to use g_main_context_{push,pop}_thread_default to "move" chardev
GSources to IOThread's context, then use g_main_context_query like main thread
and poll the fds in aio_poll?

Fam

> 
> 
> Thanks
> 
> Zhang Chen
> 
> 
> On 07/25/2017 09:02 AM, wang.yong155@zte.com.cn wrote:
> > 
> > >On 24/07/2017 12:38, wang.yong155@zte.com.cn wrote:
> > 
> > >> finally use g_main_loop_run to replace aio_poll  in the
> > 
> > >> iothread_run function.
> > 
> > >
> > 
> > >That would make the performance of virtio-blk with iothreads worse,
> > 
> > >unfortunately.  aio_poll is much more optimized than g_main_loop_run.
> > 
> > Hi Paolo,
> > 
> > Any other good idea to achieve this?
> > 
> > 
> > Thanks
> > 
> > 
> > >
> > 
> > >Paolo
> > 
> > >
> > 
> > >> After that IOThread
> > 
> > >> runs the GMainContext event loop,chardev and IOThread can work
> > together.
> > 
> > >>
> > 
> > >> How about it? If feasible, I will try to submit
> > 
> > 
> > 
> > 
> > 原始邮件
> > *发件人：*<pbonzini@redhat.com>;
> > *收件人：*王勇10170530;<stefanha@redhat.com>;<jasowang@redhat.com>;<marcandre.lureau@gmail.com>;
> > *抄送人：*<zhang.zhanghailiang@huawei.com>;<zhangchen.fnst@cn.fujitsu.com>;<lizhijian@cn.fujitsu.com>;<qemu-devel@nongnu.org>;王广10165992;
> > *日 期 ：*2017年07月24日 19:59
> > *主 题 ：**Re: [PATCHv2 02/04] colo-compare: Processpactkets in the
> > IOThreadofthe primary*
> > 
> > 
> > On 24/07/2017 12:38, wang.yong155@zte.com.cn wrote:
> > > finally use g_main_loop_run to replace aio_poll  in the
> > > iothread_run function.
> > 
> > That would make the performance of virtio-blk with iothreads worse,
> > unfortunately.  aio_poll is much more optimized than g_main_loop_run.
> > 
> > Paolo
> > 
> > > After that IOThread
> > > runs the GMainContext event loop,chardev and IOThread can work together.
> > >
> > > How about it? If feasible, I will try to submit a patch.
> > 
> > 
> > 
> 
> -- 
> Thanks
> Zhang Chen
> 
> 
> 
> 

Re: [Qemu-devel] [PATCHv2 02/04] colo-compare: Processpactkets in the IOThreadofthe primary

[Paolo Bonzini]

On 28/07/2017 02:25, Fam Zheng wrote:
> On Thu, 07/27 15:47, Zhang Chen wrote:
>> CC. Fam and David.
>>
>> Any idea about it?
> 
> Is it possible to use g_main_context_{push,pop}_thread_default to "move" chardev
> GSources to IOThread's context, then use g_main_context_query like main thread
> and poll the fds in aio_poll?

How would you do that without making aio_poll performance worse for
everyone?

Paolo

Re: [Qemu-devel] [PATCHv2 02/04] colo-compare: Processpactkets in the IOThreadofthe primary

[Fam Zheng]

On Tue, 08/01 12:25, Paolo Bonzini wrote:
> On 28/07/2017 02:25, Fam Zheng wrote:
> > On Thu, 07/27 15:47, Zhang Chen wrote:
> >> CC. Fam and David.
> >>
> >> Any idea about it?
> > 
> > Is it possible to use g_main_context_{push,pop}_thread_default to "move" chardev
> > GSources to IOThread's context, then use g_main_context_query like main thread
> > and poll the fds in aio_poll?
> 
> How would you do that without making aio_poll performance worse for
> everyone?

I don't knoe. Maintain a flag and only do these slow stuff after at least one
GSource has been moved around?

Fam