All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] x11vnc: update to 0.9.14
@ 2017-04-24 12:22 Martin Kepplinger
  2017-04-24 12:27 ` Martin Kepplinger
  0 siblings, 1 reply; 13+ messages in thread
From: Martin Kepplinger @ 2017-04-24 12:22 UTC (permalink / raw)
  To: buildroot

This uses x11vnc's new upstream location, github, via https. Autoreconf is
added, because it's really only a code snapshot release.

Signed-off-by: Martin Kepplinger <martin.kepplinger@ginzinger.com>
---
 package/x11vnc/x11vnc.hash | 2 +-
 package/x11vnc/x11vnc.mk   | 9 +++++++--
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/package/x11vnc/x11vnc.hash b/package/x11vnc/x11vnc.hash
index 5828b12..0da7765 100644
--- a/package/x11vnc/x11vnc.hash
+++ b/package/x11vnc/x11vnc.hash
@@ -1,2 +1,2 @@
 # Locally computed:
-sha256  f6829f2e629667a5284de62b080b13126a0736499fe47cdb447aedb07a59f13b  x11vnc-0.9.13.tar.gz
+sha256  45f87c5e4382988c73e8c7891ac2bfb45d8f9ce1196ae06651c84636684ea143  0.9.14.tar.gz
diff --git a/package/x11vnc/x11vnc.mk b/package/x11vnc/x11vnc.mk
index 9f4af12..d988201 100644
--- a/package/x11vnc/x11vnc.mk
+++ b/package/x11vnc/x11vnc.mk
@@ -4,8 +4,9 @@
 #
 ################################################################################
 
-X11VNC_VERSION = 0.9.13
-X11VNC_SITE = http://downloads.sourceforge.net/project/libvncserver/x11vnc/$(X11VNC_VERSION)
+X11VNC_VERSION = 0.9.14
+X11VNC_SOURCE = $(X11VNC_VERSION).tar.gz
+X11VNC_SITE = https://github.com/LibVNC/x11vnc/archive
 # sdl support is not used in x11vnc, but host include / library search paths
 # leak in if host has sdl-config
 X11VNC_CONF_OPTS = --without-sdl
@@ -13,6 +14,10 @@ X11VNC_DEPENDENCIES = xlib_libXt xlib_libXext xlib_libXtst
 X11VNC_LICENSE = GPL-2.0+
 X11VNC_LICENSE_FILES = COPYING
 
+# Upstream moved to github. It's archives don't include a configure script,
+# so we need to generate it.
+X11VNC_AUTORECONF = YES
+
 ifeq ($(BR2_PACKAGE_AVAHI_DAEMON)$(BR2_PACKAGE_DBUS),yy)
 X11VNC_DEPENDENCIES += avahi dbus
 else
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [Buildroot] [PATCH] x11vnc: update to 0.9.14
  2017-04-24 12:22 [Buildroot] [PATCH] x11vnc: update to 0.9.14 Martin Kepplinger
@ 2017-04-24 12:27 ` Martin Kepplinger
  2017-04-24 12:55   ` Vicente Olivert Riera
  0 siblings, 1 reply; 13+ messages in thread
From: Martin Kepplinger @ 2017-04-24 12:27 UTC (permalink / raw)
  To: buildroot

On 2017-04-24 14:22, Martin Kepplinger wrote:
> This uses x11vnc's new upstream location, github, via https. Autoreconf is
> added, because it's really only a code snapshot release.
> 
> Signed-off-by: Martin Kepplinger <martin.kepplinger@ginzinger.com>
> ---
>  package/x11vnc/x11vnc.hash | 2 +-
>  package/x11vnc/x11vnc.mk   | 9 +++++++--
>  2 files changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/package/x11vnc/x11vnc.hash b/package/x11vnc/x11vnc.hash
> index 5828b12..0da7765 100644
> --- a/package/x11vnc/x11vnc.hash
> +++ b/package/x11vnc/x11vnc.hash
> @@ -1,2 +1,2 @@
>  # Locally computed:
> -sha256  f6829f2e629667a5284de62b080b13126a0736499fe47cdb447aedb07a59f13b  x11vnc-0.9.13.tar.gz
> +sha256  45f87c5e4382988c73e8c7891ac2bfb45d8f9ce1196ae06651c84636684ea143  0.9.14.tar.gz


It's ugly to have 0.9.14.tar.gz. Is there a buildroot-style solution to
this?

And other than that, is there a reason why x11vnc had not been updated
before? 0.9.14 is one and a half years old.

thanks

                       martin

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Buildroot] [PATCH] x11vnc: update to 0.9.14
  2017-04-24 12:27 ` Martin Kepplinger
@ 2017-04-24 12:55   ` Vicente Olivert Riera
  2017-04-24 13:26     ` Martin Kepplinger
  0 siblings, 1 reply; 13+ messages in thread
From: Vicente Olivert Riera @ 2017-04-24 12:55 UTC (permalink / raw)
  To: buildroot

Hi Martin,

On 24/04/17 13:27, Martin Kepplinger wrote:
> On 2017-04-24 14:22, Martin Kepplinger wrote:
>> This uses x11vnc's new upstream location, github, via https. Autoreconf is
>> added, because it's really only a code snapshot release.
>>
>> Signed-off-by: Martin Kepplinger <martin.kepplinger@ginzinger.com>
>> ---
>>  package/x11vnc/x11vnc.hash | 2 +-
>>  package/x11vnc/x11vnc.mk   | 9 +++++++--
>>  2 files changed, 8 insertions(+), 3 deletions(-)
>>
>> diff --git a/package/x11vnc/x11vnc.hash b/package/x11vnc/x11vnc.hash
>> index 5828b12..0da7765 100644
>> --- a/package/x11vnc/x11vnc.hash
>> +++ b/package/x11vnc/x11vnc.hash
>> @@ -1,2 +1,2 @@
>>  # Locally computed:
>> -sha256  f6829f2e629667a5284de62b080b13126a0736499fe47cdb447aedb07a59f13b  x11vnc-0.9.13.tar.gz
>> +sha256  45f87c5e4382988c73e8c7891ac2bfb45d8f9ce1196ae06651c84636684ea143  0.9.14.tar.gz
> 
> 
> It's ugly to have 0.9.14.tar.gz. Is there a buildroot-style solution to
> this?

This is just fine, it's not the only package whose tarball name doesn't
include the package name. Look for instance the mpv and yaffs2utils
packages.

> 
> And other than that, is there a reason why x11vnc had not been updated
> before? 0.9.14 is one and a half years old.

Because nobody did it, probably. Anyway, the 0.9.14 is considered a
bleeding edge development release (according to x11vnc's website) and
even with that, as you said, is one and a half years old. Just
wondering..., shouldn't be better to go with ToT (top of the tree) instead?

X11VNC_VERSION = e47d922d4a4d980f8dce3e466c73dc4665e4bc01
X11VNC_SITE = $(call github,LibVNC,x11vnc,$(X11VNC_VERSION))

Regards,

Vincent

> 
> thanks
> 
>                        martin
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
> 

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Buildroot] [PATCH] x11vnc: update to 0.9.14
  2017-04-24 12:55   ` Vicente Olivert Riera
@ 2017-04-24 13:26     ` Martin Kepplinger
  2017-04-24 19:47       ` Arnout Vandecappelle
  0 siblings, 1 reply; 13+ messages in thread
From: Martin Kepplinger @ 2017-04-24 13:26 UTC (permalink / raw)
  To: buildroot



On 2017-04-24 14:55, Vicente Olivert Riera wrote:
> Hi Martin,
> 
> On 24/04/17 13:27, Martin Kepplinger wrote:
>> On 2017-04-24 14:22, Martin Kepplinger wrote:
>>> This uses x11vnc's new upstream location, github, via https. Autoreconf is
>>> added, because it's really only a code snapshot release.
>>>
>>> Signed-off-by: Martin Kepplinger <martin.kepplinger@ginzinger.com>
>>> ---
>>>  package/x11vnc/x11vnc.hash | 2 +-
>>>  package/x11vnc/x11vnc.mk   | 9 +++++++--
>>>  2 files changed, 8 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/package/x11vnc/x11vnc.hash b/package/x11vnc/x11vnc.hash
>>> index 5828b12..0da7765 100644
>>> --- a/package/x11vnc/x11vnc.hash
>>> +++ b/package/x11vnc/x11vnc.hash
>>> @@ -1,2 +1,2 @@
>>>  # Locally computed:
>>> -sha256  f6829f2e629667a5284de62b080b13126a0736499fe47cdb447aedb07a59f13b  x11vnc-0.9.13.tar.gz
>>> +sha256  45f87c5e4382988c73e8c7891ac2bfb45d8f9ce1196ae06651c84636684ea143  0.9.14.tar.gz
>>
>>
>> It's ugly to have 0.9.14.tar.gz. Is there a buildroot-style solution to
>> this?
> 
> This is just fine, it's not the only package whose tarball name doesn't
> include the package name. Look for instance the mpv and yaffs2utils
> packages.
> 
>>
>> And other than that, is there a reason why x11vnc had not been updated
>> before? 0.9.14 is one and a half years old.
> 
> Because nobody did it, probably. Anyway, the 0.9.14 is considered a
> bleeding edge development release (according to x11vnc's website) and
> even with that, as you said, is one and a half years old. Just
> wondering..., shouldn't be better to go with ToT (top of the tree) instead?
> 
> X11VNC_VERSION = e47d922d4a4d980f8dce3e466c73dc4665e4bc01
> X11VNC_SITE = $(call github,LibVNC,x11vnc,$(X11VNC_VERSION))
> 

They don't seem to use development branches; While I think it would be
fine to use the master branch, just from my personal feeling I'd use the
tagged versions. Seems like the project is maintained and 0.9.15 somehow
on the horizon sometime sooner or later.

> Regards,
> 
> Vincent
> 
>>
>> thanks
>>
>>                        martin
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
>>

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Buildroot] [PATCH] x11vnc: update to 0.9.14
  2017-04-24 13:26     ` Martin Kepplinger
@ 2017-04-24 19:47       ` Arnout Vandecappelle
  2017-04-25  7:23         ` Martin Kepplinger
  2017-04-26  8:03         ` Thomas Petazzoni
  0 siblings, 2 replies; 13+ messages in thread
From: Arnout Vandecappelle @ 2017-04-24 19:47 UTC (permalink / raw)
  To: buildroot



On 24-04-17 15:26, Martin Kepplinger wrote:
> 
> 
> On 2017-04-24 14:55, Vicente Olivert Riera wrote:
>> Hi Martin,
>>
>> On 24/04/17 13:27, Martin Kepplinger wrote:
>>> On 2017-04-24 14:22, Martin Kepplinger wrote:
>>>> This uses x11vnc's new upstream location, github, via https. Autoreconf is
>>>> added, because it's really only a code snapshot release.
>>>>
>>>> Signed-off-by: Martin Kepplinger <martin.kepplinger@ginzinger.com>
>>>> ---
>>>>  package/x11vnc/x11vnc.hash | 2 +-
>>>>  package/x11vnc/x11vnc.mk   | 9 +++++++--
>>>>  2 files changed, 8 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git a/package/x11vnc/x11vnc.hash b/package/x11vnc/x11vnc.hash
>>>> index 5828b12..0da7765 100644
>>>> --- a/package/x11vnc/x11vnc.hash
>>>> +++ b/package/x11vnc/x11vnc.hash
>>>> @@ -1,2 +1,2 @@
>>>>  # Locally computed:
>>>> -sha256  f6829f2e629667a5284de62b080b13126a0736499fe47cdb447aedb07a59f13b  x11vnc-0.9.13.tar.gz
>>>> +sha256  45f87c5e4382988c73e8c7891ac2bfb45d8f9ce1196ae06651c84636684ea143  0.9.14.tar.gz
>>>
>>>
>>> It's ugly to have 0.9.14.tar.gz. Is there a buildroot-style solution to
>>> this?

 Yes, the github helper. If the link contains 'archive', it's for the github
helper. If it contains 'releases', it's an uploaded tarball and you should use
the expanded URL.


>> This is just fine, it's not the only package whose tarball name doesn't
>> include the package name. Look for instance the mpv and yaffs2utils
>> packages.
>>
>>>
>>> And other than that, is there a reason why x11vnc had not been updated
>>> before? 0.9.14 is one and a half years old.
>>
>> Because nobody did it, probably. Anyway, the 0.9.14 is considered a
>> bleeding edge development release (according to x11vnc's website) and
>> even with that, as you said, is one and a half years old. Just
>> wondering..., shouldn't be better to go with ToT (top of the tree) instead?
>>
>> X11VNC_VERSION = e47d922d4a4d980f8dce3e466c73dc4665e4bc01
>> X11VNC_SITE = $(call github,LibVNC,x11vnc,$(X11VNC_VERSION))
>>
> 
> They don't seem to use development branches; While I think it would be
> fine to use the master branch, just from my personal feeling I'd use the
> tagged versions. Seems like the project is maintained and 0.9.15 somehow
> on the horizon sometime sooner or later.

 We indeed prefer to stick to officially released versions when upstream has
them. And we generally don't like to take releases that upstream considers a
development/alpha/... release.

 Is there a reason why you need this bump?

 Regards,
 Arnout


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Buildroot] [PATCH] x11vnc: update to 0.9.14
  2017-04-24 19:47       ` Arnout Vandecappelle
@ 2017-04-25  7:23         ` Martin Kepplinger
  2017-04-26  8:03         ` Thomas Petazzoni
  1 sibling, 0 replies; 13+ messages in thread
From: Martin Kepplinger @ 2017-04-25  7:23 UTC (permalink / raw)
  To: buildroot



On 2017-04-24 21:47, Arnout Vandecappelle wrote:
> 
> 
> On 24-04-17 15:26, Martin Kepplinger wrote:
>>
>>
>> On 2017-04-24 14:55, Vicente Olivert Riera wrote:
>>> Hi Martin,
>>>
>>> On 24/04/17 13:27, Martin Kepplinger wrote:
>>>> On 2017-04-24 14:22, Martin Kepplinger wrote:
>>>>> This uses x11vnc's new upstream location, github, via https. Autoreconf is
>>>>> added, because it's really only a code snapshot release.
>>>>>
>>>>> Signed-off-by: Martin Kepplinger <martin.kepplinger@ginzinger.com>
>>>>> ---
>>>>>  package/x11vnc/x11vnc.hash | 2 +-
>>>>>  package/x11vnc/x11vnc.mk   | 9 +++++++--
>>>>>  2 files changed, 8 insertions(+), 3 deletions(-)
>>>>>
>>>>> diff --git a/package/x11vnc/x11vnc.hash b/package/x11vnc/x11vnc.hash
>>>>> index 5828b12..0da7765 100644
>>>>> --- a/package/x11vnc/x11vnc.hash
>>>>> +++ b/package/x11vnc/x11vnc.hash
>>>>> @@ -1,2 +1,2 @@
>>>>>  # Locally computed:
>>>>> -sha256  f6829f2e629667a5284de62b080b13126a0736499fe47cdb447aedb07a59f13b  x11vnc-0.9.13.tar.gz
>>>>> +sha256  45f87c5e4382988c73e8c7891ac2bfb45d8f9ce1196ae06651c84636684ea143  0.9.14.tar.gz
>>>>
>>>>
>>>> It's ugly to have 0.9.14.tar.gz. Is there a buildroot-style solution to
>>>> this?
> 
>  Yes, the github helper. If the link contains 'archive', it's for the github
> helper. If it contains 'releases', it's an uploaded tarball and you should use
> the expanded URL.

thanks.

> 
> 
>>> This is just fine, it's not the only package whose tarball name doesn't
>>> include the package name. Look for instance the mpv and yaffs2utils
>>> packages.
>>>
>>>>
>>>> And other than that, is there a reason why x11vnc had not been updated
>>>> before? 0.9.14 is one and a half years old.
>>>
>>> Because nobody did it, probably. Anyway, the 0.9.14 is considered a
>>> bleeding edge development release (according to x11vnc's website) and
>>> even with that, as you said, is one and a half years old. Just
>>> wondering..., shouldn't be better to go with ToT (top of the tree) instead?
>>>
>>> X11VNC_VERSION = e47d922d4a4d980f8dce3e466c73dc4665e4bc01
>>> X11VNC_SITE = $(call github,LibVNC,x11vnc,$(X11VNC_VERSION))
>>>
>>
>> They don't seem to use development branches; While I think it would be
>> fine to use the master branch, just from my personal feeling I'd use the
>> tagged versions. Seems like the project is maintained and 0.9.15 somehow
>> on the horizon sometime sooner or later.
> 
>  We indeed prefer to stick to officially released versions when upstream has
> them. And we generally don't like to take releases that upstream considers a
> development/alpha/... release.
> 
>  Is there a reason why you need this bump?

Actually, no. There'd be a reason for me to have the next release. I
just thought to update in order to make it easier for 0.9.15. Let's
leave it as it is. I'll propose an update to 0.9.15 when released and
tested.

                          martin

> 
>  Regards,
>  Arnout
> 
> 

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Buildroot] [PATCH] x11vnc: update to 0.9.14
  2017-04-24 19:47       ` Arnout Vandecappelle
  2017-04-25  7:23         ` Martin Kepplinger
@ 2017-04-26  8:03         ` Thomas Petazzoni
  2017-04-26 12:37           ` [Buildroot] [PATCH v2] " Martin Kepplinger
  2017-04-28 20:17           ` [Buildroot] [PATCH] " Arnout Vandecappelle
  1 sibling, 2 replies; 13+ messages in thread
From: Thomas Petazzoni @ 2017-04-26  8:03 UTC (permalink / raw)
  To: buildroot

Hello,

On Mon, 24 Apr 2017 21:47:58 +0200, Arnout Vandecappelle wrote:

>  Is there a reason why you need this bump?

Well, do we need a reason to bump a package, other than "upstream has a
new release, possibly with new features/bug fixes" ? Tons of version
bumps we merged are not motivated by a specific reason, other than
making sure Buildroot uses recent versions of the different components.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Buildroot] [PATCH v2] x11vnc: update to 0.9.14
  2017-04-26  8:03         ` Thomas Petazzoni
@ 2017-04-26 12:37           ` Martin Kepplinger
  2017-04-28  7:02             ` Martin Kepplinger
  2017-04-28 20:23             ` Arnout Vandecappelle
  2017-04-28 20:17           ` [Buildroot] [PATCH] " Arnout Vandecappelle
  1 sibling, 2 replies; 13+ messages in thread
From: Martin Kepplinger @ 2017-04-26 12:37 UTC (permalink / raw)
  To: buildroot

This uses x11vnc's new upstream location at github. Autoreconf is
added because it's really only a code snapshot release.

Signed-off-by: Martin Kepplinger <martin.kepplinger@ginzinger.com>
---

In the end you're right and there's nothing special here. Without any reason,
buildroot doesn't hold on an old version. People do releases. People break
stuff. People fix stuff. Since I happen to need a fix in the upcoming 0.9.15
this is probably more reason to randomly update than other updates have.

... I tested it. For me, using Xfbdev, this 0.9.14 works just fine :)


revision history
----------------
v2: use the github helper instead of a URL
v1: initial proposal to update 0.9.13 to 0.9.14


 package/x11vnc/x11vnc.hash | 2 +-
 package/x11vnc/x11vnc.mk   | 6 ++++--
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/package/x11vnc/x11vnc.hash b/package/x11vnc/x11vnc.hash
index 5828b12..3cdbfa1 100644
--- a/package/x11vnc/x11vnc.hash
+++ b/package/x11vnc/x11vnc.hash
@@ -1,2 +1,2 @@
 # Locally computed:
-sha256  f6829f2e629667a5284de62b080b13126a0736499fe47cdb447aedb07a59f13b  x11vnc-0.9.13.tar.gz
+sha256  45f87c5e4382988c73e8c7891ac2bfb45d8f9ce1196ae06651c84636684ea143  x11vnc-0.9.14.tar.gz
diff --git a/package/x11vnc/x11vnc.mk b/package/x11vnc/x11vnc.mk
index 9f4af12..6c862dd 100644
--- a/package/x11vnc/x11vnc.mk
+++ b/package/x11vnc/x11vnc.mk
@@ -4,8 +4,8 @@
 #
 ################################################################################
 
-X11VNC_VERSION = 0.9.13
-X11VNC_SITE = http://downloads.sourceforge.net/project/libvncserver/x11vnc/$(X11VNC_VERSION)
+X11VNC_VERSION = 0.9.14
+X11VNC_SITE = $(call github,LibVNC,x11vnc,$(X11VNC_VERSION))
 # sdl support is not used in x11vnc, but host include / library search paths
 # leak in if host has sdl-config
 X11VNC_CONF_OPTS = --without-sdl
@@ -13,6 +13,8 @@ X11VNC_DEPENDENCIES = xlib_libXt xlib_libXext xlib_libXtst
 X11VNC_LICENSE = GPL-2.0+
 X11VNC_LICENSE_FILES = COPYING
 
+X11VNC_AUTORECONF = YES
+
 ifeq ($(BR2_PACKAGE_AVAHI_DAEMON)$(BR2_PACKAGE_DBUS),yy)
 X11VNC_DEPENDENCIES += avahi dbus
 else
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [Buildroot] [PATCH v2] x11vnc: update to 0.9.14
  2017-04-26 12:37           ` [Buildroot] [PATCH v2] " Martin Kepplinger
@ 2017-04-28  7:02             ` Martin Kepplinger
  2017-04-28 20:23             ` Arnout Vandecappelle
  1 sibling, 0 replies; 13+ messages in thread
From: Martin Kepplinger @ 2017-04-28  7:02 UTC (permalink / raw)
  To: buildroot


On 2017-04-26 14:37, Martin Kepplinger wrote:
> This uses x11vnc's new upstream location at github. Autoreconf is
> added because it's really only a code snapshot release.
> 
> Signed-off-by: Martin Kepplinger <martin.kepplinger@ginzinger.com>
> ---
> 
> In the end you're right and there's nothing special here. Without any reason,
> buildroot doesn't hold on an old version. People do releases. People break
> stuff. People fix stuff. Since I happen to need a fix in the upcoming 0.9.15
> this is probably more reason to randomly update than other updates have.
> 
> ... I tested it. For me, using Xfbdev, this 0.9.14 works just fine :)
> 
> 
> revision history
> ----------------
> v2: use the github helper instead of a URL
> v1: initial proposal to update 0.9.13 to 0.9.14
> 

Any objections? What *is* to note here maybe, is that with 0.9.14 they
renamed their x11vnc souce directory to src internally. In case people
have patches, they need to be adapted. But again, that's nothing special
here :)

thanks
                   martin

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Buildroot] [PATCH] x11vnc: update to 0.9.14
  2017-04-26  8:03         ` Thomas Petazzoni
  2017-04-26 12:37           ` [Buildroot] [PATCH v2] " Martin Kepplinger
@ 2017-04-28 20:17           ` Arnout Vandecappelle
  1 sibling, 0 replies; 13+ messages in thread
From: Arnout Vandecappelle @ 2017-04-28 20:17 UTC (permalink / raw)
  To: buildroot



On 26-04-17 10:03, Thomas Petazzoni wrote:
> Hello,
> 
> On Mon, 24 Apr 2017 21:47:58 +0200, Arnout Vandecappelle wrote:
> 
>>  Is there a reason why you need this bump?
> 
> Well, do we need a reason to bump a package, other than "upstream has a
> new release, possibly with new features/bug fixes" ? Tons of version
> bumps we merged are not motivated by a specific reason, other than
> making sure Buildroot uses recent versions of the different components.

 Why did you remove the part that explains exactly this?

>> On Mon, 24 Apr 2017 21:47:58 +0200, Arnout Vandecappelle wrote:
>>>  We indeed prefer to stick to officially released versions when upstream has
>>> them. And we generally don't like to take releases that upstream considers a
>>> development/alpha/... release.

 Quoting the x11vnc website [1]:

-----
As of Sep 2011, the x11vnc-0.9.13.tar.gz source package is released (recommended
download). [...] Also, you can get a copy of my latest, bleeding edge
x11vnc-0.9.14-dev.tar.gz tarball to build the most up to date one.
-----


 However, I didn't actually read that website before, I just read Vicente's
comment. If I had read the website, I would have noticed that it refers to a
-dev tarball, and that at the time it was expected that a real release would
happen end of 2011.

 With that in mind, I think we can conclude that the website is simply out of
date and should be relied on, and that there is no reason not to bump to 0.9.14.


 Regards,
 Arnout

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Buildroot] [PATCH v2] x11vnc: update to 0.9.14
  2017-04-26 12:37           ` [Buildroot] [PATCH v2] " Martin Kepplinger
  2017-04-28  7:02             ` Martin Kepplinger
@ 2017-04-28 20:23             ` Arnout Vandecappelle
  2017-04-29 13:00               ` [Buildroot] [PATCH v3] " Martin Kepplinger
  1 sibling, 1 reply; 13+ messages in thread
From: Arnout Vandecappelle @ 2017-04-28 20:23 UTC (permalink / raw)
  To: buildroot

 Hi Martin,

On 26-04-17 14:37, Martin Kepplinger wrote:
> This uses x11vnc's new upstream location at github. Autoreconf is
> added because it's really only a code snapshot release.
> 
> Signed-off-by: Martin Kepplinger <martin.kepplinger@ginzinger.com>
> ---
> 
> In the end you're right and there's nothing special here. Without any reason,
> buildroot doesn't hold on an old version. People do releases. People break
> stuff. People fix stuff. Since I happen to need a fix in the upcoming 0.9.15
> this is probably more reason to randomly update than other updates have.
> 
> ... I tested it. For me, using Xfbdev, this 0.9.14 works just fine :)
> 
> 
> revision history
> ----------------
> v2: use the github helper instead of a URL
> v1: initial proposal to update 0.9.13 to 0.9.14
> 
> 
>  package/x11vnc/x11vnc.hash | 2 +-
>  package/x11vnc/x11vnc.mk   | 6 ++++--
>  2 files changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/package/x11vnc/x11vnc.hash b/package/x11vnc/x11vnc.hash
> index 5828b12..3cdbfa1 100644
> --- a/package/x11vnc/x11vnc.hash
> +++ b/package/x11vnc/x11vnc.hash
> @@ -1,2 +1,2 @@
>  # Locally computed:
> -sha256  f6829f2e629667a5284de62b080b13126a0736499fe47cdb447aedb07a59f13b  x11vnc-0.9.13.tar.gz
> +sha256  45f87c5e4382988c73e8c7891ac2bfb45d8f9ce1196ae06651c84636684ea143  x11vnc-0.9.14.tar.gz
> diff --git a/package/x11vnc/x11vnc.mk b/package/x11vnc/x11vnc.mk
> index 9f4af12..6c862dd 100644
> --- a/package/x11vnc/x11vnc.mk
> +++ b/package/x11vnc/x11vnc.mk
> @@ -4,8 +4,8 @@
>  #
>  ################################################################################
>  
> -X11VNC_VERSION = 0.9.13
> -X11VNC_SITE = http://downloads.sourceforge.net/project/libvncserver/x11vnc/$(X11VNC_VERSION)
> +X11VNC_VERSION = 0.9.14
> +X11VNC_SITE = $(call github,LibVNC,x11vnc,$(X11VNC_VERSION))
>  # sdl support is not used in x11vnc, but host include / library search paths
>  # leak in if host has sdl-config
>  X11VNC_CONF_OPTS = --without-sdl
> @@ -13,6 +13,8 @@ X11VNC_DEPENDENCIES = xlib_libXt xlib_libXext xlib_libXtst
>  X11VNC_LICENSE = GPL-2.0+
>  X11VNC_LICENSE_FILES = COPYING
>  
> +X11VNC_AUTORECONF = YES

 Please add a comment above it:

# Source coming from github, no configure included


 If you resubmit, you can add my

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>



 Regards,
 Arnout


> +
>  ifeq ($(BR2_PACKAGE_AVAHI_DAEMON)$(BR2_PACKAGE_DBUS),yy)
>  X11VNC_DEPENDENCIES += avahi dbus
>  else
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Buildroot] [PATCH v3] x11vnc: update to 0.9.14
  2017-04-28 20:23             ` Arnout Vandecappelle
@ 2017-04-29 13:00               ` Martin Kepplinger
  2017-04-29 13:25                 ` Thomas Petazzoni
  0 siblings, 1 reply; 13+ messages in thread
From: Martin Kepplinger @ 2017-04-29 13:00 UTC (permalink / raw)
  To: buildroot

This switches to x11vnc's new upstream location at github. Autoreconf is
added because it's only a code snapshot release. Subsequent releases
will most probably look the same, see
https://github.com/LibVNC/x11vnc/issues/35#issuecomment-297474900

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Signed-off-by: Martin Kepplinger <martink@posteo.de>
---

redone the patch. As mentioned earlier, I at least did a test-run with
this version. And 0.9.15 is indeed in the works, see
https://github.com/LibVNC/x11vnc/milestone/2 :)


revision history
----------------
v3: add a comment, why AUTORECONF is added; thanks Arnout Vandecappelle
v2: use the github helper instead of a URL
v1: initial proposal to update 0.9.13 to 0.9.14


 package/x11vnc/x11vnc.hash | 2 +-
 package/x11vnc/x11vnc.mk   | 7 +++++--
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/package/x11vnc/x11vnc.hash b/package/x11vnc/x11vnc.hash
index 5828b12cd..3cdbfa1b0 100644
--- a/package/x11vnc/x11vnc.hash
+++ b/package/x11vnc/x11vnc.hash
@@ -1,2 +1,2 @@
 # Locally computed:
-sha256  f6829f2e629667a5284de62b080b13126a0736499fe47cdb447aedb07a59f13b  x11vnc-0.9.13.tar.gz
+sha256  45f87c5e4382988c73e8c7891ac2bfb45d8f9ce1196ae06651c84636684ea143  x11vnc-0.9.14.tar.gz
diff --git a/package/x11vnc/x11vnc.mk b/package/x11vnc/x11vnc.mk
index 9f4af1258..9233b7047 100644
--- a/package/x11vnc/x11vnc.mk
+++ b/package/x11vnc/x11vnc.mk
@@ -4,8 +4,8 @@
 #
 ################################################################################
 
-X11VNC_VERSION = 0.9.13
-X11VNC_SITE = http://downloads.sourceforge.net/project/libvncserver/x11vnc/$(X11VNC_VERSION)
+X11VNC_VERSION = 0.9.14
+X11VNC_SITE = $(call github,LibVNC,x11vnc,$(X11VNC_VERSION))
 # sdl support is not used in x11vnc, but host include / library search paths
 # leak in if host has sdl-config
 X11VNC_CONF_OPTS = --without-sdl
@@ -13,6 +13,9 @@ X11VNC_DEPENDENCIES = xlib_libXt xlib_libXext xlib_libXtst
 X11VNC_LICENSE = GPL-2.0+
 X11VNC_LICENSE_FILES = COPYING
 
+# Source coming from github, no configure included
+X11VNC_AUTORECONF = YES
+
 ifeq ($(BR2_PACKAGE_AVAHI_DAEMON)$(BR2_PACKAGE_DBUS),yy)
 X11VNC_DEPENDENCIES += avahi dbus
 else
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [Buildroot] [PATCH v3] x11vnc: update to 0.9.14
  2017-04-29 13:00               ` [Buildroot] [PATCH v3] " Martin Kepplinger
@ 2017-04-29 13:25                 ` Thomas Petazzoni
  0 siblings, 0 replies; 13+ messages in thread
From: Thomas Petazzoni @ 2017-04-29 13:25 UTC (permalink / raw)
  To: buildroot

Hello,

On Sat, 29 Apr 2017 15:00:34 +0200, Martin Kepplinger wrote:
> This switches to x11vnc's new upstream location at github. Autoreconf is
> added because it's only a code snapshot release. Subsequent releases
> will most probably look the same, see
> https://github.com/LibVNC/x11vnc/issues/35#issuecomment-297474900
> 
> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> Signed-off-by: Martin Kepplinger <martink@posteo.de>
> ---

Applied to master, thanks. Since you are interested in x11vnc, can you
add yourself as a developer for this package in the DEVELOPERS file ?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2017-04-29 13:25 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-24 12:22 [Buildroot] [PATCH] x11vnc: update to 0.9.14 Martin Kepplinger
2017-04-24 12:27 ` Martin Kepplinger
2017-04-24 12:55   ` Vicente Olivert Riera
2017-04-24 13:26     ` Martin Kepplinger
2017-04-24 19:47       ` Arnout Vandecappelle
2017-04-25  7:23         ` Martin Kepplinger
2017-04-26  8:03         ` Thomas Petazzoni
2017-04-26 12:37           ` [Buildroot] [PATCH v2] " Martin Kepplinger
2017-04-28  7:02             ` Martin Kepplinger
2017-04-28 20:23             ` Arnout Vandecappelle
2017-04-29 13:00               ` [Buildroot] [PATCH v3] " Martin Kepplinger
2017-04-29 13:25                 ` Thomas Petazzoni
2017-04-28 20:17           ` [Buildroot] [PATCH] " Arnout Vandecappelle

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.