From: Oleksii Kurochko <oleksii.kurochko@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Gianluca Guida <gianluca@rivosinc.com>,
Oleksii Kurochko <oleksii.kurochko@gmail.com>,
Bob Eshleman <bobbyeshleman@gmail.com>,
Alistair Francis <alistair.francis@wdc.com>,
Connor Davis <connojdavis@gmail.com>
Subject: [PATCH v2 08/14] xen/riscv: introduce exception handlers implementation
Date: Fri, 27 Jan 2023 15:59:13 +0200 [thread overview]
Message-ID: <9cc958411ef5e0a36bbfb056a71ce7232e6665ef.1674818705.git.oleksii.kurochko@gmail.com> (raw)
In-Reply-To: <cover.1674818705.git.oleksii.kurochko@gmail.com>
The patch introduces an implementation of basic exception handlers:
- to save/restore context
- to handle an exception itself. The handler calls wait_for_interrupt
now, nothing more.
Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
---
Changes in V2:
- Refactor entry.S to start using of defines introduced in asm_offsets.C
- Rename {__,}handle_exception to handle_trap() and do_trap() to be more
consistent with RISC-V spec.
- Wrap handle_trap() to ENTRY().
---
xen/arch/riscv/Makefile | 2 +
xen/arch/riscv/entry.S | 94 ++++++++++++++++++++++++++++++
xen/arch/riscv/include/asm/traps.h | 13 +++++
xen/arch/riscv/traps.c | 13 +++++
4 files changed, 122 insertions(+)
create mode 100644 xen/arch/riscv/entry.S
create mode 100644 xen/arch/riscv/include/asm/traps.h
create mode 100644 xen/arch/riscv/traps.c
diff --git a/xen/arch/riscv/Makefile b/xen/arch/riscv/Makefile
index 1a4f1a6015..443f6bf15f 100644
--- a/xen/arch/riscv/Makefile
+++ b/xen/arch/riscv/Makefile
@@ -1,7 +1,9 @@
obj-$(CONFIG_EARLY_PRINTK) += early_printk.o
+obj-y += entry.o
obj-$(CONFIG_RISCV_64) += riscv64/
obj-y += sbi.o
obj-y += setup.o
+obj-y += traps.o
$(TARGET): $(TARGET)-syms
$(OBJCOPY) -O binary -S $< $@
diff --git a/xen/arch/riscv/entry.S b/xen/arch/riscv/entry.S
new file mode 100644
index 0000000000..0be543f8e0
--- /dev/null
+++ b/xen/arch/riscv/entry.S
@@ -0,0 +1,94 @@
+#include <asm/asm.h>
+#include <asm/asm-offsets.h>
+#include <asm/processor.h>
+#include <asm/riscv_encoding.h>
+#include <asm/traps.h>
+
+/* WIP: only works while interrupting Xen context */
+ENTRY(handle_trap)
+
+ /* Exceptions from xen */
+save_to_stack:
+ /* Save context to stack */
+ REG_S sp, (CPU_USER_REGS_SP - CPU_USER_REGS_SIZE) (sp)
+ addi sp, sp, -CPU_USER_REGS_SIZE
+ REG_S t0, CPU_USER_REGS_T0(sp)
+
+ /* Save registers */
+ REG_S ra, CPU_USER_REGS_RA(sp)
+ REG_S gp, CPU_USER_REGS_GP(sp)
+ REG_S t1, CPU_USER_REGS_T1(sp)
+ REG_S t2, CPU_USER_REGS_T2(sp)
+ REG_S s0, CPU_USER_REGS_S0(sp)
+ REG_S s1, CPU_USER_REGS_S1(sp)
+ REG_S a0, CPU_USER_REGS_A0(sp)
+ REG_S a1, CPU_USER_REGS_A1(sp)
+ REG_S a2, CPU_USER_REGS_A2(sp)
+ REG_S a3, CPU_USER_REGS_A3(sp)
+ REG_S a4, CPU_USER_REGS_A4(sp)
+ REG_S a5, CPU_USER_REGS_A5(sp)
+ REG_S a6, CPU_USER_REGS_A6(sp)
+ REG_S a7, CPU_USER_REGS_A7(sp)
+ REG_S s2, CPU_USER_REGS_S2(sp)
+ REG_S s3, CPU_USER_REGS_S3(sp)
+ REG_S s4, CPU_USER_REGS_S4(sp)
+ REG_S s5, CPU_USER_REGS_S5(sp)
+ REG_S s6, CPU_USER_REGS_S6(sp)
+ REG_S s7, CPU_USER_REGS_S7(sp)
+ REG_S s8, CPU_USER_REGS_S8(sp)
+ REG_S s9, CPU_USER_REGS_S9(sp)
+ REG_S s10,CPU_USER_REGS_S10(sp)
+ REG_S s11,CPU_USER_REGS_S11(sp)
+ REG_S t3, CPU_USER_REGS_T3(sp)
+ REG_S t4, CPU_USER_REGS_T4(sp)
+ REG_S t5, CPU_USER_REGS_T5(sp)
+ REG_S t6, CPU_USER_REGS_T6(sp)
+ csrr t0, CSR_SEPC
+ REG_S t0, CPU_USER_REGS_SEPC(sp)
+ csrr t0, CSR_SSTATUS
+ REG_S t0, CPU_USER_REGS_SSTATUS(sp)
+
+ mv a0, sp
+ jal do_trap
+
+restore_registers:
+ /* Restore stack_cpu_regs */
+ REG_L t0, CPU_USER_REGS_SEPC(sp)
+ csrw CSR_SEPC, t0
+ REG_L t0, CPU_USER_REGS_SSTATUS(sp)
+ csrw CSR_SSTATUS, t0
+
+ REG_L ra, CPU_USER_REGS_RA(sp)
+ REG_L gp, CPU_USER_REGS_GP(sp)
+ REG_L t0, CPU_USER_REGS_T0(sp)
+ REG_L t1, CPU_USER_REGS_T1(sp)
+ REG_L t2, CPU_USER_REGS_T2(sp)
+ REG_L s0, CPU_USER_REGS_S0(sp)
+ REG_L s1, CPU_USER_REGS_S1(sp)
+ REG_L a0, CPU_USER_REGS_A0(sp)
+ REG_L a1, CPU_USER_REGS_A1(sp)
+ REG_L a2, CPU_USER_REGS_A2(sp)
+ REG_L a3, CPU_USER_REGS_A3(sp)
+ REG_L a4, CPU_USER_REGS_A4(sp)
+ REG_L a5, CPU_USER_REGS_A5(sp)
+ REG_L a6, CPU_USER_REGS_A6(sp)
+ REG_L a7, CPU_USER_REGS_A7(sp)
+ REG_L s2, CPU_USER_REGS_S2(sp)
+ REG_L s3, CPU_USER_REGS_S3(sp)
+ REG_L s4, CPU_USER_REGS_S4(sp)
+ REG_L s5, CPU_USER_REGS_S5(sp)
+ REG_L s6, CPU_USER_REGS_S6(sp)
+ REG_L s7, CPU_USER_REGS_S7(sp)
+ REG_L s8, CPU_USER_REGS_S8(sp)
+ REG_L s9, CPU_USER_REGS_S9(sp)
+ REG_L s10, CPU_USER_REGS_S10(sp)
+ REG_L s11, CPU_USER_REGS_S11(sp)
+ REG_L t3, CPU_USER_REGS_T3(sp)
+ REG_L t4, CPU_USER_REGS_T4(sp)
+ REG_L t5, CPU_USER_REGS_T5(sp)
+ REG_L t6, CPU_USER_REGS_T6(sp)
+
+ /* Restore sp */
+ REG_L sp, CPU_USER_REGS_SP(sp)
+
+ sret
diff --git a/xen/arch/riscv/include/asm/traps.h b/xen/arch/riscv/include/asm/traps.h
new file mode 100644
index 0000000000..f3fb6b25d1
--- /dev/null
+++ b/xen/arch/riscv/include/asm/traps.h
@@ -0,0 +1,13 @@
+#ifndef __ASM_TRAPS_H__
+#define __ASM_TRAPS_H__
+
+#include <asm/processor.h>
+
+#ifndef __ASSEMBLY__
+
+void do_trap(struct cpu_user_regs *cpu_regs);
+void handle_trap(void);
+
+#endif /* __ASSEMBLY__ */
+
+#endif /* __ASM_TRAPS_H__ */
diff --git a/xen/arch/riscv/traps.c b/xen/arch/riscv/traps.c
new file mode 100644
index 0000000000..ccd3593f5a
--- /dev/null
+++ b/xen/arch/riscv/traps.c
@@ -0,0 +1,13 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+/*
+ * Copyright (C) 2023 Vates
+ *
+ * RISC-V Trap handlers
+ */
+#include <asm/processor.h>
+#include <asm/traps.h>
+
+void do_trap(struct cpu_user_regs *cpu_regs)
+{
+ die();
+}
--
2.39.0
next prev parent reply other threads:[~2023-01-27 14:00 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-27 13:59 [PATCH v2 00/14] RISCV basic exception handling implementation Oleksii Kurochko
2023-01-27 13:59 ` [PATCH v2 01/14] xen/riscv: add _zicsr to CFLAGS Oleksii Kurochko
2023-01-31 0:21 ` Alistair Francis
2023-01-31 9:14 ` Jan Beulich
2023-02-06 16:09 ` Oleksii
2023-01-27 13:59 ` [PATCH v2 02/14] xen/riscv: add <asm/asm.h> header Oleksii Kurochko
2023-01-31 0:49 ` Alistair Francis
2023-02-06 16:22 ` Oleksii
2023-01-27 13:59 ` [PATCH v2 03/14] xen/riscv: add <asm/riscv_encoding.h header Oleksii Kurochko
2023-01-30 13:29 ` Alistair Francis
2023-01-27 13:59 ` [PATCH v2 04/14] xen/riscv: add <asm/csr.h> header Oleksii Kurochko
2023-01-27 14:10 ` Jan Beulich
2023-01-30 11:37 ` Oleksii
2023-01-30 13:26 ` Alistair Francis
2023-01-27 13:59 ` [PATCH v2 05/14] xen/riscv: introduce empty <asm/string.h> Oleksii Kurochko
2023-01-31 0:49 ` Alistair Francis
2023-01-27 13:59 ` [PATCH v2 06/14] xen/riscv: introduce empty <asm/cache.h> Oleksii Kurochko
2023-01-31 0:50 ` Alistair Francis
2023-01-27 13:59 ` [PATCH v2 07/14] xen/riscv: introduce exception context Oleksii Kurochko
2023-01-27 14:24 ` Jan Beulich
2023-01-30 11:54 ` Oleksii
2023-01-30 13:50 ` Jan Beulich
2023-01-30 22:44 ` Julien Grall
2023-02-01 2:27 ` Andrew Cooper
2023-02-01 1:30 ` Stefano Stabellini
2023-02-06 17:13 ` Oleksii
2023-01-27 14:54 ` Julien Grall
2023-01-30 11:40 ` Oleksii
2023-01-30 22:11 ` Julien Grall
2023-01-31 12:24 ` Oleksii
2023-01-31 12:39 ` Julien Grall
2023-01-27 13:59 ` Oleksii Kurochko [this message]
2023-01-27 13:59 ` [PATCH v2 09/14] xen/riscv: introduce decode_cause() stuff Oleksii Kurochko
2023-01-27 13:59 ` [PATCH v2 10/14] xen/riscv: mask all interrupts Oleksii Kurochko
2023-01-27 13:59 ` [PATCH v2 11/14] xen/riscv: introduce trap_init() Oleksii Kurochko
2023-01-27 13:59 ` [PATCH v2 12/14] xen/riscv: introduce an implementation of macros from <asm/bug.h> Oleksii Kurochko
2023-01-27 14:34 ` Jan Beulich
2023-01-30 11:23 ` Oleksii
2023-01-27 14:38 ` Jan Beulich
2023-01-27 16:02 ` Julien Grall
2023-01-30 11:35 ` Oleksii
2023-01-30 11:49 ` Juergen Gross
2023-01-30 22:28 ` Julien Grall
2023-01-31 12:34 ` Oleksii
2023-02-01 17:40 ` Oleksii
2023-02-01 22:11 ` Julien Grall
2023-02-02 11:50 ` Jan Beulich
2023-02-03 13:15 ` Oleksii
2023-02-03 13:23 ` Julien Grall
2023-02-03 16:25 ` Oleksii
2023-01-27 13:59 ` [PATCH v2 13/14] xen/riscv: test basic handling stuff Oleksii Kurochko
2023-01-27 13:59 ` [PATCH v2 14/14] automation: add smoke test to verify macros from bug.h Oleksii Kurochko
2023-01-27 14:43 ` Michal Orzel
2023-01-30 11:15 ` Oleksii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cc958411ef5e0a36bbfb056a71ce7232e6665ef.1674818705.git.oleksii.kurochko@gmail.com \
--to=oleksii.kurochko@gmail.com \
--cc=alistair.francis@wdc.com \
--cc=andrew.cooper3@citrix.com \
--cc=bobbyeshleman@gmail.com \
--cc=connojdavis@gmail.com \
--cc=gianluca@rivosinc.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.