All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean Abou Samra <jean@abou-samra.fr>
To: git@vger.kernel.org
Subject: Git bisect run should check for the existence of the script
Date: Wed, 15 Jul 2020 10:08:28 +0200	[thread overview]
Message-ID: <9cea8076-be96-19c5-c368-288193daedd8@abou-samra.fr> (raw)

Hi,

When using 'git bisect run', if the name of the script is misspelled or 
if the script was not made executable, 'git bisect' considers it to be a 
failure and stops at the first revision after the one claimed good. It 
would be better in my eyes to error out.

$ git bisect start
$ git bisect bad HEAD
$ git bisect good HEAD~10
Bisecting: 4 revisions left to test after this (roughly 2 steps)
[344dce312a0cf86d5a5772d54843cc179acaf6e3] bpo-41228: Fix /a/are/ in 
monthcalendar() descripton (GH-21372)
$ git bisect run ./non-existent.sh
running ./non-existent.sh
/usr/lib/git-core/git-bisect: 247: ./non-existent.sh: not found
Bisecting: 2 revisions left to test after this (roughly 1 step)
[6fc732a2116e2c42b0431bb7e2a21719351af755] Fix typo in docs: 'created by 
th' -> 'created by the' (GH-21384)
running ./non-existent.sh
/usr/lib/git-core/git-bisect: 247: ./non-existent.sh: not found
Bisecting: 0 revisions left to test after this (roughly 0 steps)
[8182cc2e68a3c6ea5d5342fed3f1c76b0521fbc1] bpo-39573: Use the Py_TYPE() 
macro (GH-21433)
running ./non-existent.sh
/usr/lib/git-core/git-bisect: 247: ./non-existent.sh: not found
8182cc2e68a3c6ea5d5342fed3f1c76b0521fbc1 is the first bad commit
commit 8182cc2e68a3c6ea5d5342fed3f1c76b0521fbc1
Author: Victor Stinner <vstinner@python.org>
Date:   Fri Jul 10 12:40:38 2020 +0200

     bpo-39573: Use the Py_TYPE() macro (GH-21433)

     Replace obj->ob_type with Py_TYPE(obj).

  Modules/_elementtree.c       | 2 +-
  Objects/abstract.c           | 4 ++--
  Objects/genericaliasobject.c | 2 +-
  Objects/unicodeobject.c      | 4 ++--
  PC/_msi.c                    | 6 +++---
  PC/winreg.c                  | 4 ++--
  Tools/scripts/combinerefs.py | 2 +-
  7 files changed, 12 insertions(+), 12 deletions(-)
bisect run success


Best regards,
Jean Abou Samra


             reply	other threads:[~2020-07-15  8:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-15  8:08 Jean Abou Samra [this message]
2020-07-15 14:55 ` Git bisect run should check for the existence of the script Junio C Hamano
2020-07-17 15:09   ` Jean Abou Samra
2020-07-17 19:17     ` Junio C Hamano
2020-07-17 19:30       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9cea8076-be96-19c5-c368-288193daedd8@abou-samra.fr \
    --to=jean@abou-samra.fr \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.