All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jean Abou Samra <jean@abou-samra.fr>
Cc: git@vger.kernel.org
Subject: Re: Git bisect run should check for the existence of the script
Date: Wed, 15 Jul 2020 07:55:49 -0700	[thread overview]
Message-ID: <xmqq1rlclte2.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <9cea8076-be96-19c5-c368-288193daedd8@abou-samra.fr> (Jean Abou Samra's message of "Wed, 15 Jul 2020 10:08:28 +0200")

Jean Abou Samra <jean@abou-samra.fr> writes:

> $ git bisect run ./non-existent.sh
> running ./non-existent.sh
> /usr/lib/git-core/git-bisect: 247: ./non-existent.sh: not found
> Bisecting: 2 revisions left to test after this (roughly 1 step)
> [6fc732a2116e2c42b0431bb7e2a21719351af755] Fix typo in docs: 'created
> by th' -> 'created by the' (GH-21384)
> running ./non-existent.sh
> /usr/lib/git-core/git-bisect: 247: ./non-existent.sh: not found
> Bisecting: 0 revisions left to test after this (roughly 0 steps)

Yes, it would be nice if "git bisect run" can reliably tell that it
got a "not found" error and not a "test performed by the script did
not pass" and stop at the first failure.

On the other hand, the "./non-existent.sh" script could be part of
the tracked contents (i.e. some revisions have it and the working
tree has it when they get checked out, some revisions don't and the
working tree does not have it), and the user is trying to find the
first revision that stopped having a working script in its tree.  In
such a case, the script that does not exist and the script that fails
need to be treated the same way by "git bisect run" as failures.  

So... I dunno.

  reply	other threads:[~2020-07-15 14:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-15  8:08 Git bisect run should check for the existence of the script Jean Abou Samra
2020-07-15 14:55 ` Junio C Hamano [this message]
2020-07-17 15:09   ` Jean Abou Samra
2020-07-17 19:17     ` Junio C Hamano
2020-07-17 19:30       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq1rlclte2.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jean@abou-samra.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.