All of lore.kernel.org
 help / color / mirror / Atom feed
* [xen-4.15-testing test] 173498: regressions - FAIL
@ 2022-10-12  0:46 osstest service owner
  2022-10-12  2:42 ` Henry Wang
  0 siblings, 1 reply; 8+ messages in thread
From: osstest service owner @ 2022-10-12  0:46 UTC (permalink / raw)
  To: xen-devel

flight 173498 xen-4.15-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/173498/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-arm64                   6 xen-build                fail REGR. vs. 172547
 build-arm64-xsm               6 xen-build                fail REGR. vs. 172547
 build-amd64                   6 xen-build                fail REGR. vs. 172547
 build-armhf                   6 xen-build                fail REGR. vs. 172547
 build-i386                    6 xen-build                fail REGR. vs. 172547
 build-i386-xsm                6 xen-build                fail REGR. vs. 172547
 build-amd64-xsm               6 xen-build                fail REGR. vs. 172547

Tests which did not succeed, but are not blocking:
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-amd64-i386-livepatch     1 build-check(1)               blocked  n/a
 test-amd64-i386-migrupgrade   1 build-check(1)               blocked  n/a
 test-amd64-i386-pair          1 build-check(1)               blocked  n/a
 test-amd64-i386-qemut-rhel6hvm-amd  1 build-check(1)               blocked n/a
 test-amd64-i386-qemut-rhel6hvm-intel  1 build-check(1)             blocked n/a
 test-amd64-i386-qemuu-rhel6hvm-amd  1 build-check(1)               blocked n/a
 test-amd64-i386-qemuu-rhel6hvm-intel  1 build-check(1)             blocked n/a
 test-amd64-i386-xl            1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-pvshim     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-qemut-debianhvm-amd64  1 build-check(1)         blocked n/a
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm  1 build-check(1)      blocked n/a
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-xl-qemut-win7-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemut-ws16-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64  1 build-check(1)         blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow  1 build-check(1)  blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm  1 build-check(1)      blocked n/a
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a
 test-amd64-i386-xl-qemuu-ws16-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-shadow     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-vhd        1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-xsm        1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl           1 build-check(1)               blocked  n/a
 test-amd64-coresched-amd64-xl  1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-xsm       1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-shadow    1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-rtds      1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ws16-amd64  1 build-check(1)             blocked n/a
 test-amd64-amd64-xl-qemuu-win7-amd64  1 build-check(1)             blocked n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm  1 build-check(1)     blocked n/a
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow  1 build-check(1) blocked n/a
 test-amd64-amd64-xl-qemuu-debianhvm-amd64  1 build-check(1)        blocked n/a
 test-amd64-amd64-xl-qemut-ws16-amd64  1 build-check(1)             blocked n/a
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemut-win7-amd64  1 build-check(1)             blocked n/a
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm  1 build-check(1)     blocked n/a
 build-arm64-libvirt           1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemut-debianhvm-amd64  1 build-check(1)        blocked n/a
 test-amd64-amd64-xl-qcow2     1 build-check(1)               blocked  n/a
 build-armhf-libvirt           1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-pvshim    1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-pvhv2-intel  1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-pvhv2-amd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-multivcpu  1 build-check(1)               blocked  n/a
 test-amd64-amd64-dom0pvh-xl-amd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-dom0pvh-xl-intel  1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-credit2   1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-credit1   1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl           1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-amd64-livepatch    1 build-check(1)               blocked  n/a
 test-amd64-amd64-qemuu-nested-intel  1 build-check(1)              blocked n/a
 test-amd64-amd64-migrupgrade  1 build-check(1)               blocked  n/a
 test-amd64-amd64-pair         1 build-check(1)               blocked  n/a
 test-amd64-amd64-qemuu-nested-amd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-pygrub       1 build-check(1)               blocked  n/a
 test-amd64-amd64-qemuu-freebsd11-amd64  1 build-check(1)           blocked n/a
 test-amd64-amd64-qemuu-freebsd12-amd64  1 build-check(1)           blocked n/a
 test-amd64-i386-xl-qemuu-win7-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a
 test-amd64-coresched-i386-xl  1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-amd64  1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-i386  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit1   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit2   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-seattle   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-thunderx  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-vhd       1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-xsm       1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl           1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-arndale   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit1   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-credit2   1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-cubietruck  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-multivcpu  1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-rtds      1 build-check(1)               blocked  n/a
 test-armhf-armhf-xl-vhd       1 build-check(1)               blocked  n/a
 test-xtf-amd64-amd64-1        1 build-check(1)               blocked  n/a
 test-xtf-amd64-amd64-2        1 build-check(1)               blocked  n/a
 test-xtf-amd64-amd64-3        1 build-check(1)               blocked  n/a
 test-xtf-amd64-amd64-4        1 build-check(1)               blocked  n/a
 test-xtf-amd64-amd64-5        1 build-check(1)               blocked  n/a

version targeted for testing:
 xen                  9690bb261d5fa09cb281e1fa124d93db7b84fda5
baseline version:
 xen                  9acedc3c58c31930737edbe212f2ccf437a0b757

Last test of basis   172547  2022-08-15 14:06:45 Z   57 days
Testing same since   173494  2022-10-11 13:38:08 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Henry Wang <Henry.Wang@arm.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stefano Stabellini <sstabellini@kernel.org>
  Tamas K Lengyel <tamas.lengyel@intel.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              fail    
 build-arm64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64-xtf                                              pass    
 build-amd64                                                  fail    
 build-arm64                                                  fail    
 build-armhf                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-arm64-libvirt                                          blocked 
 build-armhf-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       blocked 
 test-xtf-amd64-amd64-2                                       blocked 
 test-xtf-amd64-amd64-3                                       blocked 
 test-xtf-amd64-amd64-4                                       blocked 
 test-xtf-amd64-amd64-5                                       blocked 
 test-amd64-amd64-xl                                          blocked 
 test-amd64-coresched-amd64-xl                                blocked 
 test-arm64-arm64-xl                                          blocked 
 test-armhf-armhf-xl                                          blocked 
 test-amd64-i386-xl                                           blocked 
 test-amd64-coresched-i386-xl                                 blocked 
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        blocked 
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         blocked 
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 blocked 
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 blocked 
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-xl-xsm                                      blocked 
 test-arm64-arm64-xl-xsm                                      blocked 
 test-amd64-i386-xl-xsm                                       blocked 
 test-amd64-amd64-qemuu-nested-amd                            blocked 
 test-amd64-amd64-xl-pvhv2-amd                                blocked 
 test-amd64-i386-qemut-rhel6hvm-amd                           blocked 
 test-amd64-i386-qemuu-rhel6hvm-amd                           blocked 
 test-amd64-amd64-dom0pvh-xl-amd                              blocked 
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    blocked 
 test-amd64-i386-xl-qemut-debianhvm-amd64                     blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    blocked 
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     blocked 
 test-amd64-i386-freebsd10-amd64                              blocked 
 test-amd64-amd64-qemuu-freebsd11-amd64                       blocked 
 test-amd64-amd64-qemuu-freebsd12-amd64                       blocked 
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 
 test-amd64-amd64-xl-qemut-win7-amd64                         blocked 
 test-amd64-i386-xl-qemut-win7-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-win7-amd64                         blocked 
 test-amd64-i386-xl-qemuu-win7-amd64                          blocked 
 test-amd64-amd64-xl-qemut-ws16-amd64                         blocked 
 test-amd64-i386-xl-qemut-ws16-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-ws16-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ws16-amd64                          blocked 
 test-armhf-armhf-xl-arndale                                  blocked 
 test-amd64-amd64-xl-credit1                                  blocked 
 test-arm64-arm64-xl-credit1                                  blocked 
 test-armhf-armhf-xl-credit1                                  blocked 
 test-amd64-amd64-xl-credit2                                  blocked 
 test-arm64-arm64-xl-credit2                                  blocked 
 test-armhf-armhf-xl-credit2                                  blocked 
 test-armhf-armhf-xl-cubietruck                               blocked 
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        blocked 
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         blocked 
 test-amd64-i386-freebsd10-i386                               blocked 
 test-amd64-amd64-qemuu-nested-intel                          blocked 
 test-amd64-amd64-xl-pvhv2-intel                              blocked 
 test-amd64-i386-qemut-rhel6hvm-intel                         blocked 
 test-amd64-i386-qemuu-rhel6hvm-intel                         blocked 
 test-amd64-amd64-dom0pvh-xl-intel                            blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-livepatch                                   blocked 
 test-amd64-i386-livepatch                                    blocked 
 test-amd64-amd64-migrupgrade                                 blocked 
 test-amd64-i386-migrupgrade                                  blocked 
 test-amd64-amd64-xl-multivcpu                                blocked 
 test-armhf-armhf-xl-multivcpu                                blocked 
 test-amd64-amd64-pair                                        blocked 
 test-amd64-i386-pair                                         blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-amd64-amd64-xl-pvshim                                   blocked 
 test-amd64-i386-xl-pvshim                                    blocked 
 test-amd64-amd64-pygrub                                      blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-amd64-amd64-xl-qcow2                                    blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-xl-rtds                                     blocked 
 test-armhf-armhf-xl-rtds                                     blocked 
 test-arm64-arm64-xl-seattle                                  blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             blocked 
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              blocked 
 test-amd64-amd64-xl-shadow                                   blocked 
 test-amd64-i386-xl-shadow                                    blocked 
 test-arm64-arm64-xl-thunderx                                 blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 
 test-arm64-arm64-xl-vhd                                      blocked 
 test-armhf-armhf-xl-vhd                                      blocked 
 test-amd64-i386-xl-vhd                                       blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 689 lines long.)


^ permalink raw reply	[flat|nested] 8+ messages in thread

* RE: [xen-4.15-testing test] 173498: regressions - FAIL
  2022-10-12  0:46 [xen-4.15-testing test] 173498: regressions - FAIL osstest service owner
@ 2022-10-12  2:42 ` Henry Wang
  2022-10-12  6:28   ` Jan Beulich
  0 siblings, 1 reply; 8+ messages in thread
From: Henry Wang @ 2022-10-12  2:42 UTC (permalink / raw)
  To: osstest service owner
  Cc: Julien Grall, Jan Beulich, Juergen Gross, xen-devel,
	Bertrand Marquis, Andrew Cooper, sstabellini

Hi all,

> -----Original Message-----
> Subject: [xen-4.15-testing test] 173498: regressions - FAIL
> 
> flight 173498 xen-4.15-testing real [real]
> http://logs.test-lab.xenproject.org/osstest/logs/173498/
> 
> Regressions :-(

I think these regressions are from the backporting happened yesterday,
see below...

> 
> Tests which did not succeed and are blocking,
> including tests which could not be run:
>  build-arm64                   6 xen-build                fail REGR. vs. 172547
>  build-arm64-xsm               6 xen-build                fail REGR. vs. 172547
>  build-amd64                   6 xen-build                fail REGR. vs. 172547
>  build-armhf                   6 xen-build                fail REGR. vs. 172547

...The arm/arm64 regression is from the backporting of commit:
xen/arm, libxl: Implement XEN_DOMCTL_shadow_op for Arm

The issue is:
In 4.16, commit
2107cc76db3a libxc: split xc_logdirty_control() from xc_shadow_control()
changes the prototype of xc_shadow_control(), and hence the calling of
xc_shadow_control() in 4.13, 4.14 and 4.15 does not match the calling of
xc_shadow_control() in 4.16 and after.

>  build-i386                    6 xen-build                fail REGR. vs. 172547
>  build-i386-xsm                6 xen-build                fail REGR. vs. 172547
>  build-amd64-xsm               6 xen-build                fail REGR. vs. 172547

I think the x86 regression is from the backporting of commit:
xen/gnttab: fix gnttab_acquire_resource()

As the error message is:
make[5]: Entering directory '/home/osstest/build.173498.build-amd64/xen/tools/tests/resource'
test-resource.c: In function 'test_gnttab':
test-resource.c:74:19: error: 'gnttab' undeclared (first use in this function)
         (void **)&gnttab, PROT_READ | PROT_WRITE, 0);
                   ^~~~~~

Kind regards,
Henry


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [xen-4.15-testing test] 173498: regressions - FAIL
  2022-10-12  2:42 ` Henry Wang
@ 2022-10-12  6:28   ` Jan Beulich
  2022-10-12  6:34     ` Juergen Gross
  2022-10-12  6:42     ` Henry Wang
  0 siblings, 2 replies; 8+ messages in thread
From: Jan Beulich @ 2022-10-12  6:28 UTC (permalink / raw)
  To: Henry Wang
  Cc: Julien Grall, Juergen Gross, xen-devel, Bertrand Marquis,
	Andrew Cooper, sstabellini, osstest service owner

On 12.10.2022 04:42, Henry Wang wrote:
>> -----Original Message-----
>> Subject: [xen-4.15-testing test] 173498: regressions - FAIL
>>
>> flight 173498 xen-4.15-testing real [real]
>> http://logs.test-lab.xenproject.org/osstest/logs/173498/
>>
>> Regressions :-(
> 
> I think these regressions are from the backporting happened yesterday,
> see below...
> 
>>
>> Tests which did not succeed and are blocking,
>> including tests which could not be run:
>>  build-arm64                   6 xen-build                fail REGR. vs. 172547
>>  build-arm64-xsm               6 xen-build                fail REGR. vs. 172547
>>  build-amd64                   6 xen-build                fail REGR. vs. 172547
>>  build-armhf                   6 xen-build                fail REGR. vs. 172547
> 
> ...The arm/arm64 regression is from the backporting of commit:
> xen/arm, libxl: Implement XEN_DOMCTL_shadow_op for Arm
> 
> The issue is:
> In 4.16, commit
> 2107cc76db3a libxc: split xc_logdirty_control() from xc_shadow_control()
> changes the prototype of xc_shadow_control(), and hence the calling of
> xc_shadow_control() in 4.13, 4.14 and 4.15 does not match the calling of
> xc_shadow_control() in 4.16 and after.

So did I commit a wrong patch, or were the patches for the older branches
wrong already in xsa.git?

>>  build-i386                    6 xen-build                fail REGR. vs. 172547
>>  build-i386-xsm                6 xen-build                fail REGR. vs. 172547
>>  build-amd64-xsm               6 xen-build                fail REGR. vs. 172547
> 
> I think the x86 regression is from the backporting of commit:
> xen/gnttab: fix gnttab_acquire_resource()
> 
> As the error message is:
> make[5]: Entering directory '/home/osstest/build.173498.build-amd64/xen/tools/tests/resource'
> test-resource.c: In function 'test_gnttab':
> test-resource.c:74:19: error: 'gnttab' undeclared (first use in this function)
>          (void **)&gnttab, PROT_READ | PROT_WRITE, 0);
>                    ^~~~~~

Hmm, I'm pretty sure I did a local build test of tools/ with this in place.
I'm not in the office today, so I won't be able to do anything about it
right away.

Jan


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [xen-4.15-testing test] 173498: regressions - FAIL
  2022-10-12  6:28   ` Jan Beulich
@ 2022-10-12  6:34     ` Juergen Gross
  2022-10-12  6:39       ` Jan Beulich
  2022-10-12  6:42     ` Henry Wang
  1 sibling, 1 reply; 8+ messages in thread
From: Juergen Gross @ 2022-10-12  6:34 UTC (permalink / raw)
  To: Jan Beulich, Henry Wang
  Cc: Julien Grall, xen-devel, Bertrand Marquis, Andrew Cooper,
	sstabellini, osstest service owner


[-- Attachment #1.1.1: Type: text/plain, Size: 2397 bytes --]

On 12.10.22 08:28, Jan Beulich wrote:
> On 12.10.2022 04:42, Henry Wang wrote:
>>> -----Original Message-----
>>> Subject: [xen-4.15-testing test] 173498: regressions - FAIL
>>>
>>> flight 173498 xen-4.15-testing real [real]
>>> http://logs.test-lab.xenproject.org/osstest/logs/173498/
>>>
>>> Regressions :-(
>>
>> I think these regressions are from the backporting happened yesterday,
>> see below...
>>
>>>
>>> Tests which did not succeed and are blocking,
>>> including tests which could not be run:
>>>   build-arm64                   6 xen-build                fail REGR. vs. 172547
>>>   build-arm64-xsm               6 xen-build                fail REGR. vs. 172547
>>>   build-amd64                   6 xen-build                fail REGR. vs. 172547
>>>   build-armhf                   6 xen-build                fail REGR. vs. 172547
>>
>> ...The arm/arm64 regression is from the backporting of commit:
>> xen/arm, libxl: Implement XEN_DOMCTL_shadow_op for Arm
>>
>> The issue is:
>> In 4.16, commit
>> 2107cc76db3a libxc: split xc_logdirty_control() from xc_shadow_control()
>> changes the prototype of xc_shadow_control(), and hence the calling of
>> xc_shadow_control() in 4.13, 4.14 and 4.15 does not match the calling of
>> xc_shadow_control() in 4.16 and after.
> 
> So did I commit a wrong patch, or were the patches for the older branches
> wrong already in xsa.git?
> 
>>>   build-i386                    6 xen-build                fail REGR. vs. 172547
>>>   build-i386-xsm                6 xen-build                fail REGR. vs. 172547
>>>   build-amd64-xsm               6 xen-build                fail REGR. vs. 172547
>>
>> I think the x86 regression is from the backporting of commit:
>> xen/gnttab: fix gnttab_acquire_resource()
>>
>> As the error message is:
>> make[5]: Entering directory '/home/osstest/build.173498.build-amd64/xen/tools/tests/resource'
>> test-resource.c: In function 'test_gnttab':
>> test-resource.c:74:19: error: 'gnttab' undeclared (first use in this function)
>>           (void **)&gnttab, PROT_READ | PROT_WRITE, 0);
>>                     ^~~~~~
> 
> Hmm, I'm pretty sure I did a local build test of tools/ with this in place.
> I'm not in the office today, so I won't be able to do anything about it
> right away.

Maybe you didn't build tools/tests?

I can send a fix.


Juergen


[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3149 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [xen-4.15-testing test] 173498: regressions - FAIL
  2022-10-12  6:34     ` Juergen Gross
@ 2022-10-12  6:39       ` Jan Beulich
  0 siblings, 0 replies; 8+ messages in thread
From: Jan Beulich @ 2022-10-12  6:39 UTC (permalink / raw)
  To: Juergen Gross
  Cc: Julien Grall, xen-devel, Bertrand Marquis, Andrew Cooper,
	sstabellini, osstest service owner, Henry Wang

On 12.10.2022 08:34, Juergen Gross wrote:
> On 12.10.22 08:28, Jan Beulich wrote:
>> On 12.10.2022 04:42, Henry Wang wrote:
>>>> -----Original Message-----
>>>> Subject: [xen-4.15-testing test] 173498: regressions - FAIL
>>>>
>>>> flight 173498 xen-4.15-testing real [real]
>>>> http://logs.test-lab.xenproject.org/osstest/logs/173498/
>>>>
>>>> Regressions :-(
>>>
>>> I think these regressions are from the backporting happened yesterday,
>>> see below...
>>>
>>>>
>>>> Tests which did not succeed and are blocking,
>>>> including tests which could not be run:
>>>>   build-arm64                   6 xen-build                fail REGR. vs. 172547
>>>>   build-arm64-xsm               6 xen-build                fail REGR. vs. 172547
>>>>   build-amd64                   6 xen-build                fail REGR. vs. 172547
>>>>   build-armhf                   6 xen-build                fail REGR. vs. 172547
>>>
>>> ...The arm/arm64 regression is from the backporting of commit:
>>> xen/arm, libxl: Implement XEN_DOMCTL_shadow_op for Arm
>>>
>>> The issue is:
>>> In 4.16, commit
>>> 2107cc76db3a libxc: split xc_logdirty_control() from xc_shadow_control()
>>> changes the prototype of xc_shadow_control(), and hence the calling of
>>> xc_shadow_control() in 4.13, 4.14 and 4.15 does not match the calling of
>>> xc_shadow_control() in 4.16 and after.
>>
>> So did I commit a wrong patch, or were the patches for the older branches
>> wrong already in xsa.git?
>>
>>>>   build-i386                    6 xen-build                fail REGR. vs. 172547
>>>>   build-i386-xsm                6 xen-build                fail REGR. vs. 172547
>>>>   build-amd64-xsm               6 xen-build                fail REGR. vs. 172547
>>>
>>> I think the x86 regression is from the backporting of commit:
>>> xen/gnttab: fix gnttab_acquire_resource()
>>>
>>> As the error message is:
>>> make[5]: Entering directory '/home/osstest/build.173498.build-amd64/xen/tools/tests/resource'
>>> test-resource.c: In function 'test_gnttab':
>>> test-resource.c:74:19: error: 'gnttab' undeclared (first use in this function)
>>>           (void **)&gnttab, PROT_READ | PROT_WRITE, 0);
>>>                     ^~~~~~
>>
>> Hmm, I'm pretty sure I did a local build test of tools/ with this in place.
>> I'm not in the office today, so I won't be able to do anything about it
>> right away.
> 
> Maybe you didn't build tools/tests?

I'd need to check, but yes, that's the suspicion.

> I can send a fix.

That would be great, thanks.

Jan


^ permalink raw reply	[flat|nested] 8+ messages in thread

* RE: [xen-4.15-testing test] 173498: regressions - FAIL
  2022-10-12  6:28   ` Jan Beulich
  2022-10-12  6:34     ` Juergen Gross
@ 2022-10-12  6:42     ` Henry Wang
  2022-10-12  6:48       ` Jan Beulich
  1 sibling, 1 reply; 8+ messages in thread
From: Henry Wang @ 2022-10-12  6:42 UTC (permalink / raw)
  To: Jan Beulich
  Cc: Julien Grall, Juergen Gross, xen-devel, Bertrand Marquis,
	Andrew Cooper, sstabellini, osstest service owner

Hi Jan,

> -----Original Message-----
> From: Jan Beulich <jbeulich@suse.com>
> Subject: Re: [xen-4.15-testing test] 173498: regressions - FAIL
> 
> On 12.10.2022 04:42, Henry Wang wrote:
> >> -----Original Message-----
> >> Subject: [xen-4.15-testing test] 173498: regressions - FAIL
> >>
> >> flight 173498 xen-4.15-testing real [real]
> >> http://logs.test-lab.xenproject.org/osstest/logs/173498/
> >>
> >> Regressions :-(
> >
> > I think these regressions are from the backporting happened yesterday,
> > see below...
> >
> >>
> >> Tests which did not succeed and are blocking,
> >> including tests which could not be run:
> >>  build-arm64                   6 xen-build                fail REGR. vs. 172547
> >>  build-arm64-xsm               6 xen-build                fail REGR. vs. 172547
> >>  build-amd64                   6 xen-build                fail REGR. vs. 172547
> >>  build-armhf                   6 xen-build                fail REGR. vs. 172547
> >
> > ...The arm/arm64 regression is from the backporting of commit:
> > xen/arm, libxl: Implement XEN_DOMCTL_shadow_op for Arm
> >
> > The issue is:
> > In 4.16, commit
> > 2107cc76db3a libxc: split xc_logdirty_control() from xc_shadow_control()
> > changes the prototype of xc_shadow_control(), and hence the calling of
> > xc_shadow_control() in 4.13, 4.14 and 4.15 does not match the calling of
> > xc_shadow_control() in 4.16 and after.
> 
> So did I commit a wrong patch, or were the patches for the older branches
> wrong already in xsa.git?

I think the latter. For this commit I think the patch for master branch was picked
for the 4.13-4.15 backporting, without noticing the xc_shadow_control()
prototype change in 4.16.

I can send a fix for this. If we don't want to backport the
"libxc: split xc_logdirty_control() from xc_shadow_control()"

Kind regards,
Henry


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [xen-4.15-testing test] 173498: regressions - FAIL
  2022-10-12  6:42     ` Henry Wang
@ 2022-10-12  6:48       ` Jan Beulich
  2022-10-12  6:49         ` Henry Wang
  0 siblings, 1 reply; 8+ messages in thread
From: Jan Beulich @ 2022-10-12  6:48 UTC (permalink / raw)
  To: Henry Wang, Anthony Perard
  Cc: Julien Grall, Juergen Gross, xen-devel, Bertrand Marquis,
	Andrew Cooper, sstabellini, osstest service owner

On 12.10.2022 08:42, Henry Wang wrote:
> Hi Jan,
> 
>> -----Original Message-----
>> From: Jan Beulich <jbeulich@suse.com>
>> Subject: Re: [xen-4.15-testing test] 173498: regressions - FAIL
>>
>> On 12.10.2022 04:42, Henry Wang wrote:
>>>> -----Original Message-----
>>>> Subject: [xen-4.15-testing test] 173498: regressions - FAIL
>>>>
>>>> flight 173498 xen-4.15-testing real [real]
>>>> http://logs.test-lab.xenproject.org/osstest/logs/173498/
>>>>
>>>> Regressions :-(
>>>
>>> I think these regressions are from the backporting happened yesterday,
>>> see below...
>>>
>>>>
>>>> Tests which did not succeed and are blocking,
>>>> including tests which could not be run:
>>>>  build-arm64                   6 xen-build                fail REGR. vs. 172547
>>>>  build-arm64-xsm               6 xen-build                fail REGR. vs. 172547
>>>>  build-amd64                   6 xen-build                fail REGR. vs. 172547
>>>>  build-armhf                   6 xen-build                fail REGR. vs. 172547
>>>
>>> ...The arm/arm64 regression is from the backporting of commit:
>>> xen/arm, libxl: Implement XEN_DOMCTL_shadow_op for Arm
>>>
>>> The issue is:
>>> In 4.16, commit
>>> 2107cc76db3a libxc: split xc_logdirty_control() from xc_shadow_control()
>>> changes the prototype of xc_shadow_control(), and hence the calling of
>>> xc_shadow_control() in 4.13, 4.14 and 4.15 does not match the calling of
>>> xc_shadow_control() in 4.16 and after.
>>
>> So did I commit a wrong patch, or were the patches for the older branches
>> wrong already in xsa.git?
> 
> I think the latter. For this commit I think the patch for master branch was picked
> for the 4.13-4.15 backporting, without noticing the xc_shadow_control()
> prototype change in 4.16.
> 
> I can send a fix for this. If we don't want to backport the
> "libxc: split xc_logdirty_control() from xc_shadow_control()"

I don't think we should backport that extra change, but Anthony would have
the final say.

Jan


^ permalink raw reply	[flat|nested] 8+ messages in thread

* RE: [xen-4.15-testing test] 173498: regressions - FAIL
  2022-10-12  6:48       ` Jan Beulich
@ 2022-10-12  6:49         ` Henry Wang
  0 siblings, 0 replies; 8+ messages in thread
From: Henry Wang @ 2022-10-12  6:49 UTC (permalink / raw)
  To: Jan Beulich, Anthony Perard
  Cc: Julien Grall, Juergen Gross, xen-devel, Bertrand Marquis,
	Andrew Cooper, sstabellini, osstest service owner

Hi Jan,

> -----Original Message-----
> From: Jan Beulich <jbeulich@suse.com>
> Subject: Re: [xen-4.15-testing test] 173498: regressions - FAIL
> 
> On 12.10.2022 08:42, Henry Wang wrote:
> > Hi Jan,
> >
> >> -----Original Message-----
> >> From: Jan Beulich <jbeulich@suse.com>
> >> Subject: Re: [xen-4.15-testing test] 173498: regressions - FAIL
> >>
> >> On 12.10.2022 04:42, Henry Wang wrote:
> >>>> -----Original Message-----
> >>>> Subject: [xen-4.15-testing test] 173498: regressions - FAIL
> >>>>
> >>>> flight 173498 xen-4.15-testing real [real]
> >>>> http://logs.test-lab.xenproject.org/osstest/logs/173498/
> >>>>
> >>>> Regressions :-(
> >>>
> >>> I think these regressions are from the backporting happened yesterday,
> >>> see below...
> >>>
> >>>>
> >>>> Tests which did not succeed and are blocking,
> >>>> including tests which could not be run:
> >>>>  build-arm64                   6 xen-build                fail REGR. vs. 172547
> >>>>  build-arm64-xsm               6 xen-build                fail REGR. vs. 172547
> >>>>  build-amd64                   6 xen-build                fail REGR. vs. 172547
> >>>>  build-armhf                   6 xen-build                fail REGR. vs. 172547
> >>>
> >>> ...The arm/arm64 regression is from the backporting of commit:
> >>> xen/arm, libxl: Implement XEN_DOMCTL_shadow_op for Arm
> >>>
> >>> The issue is:
> >>> In 4.16, commit
> >>> 2107cc76db3a libxc: split xc_logdirty_control() from xc_shadow_control()
> >>> changes the prototype of xc_shadow_control(), and hence the calling of
> >>> xc_shadow_control() in 4.13, 4.14 and 4.15 does not match the calling of
> >>> xc_shadow_control() in 4.16 and after.
> >>
> >> So did I commit a wrong patch, or were the patches for the older branches
> >> wrong already in xsa.git?
> >
> > I think the latter. For this commit I think the patch for master branch was
> picked
> > for the 4.13-4.15 backporting, without noticing the xc_shadow_control()
> > prototype change in 4.16.
> >
> > I can send a fix for this. If we don't want to backport the
> > "libxc: split xc_logdirty_control() from xc_shadow_control()"
> 
> I don't think we should backport that extra change, but Anthony would have
> the final say.

Then I will try to prepare a fix.

Kind regards,
Henry

> 
> Jan

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2022-10-12  6:50 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-12  0:46 [xen-4.15-testing test] 173498: regressions - FAIL osstest service owner
2022-10-12  2:42 ` Henry Wang
2022-10-12  6:28   ` Jan Beulich
2022-10-12  6:34     ` Juergen Gross
2022-10-12  6:39       ` Jan Beulich
2022-10-12  6:42     ` Henry Wang
2022-10-12  6:48       ` Jan Beulich
2022-10-12  6:49         ` Henry Wang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.