All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Andy Lutomirski <luto@amacapital.net>, Minfei Huang <mnghuan@gmail.com>
Cc: Borislav Petkov <bp@suse.de>, Andrew Lutomirski <luto@kernel.org>,
	"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>, X86 ML <x86@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] pvclock: Add a new wrapper function to only get variable flags
Date: Fri, 27 May 2016 18:06:04 +0200	[thread overview]
Message-ID: <9d18b1a3-90b4-6969-6bda-b7556d8264a6@redhat.com> (raw)
In-Reply-To: <CALCETrXGVjiyE1dWe0_1N3v+-5SO7GqEazfVE4Uhqz9c4QxgSA@mail.gmail.com>



On 27/05/2016 17:40, Andy Lutomirski wrote:
> On Thu, May 26, 2016 at 11:17 PM, Minfei Huang <mnghuan@gmail.com> wrote:
>> There is a generic function __pvclock_read_cycles to be used to get both
>> flags and cycles. For function pvclock_read_flags, it's useless to get
>> cycles value. To make this function be more effective, add a new wrapper
>> function to only get variable flags.
> 
> Why not just get rid of this function entirely?

I agree.  If you want to abstract the retry logic, perhaps you can add
pvclock_read_{begin,retry} functions like seqlock_read_{begin,retry}?

Thanks,

Paolo

  reply	other threads:[~2016-05-27 16:06 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-27  6:17 [PATCH 1/3] pvclock: Add CPU barries to get correct version value Minfei Huang
2016-05-27  6:17 ` [PATCH 2/3] pvclock: Cleanup to remove function pvclock_get_nsec_offset Minfei Huang
2016-05-27 15:40   ` Andy Lutomirski
2016-05-27  6:17 ` [PATCH 3/3] pvclock: Add a new wrapper function to only get variable flags Minfei Huang
2016-05-27 15:40   ` Andy Lutomirski
2016-05-27 16:06     ` Paolo Bonzini [this message]
2016-05-28 12:02       ` Minfei Huang
2016-05-28 12:27   ` [PATCH 3/3 V2] pvclock: Get rid of __pvclock_read_cycles in function pvclock_read_flags Minfei Huang
2016-06-07 13:16     ` Minfei Huang
2016-06-09 11:17       ` Paolo Bonzini
2016-06-08  8:17     ` Borislav Petkov
2016-06-09 11:21       ` Paolo Bonzini
2016-06-09 11:28         ` Borislav Petkov
2016-06-09 12:31           ` Paolo Bonzini
2016-06-12 11:46           ` Minfei Huang
2016-06-09 12:16     ` Peter Zijlstra
2016-06-09 12:24       ` Peter Zijlstra
2016-06-09 12:26       ` Paolo Bonzini
2016-06-09 12:35         ` Peter Zijlstra
2016-05-27 15:39 ` [PATCH 1/3] pvclock: Add CPU barries to get correct version value Andy Lutomirski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9d18b1a3-90b4-6969-6bda-b7556d8264a6@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=bp@suse.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=mnghuan@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.