All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Coccinelle <cocci@systeme.lip6.fr>
Subject: Re: [Cocci] Checking redundant variable initialisations with SmPL?
Date: Sat, 22 Jun 2019 15:15:08 +0200	[thread overview]
Message-ID: <9d2ef926-62b9-d182-d6d6-cd82ca13173f@web.de> (raw)
In-Reply-To: <alpine.DEB.2.21.1906212251430.2538@hadrien>

>> elfring@Sonne:~/Projekte/Linux/next-patched> spatch ~/Projekte/Coccinelle/janitor/show_questionable_variable_initialisation1.cocci drivers/misc/lkdtm/core.c
>> …
>> exn while in timeout_function
>> Fatal error: exception Coccinelle_modules.Common.Impossible(56)
>>
>>
>> How do you think about the software situation?
>
> This problem is now fixed.

Another aspect was improved also for the Coccinelle software.

The following SmPL script variant can point source code places out for
further considerations.

@display@
binary operator bo;
expression e1, e2, e3, call;
identifier var;
statement is, es;
type t;
@@
*t var = e1;
 ... when != if ( \( var bo e2 \| var \) ) is else es
     when != call(..., var, ...)
     when exists
*var = e3


But it seems that data flow analysis would be needed to exclude remaining
false positives for such a source code search pattern.

Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

  reply	other threads:[~2019-06-22 13:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-20 12:30 [Cocci] Checking redundant variable initialisations with SmPL? Markus Elfring
2019-06-21 20:52 ` Julia Lawall
2019-06-22 13:15   ` Markus Elfring [this message]
2019-06-22 13:19     ` Julia Lawall
2019-06-22 13:35       ` Markus Elfring
2019-06-22 13:58         ` Julia Lawall
2019-06-22 14:16           ` Markus Elfring
2019-06-23  7:48           ` Markus Elfring
2019-06-23 12:48           ` Markus Elfring
2019-06-23 12:55             ` Julia Lawall
2019-06-23 13:05               ` Markus Elfring
2019-06-23 13:13                 ` Julia Lawall
2019-06-23 14:17                   ` Markus Elfring
2019-06-23 13:05               ` Markus Elfring
2019-06-23 12:48           ` Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9d2ef926-62b9-d182-d6d6-cd82ca13173f@web.de \
    --to=markus.elfring@web.de \
    --cc=cocci@systeme.lip6.fr \
    --cc=julia.lawall@lip6.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.