All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julia Lawall <julia.lawall@lip6.fr>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Coccinelle <cocci@systeme.lip6.fr>
Subject: Re: [Cocci] Checking redundant variable initialisations with SmPL?
Date: Sat, 22 Jun 2019 15:58:40 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.21.1906221555220.3253@hadrien> (raw)
In-Reply-To: <4dfb9359-ab09-d206-3110-0fd177ba34b3@web.de>



On Sat, 22 Jun 2019, Markus Elfring wrote:

> > It could be helpful to replace the last line by:
> >
> > (
> >   e3 = <+...var...+>
>
> Can this SmPL specification make sense as another when constraint?

No.  When is about the code between the code that matches what is before
or after.  If you put when, you will get a false positives for var = var +
1.

>
>
> > |
> > * var = e3
> > )
> >
> > In that case, it would also be beneficial to remove the *
>
> I find the asterisk required here

Yu can do whatever you want, but you will get lotsof false positives if
you keep it.  If you really want a star on the declaration then you need
to make two rules.  The first that finds the positions of the places that
match and the second that only puts a * when there is both a matched
declaration and a matched reinitialization.  But I wold imagine that from
the reinitialization, it would be easy to find the declaration, so it
doesn't seem worth further complicating the rule.

julia
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

  reply	other threads:[~2019-06-22 13:58 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-20 12:30 [Cocci] Checking redundant variable initialisations with SmPL? Markus Elfring
2019-06-21 20:52 ` Julia Lawall
2019-06-22 13:15   ` Markus Elfring
2019-06-22 13:19     ` Julia Lawall
2019-06-22 13:35       ` Markus Elfring
2019-06-22 13:58         ` Julia Lawall [this message]
2019-06-22 14:16           ` Markus Elfring
2019-06-23  7:48           ` Markus Elfring
2019-06-23 12:48           ` Markus Elfring
2019-06-23 12:55             ` Julia Lawall
2019-06-23 13:05               ` Markus Elfring
2019-06-23 13:13                 ` Julia Lawall
2019-06-23 14:17                   ` Markus Elfring
2019-06-23 13:05               ` Markus Elfring
2019-06-23 12:48           ` Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1906221555220.3253@hadrien \
    --to=julia.lawall@lip6.fr \
    --cc=Markus.Elfring@web.de \
    --cc=cocci@systeme.lip6.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.