All of lore.kernel.org
 help / color / mirror / Atom feed
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Jerome Brunet <jbrunet@baylibre.com>,
	Mark Brown <broonie@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>
Cc: Stephen Boyd <sboyd@kernel.org>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] ASoC: lpass: use the clock provider API
Date: Mon, 12 Apr 2021 14:55:51 +0100	[thread overview]
Message-ID: <9d56c9ea-a64a-2939-1bce-dcd40ca16b40@linaro.org> (raw)
In-Reply-To: <1jmtu38znu.fsf@starbuckisacylon.baylibre.com>



On 12/04/2021 13:17, Jerome Brunet wrote:
>>>    -	return of_clk_add_provider(np, of_clk_src_simple_get, va->hw.clk);
>>> +	return devm_of_clk_add_hw_provider(dev, of_clk_hw_simple_get, &va->hw);
>> Now that we convert this to devm, You missed error path and driver remove
>> where we delete clk provider. This should be removed as well as part of
>> this patch.
> Indeed. I should not have switched to devm here - It was not really the
> purpose of the patch. Habits I guess.
> 
> Do you prefer I stick with devm (with the suggested fix) or revert to the
> no-devm way for the v2 ? It makes no difference to me TBH.

devm should be good.

--srini
> 

  reply	other threads:[~2021-04-12 13:55 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-10 11:13 [PATCH 0/5] ASoC: clock provider clean-up Jerome Brunet
2021-04-10 11:13 ` Jerome Brunet
2021-04-10 11:13 ` [PATCH 1/5] ASoC: stm32: properly get clk from the provider Jerome Brunet
2021-04-10 11:13   ` Jerome Brunet
2021-04-12 20:25   ` Stephen Boyd
2021-04-12 20:25     ` Stephen Boyd
2021-04-10 11:13 ` [PATCH 2/5] ASoC: wcd934x: use the clock provider API Jerome Brunet
2021-04-10 11:13   ` Jerome Brunet
2021-04-12 20:26   ` Stephen Boyd
2021-04-12 20:26     ` Stephen Boyd
2021-04-10 11:13 ` [PATCH 3/5] ASoC: rt5682: clock driver must " Jerome Brunet
2021-04-10 11:13   ` Jerome Brunet
2021-04-12 20:27   ` Stephen Boyd
2021-04-12 20:27     ` Stephen Boyd
2021-04-13  7:31     ` Jerome Brunet
2021-04-10 11:13 ` [PATCH 4/5] ASoC: lpass: " Jerome Brunet
2021-04-10 11:13   ` Jerome Brunet
2021-04-12  9:38   ` Srinivas Kandagatla
2021-04-12 12:17     ` Jerome Brunet
2021-04-12 13:55       ` Srinivas Kandagatla [this message]
2021-04-10 11:13 ` [PATCH 5/5] ASoC: da7219: properly get clk from the provider Jerome Brunet
2021-04-10 11:13   ` Jerome Brunet
2021-04-12 20:27   ` Stephen Boyd
2021-04-12 20:27     ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9d56c9ea-a64a-2939-1bce-dcd40ca16b40@linaro.org \
    --to=srinivas.kandagatla@linaro.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=jbrunet@baylibre.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.