[PATCH dm-zoned-tools 1/2] README: fix small typo host-manmaged --> host-managed

[PATCH dm-zoned-tools 1/2] README: fix small typo host-manmaged --> host-managed

[Luis R. Rodriguez]

Small typo fix.

Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
---
 README | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/README b/README
index 61830dd..7762694 100644
--- a/README
+++ b/README
@@ -23,7 +23,7 @@ http://www.t13.org/Documents/UploadedDocuments/docs2015/
 di537r05-Zoned_Device_ATA_Command_Set_ZAC.pdf
 
 dm-zoned implementation focused on simplicity and on minimizing overhead (CPU,
-memory and storage overhead). For a 10TB host-manmaged disk with 256 MB zones,
+memory and storage overhead). For a 10TB host-managed disk with 256 MB zones,
 dm-zoned memory usage per disk instance is at most 4.5 MB and as little as 5
 zones will be used internally for storing metadata and performaing reclaim
 operations.
-- 
2.17.0

[PATCH dm-zoned-tools 2/2] README: fix example script

[Luis R. Rodriguez]

The target type should be "zoned", not "dm-zoned".

Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
---
 README | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

The README does note explain if one should use dmzadm to format a drive
if using dm zone or only if one is to use a filesystem which supports
zones, such as f2fs. Or if we should *always* use dmzadm format regardless
of the circumstance.

Could this be clarfied? What are the downsides to not using dmzadm
format on a drive and say a user just going straight to use the dm zone
and then mkfs on top of it?

diff --git a/README b/README
index 7762694..9aea28e 100644
--- a/README
+++ b/README
@@ -184,7 +184,7 @@ options="$@"
 
 modprobe dm-zoned
 
-echo "0 `blockdev --getsize ${dev}` dm-zoned ${dev} ${options}" | \
+echo "0 `blockdev --getsize ${dev}` zoned ${dev} ${options}" | \
 dmsetup create zoned-`basename ${dev}`
 ]]
 
-- 
2.17.0

Re: [PATCH dm-zoned-tools 1/2] README: fix small typo host-manmaged --> host-managed

[Damien Le Moal]

T24gMjAxOC8wNC8zMCAxMjo0NSwgTHVpcyBSLiBSb2RyaWd1ZXogd3JvdGU6DQo+IFNtYWxsIHR5
cG8gZml4Lg0KPiANCj4gU2lnbmVkLW9mZi1ieTogTHVpcyBSLiBSb2RyaWd1ZXogPG1jZ3JvZkBr
ZXJuZWwub3JnPg0KPiAtLS0NCj4gIFJFQURNRSB8IDIgKy0NCj4gIDEgZmlsZSBjaGFuZ2VkLCAx
IGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL1JFQURNRSBi
L1JFQURNRQ0KPiBpbmRleCA2MTgzMGRkLi43NzYyNjk0IDEwMDY0NA0KPiAtLS0gYS9SRUFETUUN
Cj4gKysrIGIvUkVBRE1FDQo+IEBAIC0yMyw3ICsyMyw3IEBAIGh0dHA6Ly93d3cudDEzLm9yZy9E
b2N1bWVudHMvVXBsb2FkZWREb2N1bWVudHMvZG9jczIwMTUvDQo+ICBkaTUzN3IwNS1ab25lZF9E
ZXZpY2VfQVRBX0NvbW1hbmRfU2V0X1pBQy5wZGYNCj4gIA0KPiAgZG0tem9uZWQgaW1wbGVtZW50
YXRpb24gZm9jdXNlZCBvbiBzaW1wbGljaXR5IGFuZCBvbiBtaW5pbWl6aW5nIG92ZXJoZWFkIChD
UFUsDQo+IC1tZW1vcnkgYW5kIHN0b3JhZ2Ugb3ZlcmhlYWQpLiBGb3IgYSAxMFRCIGhvc3QtbWFu
bWFnZWQgZGlzayB3aXRoIDI1NiBNQiB6b25lcywNCj4gK21lbW9yeSBhbmQgc3RvcmFnZSBvdmVy
aGVhZCkuIEZvciBhIDEwVEIgaG9zdC1tYW5hZ2VkIGRpc2sgd2l0aCAyNTYgTUIgem9uZXMsDQo+
ICBkbS16b25lZCBtZW1vcnkgdXNhZ2UgcGVyIGRpc2sgaW5zdGFuY2UgaXMgYXQgbW9zdCA0LjUg
TUIgYW5kIGFzIGxpdHRsZSBhcyA1DQo+ICB6b25lcyB3aWxsIGJlIHVzZWQgaW50ZXJuYWxseSBm
b3Igc3RvcmluZyBtZXRhZGF0YSBhbmQgcGVyZm9ybWFpbmcgcmVjbGFpbQ0KPiAgb3BlcmF0aW9u
cy4NCg0KVGhhbmtzIEx1aXMgIQ0KDQpSZXZpZXdlZC1ieTogRGFtaWVuIExlIE1vYWwgPGRhbWll
bi5sZW1vYWxAd2RjLmNvbT4NCg0KDQotLSANCkRhbWllbiBMZSBNb2FsDQpXZXN0ZXJuIERpZ2l0
YWwgUmVzZWFyY2g=

Re: [PATCH dm-zoned-tools 1/2] README: fix small typo host-manmaged --> host-managed

[Damien Le Moal]

On 2018/04/30 12:45, Luis R. Rodriguez wrote:
> Small typo fix.
> 
> Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
> ---
>  README | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/README b/README
> index 61830dd..7762694 100644
> --- a/README
> +++ b/README
> @@ -23,7 +23,7 @@ http://www.t13.org/Documents/UploadedDocuments/docs2015/
>  di537r05-Zoned_Device_ATA_Command_Set_ZAC.pdf
>  
>  dm-zoned implementation focused on simplicity and on minimizing overhead (CPU,
> -memory and storage overhead). For a 10TB host-manmaged disk with 256 MB zones,
> +memory and storage overhead). For a 10TB host-managed disk with 256 MB zones,
>  dm-zoned memory usage per disk instance is at most 4.5 MB and as little as 5
>  zones will be used internally for storing metadata and performaing reclaim
>  operations.

Thanks Luis !

Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>


-- 
Damien Le Moal
Western Digital Research

Re: [PATCH dm-zoned-tools 2/2] README: fix example script

[Damien Le Moal]

T24gMjAxOC8wNC8zMCAxMjo0NSwgTHVpcyBSLiBSb2RyaWd1ZXogd3JvdGU6DQo+IFRoZSB0YXJn
ZXQgdHlwZSBzaG91bGQgYmUgInpvbmVkIiwgbm90ICJkbS16b25lZCIuDQo+IA0KPiBTaWduZWQt
b2ZmLWJ5OiBMdWlzIFIuIFJvZHJpZ3VleiA8bWNncm9mQGtlcm5lbC5vcmc+DQo+IC0tLQ0KPiAg
UkVBRE1FIHwgMiArLQ0KPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0
aW9uKC0pDQo+IA0KPiBUaGUgUkVBRE1FIGRvZXMgbm90ZSBleHBsYWluIGlmIG9uZSBzaG91bGQg
dXNlIGRtemFkbSB0byBmb3JtYXQgYSBkcml2ZQ0KPiBpZiB1c2luZyBkbSB6b25lIG9yIG9ubHkg
aWYgb25lIGlzIHRvIHVzZSBhIGZpbGVzeXN0ZW0gd2hpY2ggc3VwcG9ydHMNCj4gem9uZXMsIHN1
Y2ggYXMgZjJmcy4gT3IgaWYgd2Ugc2hvdWxkICphbHdheXMqIHVzZSBkbXphZG0gZm9ybWF0IHJl
Z2FyZGxlc3MNCj4gb2YgdGhlIGNpcmN1bXN0YW5jZS4NCg0KZG16YWRtIGlzIG9ubHkgZm9yIGRt
LXpvbmVkIGRldmljZSBtYXBwZXIuIElmIHRoZSBmaWxlIHN5c3RlbSBuYXRpdmVseSBzdXBwb3J0
DQp6b25lZCBibG9jayBkZXZpY2VzLCBpdCBpcyB0aGUgRlMgcHJvYmxlbSB0byBmb3JtYXQgdGhl
IGRyaXZlIGFjY29yZGluZ2x5IHRvDQpaQkMvWkFDIGNvbnN0cmFpbnRzLiBBbmQgZm9yIHRoZXNl
IGZpbGVzIHN5c3RlbXMsIGRtLXpvbmVkIGlzIHVzZWxlc3MuDQoNCj4gQ291bGQgdGhpcyBiZSBj
bGFyZmllZD8gV2hhdCBhcmUgdGhlIGRvd25zaWRlcyB0byBub3QgdXNpbmcgZG16YWRtDQo+IGZv
cm1hdCBvbiBhIGRyaXZlIGFuZCBzYXkgYSB1c2VyIGp1c3QgZ29pbmcgc3RyYWlnaHQgdG8gdXNl
IHRoZSBkbSB6b25lDQo+IGFuZCB0aGVuIG1rZnMgb24gdG9wIG9mIGl0Pw0KDQpPSy4gSSB3aWxs
IGxvb2sgaW50byBpdCBhbmQgY2xhcmlmeS4NCg0KPiANCj4gZGlmZiAtLWdpdCBhL1JFQURNRSBi
L1JFQURNRQ0KPiBpbmRleCA3NzYyNjk0Li45YWVhMjhlIDEwMDY0NA0KPiAtLS0gYS9SRUFETUUN
Cj4gKysrIGIvUkVBRE1FDQo+IEBAIC0xODQsNyArMTg0LDcgQEAgb3B0aW9ucz0iJEAiDQo+ICAN
Cj4gIG1vZHByb2JlIGRtLXpvbmVkDQo+ICANCj4gLWVjaG8gIjAgYGJsb2NrZGV2IC0tZ2V0c2l6
ZSAke2Rldn1gIGRtLXpvbmVkICR7ZGV2fSAke29wdGlvbnN9IiB8IFwNCj4gK2VjaG8gIjAgYGJs
b2NrZGV2IC0tZ2V0c2l6ZSAke2Rldn1gIHpvbmVkICR7ZGV2fSAke29wdGlvbnN9IiB8IFwNCj4g
IGRtc2V0dXAgY3JlYXRlIHpvbmVkLWBiYXNlbmFtZSAke2Rldn1gDQo+ICBdXQ0KDQpZZXMsIGlu
ZGVlZC4uLg0KDQpSZXZpZXdlZC1ieTogRGFtaWVuIExlIE1vYWwgPGRhbWllbi5sZW1vYWxAd2Rj
LmNvbT4NCg0KLS0gDQpEYW1pZW4gTGUgTW9hbA0KV2VzdGVybiBEaWdpdGFsIFJlc2VhcmNo

Re: [PATCH dm-zoned-tools 2/2] README: fix example script

[Damien Le Moal]

On 2018/04/30 12:45, Luis R. Rodriguez wrote:
> The target type should be "zoned", not "dm-zoned".
> 
> Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
> ---
>  README | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> The README does note explain if one should use dmzadm to format a drive
> if using dm zone or only if one is to use a filesystem which supports
> zones, such as f2fs. Or if we should *always* use dmzadm format regardless
> of the circumstance.

dmzadm is only for dm-zoned device mapper. If the file system natively support
zoned block devices, it is the FS problem to format the drive accordingly to
ZBC/ZAC constraints. And for these files systems, dm-zoned is useless.

> Could this be clarfied? What are the downsides to not using dmzadm
> format on a drive and say a user just going straight to use the dm zone
> and then mkfs on top of it?

OK. I will look into it and clarify.

> 
> diff --git a/README b/README
> index 7762694..9aea28e 100644
> --- a/README
> +++ b/README
> @@ -184,7 +184,7 @@ options="$@"
>  
>  modprobe dm-zoned
>  
> -echo "0 `blockdev --getsize ${dev}` dm-zoned ${dev} ${options}" | \
> +echo "0 `blockdev --getsize ${dev}` zoned ${dev} ${options}" | \
>  dmsetup create zoned-`basename ${dev}`
>  ]]

Yes, indeed...

Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>

-- 
Damien Le Moal
Western Digital Research

Re: [PATCH dm-zoned-tools 2/2] README: fix example script

[Luis R. Rodriguez]

On Mon, Apr 30, 2018 at 08:36:09PM +0000, Damien Le Moal wrote:
> On 2018/04/30 12:45, Luis R. Rodriguez wrote:
> > The target type should be "zoned", not "dm-zoned".
> > 
> > Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
> > ---
> >  README | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > The README does note explain if one should use dmzadm to format a drive
> > if using dm zone or only if one is to use a filesystem which supports
> > zones, such as f2fs. Or if we should *always* use dmzadm format regardless
> > of the circumstance.
> 
> dmzadm is only for dm-zoned device mapper. If the file system natively support
> zoned block devices, it is the FS problem to format the drive accordingly to
> ZBC/ZAC constraints.

The README could be update to reflect this then, just to be sure. Only now
that I realize it has the dm prefix did I realize this was an obvious
requirement :P

> And for these files systems, dm-zoned is useless.

Sure, make sense.

  Luis