* [PATCH] dt-bindings: spi: delete unused required and adjust the item.
@ 2022-02-18 1:56 Li-hao Kuo
2022-02-24 13:36 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Li-hao Kuo @ 2022-02-18 1:56 UTC (permalink / raw)
To: broonie, robh+dt, linux-spi, devicetree, linux-kernel
Cc: wells.lu, lh.kuo, Li-hao Kuo
delete unused required(clock-name)
adjust position (interrupts)
Fixes: 3b8ab4da34 ("spi: Fix test error for sp7021")
Reported-by: Rob Herring <robh+dt@kernel.org>
Signed-off-by: Li-hao Kuo <lhjeff911@gmail.com>
---
Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml b/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml
index 298eac2..9df08d7 100644
--- a/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml
+++ b/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml
@@ -47,10 +47,9 @@ required:
- compatible
- reg
- reg-names
- - interrupts
- interrupt-names
+ - interrupts
- clocks
- - clocks-names
- resets
- pinctrl-names
- pinctrl-0
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: spi: delete unused required and adjust the item.
2022-02-18 1:56 [PATCH] dt-bindings: spi: delete unused required and adjust the item Li-hao Kuo
@ 2022-02-24 13:36 ` Rob Herring
2022-02-25 1:23 ` Lh Kuo 郭力豪
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2022-02-24 13:36 UTC (permalink / raw)
To: Li-hao Kuo
Cc: Mark Brown, linux-spi, devicetree, linux-kernel,
Wells Lu 呂芳騰,
LH.Kuo
On Thu, Feb 17, 2022 at 7:56 PM Li-hao Kuo <lhjeff911@gmail.com> wrote:
>
> delete unused required(clock-name)
> adjust position (interrupts)
Why? This seems like an unnecessary change.
Please write complete sentences that answer why this change is needed,
not what the change is. The diff describes what changed. In this case,
quoting the warning you are fixing is typical.
>
> Fixes: 3b8ab4da34 ("spi: Fix test error for sp7021")
>
There should not be a blank line here.
> Reported-by: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Li-hao Kuo <lhjeff911@gmail.com>
> ---
> Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml b/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml
> index 298eac2..9df08d7 100644
> --- a/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml
> +++ b/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml
> @@ -47,10 +47,9 @@ required:
> - compatible
> - reg
> - reg-names
> - - interrupts
> - interrupt-names
> + - interrupts
> - clocks
> - - clocks-names
> - resets
> - pinctrl-names
> - pinctrl-0
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] dt-bindings: spi: delete unused required and adjust the item.
2022-02-24 13:36 ` Rob Herring
@ 2022-02-25 1:23 ` Lh Kuo 郭力豪
0 siblings, 0 replies; 3+ messages in thread
From: Lh Kuo 郭力豪 @ 2022-02-25 1:23 UTC (permalink / raw)
To: Rob Herring, Li-hao Kuo
Cc: Mark Brown, linux-spi, devicetree, linux-kernel,
Wells Lu 呂芳騰
Hi Mr.Rob Herring :
I am sorry for that.
This patch will fix testing issues as clock names are not used
Checking for a patch will show a warning
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-25 1:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-18 1:56 [PATCH] dt-bindings: spi: delete unused required and adjust the item Li-hao Kuo
2022-02-24 13:36 ` Rob Herring
2022-02-25 1:23 ` Lh Kuo 郭力豪
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.