* [dm-devel] [PATCH RFC] multipath-tools: update "Generic NVMe" options in hwtable @ 2022-03-30 19:49 Xose Vazquez Perez 2022-03-31 11:02 ` Martin Wilck 0 siblings, 1 reply; 4+ messages in thread From: Xose Vazquez Perez @ 2022-03-30 19:49 UTC (permalink / raw) Cc: Xose Vazquez Perez, Martin Wilck, DM-DEVEL ML Removed values were default. Check ANA, else fall back to CONST(multibus). Cc: Martin Wilck <mwilck@suse.com> Cc: Benjamin Marzinski <bmarzins@redhat.com> Cc: Christophe Varoqui <christophe.varoqui@opensvc.com> Cc: DM-DEVEL ML <dm-devel@redhat.com> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com> --- libmultipath/hwtable.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c index 0e1c0a41..81dca0d5 100644 --- a/libmultipath/hwtable.c +++ b/libmultipath/hwtable.c @@ -88,9 +88,9 @@ static struct hwentry default_hw[] = { /* Generic NVMe */ .vendor = "NVME", .product = ".*", - .uid_attribute = DEFAULT_NVME_UID_ATTRIBUTE, - .checker_name = NONE, - .retain_hwhandler = RETAIN_HWHANDLER_OFF, + .pgpolicy = GROUP_BY_PRIO, + .pgfailback = -FAILBACK_IMMEDIATE, + .no_path_retry = NO_PATH_RETRY_QUEUE, }, /* * Apple -- 2.35.1 -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [dm-devel] [PATCH RFC] multipath-tools: update "Generic NVMe" options in hwtable 2022-03-30 19:49 [dm-devel] [PATCH RFC] multipath-tools: update "Generic NVMe" options in hwtable Xose Vazquez Perez @ 2022-03-31 11:02 ` Martin Wilck 2022-05-15 13:16 ` Xose Vazquez Perez 0 siblings, 1 reply; 4+ messages in thread From: Martin Wilck @ 2022-03-31 11:02 UTC (permalink / raw) To: Xose Vazquez Perez; +Cc: DM-DEVEL ML On Wed, 2022-03-30 at 21:49 +0200, Xose Vazquez Perez wrote: > Removed values were default. This is wrong for uid_attribute. You can see it when you run "make test", which fails with your patch. It's also wrong for retain_hwhandler, but that entry should indeed be removed, because keeping it there is misleading at best. hwhandlers have no meaning for NVMe, and retain_hwhandler is enforced to be true an all kernels since 4.3. Regards, Martin > Check ANA, else fall back to CONST(multibus). > > Cc: Martin Wilck <mwilck@suse.com> > Cc: Benjamin Marzinski <bmarzins@redhat.com> > Cc: Christophe Varoqui <christophe.varoqui@opensvc.com> > Cc: DM-DEVEL ML <dm-devel@redhat.com> > Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com> > --- > libmultipath/hwtable.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c > index 0e1c0a41..81dca0d5 100644 > --- a/libmultipath/hwtable.c > +++ b/libmultipath/hwtable.c > @@ -88,9 +88,9 @@ static struct hwentry default_hw[] = { > /* Generic NVMe */ > .vendor = "NVME", > .product = ".*", > - .uid_attribute = DEFAULT_NVME_UID_ATTRIBUTE, > - .checker_name = NONE, > - .retain_hwhandler = RETAIN_HWHANDLER_OFF, > + .pgpolicy = GROUP_BY_PRIO, > + .pgfailback = -FAILBACK_IMMEDIATE, > + .no_path_retry = NO_PATH_RETRY_QUEUE, > }, > /* > * Apple -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dm-devel] [PATCH RFC] multipath-tools: update "Generic NVMe" options in hwtable 2022-03-31 11:02 ` Martin Wilck @ 2022-05-15 13:16 ` Xose Vazquez Perez 2022-05-19 12:35 ` Martin Wilck 0 siblings, 1 reply; 4+ messages in thread From: Xose Vazquez Perez @ 2022-05-15 13:16 UTC (permalink / raw) To: Martin Wilck; +Cc: Christophe Varoqui, DM-DEVEL ML On 3/31/22 13:02, Martin Wilck wrote: > On Wed, 2022-03-30 at 21:49 +0200, Xose Vazquez Perez wrote: >> Removed values were default. > > This is wrong for uid_attribute. You can see it when you run "make > test", which fails with your patch. It's also wrong for > retain_hwhandler, but that entry should indeed be removed, because > keeping it there is misleading at best. hwhandlers have no meaning for > NVMe, and retain_hwhandler is enforced to be true an all kernels since > 4.3. > > Regards, > Martin > >> Check ANA, else fall back to CONST(multibus). >> >> Cc: Martin Wilck <mwilck@suse.com> >> Cc: Benjamin Marzinski <bmarzins@redhat.com> >> Cc: Christophe Varoqui <christophe.varoqui@opensvc.com> >> Cc: DM-DEVEL ML <dm-devel@redhat.com> >> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com> >> --- >> libmultipath/hwtable.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c >> index 0e1c0a41..81dca0d5 100644 >> --- a/libmultipath/hwtable.c >> +++ b/libmultipath/hwtable.c >> @@ -88,9 +88,9 @@ static struct hwentry default_hw[] = { >> /* Generic NVMe */ >> .vendor = "NVME", >> .product = ".*", >> - .uid_attribute = DEFAULT_NVME_UID_ATTRIBUTE, >> - .checker_name = NONE, >> - .retain_hwhandler = RETAIN_HWHANDLER_OFF, >> + .pgpolicy = GROUP_BY_PRIO, >> + .pgfailback = -FAILBACK_IMMEDIATE, >> + .no_path_retry = NO_PATH_RETRY_QUEUE, >> }, >> /* >> * Apple > as of this patch, what else do you want to add/remove ? diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c index 47ea5d3d..2f750adb 100644 --- a/libmultipath/hwtable.c +++ b/libmultipath/hwtable.c @@ -86,11 +86,10 @@ static struct hwentry default_hw[] = { */ { /* Generic NVMe */ - .vendor = "NVME", + .vendor = "NVM[eE]", .product = ".*", .uid_attribute = DEFAULT_NVME_UID_ATTRIBUTE, .checker_name = NONE, - .retain_hwhandler = RETAIN_HWHANDLER_OFF, }, /* * Apple -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [dm-devel] [PATCH RFC] multipath-tools: update "Generic NVMe" options in hwtable 2022-05-15 13:16 ` Xose Vazquez Perez @ 2022-05-19 12:35 ` Martin Wilck 0 siblings, 0 replies; 4+ messages in thread From: Martin Wilck @ 2022-05-19 12:35 UTC (permalink / raw) To: Xose Vazquez Perez; +Cc: Christophe Varoqui, DM-DEVEL ML On Sun, 2022-05-15 at 15:16 +0200, Xose Vazquez Perez wrote: > On 3/31/22 13:02, Martin Wilck wrote: > > On Wed, 2022-03-30 at 21:49 +0200, Xose Vazquez Perez wrote: > > > Removed values were default. > > > > This is wrong for uid_attribute. You can see it when you run "make > > test", which fails with your patch. It's also wrong for > > retain_hwhandler, but that entry should indeed be removed, because > > keeping it there is misleading at best. hwhandlers have no meaning > > for > > NVMe, and retain_hwhandler is enforced to be true an all kernels > > since > > 4.3. > > > > Regards, > > Martin > > > > > Check ANA, else fall back to CONST(multibus). > > > > > > Cc: Martin Wilck <mwilck@suse.com> > > > Cc: Benjamin Marzinski <bmarzins@redhat.com> > > > Cc: Christophe Varoqui <christophe.varoqui@opensvc.com> > > > Cc: DM-DEVEL ML <dm-devel@redhat.com> > > > Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com> > > > --- > > > libmultipath/hwtable.c | 6 +++--- > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c > > > index 0e1c0a41..81dca0d5 100644 > > > --- a/libmultipath/hwtable.c > > > +++ b/libmultipath/hwtable.c > > > @@ -88,9 +88,9 @@ static struct hwentry default_hw[] = { > > > /* Generic NVMe */ > > > .vendor = "NVME", > > > .product = ".*", > > > - .uid_attribute = DEFAULT_NVME_UID_ATTRIBUTE, > > > - .checker_name = NONE, > > > - .retain_hwhandler = RETAIN_HWHANDLER_OFF, > > > + .pgpolicy = GROUP_BY_PRIO, > > > + .pgfailback = -FAILBACK_IMMEDIATE, > > > + .no_path_retry = NO_PATH_RETRY_QUEUE, > > > }, > > > /* > > > * Apple > > > > as of this patch, what else do you want to add/remove ? > > diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c > index 47ea5d3d..2f750adb 100644 > --- a/libmultipath/hwtable.c > +++ b/libmultipath/hwtable.c > @@ -86,11 +86,10 @@ static struct hwentry default_hw[] = { > */ > { > /* Generic NVMe */ > - .vendor = "NVME", > + .vendor = "NVM[eE]", > .product = ".*", > .uid_attribute = DEFAULT_NVME_UID_ATTRIBUTE, > .checker_name = NONE, > - .retain_hwhandler = RETAIN_HWHANDLER_OFF, > }, > /* > * Apple > This looks ok to me. Martin -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-05-19 12:36 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-03-30 19:49 [dm-devel] [PATCH RFC] multipath-tools: update "Generic NVMe" options in hwtable Xose Vazquez Perez 2022-03-31 11:02 ` Martin Wilck 2022-05-15 13:16 ` Xose Vazquez Perez 2022-05-19 12:35 ` Martin Wilck
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.