All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Gagandeep Singh <g.singh@nxp.com>, dev@dpdk.org
Cc: pankaj.chauhan@nxp.com
Subject: Re: [PATCH v2 3/3] net/enetc: enable Rx and Tx
Date: Fri, 21 Sep 2018 14:28:36 +0100	[thread overview]
Message-ID: <9d6ed0aa-c08d-9be2-0798-115c0d086207@intel.com> (raw)
In-Reply-To: <20180913094201.17098-4-g.singh@nxp.com>

On 9/13/2018 10:42 AM, Gagandeep Singh wrote:
> Add RX and TX queue setup, datapath functions
> and enable the packet parsing
> 
> Signed-off-by: Gagandeep Singh <g.singh@nxp.com>
<...>

> -LDLIBS += -lrte_eal
> +LDLIBS += -lrte_eal -lrte_mempool
>  LDLIBS += -lrte_ethdev
>  LDLIBS += -lrte_bus_pci

Isn't mbuf and ring are dependency?

<...>

> +static inline void __attribute__((hot))
> +enetc_dev_rx_parse(struct rte_mbuf *m, uint16_t parse_results)
> +{
> +	ENETC_PMD_DP_DEBUG("parse summary = 0x%x   ", parse_results);
> +
> +	m->packet_type = RTE_PTYPE_UNKNOWN;
> +	switch (parse_results) {
> +	case ENETC_PKT_TYPE_ETHER:
> +		m->packet_type = RTE_PTYPE_L2_ETHER;
> +		break;
> +	case ENETC_PKT_TYPE_IPV4:
> +		m->packet_type = RTE_PTYPE_L2_ETHER |
> +					RTE_PTYPE_L3_IPV4;
> +		break;
> +	case ENETC_PKT_TYPE_IPV6:
> +		m->packet_type = RTE_PTYPE_L2_ETHER |
> +					RTE_PTYPE_L3_IPV6;
> +		break;
> +	case ENETC_PKT_TYPE_IPV4_TCP:
> +		m->packet_type = RTE_PTYPE_L2_ETHER |
> +			RTE_PTYPE_L3_IPV4 | RTE_PTYPE_L4_TCP;
> +		break;
> +	case ENETC_PKT_TYPE_IPV6_TCP:
> +		m->packet_type = RTE_PTYPE_L2_ETHER |
> +			RTE_PTYPE_L3_IPV6 | RTE_PTYPE_L4_TCP;
> +		break;
> +	case ENETC_PKT_TYPE_IPV4_UDP:
> +		m->packet_type = RTE_PTYPE_L2_ETHER |
> +			RTE_PTYPE_L3_IPV4 | RTE_PTYPE_L4_UDP;
> +		break;
> +	case ENETC_PKT_TYPE_IPV6_UDP:
> +		m->packet_type = RTE_PTYPE_L2_ETHER |
> +			RTE_PTYPE_L3_IPV6 | RTE_PTYPE_L4_UDP;
> +		break;
> +	case ENETC_PKT_TYPE_IPV4_SCTP:
> +		m->packet_type = RTE_PTYPE_L2_ETHER |
> +			RTE_PTYPE_L3_IPV4 | RTE_PTYPE_L4_SCTP;
> +		break;
> +	case ENETC_PKT_TYPE_IPV6_SCTP:
> +		m->packet_type = RTE_PTYPE_L2_ETHER |
> +			RTE_PTYPE_L3_IPV6 | RTE_PTYPE_L4_SCTP;
> +		break;
> +	case ENETC_PKT_TYPE_IPV4_ICMP:
> +		m->packet_type = RTE_PTYPE_L2_ETHER |
> +			RTE_PTYPE_L3_IPV4 | RTE_PTYPE_L4_ICMP;
> +		break;
> +	case ENETC_PKT_TYPE_IPV6_ICMP:
> +		m->packet_type = RTE_PTYPE_L2_ETHER |
> +			RTE_PTYPE_L3_IPV6 | RTE_PTYPE_L4_ICMP;
> +		break;
> +	/* More switch cases can be added */
> +	default:
> +		m->packet_type = RTE_PTYPE_UNKNOWN;
> +	}
> +}

You are already getting packet type info from device and set mbuf, by
implementing (relatively easy) rte_eth_dev_get_supported_ptypes() API you can
make applications use these values better,
And enable "Packet type parsing" feature in .ini file

  parent reply	other threads:[~2018-09-21 13:28 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-06  5:54 [PATCH 0/3] introduces the ENETC PMD Gagandeep Singh
2018-09-06  5:54 ` [PATCH 1/3] doc: add usage doc for " Gagandeep Singh
2018-09-06  5:54 ` [PATCH 2/3] net/enetc: add ENETC PMD with basic operations Gagandeep Singh
2018-09-19 12:15   ` Shreyansh Jain
2018-09-06  5:54 ` [PATCH 3/3] net/enetc: enable Rx and Tx Gagandeep Singh
2018-09-13  9:41 ` [PATCH v2 0/3] introduces the enetc PMD driver Gagandeep Singh
2018-09-13  9:41   ` [PATCH v2 1/3] doc: add usage doc for ENETC PMD Gagandeep Singh
2018-09-21 13:22     ` Ferruh Yigit
2018-09-13  9:42   ` [PATCH v2 2/3] net/enetc: add ENETC PMD with basic operations Gagandeep Singh
2018-09-21 13:27     ` Ferruh Yigit
2018-09-13  9:42   ` [PATCH v2 3/3] net/enetc: enable Rx and Tx Gagandeep Singh
2018-09-19 12:26     ` Shreyansh Jain
2018-09-21 13:28     ` Ferruh Yigit [this message]
2018-09-28  5:16   ` [PATCH v3 0/3] introduces the enetc PMD driver Gagandeep Singh
2018-09-28  5:16     ` [PATCH v3 1/3] net/enetc: enable Rx and Tx Gagandeep Singh
2018-09-28  5:16     ` [PATCH v3 2/3] net/enetc: support packet parse type Gagandeep Singh
2018-09-28  5:16     ` [PATCH v3 3/3] doc: add usage doc for ENETC PMD Gagandeep Singh
2018-09-28  5:26     ` [PATCH v3 0/3] introduces the enetc PMD driver Gagandeep Singh
2018-09-28  7:45     ` [PATCH v4 0/4] " Gagandeep Singh
2018-09-28  7:45       ` [PATCH v4 1/4] net/enetc: add ENETC PMD with basic operations Gagandeep Singh
2018-10-01 15:58         ` Ferruh Yigit
2018-09-28  7:45       ` [PATCH v4 2/4] net/enetc: enable Rx and Tx Gagandeep Singh
2018-10-01 15:59         ` Ferruh Yigit
2018-09-28  7:46       ` [PATCH v4 3/4] net/enetc: support packet parse type Gagandeep Singh
2018-09-28 10:17         ` Shreyansh Jain
2018-10-01 15:59           ` Ferruh Yigit
2018-09-28  7:46       ` [PATCH v4 4/4] doc: add usage doc for ENETC PMD Gagandeep Singh
2018-10-01 16:00         ` Ferruh Yigit
2018-09-28 10:36       ` [PATCH v4 0/4] introduces the enetc PMD driver Shreyansh Jain
2018-10-03 13:36       ` [PATCH v5 " Gagandeep Singh
2018-10-03 13:36         ` [PATCH v5 1/4] net/enetc: add ENETC PMD with basic operations Gagandeep Singh
2018-10-03 19:47           ` Ferruh Yigit
2018-10-03 13:36         ` [PATCH v5 2/4] net/enetc: enable Rx and Tx Gagandeep Singh
2018-10-03 13:36         ` [PATCH v5 3/4] net/enetc: support packet parse type Gagandeep Singh
2018-10-03 13:36         ` [PATCH v5 4/4] doc: add usage doc for ENETC PMD Gagandeep Singh
2018-10-03 19:47           ` Ferruh Yigit
2018-10-03 19:48         ` [PATCH v5 0/4] introduces the enetc PMD driver Ferruh Yigit
2018-11-21 17:36           ` Ferruh Yigit
2018-11-22 10:34             ` Shreyansh Jain
2018-11-22 12:08               ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9d6ed0aa-c08d-9be2-0798-115c0d086207@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=g.singh@nxp.com \
    --cc=pankaj.chauhan@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.