From: Jean-Philippe Brucker <jean-philippe.brucker@arm.com> To: Jacob Pan <jacob.jun.pan@linux.intel.com> Cc: yi.l.liu@linux.intel.com, ashok.raj@intel.com, alex.williamson@redhat.com, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] iommu: Add recoverable fault reporting Date: Fri, 31 May 2019 12:05:18 +0100 [thread overview] Message-ID: <9df2db3b-3892-f4ae-c7de-dbb27a12b293@arm.com> (raw) In-Reply-To: <20190524111444.676a4df1@jacob-builder> On 24/05/2019 19:14, Jacob Pan wrote: > On Thu, 23 May 2019 19:06:13 +0100 >> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c >> index d546f7baa0d4..b09b3707f0e4 100644 >> --- a/drivers/iommu/iommu.c >> +++ b/drivers/iommu/iommu.c >> @@ -872,7 +872,14 @@ >> EXPORT_SYMBOL_GPL(iommu_group_unregister_notifier); >> * @data: private data passed as argument to the handler >> * >> * When an IOMMU fault event is received, this handler gets called >> with the >> - * fault event and data as argument. The handler should return 0 on >> success. >> + * fault event and data as argument. The handler should return 0 on >> success. If >> + * the fault is recoverable (IOMMU_FAULT_PAGE_REQ), the handler >> should also >> + * complete the fault by calling iommu_page_response() with one of >> the following > nit, in case of injecting into the guest, handler does not have to call > iommu_page_response() directly. True, I'll think of a better wording. Maybe just s/handler/consumer/ although we didn't define consumer anywhere >> IOMMU_PAGE_RESP_PASID_VALID : 0; + >> + ret = domain->ops->page_response(dev, msg, >> evt->iommu_private); > I guess here you could drop iommu_private in favor of prm such that > drivers such as vt-d can recover private data as needed? Yes, will change this Thanks, Jean
WARNING: multiple messages have this Message-ID (diff)
From: Jean-Philippe Brucker <jean-philippe.brucker@arm.com> To: Jacob Pan <jacob.jun.pan@linux.intel.com> Cc: yi.l.liu@linux.intel.com, alex.williamson@redhat.com, ashok.raj@intel.com, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] iommu: Add recoverable fault reporting Date: Fri, 31 May 2019 12:05:18 +0100 [thread overview] Message-ID: <9df2db3b-3892-f4ae-c7de-dbb27a12b293@arm.com> (raw) In-Reply-To: <20190524111444.676a4df1@jacob-builder> On 24/05/2019 19:14, Jacob Pan wrote: > On Thu, 23 May 2019 19:06:13 +0100 >> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c >> index d546f7baa0d4..b09b3707f0e4 100644 >> --- a/drivers/iommu/iommu.c >> +++ b/drivers/iommu/iommu.c >> @@ -872,7 +872,14 @@ >> EXPORT_SYMBOL_GPL(iommu_group_unregister_notifier); >> * @data: private data passed as argument to the handler >> * >> * When an IOMMU fault event is received, this handler gets called >> with the >> - * fault event and data as argument. The handler should return 0 on >> success. >> + * fault event and data as argument. The handler should return 0 on >> success. If >> + * the fault is recoverable (IOMMU_FAULT_PAGE_REQ), the handler >> should also >> + * complete the fault by calling iommu_page_response() with one of >> the following > nit, in case of injecting into the guest, handler does not have to call > iommu_page_response() directly. True, I'll think of a better wording. Maybe just s/handler/consumer/ although we didn't define consumer anywhere >> IOMMU_PAGE_RESP_PASID_VALID : 0; + >> + ret = domain->ops->page_response(dev, msg, >> evt->iommu_private); > I guess here you could drop iommu_private in favor of prm such that > drivers such as vt-d can recover private data as needed? Yes, will change this Thanks, Jean _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2019-05-31 11:05 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-23 18:06 [PATCH 0/4] iommu: Add device fault reporting API Jean-Philippe Brucker 2019-05-23 18:06 ` Jean-Philippe Brucker 2019-05-23 18:06 ` [PATCH 1/4] driver core: Add per device iommu param Jean-Philippe Brucker 2019-05-23 18:06 ` Jean-Philippe Brucker 2019-05-23 18:06 ` [PATCH 2/4] iommu: Introduce device fault data Jean-Philippe Brucker 2019-05-23 18:06 ` Jean-Philippe Brucker 2019-05-23 18:43 ` Robin Murphy 2019-05-23 18:43 ` Robin Murphy 2019-05-24 13:49 ` Jacob Pan 2019-05-24 13:49 ` Jacob Pan 2019-05-24 16:14 ` Jean-Philippe Brucker 2019-05-24 16:14 ` Jean-Philippe Brucker 2019-05-24 17:44 ` Jacob Pan 2019-05-24 17:44 ` Jacob Pan 2019-05-23 18:06 ` [PATCH 3/4] iommu: Introduce device fault report API Jean-Philippe Brucker 2019-05-23 18:06 ` Jean-Philippe Brucker 2019-05-23 18:56 ` Robin Murphy 2019-05-23 18:56 ` Robin Murphy 2019-05-24 18:00 ` Jacob Pan 2019-05-24 18:00 ` Jacob Pan 2019-05-31 13:37 ` Jean-Philippe Brucker 2019-05-31 13:37 ` Jean-Philippe Brucker 2019-05-23 18:06 ` [PATCH 4/4] iommu: Add recoverable fault reporting Jean-Philippe Brucker 2019-05-23 18:06 ` Jean-Philippe Brucker 2019-05-24 18:14 ` Jacob Pan 2019-05-24 18:14 ` Jacob Pan 2019-05-31 11:05 ` Jean-Philippe Brucker [this message] 2019-05-31 11:05 ` Jean-Philippe Brucker
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=9df2db3b-3892-f4ae-c7de-dbb27a12b293@arm.com \ --to=jean-philippe.brucker@arm.com \ --cc=alex.williamson@redhat.com \ --cc=ashok.raj@intel.com \ --cc=iommu@lists.linux-foundation.org \ --cc=jacob.jun.pan@linux.intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=yi.l.liu@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.