All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chao Yu <yuchao0@huawei.com>
To: Jaegeuk Kim <jaegeuk@kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-f2fs-devel@lists.sourceforge.net>
Subject: Re: [f2fs-dev] [PATCH] f2fs: avoid null pointer access when handling IPU error
Date: Tue, 11 May 2021 09:29:07 +0800	[thread overview]
Message-ID: <9df7d088-3580-122b-60a3-799ea665cfeb@huawei.com> (raw)
In-Reply-To: <20210510142804.511265-1-jaegeuk@kernel.org>

On 2021/5/10 22:28, Jaegeuk Kim wrote:
>   Unable to handle kernel NULL pointer dereference at virtual address 000000000000001a
>   pc : f2fs_inplace_write_data+0x144/0x208
>   lr : f2fs_inplace_write_data+0x134/0x208
>   Call trace:
>    f2fs_inplace_write_data+0x144/0x208
>    f2fs_do_write_data_page+0x270/0x770
>    f2fs_write_single_data_page+0x47c/0x830
>    __f2fs_write_data_pages+0x444/0x98c
>    f2fs_write_data_pages.llvm.16514453770497736882+0x2c/0x38
>    do_writepages+0x58/0x118
>    __writeback_single_inode+0x44/0x300
>    writeback_sb_inodes+0x4b8/0x9c8
>    wb_writeback+0x148/0x42c
>    wb_do_writeback+0xc8/0x390
>    wb_workfn+0xb0/0x2f4
>    process_one_work+0x1fc/0x444
>    worker_thread+0x268/0x4b4
>    kthread+0x13c/0x158
>    ret_from_fork+0x10/0x18
> 
> Fixes: 955772787667 ("f2fs: drop inplace IO if fs status is abnormal")

My bad, thanks for fixing this.

> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
>   fs/f2fs/segment.c | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index c605415840b5..ae875557d693 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -3577,9 +3577,11 @@ int f2fs_inplace_write_data(struct f2fs_io_info *fio)
>   	if (fio->bio) {
>   		struct bio *bio = *(fio->bio);
>   
> -		bio->bi_status = BLK_STS_IOERR;
> -		bio_endio(bio);
> -		fio->bio = NULL;
> +		if (bio) {
> +			bio->bi_status = BLK_STS_IOERR;
> +			bio_endio(bio);
> +			fio->bio = NULL;

fio->bio points a bio assigned in writepages(), so it should reset
that bio to NULL by *(fio->bio) = NULL.

Thanks,

> +		}
>   	}
>   	return err;
>   }
> 

WARNING: multiple messages have this Message-ID (diff)
From: Chao Yu <yuchao0@huawei.com>
To: Jaegeuk Kim <jaegeuk@kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-f2fs-devel@lists.sourceforge.net>
Subject: Re: [f2fs-dev] [PATCH] f2fs: avoid null pointer access when handling IPU error
Date: Tue, 11 May 2021 09:29:07 +0800	[thread overview]
Message-ID: <9df7d088-3580-122b-60a3-799ea665cfeb@huawei.com> (raw)
In-Reply-To: <20210510142804.511265-1-jaegeuk@kernel.org>

On 2021/5/10 22:28, Jaegeuk Kim wrote:
>   Unable to handle kernel NULL pointer dereference at virtual address 000000000000001a
>   pc : f2fs_inplace_write_data+0x144/0x208
>   lr : f2fs_inplace_write_data+0x134/0x208
>   Call trace:
>    f2fs_inplace_write_data+0x144/0x208
>    f2fs_do_write_data_page+0x270/0x770
>    f2fs_write_single_data_page+0x47c/0x830
>    __f2fs_write_data_pages+0x444/0x98c
>    f2fs_write_data_pages.llvm.16514453770497736882+0x2c/0x38
>    do_writepages+0x58/0x118
>    __writeback_single_inode+0x44/0x300
>    writeback_sb_inodes+0x4b8/0x9c8
>    wb_writeback+0x148/0x42c
>    wb_do_writeback+0xc8/0x390
>    wb_workfn+0xb0/0x2f4
>    process_one_work+0x1fc/0x444
>    worker_thread+0x268/0x4b4
>    kthread+0x13c/0x158
>    ret_from_fork+0x10/0x18
> 
> Fixes: 955772787667 ("f2fs: drop inplace IO if fs status is abnormal")

My bad, thanks for fixing this.

> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
>   fs/f2fs/segment.c | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index c605415840b5..ae875557d693 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -3577,9 +3577,11 @@ int f2fs_inplace_write_data(struct f2fs_io_info *fio)
>   	if (fio->bio) {
>   		struct bio *bio = *(fio->bio);
>   
> -		bio->bi_status = BLK_STS_IOERR;
> -		bio_endio(bio);
> -		fio->bio = NULL;
> +		if (bio) {
> +			bio->bi_status = BLK_STS_IOERR;
> +			bio_endio(bio);
> +			fio->bio = NULL;

fio->bio points a bio assigned in writepages(), so it should reset
that bio to NULL by *(fio->bio) = NULL.

Thanks,

> +		}
>   	}
>   	return err;
>   }
> 


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

  reply	other threads:[~2021-05-11  1:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-10 14:28 [PATCH] f2fs: avoid null pointer access when handling IPU error Jaegeuk Kim
2021-05-10 14:28 ` [f2fs-dev] " Jaegeuk Kim
2021-05-11  1:29 ` Chao Yu [this message]
2021-05-11  1:29   ` Chao Yu
2021-05-11  5:07   ` Jaegeuk Kim
2021-05-11  5:07     ` Jaegeuk Kim
2021-05-11  6:02     ` Chao Yu
2021-05-11  6:02       ` Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9df7d088-3580-122b-60a3-799ea665cfeb@huawei.com \
    --to=yuchao0@huawei.com \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.