Re: [PATCH 64/64] media: Kconfig: cleanup VIDEO_DEV dependencies

From: Shuah Khan <skhan@linuxfoundation.org>
To: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Fabio Estevam <festevam@gmail.com>,
	Felipe Balbi <balbi@kernel.org>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Giulio Benetti <giulio.benetti@benettiengineering.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	Heiko Stuebner <heiko@sntech.de>,
	Heungjun Kim <riverful.kim@samsung.com>,
	Houlong Wei <houlong.wei@mediatek.com>,
	Hugues Fruchet <hugues.fruchet@foss.st.com>,
	Hyun Kwon <hyun.kwon@xilinx.com>,
	Jacek Anaszewski <jacek.anaszewski@gmail.com>,
	Jacob Chen <jacob-chen@iotwrt.com>,
	Jaroslav Kysela <perex@perex.cz>,
	Jean-Christophe Trotin <jean-christophe.trotin@foss.st.com>,
	Jeff LaBundy <jeff@labundy.com>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Joe Hung <joe_hung@ilitek.com>, Joel Stanley <joel@jms.id.au>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Kieran Bingham <kieran.bingham@ideasonboard.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Ludovic Desroches <ludovic.desroches@microchip.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Marek Vasut <marex@denx.de>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Martina Krasteva <martinax.krasteva@intel.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Maxime Ripard <mripard@kernel.org>,
	Michael Grzeschik <m.grzeschik@pengutronix.de>,
	Michael Tretter <m.tretter@pengutronix.de>,
	Michal Simek <michal.simek@xilinx.com>,
	Mike Isely <isely@pobox.com>, Ming Qian <ming.qian@nxp.com>,
	Minghsiu Tsai <minghsiu.tsai@mediatek.com>,
	Mirela Rabulea <mirela.rabulea@nxp.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Nicolas Ferre <nicolas.ferre@microchip.com>,
	Nicolas Saenz Julienne <nsaenz@kernel.org>,
	Olivier Lorin <o.lorin@laposte.net>,
	Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
	Pavel Machek <pavel@ucw.cz>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Randy Dunlap <rdunlap@infradead.org>, Ray Jui <rjui@broadcom.com>,
	Rick Chang <rick.chang@mediatek.com>,
	Robert Foss <robert.foss@linaro.org>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Scott Branden <sbranden@broadcom.com>, Sean Young <sean@mess.org>,
	Shawn Guo <shawnguo@kernel.org>, Shawn Tu <shawnx.tu@intel.com>,
	Shijie Qin <shijie.qin@nxp.com>,
	Sowjanya Komatineni <skomatineni@nvidia.com>,
	Stanimir Varbanov <stanimir.varbanov@linaro.org>,
	Steve Longerbeam <slongerbeam@gmail.com>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Takashi Iwai <tiwai@suse.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Tianshu Qiu <tian.shu.qiu@intel.com>,
	Tiffany Lin <tiffany.lin@mediatek.com>,
	Todor Tomov <todor.too@gmail.com>,
	Vincent Knecht <vincent.knecht@mailoo.org>,
	Yong Deng <yong.deng@magewell.com>, Yong Zhi <yong.zhi@intel.com>,
	Zhou Peng <eagle.zhou@nxp.com>,
	alsa-devel@alsa-project.org,
	bcm-kernel-feedback-list@broadcom.com,
	linux-amlogic@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-arm-msm@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-rpi-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-staging@lists.linux.dev,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org,
	linux-usb@vger.kernel.org, mjpeg-users@lists.sourceforge.net,
	openbmc@lists.ozlabs.org, Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH 64/64] media: Kconfig: cleanup VIDEO_DEV dependencies
Date: Fri, 18 Mar 2022 14:59:05 -0600	[thread overview]
Message-ID: <9e02d88a-3344-8d91-c652-72cb989506de@linuxfoundation.org> (raw)
In-Reply-To: <decd26e90adc5c16470e4f738810f22fe6478b27.1647242579.git.mchehab@kernel.org>

On 3/14/22 1:55 AM, Mauro Carvalho Chehab wrote:
> media Kconfig has two entries associated to V4L API:
> VIDEO_DEV and VIDEO_V4L2.
> 
> On Kernel 2.6.x, there were two V4L APIs, each one with its own flag.
> VIDEO_DEV were meant to:
> 	1) enable Video4Linux and make its Kconfig options to appear;
> 	2) it makes the Kernel build the V4L core.
> 
> while VIDEO_V4L2 where used to distinguish between drivers that
> implement the newer API and drivers that implemented the former one.
> 
> With time, such meaning changed, specially after the removal of
> all V4L version 1 drivers.
> 
> At the current implementation, VIDEO_DEV only does (1): it enables
> the media options related to V4L, that now has:
> 
> 	menu "Video4Linux options"
> 		visible if VIDEO_DEV
> 
> 	source "drivers/media/v4l2-core/Kconfig"
> 	endmenu
> 
> but it doesn't affect anymore the V4L core drivers.
> 
> The rationale is that the V4L2 core has a "soft" dependency
> at the I2C bus, and now requires to select a number of other
> Kconfig options:
> 
> 	config VIDEO_V4L2
> 		tristate
> 		depends on (I2C || I2C=n) && VIDEO_DEV
> 		select RATIONAL
> 		select VIDEOBUF2_V4L2 if VIDEOBUF2_CORE
> 		default (I2C || I2C=n) && VIDEO_DEV
> 
> In the past, merging them would be tricky, but it seems that it is now
> possible to merge those symbols, in order to simplify V4L dependencies.
> 
> Let's keep VIDEO_DEV, as this one is used on some make *defconfig
> configurations.
> 
> Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> ---
> 

>   drivers/media/test-drivers/vicodec/Kconfig    |   2 +-
>   drivers/media/test-drivers/vimc/Kconfig       |   2 +-
>   drivers/media/test-drivers/vivid/Kconfig      |   2 +-
>

For vimc change: (trimmed the recipient list to send response)

Acked-by: Shuah Khan <skhan@linuxfoundation.org>

thanks,
-- Shuah