Re: [PATCH] mbi: use per segment a separate relocator chunk

From: Alexander Boettcher <alexander.boettcher@genode-labs.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Cc: Daniel Kiper <dkiper@net-space.pl>
Subject: Re: [PATCH] mbi: use per segment a separate relocator chunk
Date: Tue, 5 Jun 2018 21:59:39 +0200	[thread overview]
Message-ID: <9e0d0cb1-ac0b-7a3c-4bc3-d248cd47d877@genode-labs.com> (raw)
In-Reply-To: <20180515134229.GC16845@router-fw-old.local.net-space.pl>

On 15.05.2018 15:42, Daniel Kiper wrote:
> On Mon, May 14, 2018 at 09:02:00PM +0200, Alexander Boettcher wrote:
>>    grub_relocator_chunk_t ch;
>> -  grub_uint32_t load_offset, load_size;
>> +  grub_uint32_t load_offset = 0, load_size;
>>    int i;
>> -  void *source;
>> +  void *source = NULL;
> 
> It seems to me that this change is not needed.
> I am thinking about "void *source = NULL;".
> 

The compiler complains if I remove the NULL assignment with:

 error: ‘source’ may be used uninitialized in this function
[-Werror=maybe-uninitialized]
             grub_memset ((grub_uint8_t *) source + load_offset +
phdr(i)->p_filesz, 0,

I try to incorporate your further comments and re-send the patch.

-- 
Alexander Boettcher
Genode Labs

http://www.genode-labs.com - http://www.genode.org

Genode Labs GmbH - Amtsgericht Dresden - HRB 28424 - Sitz Dresden
Geschäftsführer: Dr.-Ing. Norman Feske, Christian Helmuth