From: Jeremy Linton <jeremy.linton@arm.com> To: Will Deacon <will.deacon@arm.com>, linux-kernel@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, peterz@infradead.org, mingo@redhat.com, longman@redhat.com, boqun.feng@gmail.com, paulmck@linux.vnet.ibm.com Subject: Re: [PATCH 0/6] Switch arm64 over to qrwlock Date: Thu, 5 Oct 2017 17:12:44 -0500 [thread overview] Message-ID: <9e2468c3-894e-1204-4578-3d8266c56d6c@arm.com> (raw) In-Reply-To: <1507208097-825-1-git-send-email-will.deacon@arm.com> Hi, On 10/05/2017 07:54 AM, Will Deacon wrote: > Hi all, > > This patch series reworks bits of the qrwlock code that it can be used > to replace the asm rwlocks currently implemented for arm64. The structure > of the series is: > > Patches 1-3 : Work WFE into qrwlock using atomic_cond_read_acquire so > we can avoid busy-waiting. > > Patch 4 : Enable qrwlocks for arm64 > > Patch 5-6 : Ensure writer slowpath fairness. This has a potential > performance impact on the writer unlock path, so I've > kept them at the end. > > The patches apply on top of my other locking cleanups: > > http://lkml.kernel.org/r/1507055129-12300-1-git-send-email-will.deacon@arm.com > > although the conflict with mainline is trivial to resolve without those. > The full stack is also pushed here: > > git://git.kernel.org/pub/scm/linux/kernel/git/will/linux.git qrwlock > > All comments (particularly related to testing and performance) welcome! I haven't done any perf testing, but the machines continue to boot, and the stress-ng test which causes task lock problems with the normal arm64 rwlock now appears to run as expected. So, its a good start! > > Cheers, > > Will > > --->8 > > Will Deacon (6): > kernel/locking: Use struct qrwlock instead of struct __qrwlock > locking/atomic: Add atomic_cond_read_acquire > kernel/locking: Use atomic_cond_read_acquire when spinning in qrwlock > arm64: locking: Move rwlock implementation over to qrwlocks > kernel/locking: Prevent slowpath writers getting held up by fastpath > kernel/locking: Remove unused union members from struct qrwlock > > arch/arm64/Kconfig | 17 ++++ > arch/arm64/include/asm/Kbuild | 1 + > arch/arm64/include/asm/spinlock.h | 164 +------------------------------- > arch/arm64/include/asm/spinlock_types.h | 6 +- > include/asm-generic/atomic-long.h | 3 + > include/asm-generic/qrwlock.h | 14 +-- > include/asm-generic/qrwlock_types.h | 2 +- > include/linux/atomic.h | 4 + > kernel/locking/qrwlock.c | 83 +++------------- > 9 files changed, 43 insertions(+), 251 deletions(-) >
WARNING: multiple messages have this Message-ID (diff)
From: jeremy.linton@arm.com (Jeremy Linton) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 0/6] Switch arm64 over to qrwlock Date: Thu, 5 Oct 2017 17:12:44 -0500 [thread overview] Message-ID: <9e2468c3-894e-1204-4578-3d8266c56d6c@arm.com> (raw) In-Reply-To: <1507208097-825-1-git-send-email-will.deacon@arm.com> Hi, On 10/05/2017 07:54 AM, Will Deacon wrote: > Hi all, > > This patch series reworks bits of the qrwlock code that it can be used > to replace the asm rwlocks currently implemented for arm64. The structure > of the series is: > > Patches 1-3 : Work WFE into qrwlock using atomic_cond_read_acquire so > we can avoid busy-waiting. > > Patch 4 : Enable qrwlocks for arm64 > > Patch 5-6 : Ensure writer slowpath fairness. This has a potential > performance impact on the writer unlock path, so I've > kept them at the end. > > The patches apply on top of my other locking cleanups: > > http://lkml.kernel.org/r/1507055129-12300-1-git-send-email-will.deacon at arm.com > > although the conflict with mainline is trivial to resolve without those. > The full stack is also pushed here: > > git://git.kernel.org/pub/scm/linux/kernel/git/will/linux.git qrwlock > > All comments (particularly related to testing and performance) welcome! I haven't done any perf testing, but the machines continue to boot, and the stress-ng test which causes task lock problems with the normal arm64 rwlock now appears to run as expected. So, its a good start! > > Cheers, > > Will > > --->8 > > Will Deacon (6): > kernel/locking: Use struct qrwlock instead of struct __qrwlock > locking/atomic: Add atomic_cond_read_acquire > kernel/locking: Use atomic_cond_read_acquire when spinning in qrwlock > arm64: locking: Move rwlock implementation over to qrwlocks > kernel/locking: Prevent slowpath writers getting held up by fastpath > kernel/locking: Remove unused union members from struct qrwlock > > arch/arm64/Kconfig | 17 ++++ > arch/arm64/include/asm/Kbuild | 1 + > arch/arm64/include/asm/spinlock.h | 164 +------------------------------- > arch/arm64/include/asm/spinlock_types.h | 6 +- > include/asm-generic/atomic-long.h | 3 + > include/asm-generic/qrwlock.h | 14 +-- > include/asm-generic/qrwlock_types.h | 2 +- > include/linux/atomic.h | 4 + > kernel/locking/qrwlock.c | 83 +++------------- > 9 files changed, 43 insertions(+), 251 deletions(-) >
next prev parent reply other threads:[~2017-10-05 22:12 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-10-05 12:54 [PATCH 0/6] Switch arm64 over to qrwlock Will Deacon 2017-10-05 12:54 ` Will Deacon 2017-10-05 12:54 ` [PATCH 1/6] kernel/locking: Use struct qrwlock instead of struct __qrwlock Will Deacon 2017-10-05 12:54 ` Will Deacon 2017-10-05 12:54 ` [PATCH 2/6] locking/atomic: Add atomic_cond_read_acquire Will Deacon 2017-10-05 12:54 ` Will Deacon 2017-10-05 12:54 ` [PATCH 3/6] kernel/locking: Use atomic_cond_read_acquire when spinning in qrwlock Will Deacon 2017-10-05 12:54 ` Will Deacon 2017-10-05 12:54 ` [PATCH 4/6] arm64: locking: Move rwlock implementation over to qrwlocks Will Deacon 2017-10-05 12:54 ` Will Deacon 2017-10-05 12:54 ` [PATCH 5/6] kernel/locking: Prevent slowpath writers getting held up by fastpath Will Deacon 2017-10-05 12:54 ` Will Deacon 2017-10-05 13:56 ` Peter Zijlstra 2017-10-05 13:56 ` Peter Zijlstra 2017-10-05 14:37 ` Waiman Long 2017-10-05 14:37 ` Waiman Long 2017-10-05 14:42 ` Will Deacon 2017-10-05 14:42 ` Will Deacon 2017-10-05 12:54 ` [PATCH 6/6] kernel/locking: Remove unused union members from struct qrwlock Will Deacon 2017-10-05 12:54 ` Will Deacon 2017-10-05 22:12 ` Jeremy Linton [this message] 2017-10-05 22:12 ` [PATCH 0/6] Switch arm64 over to qrwlock Jeremy Linton 2017-10-06 8:39 ` Will Deacon 2017-10-06 8:39 ` Will Deacon 2017-10-10 15:17 Jan Glauber
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=9e2468c3-894e-1204-4578-3d8266c56d6c@arm.com \ --to=jeremy.linton@arm.com \ --cc=boqun.feng@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=longman@redhat.com \ --cc=mingo@redhat.com \ --cc=paulmck@linux.vnet.ibm.com \ --cc=peterz@infradead.org \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.