All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Coffin <mcoffin13@gmail.com>
To: Evan Quan <evan.quan@amd.com>
Cc: "amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 1/2] drm/amd/pm: restore user customized OD settings properly for NV1x
Date: Fri, 23 Jul 2021 13:59:58 -0600	[thread overview]
Message-ID: <9e502775-bf10-6b0d-116d-1159d674e11b@gmail.com> (raw)
In-Reply-To: <20210722032046.767094-1-evan.quan@amd.com>

On 7/21/21 9:20 PM, Evan Quan wrote:
> The customized OD settings can be divided into two parts: those
> committed ones and non-committed ones.
>    - For those changes which had been fed to SMU before S3/S4/Runpm
>      suspend kicked, they are committed changes. They should be properly
>      restored and fed to SMU on S3/S4/Runpm resume.
>    - For those non-committed changes, they are restored only without feeding
>      to SMU.
> 
> Change-Id: Iea7cf7908dfcd919a4d0205e10bff91b1149a440
> Signed-off-by: Evan Quan <evan.quan@amd.com>
> ---

It's been a while since I've been through the SMU code so I don't know 
all the places that restore_uesr_profile is used, but, just to confirm, 
these would still go back to default (boot) values on a GPU reset, yes?

I ask because when pushing OD settings too far, GPU resets are often 
encountered, and you might be able to create a state where it would 
continually reset if your OD settings are remembered even through a full 
reset.

Very nice feature other than that, though, as I actually keep 
`radeontop` open in a tmux session to prevent my secondary card from 
resetting my OD settings, so this will be nice.

Thanks for listening, and for the driver in general,
Matt
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  parent reply	other threads:[~2021-07-23 20:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-22  3:20 [PATCH 1/2] drm/amd/pm: restore user customized OD settings properly for NV1x Evan Quan
2021-07-22  3:20 ` [PATCH 2/2] drm/amd/pm: restore user customized OD settings properly for Sienna Cichlid Evan Quan
2021-07-22  8:10 ` [PATCH 1/2] drm/amd/pm: restore user customized OD settings properly for NV1x Lazar, Lijo
2021-07-22  8:33   ` Quan, Evan
2021-07-22  9:03     ` Lazar, Lijo
2021-07-23  6:47       ` Quan, Evan
2021-07-23  7:20         ` Quan, Evan
2021-07-23  7:39           ` Lazar, Lijo
2021-07-23  9:11             ` Quan, Evan
2021-07-23 19:59 ` Matt Coffin [this message]
2021-07-26  4:12   ` Quan, Evan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9e502775-bf10-6b0d-116d-1159d674e11b@gmail.com \
    --to=mcoffin13@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=evan.quan@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.