All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vlastimil Babka <vbabka@suse.cz>
To: maninder1.s@samsung.com,
	"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
	"cl@linux.com" <cl@linux.com>,
	"penberg@kernel.org" <penberg@kernel.org>,
	"rientjes@google.com" <rientjes@google.com>,
	"iamjoonsoo.kim@lge.com" <iamjoonsoo.kim@lge.com>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Cc: "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	AMIT SAHRAWAT <a.sahrawat@samsung.com>,
	Vaneet Narang <v.narang@samsung.com>,
	"Paul E . McKenney" <paulmck@kernel.org>
Subject: Re: [PATCH v2] arm: print alloc free paths for address in registers
Date: Fri, 12 Mar 2021 10:21:07 +0100	[thread overview]
Message-ID: <9e517b50-de9d-4191-21d0-08f278091b62@suse.cz> (raw)
In-Reply-To: <20210311105115epcms5p679b5dd4fb157f85a73f5a36632ee2c43@epcms5p6>

On 3/11/21 11:51 AM, Maninder Singh wrote:
> Hi,
> 
>  
> 
>> Instead of your changes to SL*B, could you check mem_dump_obj() and others added
>> by Paul in 5.12-rc1?
> 
>> (+CC Paul, thus not trimming)
> 
>  
> 
> checked mem_dump_obj(), but it only provides path of allocation and not of free.
> 
> /**
>  * mem_dump_obj - Print available provenance information
> 
> ..
> 
>  * if available, the return address and stack trace from the allocation
>  * of that object.
>  */
> void mem_dump_obj(void *object)
> 
> and in case of "Use After Free", Free path is also required.
> 
> So we need to add support for free path in this API if we have to use it.

I think that would make sense.  

> Thanks,
> 
> Maninder Singh
> 


WARNING: multiple messages have this Message-ID (diff)
From: Vlastimil Babka <vbabka@suse.cz>
To: maninder1.s@samsung.com,
	"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
	 "cl@linux.com" <cl@linux.com>,
	"penberg@kernel.org" <penberg@kernel.org>,
	 "rientjes@google.com" <rientjes@google.com>,
	"iamjoonsoo.kim@lge.com" <iamjoonsoo.kim@lge.com>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Cc: "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	AMIT SAHRAWAT <a.sahrawat@samsung.com>,
	Vaneet Narang <v.narang@samsung.com>,
	"Paul E . McKenney" <paulmck@kernel.org>
Subject: Re: [PATCH v2] arm: print alloc free paths for address in registers
Date: Fri, 12 Mar 2021 10:21:07 +0100	[thread overview]
Message-ID: <9e517b50-de9d-4191-21d0-08f278091b62@suse.cz> (raw)
In-Reply-To: <20210311105115epcms5p679b5dd4fb157f85a73f5a36632ee2c43@epcms5p6>

On 3/11/21 11:51 AM, Maninder Singh wrote:
> Hi,
> 
>  
> 
>> Instead of your changes to SL*B, could you check mem_dump_obj() and others added
>> by Paul in 5.12-rc1?
> 
>> (+CC Paul, thus not trimming)
> 
>  
> 
> checked mem_dump_obj(), but it only provides path of allocation and not of free.
> 
> /**
>  * mem_dump_obj - Print available provenance information
> 
> ..
> 
>  * if available, the return address and stack trace from the allocation
>  * of that object.
>  */
> void mem_dump_obj(void *object)
> 
> and in case of "Use After Free", Free path is also required.
> 
> So we need to add support for free path in this API if we have to use it.

I think that would make sense.  

> Thanks,
> 
> Maninder Singh
> 


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-03-12  9:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20210225075653epcas5p3d9551f01177d0c851c9c37f6ae84f38d@epcas5p3.samsung.com>
2021-02-25  7:56 ` [PATCH v2] arm: print alloc free paths for address in registers Maninder Singh
2021-02-25  7:56   ` Maninder Singh
     [not found]   ` <CGME20210225075653epcas5p3d9551f01177d0c851c9c37f6ae84f38d@epcms5p2>
2021-03-10  5:50     ` Maninder Singh
2021-03-10  5:50       ` Maninder Singh
2021-03-10  5:50       ` Maninder Singh
2021-03-10 14:02   ` Vlastimil Babka
2021-03-10 14:02     ` Vlastimil Babka
     [not found]   ` <CGME20210225075653epcas5p3d9551f01177d0c851c9c37f6ae84f38d@epcms5p6>
     [not found]     ` <20210311105115epcms5p679b5dd4fb157f85a73f5a36632ee2c43@epcms5p6>
2021-03-12  9:21       ` Vlastimil Babka [this message]
2021-03-12  9:21         ` Vlastimil Babka
2021-03-12  9:21         ` Vlastimil Babka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9e517b50-de9d-4191-21d0-08f278091b62@suse.cz \
    --to=vbabka@suse.cz \
    --cc=a.sahrawat@samsung.com \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux@armlinux.org.uk \
    --cc=maninder1.s@samsung.com \
    --cc=paulmck@kernel.org \
    --cc=penberg@kernel.org \
    --cc=rientjes@google.com \
    --cc=v.narang@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.