* [PATCH] scsi: ufs-hisi: Use PTR_ERR_OR_ZERO() in ufs_hisi_get_resource()
@ 2019-09-07 12:36 ` Markus Elfring
0 siblings, 0 replies; 4+ messages in thread
From: Markus Elfring @ 2019-09-07 12:36 UTC (permalink / raw)
To: linux-scsi, Alim Akhtar, Allison Randal, Arnd Bergmann,
Avri Altman, Greg Kroah-Hartman, James E. J. Bottomley,
Kangjie Lu, Manivannan Sadhasivam, Martin K. Petersen,
Pedro Sousa, Stanley Chu, Thomas Gleixner, Wei Li
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 7 Sep 2019 14:25:31 +0200
Simplify this function implementation by using a known function.
Generated by: scripts/coccinelle/api/ptr_ret.cocci
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/scsi/ufs/ufs-hisi.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/scsi/ufs/ufs-hisi.c b/drivers/scsi/ufs/ufs-hisi.c
index f4d1dca962c4..a0ea57c19dbc 100644
--- a/drivers/scsi/ufs/ufs-hisi.c
+++ b/drivers/scsi/ufs/ufs-hisi.c
@@ -454,10 +454,7 @@ static int ufs_hisi_get_resource(struct ufs_hisi_host *host)
/* get resource of ufs sys ctrl */
mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
host->ufs_sys_ctrl = devm_ioremap_resource(dev, mem_res);
- if (IS_ERR(host->ufs_sys_ctrl))
- return PTR_ERR(host->ufs_sys_ctrl);
-
- return 0;
+ return PTR_ERR_OR_ZERO(host->ufs_sys_ctrl);
}
static void ufs_hisi_set_pm_lvl(struct ufs_hba *hba)
--
2.23.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] scsi: ufs-hisi: Use PTR_ERR_OR_ZERO() in ufs_hisi_get_resource()
@ 2019-09-07 12:36 ` Markus Elfring
0 siblings, 0 replies; 4+ messages in thread
From: Markus Elfring @ 2019-09-07 12:36 UTC (permalink / raw)
To: linux-scsi, Alim Akhtar, Allison Randal, Arnd Bergmann,
Avri Altman, Greg Kroah-Hartman, James E. J. Bottomley,
Kangjie Lu, Manivannan Sadhasivam, Martin K. Petersen,
Pedro Sousa, Stanley Chu, Thomas Gleixner, Wei Li
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 7 Sep 2019 14:25:31 +0200
Simplify this function implementation by using a known function.
Generated by: scripts/coccinelle/api/ptr_ret.cocci
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/scsi/ufs/ufs-hisi.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/scsi/ufs/ufs-hisi.c b/drivers/scsi/ufs/ufs-hisi.c
index f4d1dca962c4..a0ea57c19dbc 100644
--- a/drivers/scsi/ufs/ufs-hisi.c
+++ b/drivers/scsi/ufs/ufs-hisi.c
@@ -454,10 +454,7 @@ static int ufs_hisi_get_resource(struct ufs_hisi_host *host)
/* get resource of ufs sys ctrl */
mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
host->ufs_sys_ctrl = devm_ioremap_resource(dev, mem_res);
- if (IS_ERR(host->ufs_sys_ctrl))
- return PTR_ERR(host->ufs_sys_ctrl);
-
- return 0;
+ return PTR_ERR_OR_ZERO(host->ufs_sys_ctrl);
}
static void ufs_hisi_set_pm_lvl(struct ufs_hba *hba)
--
2.23.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH] scsi: ufs-hisi: Use PTR_ERR_OR_ZERO() in ufs_hisi_get_resource()
2019-09-07 12:36 ` Markus Elfring
@ 2019-09-11 12:55 ` Avri Altman
-1 siblings, 0 replies; 4+ messages in thread
From: Avri Altman @ 2019-09-11 12:55 UTC (permalink / raw)
To: Markus Elfring, linux-scsi, Alim Akhtar, Allison Randal,
Arnd Bergmann, Greg Kroah-Hartman, James E. J. Bottomley,
Kangjie Lu, Manivannan Sadhasivam, Martin K. Petersen,
Pedro Sousa, Stanley Chu, Thomas Gleixner, Wei Li
Cc: LKML, kernel-janitors
>
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 7 Sep 2019 14:25:31 +0200
>
> Simplify this function implementation by using a known function.
>
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: Avri Altman <avri.altman@wdc.com>
> ---
> drivers/scsi/ufs/ufs-hisi.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufs-hisi.c b/drivers/scsi/ufs/ufs-hisi.c index
> f4d1dca962c4..a0ea57c19dbc 100644
> --- a/drivers/scsi/ufs/ufs-hisi.c
> +++ b/drivers/scsi/ufs/ufs-hisi.c
> @@ -454,10 +454,7 @@ static int ufs_hisi_get_resource(struct ufs_hisi_host
> *host)
> /* get resource of ufs sys ctrl */
> mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> host->ufs_sys_ctrl = devm_ioremap_resource(dev, mem_res);
> - if (IS_ERR(host->ufs_sys_ctrl))
> - return PTR_ERR(host->ufs_sys_ctrl);
> -
> - return 0;
> + return PTR_ERR_OR_ZERO(host->ufs_sys_ctrl);
> }
>
> static void ufs_hisi_set_pm_lvl(struct ufs_hba *hba)
> --
> 2.23.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] scsi: ufs-hisi: Use PTR_ERR_OR_ZERO() in ufs_hisi_get_resource()
@ 2019-09-11 12:55 ` Avri Altman
0 siblings, 0 replies; 4+ messages in thread
From: Avri Altman @ 2019-09-11 12:55 UTC (permalink / raw)
To: Markus Elfring, linux-scsi, Alim Akhtar, Allison Randal,
Arnd Bergmann, Greg Kroah-Hartman, James E. J. Bottomley,
Kangjie Lu, Manivannan Sadhasivam, Martin K. Petersen,
Pedro Sousa, Stanley Chu, Thomas Gleixner, Wei Li
Cc: LKML, kernel-janitors
PiANCj4gRnJvbTogTWFya3VzIEVsZnJpbmcgPGVsZnJpbmdAdXNlcnMuc291cmNlZm9yZ2UubmV0
Pg0KPiBEYXRlOiBTYXQsIDcgU2VwIDIwMTkgMTQ6MjU6MzEgKzAyMDANCj4gDQo+IFNpbXBsaWZ5
IHRoaXMgZnVuY3Rpb24gaW1wbGVtZW50YXRpb24gYnkgdXNpbmcgYSBrbm93biBmdW5jdGlvbi4N
Cj4gDQo+IEdlbmVyYXRlZCBieTogc2NyaXB0cy9jb2NjaW5lbGxlL2FwaS9wdHJfcmV0LmNvY2Np
DQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBNYXJrdXMgRWxmcmluZyA8ZWxmcmluZ0B1c2Vycy5zb3Vy
Y2Vmb3JnZS5uZXQ+DQpSZXZpZXdlZC1ieTogQXZyaSBBbHRtYW4gPGF2cmkuYWx0bWFuQHdkYy5j
b20+DQoNCj4gLS0tDQo+ICBkcml2ZXJzL3Njc2kvdWZzL3Vmcy1oaXNpLmMgfCA1ICstLS0tDQo+
ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDQgZGVsZXRpb25zKC0pDQo+IA0KPiBk
aWZmIC0tZ2l0IGEvZHJpdmVycy9zY3NpL3Vmcy91ZnMtaGlzaS5jIGIvZHJpdmVycy9zY3NpL3Vm
cy91ZnMtaGlzaS5jIGluZGV4DQo+IGY0ZDFkY2E5NjJjNC4uYTBlYTU3YzE5ZGJjIDEwMDY0NA0K
PiAtLS0gYS9kcml2ZXJzL3Njc2kvdWZzL3Vmcy1oaXNpLmMNCj4gKysrIGIvZHJpdmVycy9zY3Np
L3Vmcy91ZnMtaGlzaS5jDQo+IEBAIC00NTQsMTAgKzQ1NCw3IEBAIHN0YXRpYyBpbnQgdWZzX2hp
c2lfZ2V0X3Jlc291cmNlKHN0cnVjdCB1ZnNfaGlzaV9ob3N0DQo+ICpob3N0KQ0KPiAgICAgICAg
IC8qIGdldCByZXNvdXJjZSBvZiB1ZnMgc3lzIGN0cmwgKi8NCj4gICAgICAgICBtZW1fcmVzID0g
cGxhdGZvcm1fZ2V0X3Jlc291cmNlKHBkZXYsIElPUkVTT1VSQ0VfTUVNLCAxKTsNCj4gICAgICAg
ICBob3N0LT51ZnNfc3lzX2N0cmwgPSBkZXZtX2lvcmVtYXBfcmVzb3VyY2UoZGV2LCBtZW1fcmVz
KTsNCj4gLSAgICAgICBpZiAoSVNfRVJSKGhvc3QtPnVmc19zeXNfY3RybCkpDQo+IC0gICAgICAg
ICAgICAgICByZXR1cm4gUFRSX0VSUihob3N0LT51ZnNfc3lzX2N0cmwpOw0KPiAtDQo+IC0gICAg
ICAgcmV0dXJuIDA7DQo+ICsgICAgICAgcmV0dXJuIFBUUl9FUlJfT1JfWkVSTyhob3N0LT51ZnNf
c3lzX2N0cmwpOw0KPiAgfQ0KPiANCj4gIHN0YXRpYyB2b2lkIHVmc19oaXNpX3NldF9wbV9sdmwo
c3RydWN0IHVmc19oYmEgKmhiYSkNCj4gLS0NCj4gMi4yMy4wDQoNCg=
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-09-11 12:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-07 12:36 [PATCH] scsi: ufs-hisi: Use PTR_ERR_OR_ZERO() in ufs_hisi_get_resource() Markus Elfring
2019-09-07 12:36 ` Markus Elfring
2019-09-11 12:55 ` Avri Altman
2019-09-11 12:55 ` Avri Altman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.