[PATCH v3] drm: add a check to verify the size alignment

[PATCH v3] drm: add a check to verify the size alignment

[Arunpravin Paneer Selvam]

Add a simple check to reject any size not aligned to the
min_page_size.

when size is not aligned to min_page_size, driver module
should handle in their own way either to round_up() the
size value to min_page_size or just to enable WARN_ON().

If we dont handle the alignment properly, we may hit the
following bug, Unigine Heaven has allocation requests for
example required pages are 257 and alignment request is 256.
To allocate the left over 1 page, continues the iteration to
find the order value which is 0 and when it compares with
min_order = 8, triggers the BUG_ON(order < min_order).

v2: add more commit description
v3: remove WARN_ON()

Signed-off-by: Arunpravin Paneer Selvam <Arunpravin.PaneerSelvam@amd.com>
Suggested-by: Matthew Auld <matthew.auld@intel.com>
---
 drivers/gpu/drm/drm_buddy.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/drm_buddy.c b/drivers/gpu/drm/drm_buddy.c
index 72f52f293249..11bb59399471 100644
--- a/drivers/gpu/drm/drm_buddy.c
+++ b/drivers/gpu/drm/drm_buddy.c
@@ -665,6 +665,9 @@ int drm_buddy_alloc_blocks(struct drm_buddy *mm,
 	if (start + size == end)
 		return __drm_buddy_alloc_range(mm, start, size, blocks);
 
+	if (!IS_ALIGNED(size, min_page_size))
+		return -EINVAL;
+
 	pages = size >> ilog2(mm->chunk_size);
 	order = fls(pages) - 1;
 	min_order = ilog2(min_page_size) - ilog2(mm->chunk_size);

base-commit: 4dcdb745569d8eef8db09e24e8ff2e5dffc0664c
-- 
2.25.1

[Intel-gfx] [PATCH v3] drm: add a check to verify the size alignment

[Arunpravin Paneer Selvam]

Add a simple check to reject any size not aligned to the
min_page_size.

when size is not aligned to min_page_size, driver module
should handle in their own way either to round_up() the
size value to min_page_size or just to enable WARN_ON().

If we dont handle the alignment properly, we may hit the
following bug, Unigine Heaven has allocation requests for
example required pages are 257 and alignment request is 256.
To allocate the left over 1 page, continues the iteration to
find the order value which is 0 and when it compares with
min_order = 8, triggers the BUG_ON(order < min_order).

v2: add more commit description
v3: remove WARN_ON()

Signed-off-by: Arunpravin Paneer Selvam <Arunpravin.PaneerSelvam@amd.com>
Suggested-by: Matthew Auld <matthew.auld@intel.com>
---
 drivers/gpu/drm/drm_buddy.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/drm_buddy.c b/drivers/gpu/drm/drm_buddy.c
index 72f52f293249..11bb59399471 100644
--- a/drivers/gpu/drm/drm_buddy.c
+++ b/drivers/gpu/drm/drm_buddy.c
@@ -665,6 +665,9 @@ int drm_buddy_alloc_blocks(struct drm_buddy *mm,
 	if (start + size == end)
 		return __drm_buddy_alloc_range(mm, start, size, blocks);
 
+	if (!IS_ALIGNED(size, min_page_size))
+		return -EINVAL;
+
 	pages = size >> ilog2(mm->chunk_size);
 	order = fls(pages) - 1;
 	min_order = ilog2(min_page_size) - ilog2(mm->chunk_size);

base-commit: 4dcdb745569d8eef8db09e24e8ff2e5dffc0664c
-- 
2.25.1

[PATCH v3] drm: add a check to verify the size alignment

[Arunpravin Paneer Selvam]

Add a simple check to reject any size not aligned to the
min_page_size.

when size is not aligned to min_page_size, driver module
should handle in their own way either to round_up() the
size value to min_page_size or just to enable WARN_ON().

If we dont handle the alignment properly, we may hit the
following bug, Unigine Heaven has allocation requests for
example required pages are 257 and alignment request is 256.
To allocate the left over 1 page, continues the iteration to
find the order value which is 0 and when it compares with
min_order = 8, triggers the BUG_ON(order < min_order).

v2: add more commit description
v3: remove WARN_ON()

Signed-off-by: Arunpravin Paneer Selvam <Arunpravin.PaneerSelvam@amd.com>
Suggested-by: Matthew Auld <matthew.auld@intel.com>
---
 drivers/gpu/drm/drm_buddy.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/drm_buddy.c b/drivers/gpu/drm/drm_buddy.c
index 72f52f293249..11bb59399471 100644
--- a/drivers/gpu/drm/drm_buddy.c
+++ b/drivers/gpu/drm/drm_buddy.c
@@ -665,6 +665,9 @@ int drm_buddy_alloc_blocks(struct drm_buddy *mm,
 	if (start + size == end)
 		return __drm_buddy_alloc_range(mm, start, size, blocks);
 
+	if (!IS_ALIGNED(size, min_page_size))
+		return -EINVAL;
+
 	pages = size >> ilog2(mm->chunk_size);
 	order = fls(pages) - 1;
 	min_order = ilog2(min_page_size) - ilog2(mm->chunk_size);

base-commit: 4dcdb745569d8eef8db09e24e8ff2e5dffc0664c
-- 
2.25.1

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm: add a check to verify the size alignment (rev3)

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 5035 bytes --]

== Series Details ==

Series: drm: add a check to verify the size alignment (rev3)
URL   : https://patchwork.freedesktop.org/series/101569/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_11481 -> Patchwork_22837
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_22837 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_22837, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22837/index.html

Participating hosts (48 -> 42)
------------------------------

  Additional (1): fi-tgl-u2 
  Missing    (7): shard-tglu bat-adlm-1 fi-bsw-cyan fi-hsw-4770 shard-rkl shard-dg1 fi-bdw-samus 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_22837:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_selftest@live@gem_contexts:
    - fi-bdw-5557u:       NOTRUN -> [INCOMPLETE][1]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22837/fi-bdw-5557u/igt@i915_selftest@live@gem_contexts.html

  
Known issues
------------

  Here are the changes found in Patchwork_22837 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_huc_copy@huc-copy:
    - fi-tgl-u2:          NOTRUN -> [SKIP][2] ([i915#2190])
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22837/fi-tgl-u2/igt@gem_huc_copy@huc-copy.html

  * igt@kms_busy@basic@flip:
    - fi-tgl-u2:          NOTRUN -> [DMESG-WARN][3] ([i915#402])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22837/fi-tgl-u2/igt@kms_busy@basic@flip.html

  * igt@kms_chamelium@common-hpd-after-suspend:
    - fi-tgl-u2:          NOTRUN -> [SKIP][4] ([fdo#109284] / [fdo#111827]) +8 similar issues
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22837/fi-tgl-u2/igt@kms_chamelium@common-hpd-after-suspend.html

  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
    - fi-tgl-u2:          NOTRUN -> [SKIP][5] ([i915#4103]) +1 similar issue
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22837/fi-tgl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html

  * igt@kms_force_connector_basic@force-load-detect:
    - fi-tgl-u2:          NOTRUN -> [SKIP][6] ([fdo#109285])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22837/fi-tgl-u2/igt@kms_force_connector_basic@force-load-detect.html

  * igt@kms_setmode@basic-clone-single-crtc:
    - fi-tgl-u2:          NOTRUN -> [SKIP][7] ([i915#3555])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22837/fi-tgl-u2/igt@kms_setmode@basic-clone-single-crtc.html

  
#### Possible fixes ####

  * igt@i915_selftest@live@vma:
    - fi-bdw-5557u:       [INCOMPLETE][8] -> [PASS][9]
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/fi-bdw-5557u/igt@i915_selftest@live@vma.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22837/fi-bdw-5557u/igt@i915_selftest@live@vma.html

  
#### Warnings ####

  * igt@core_hotunplug@unbind-rebind:
    - fi-kbl-soraka:      [DMESG-WARN][10] ([i915#5437]) -> [DMESG-WARN][11] ([i915#1982] / [i915#5437])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11481/fi-kbl-soraka/igt@core_hotunplug@unbind-rebind.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22837/fi-kbl-soraka/igt@core_hotunplug@unbind-rebind.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
  [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
  [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
  [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
  [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
  [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
  [i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576
  [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
  [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
  [i915#5437]: https://gitlab.freedesktop.org/drm/intel/issues/5437


Build changes
-------------

  * Linux: CI_DRM_11481 -> Patchwork_22837

  CI-20190529: 20190529
  CI_DRM_11481: 9bf68eb47288411da23ce5c9967f27dba43bda1d @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_6415: c3b690bd5f7fb1fb7ed786ab0f3b815930a6a55f @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  Patchwork_22837: 3980953942302c2365f0046f83cab5c23f761976 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

398095394230 drm: add a check to verify the size alignment

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22837/index.html

[-- Attachment #2: Type: text/html, Size: 5873 bytes --]

Re: [PATCH v3] drm: add a check to verify the size alignment

[Matthew Auld]

On 11/04/2022 08:38, Arunpravin Paneer Selvam wrote:
> Add a simple check to reject any size not aligned to the
> min_page_size.
> 
> when size is not aligned to min_page_size, driver module
> should handle in their own way either to round_up() the
> size value to min_page_size or just to enable WARN_ON().
> 
> If we dont handle the alignment properly, we may hit the
> following bug, Unigine Heaven has allocation requests for
> example required pages are 257 and alignment request is 256.
> To allocate the left over 1 page, continues the iteration to
> find the order value which is 0 and when it compares with
> min_order = 8, triggers the BUG_ON(order < min_order).
> 
> v2: add more commit description
> v3: remove WARN_ON()
> 
> Signed-off-by: Arunpravin Paneer Selvam <Arunpravin.PaneerSelvam@amd.com>
> Suggested-by: Matthew Auld <matthew.auld@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>

Re: [Intel-gfx] [PATCH v3] drm: add a check to verify the size alignment

[Matthew Auld]

On 11/04/2022 08:38, Arunpravin Paneer Selvam wrote:
> Add a simple check to reject any size not aligned to the
> min_page_size.
> 
> when size is not aligned to min_page_size, driver module
> should handle in their own way either to round_up() the
> size value to min_page_size or just to enable WARN_ON().
> 
> If we dont handle the alignment properly, we may hit the
> following bug, Unigine Heaven has allocation requests for
> example required pages are 257 and alignment request is 256.
> To allocate the left over 1 page, continues the iteration to
> find the order value which is 0 and when it compares with
> min_order = 8, triggers the BUG_ON(order < min_order).
> 
> v2: add more commit description
> v3: remove WARN_ON()
> 
> Signed-off-by: Arunpravin Paneer Selvam <Arunpravin.PaneerSelvam@amd.com>
> Suggested-by: Matthew Auld <matthew.auld@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>

Re: [PATCH v3] drm: add a check to verify the size alignment

[Matthew Auld]

On 11/04/2022 08:38, Arunpravin Paneer Selvam wrote:
> Add a simple check to reject any size not aligned to the
> min_page_size.
> 
> when size is not aligned to min_page_size, driver module
> should handle in their own way either to round_up() the
> size value to min_page_size or just to enable WARN_ON().
> 
> If we dont handle the alignment properly, we may hit the
> following bug, Unigine Heaven has allocation requests for
> example required pages are 257 and alignment request is 256.
> To allocate the left over 1 page, continues the iteration to
> find the order value which is 0 and when it compares with
> min_order = 8, triggers the BUG_ON(order < min_order).
> 
> v2: add more commit description
> v3: remove WARN_ON()
> 
> Signed-off-by: Arunpravin Paneer Selvam <Arunpravin.PaneerSelvam@amd.com>
> Suggested-by: Matthew Auld <matthew.auld@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>

Re: [PATCH v3] drm: add a check to verify the size alignment

[Christian König]

Am 11.04.22 um 11:47 schrieb Matthew Auld:
> On 11/04/2022 08:38, Arunpravin Paneer Selvam wrote:
>> Add a simple check to reject any size not aligned to the
>> min_page_size.
>>
>> when size is not aligned to min_page_size, driver module
>> should handle in their own way either to round_up() the
>> size value to min_page_size or just to enable WARN_ON().
>>
>> If we dont handle the alignment properly, we may hit the
>> following bug, Unigine Heaven has allocation requests for
>> example required pages are 257 and alignment request is 256.
>> To allocate the left over 1 page, continues the iteration to
>> find the order value which is 0 and when it compares with
>> min_order = 8, triggers the BUG_ON(order < min_order).
>>
>> v2: add more commit description
>> v3: remove WARN_ON()
>>
>> Signed-off-by: Arunpravin Paneer Selvam 
>> <Arunpravin.PaneerSelvam@amd.com>
>> Suggested-by: Matthew Auld <matthew.auld@intel.com>
> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
>

Question here is who will be pushing that to drm-misc-next? Should I 
take care of that?

I think it's time that Arun should request push permission for 
drm-misc-next.

Thanks,
Christian.

Re: [PATCH v3] drm: add a check to verify the size alignment

[Christian König]

Am 11.04.22 um 11:47 schrieb Matthew Auld:
> On 11/04/2022 08:38, Arunpravin Paneer Selvam wrote:
>> Add a simple check to reject any size not aligned to the
>> min_page_size.
>>
>> when size is not aligned to min_page_size, driver module
>> should handle in their own way either to round_up() the
>> size value to min_page_size or just to enable WARN_ON().
>>
>> If we dont handle the alignment properly, we may hit the
>> following bug, Unigine Heaven has allocation requests for
>> example required pages are 257 and alignment request is 256.
>> To allocate the left over 1 page, continues the iteration to
>> find the order value which is 0 and when it compares with
>> min_order = 8, triggers the BUG_ON(order < min_order).
>>
>> v2: add more commit description
>> v3: remove WARN_ON()
>>
>> Signed-off-by: Arunpravin Paneer Selvam 
>> <Arunpravin.PaneerSelvam@amd.com>
>> Suggested-by: Matthew Auld <matthew.auld@intel.com>
> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
>

Question here is who will be pushing that to drm-misc-next? Should I 
take care of that?

I think it's time that Arun should request push permission for 
drm-misc-next.

Thanks,
Christian.

Re: [Intel-gfx] [PATCH v3] drm: add a check to verify the size alignment

[Christian König]

Am 11.04.22 um 11:47 schrieb Matthew Auld:
> On 11/04/2022 08:38, Arunpravin Paneer Selvam wrote:
>> Add a simple check to reject any size not aligned to the
>> min_page_size.
>>
>> when size is not aligned to min_page_size, driver module
>> should handle in their own way either to round_up() the
>> size value to min_page_size or just to enable WARN_ON().
>>
>> If we dont handle the alignment properly, we may hit the
>> following bug, Unigine Heaven has allocation requests for
>> example required pages are 257 and alignment request is 256.
>> To allocate the left over 1 page, continues the iteration to
>> find the order value which is 0 and when it compares with
>> min_order = 8, triggers the BUG_ON(order < min_order).
>>
>> v2: add more commit description
>> v3: remove WARN_ON()
>>
>> Signed-off-by: Arunpravin Paneer Selvam 
>> <Arunpravin.PaneerSelvam@amd.com>
>> Suggested-by: Matthew Auld <matthew.auld@intel.com>
> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
>

Question here is who will be pushing that to drm-misc-next? Should I 
take care of that?

I think it's time that Arun should request push permission for 
drm-misc-next.

Thanks,
Christian.

Re: [PATCH v3] drm: add a check to verify the size alignment

[Matthew Auld]

On 11/04/2022 13:42, Christian König wrote:
> 
> Am 11.04.22 um 11:47 schrieb Matthew Auld:
>> On 11/04/2022 08:38, Arunpravin Paneer Selvam wrote:
>>> Add a simple check to reject any size not aligned to the
>>> min_page_size.
>>>
>>> when size is not aligned to min_page_size, driver module
>>> should handle in their own way either to round_up() the
>>> size value to min_page_size or just to enable WARN_ON().
>>>
>>> If we dont handle the alignment properly, we may hit the
>>> following bug, Unigine Heaven has allocation requests for
>>> example required pages are 257 and alignment request is 256.
>>> To allocate the left over 1 page, continues the iteration to
>>> find the order value which is 0 and when it compares with
>>> min_order = 8, triggers the BUG_ON(order < min_order).
>>>
>>> v2: add more commit description
>>> v3: remove WARN_ON()
>>>
>>> Signed-off-by: Arunpravin Paneer Selvam 
>>> <Arunpravin.PaneerSelvam@amd.com>
>>> Suggested-by: Matthew Auld <matthew.auld@intel.com>
>> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
>>
> 
> Question here is who will be pushing that to drm-misc-next? Should I 
> take care of that?

Yes, please do.

> 
> I think it's time that Arun should request push permission for 
> drm-misc-next.
> 
> Thanks,
> Christian.

Re: [Intel-gfx] [PATCH v3] drm: add a check to verify the size alignment

[Matthew Auld]

On 11/04/2022 13:42, Christian König wrote:
> 
> Am 11.04.22 um 11:47 schrieb Matthew Auld:
>> On 11/04/2022 08:38, Arunpravin Paneer Selvam wrote:
>>> Add a simple check to reject any size not aligned to the
>>> min_page_size.
>>>
>>> when size is not aligned to min_page_size, driver module
>>> should handle in their own way either to round_up() the
>>> size value to min_page_size or just to enable WARN_ON().
>>>
>>> If we dont handle the alignment properly, we may hit the
>>> following bug, Unigine Heaven has allocation requests for
>>> example required pages are 257 and alignment request is 256.
>>> To allocate the left over 1 page, continues the iteration to
>>> find the order value which is 0 and when it compares with
>>> min_order = 8, triggers the BUG_ON(order < min_order).
>>>
>>> v2: add more commit description
>>> v3: remove WARN_ON()
>>>
>>> Signed-off-by: Arunpravin Paneer Selvam 
>>> <Arunpravin.PaneerSelvam@amd.com>
>>> Suggested-by: Matthew Auld <matthew.auld@intel.com>
>> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
>>
> 
> Question here is who will be pushing that to drm-misc-next? Should I 
> take care of that?

Yes, please do.

> 
> I think it's time that Arun should request push permission for 
> drm-misc-next.
> 
> Thanks,
> Christian.

Re: [PATCH v3] drm: add a check to verify the size alignment

[Matthew Auld]

On 11/04/2022 13:42, Christian König wrote:
> 
> Am 11.04.22 um 11:47 schrieb Matthew Auld:
>> On 11/04/2022 08:38, Arunpravin Paneer Selvam wrote:
>>> Add a simple check to reject any size not aligned to the
>>> min_page_size.
>>>
>>> when size is not aligned to min_page_size, driver module
>>> should handle in their own way either to round_up() the
>>> size value to min_page_size or just to enable WARN_ON().
>>>
>>> If we dont handle the alignment properly, we may hit the
>>> following bug, Unigine Heaven has allocation requests for
>>> example required pages are 257 and alignment request is 256.
>>> To allocate the left over 1 page, continues the iteration to
>>> find the order value which is 0 and when it compares with
>>> min_order = 8, triggers the BUG_ON(order < min_order).
>>>
>>> v2: add more commit description
>>> v3: remove WARN_ON()
>>>
>>> Signed-off-by: Arunpravin Paneer Selvam 
>>> <Arunpravin.PaneerSelvam@amd.com>
>>> Suggested-by: Matthew Auld <matthew.auld@intel.com>
>> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
>>
> 
> Question here is who will be pushing that to drm-misc-next? Should I 
> take care of that?

Yes, please do.

> 
> I think it's time that Arun should request push permission for 
> drm-misc-next.
> 
> Thanks,
> Christian.

Re: [PATCH v3] drm: add a check to verify the size alignment

[Christian König]

Am 11.04.22 um 15:49 schrieb Arunpravin Paneer Selvam:
>
> On 11/04/22 7:02 pm, Matthew Auld wrote:
>> On 11/04/2022 13:42, Christian König wrote:
>>> Am 11.04.22 um 11:47 schrieb Matthew Auld:
>>>> On 11/04/2022 08:38, Arunpravin Paneer Selvam wrote:
>>>>> Add a simple check to reject any size not aligned to the
>>>>> min_page_size.
>>>>>
>>>>> when size is not aligned to min_page_size, driver module
>>>>> should handle in their own way either to round_up() the
>>>>> size value to min_page_size or just to enable WARN_ON().
>>>>>
>>>>> If we dont handle the alignment properly, we may hit the
>>>>> following bug, Unigine Heaven has allocation requests for
>>>>> example required pages are 257 and alignment request is 256.
>>>>> To allocate the left over 1 page, continues the iteration to
>>>>> find the order value which is 0 and when it compares with
>>>>> min_order = 8, triggers the BUG_ON(order < min_order).
>>>>>
>>>>> v2: add more commit description
>>>>> v3: remove WARN_ON()
>>>>>
>>>>> Signed-off-by: Arunpravin Paneer Selvam
>>>>> <Arunpravin.PaneerSelvam@amd.com>
>>>>> Suggested-by: Matthew Auld <matthew.auld@intel.com>
>>>> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
>>>>
>>> Question here is who will be pushing that to drm-misc-next? Should I
>>> take care of that?
>> Yes, please do.
>>
>>> I think it's time that Arun should request push permission for
>>> drm-misc-next.
> How to get push permission for drm-misc-next, should I send request mail
> to maintainers, may be next time I will push myself.

See here 
https://drm.pages.freedesktop.org/maintainer-tools/commit-access.html

Regards,
Christian.

>
> Thanks,
> Arun
>>> Thanks,
>>> Christian.

Re: [PATCH v3] drm: add a check to verify the size alignment

[Christian König]

Am 11.04.22 um 15:49 schrieb Arunpravin Paneer Selvam:
>
> On 11/04/22 7:02 pm, Matthew Auld wrote:
>> On 11/04/2022 13:42, Christian König wrote:
>>> Am 11.04.22 um 11:47 schrieb Matthew Auld:
>>>> On 11/04/2022 08:38, Arunpravin Paneer Selvam wrote:
>>>>> Add a simple check to reject any size not aligned to the
>>>>> min_page_size.
>>>>>
>>>>> when size is not aligned to min_page_size, driver module
>>>>> should handle in their own way either to round_up() the
>>>>> size value to min_page_size or just to enable WARN_ON().
>>>>>
>>>>> If we dont handle the alignment properly, we may hit the
>>>>> following bug, Unigine Heaven has allocation requests for
>>>>> example required pages are 257 and alignment request is 256.
>>>>> To allocate the left over 1 page, continues the iteration to
>>>>> find the order value which is 0 and when it compares with
>>>>> min_order = 8, triggers the BUG_ON(order < min_order).
>>>>>
>>>>> v2: add more commit description
>>>>> v3: remove WARN_ON()
>>>>>
>>>>> Signed-off-by: Arunpravin Paneer Selvam
>>>>> <Arunpravin.PaneerSelvam@amd.com>
>>>>> Suggested-by: Matthew Auld <matthew.auld@intel.com>
>>>> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
>>>>
>>> Question here is who will be pushing that to drm-misc-next? Should I
>>> take care of that?
>> Yes, please do.
>>
>>> I think it's time that Arun should request push permission for
>>> drm-misc-next.
> How to get push permission for drm-misc-next, should I send request mail
> to maintainers, may be next time I will push myself.

See here 
https://drm.pages.freedesktop.org/maintainer-tools/commit-access.html

Regards,
Christian.

>
> Thanks,
> Arun
>>> Thanks,
>>> Christian.

Re: [Intel-gfx] [PATCH v3] drm: add a check to verify the size alignment

[Christian König]

Am 11.04.22 um 15:49 schrieb Arunpravin Paneer Selvam:
>
> On 11/04/22 7:02 pm, Matthew Auld wrote:
>> On 11/04/2022 13:42, Christian König wrote:
>>> Am 11.04.22 um 11:47 schrieb Matthew Auld:
>>>> On 11/04/2022 08:38, Arunpravin Paneer Selvam wrote:
>>>>> Add a simple check to reject any size not aligned to the
>>>>> min_page_size.
>>>>>
>>>>> when size is not aligned to min_page_size, driver module
>>>>> should handle in their own way either to round_up() the
>>>>> size value to min_page_size or just to enable WARN_ON().
>>>>>
>>>>> If we dont handle the alignment properly, we may hit the
>>>>> following bug, Unigine Heaven has allocation requests for
>>>>> example required pages are 257 and alignment request is 256.
>>>>> To allocate the left over 1 page, continues the iteration to
>>>>> find the order value which is 0 and when it compares with
>>>>> min_order = 8, triggers the BUG_ON(order < min_order).
>>>>>
>>>>> v2: add more commit description
>>>>> v3: remove WARN_ON()
>>>>>
>>>>> Signed-off-by: Arunpravin Paneer Selvam
>>>>> <Arunpravin.PaneerSelvam@amd.com>
>>>>> Suggested-by: Matthew Auld <matthew.auld@intel.com>
>>>> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
>>>>
>>> Question here is who will be pushing that to drm-misc-next? Should I
>>> take care of that?
>> Yes, please do.
>>
>>> I think it's time that Arun should request push permission for
>>> drm-misc-next.
> How to get push permission for drm-misc-next, should I send request mail
> to maintainers, may be next time I will push myself.

See here 
https://drm.pages.freedesktop.org/maintainer-tools/commit-access.html

Regards,
Christian.

>
> Thanks,
> Arun
>>> Thanks,
>>> Christian.

Re: [PATCH v3] drm: add a check to verify the size alignment

[Arunpravin Paneer Selvam]

On 11/04/22 7:02 pm, Matthew Auld wrote:
> On 11/04/2022 13:42, Christian König wrote:
>>
>> Am 11.04.22 um 11:47 schrieb Matthew Auld:
>>> On 11/04/2022 08:38, Arunpravin Paneer Selvam wrote:
>>>> Add a simple check to reject any size not aligned to the
>>>> min_page_size.
>>>>
>>>> when size is not aligned to min_page_size, driver module
>>>> should handle in their own way either to round_up() the
>>>> size value to min_page_size or just to enable WARN_ON().
>>>>
>>>> If we dont handle the alignment properly, we may hit the
>>>> following bug, Unigine Heaven has allocation requests for
>>>> example required pages are 257 and alignment request is 256.
>>>> To allocate the left over 1 page, continues the iteration to
>>>> find the order value which is 0 and when it compares with
>>>> min_order = 8, triggers the BUG_ON(order < min_order).
>>>>
>>>> v2: add more commit description
>>>> v3: remove WARN_ON()
>>>>
>>>> Signed-off-by: Arunpravin Paneer Selvam 
>>>> <Arunpravin.PaneerSelvam@amd.com>
>>>> Suggested-by: Matthew Auld <matthew.auld@intel.com>
>>> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
>>>
>>
>> Question here is who will be pushing that to drm-misc-next? Should I 
>> take care of that?
> 
> Yes, please do.
> 
>>
>> I think it's time that Arun should request push permission for 
>> drm-misc-next.

How to get push permission for drm-misc-next, should I send request mail
to maintainers, may be next time I will push myself.

Thanks,
Arun
>>
>> Thanks,
>> Christian.

Re: [Intel-gfx] [PATCH v3] drm: add a check to verify the size alignment

[Arunpravin Paneer Selvam]

On 11/04/22 7:02 pm, Matthew Auld wrote:
> On 11/04/2022 13:42, Christian König wrote:
>>
>> Am 11.04.22 um 11:47 schrieb Matthew Auld:
>>> On 11/04/2022 08:38, Arunpravin Paneer Selvam wrote:
>>>> Add a simple check to reject any size not aligned to the
>>>> min_page_size.
>>>>
>>>> when size is not aligned to min_page_size, driver module
>>>> should handle in their own way either to round_up() the
>>>> size value to min_page_size or just to enable WARN_ON().
>>>>
>>>> If we dont handle the alignment properly, we may hit the
>>>> following bug, Unigine Heaven has allocation requests for
>>>> example required pages are 257 and alignment request is 256.
>>>> To allocate the left over 1 page, continues the iteration to
>>>> find the order value which is 0 and when it compares with
>>>> min_order = 8, triggers the BUG_ON(order < min_order).
>>>>
>>>> v2: add more commit description
>>>> v3: remove WARN_ON()
>>>>
>>>> Signed-off-by: Arunpravin Paneer Selvam 
>>>> <Arunpravin.PaneerSelvam@amd.com>
>>>> Suggested-by: Matthew Auld <matthew.auld@intel.com>
>>> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
>>>
>>
>> Question here is who will be pushing that to drm-misc-next? Should I 
>> take care of that?
> 
> Yes, please do.
> 
>>
>> I think it's time that Arun should request push permission for 
>> drm-misc-next.

How to get push permission for drm-misc-next, should I send request mail
to maintainers, may be next time I will push myself.

Thanks,
Arun
>>
>> Thanks,
>> Christian.

Re: [PATCH v3] drm: add a check to verify the size alignment

[Arunpravin Paneer Selvam]

On 11/04/22 7:02 pm, Matthew Auld wrote:
> On 11/04/2022 13:42, Christian König wrote:
>>
>> Am 11.04.22 um 11:47 schrieb Matthew Auld:
>>> On 11/04/2022 08:38, Arunpravin Paneer Selvam wrote:
>>>> Add a simple check to reject any size not aligned to the
>>>> min_page_size.
>>>>
>>>> when size is not aligned to min_page_size, driver module
>>>> should handle in their own way either to round_up() the
>>>> size value to min_page_size or just to enable WARN_ON().
>>>>
>>>> If we dont handle the alignment properly, we may hit the
>>>> following bug, Unigine Heaven has allocation requests for
>>>> example required pages are 257 and alignment request is 256.
>>>> To allocate the left over 1 page, continues the iteration to
>>>> find the order value which is 0 and when it compares with
>>>> min_order = 8, triggers the BUG_ON(order < min_order).
>>>>
>>>> v2: add more commit description
>>>> v3: remove WARN_ON()
>>>>
>>>> Signed-off-by: Arunpravin Paneer Selvam 
>>>> <Arunpravin.PaneerSelvam@amd.com>
>>>> Suggested-by: Matthew Auld <matthew.auld@intel.com>
>>> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
>>>
>>
>> Question here is who will be pushing that to drm-misc-next? Should I 
>> take care of that?
> 
> Yes, please do.
> 
>>
>> I think it's time that Arun should request push permission for 
>> drm-misc-next.

How to get push permission for drm-misc-next, should I send request mail
to maintainers, may be next time I will push myself.

Thanks,
Arun
>>
>> Thanks,
>> Christian.