Adding a resolved timestamp to phosphor-logging's event logs

Adding a resolved timestamp to phosphor-logging's event logs

[Matt Spinler]

To those that use phosphor-logging's openbmc event logs:

I just put up a phosphor-dbus-interfaces change 
https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-dbus-interfaces/+/29734
to add a new ResolvedTimestamp property to the OpenBMC event log entry.

Next I'll update phosphor-logging to set that timestamp when the Resolved
property changes, so that users can know when an error was resolved.

Review if interested.

Thanks

Re: Adding a resolved timestamp to phosphor-logging's event logs

[Gunnar Mills]

On 2/25/2020 12:58 PM, Matt Spinler wrote:
> To those that use phosphor-logging's openbmc event logs:
>
> I just put up a phosphor-dbus-interfaces change 
> https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-dbus-interfaces/+/29734
> to add a new ResolvedTimestamp property to the OpenBMC event log entry.
>
> Next I'll update phosphor-logging to set that timestamp when the Resolved
> property changes, so that users can know when an error was resolved.
>

Redfish is adding a "modified" property to the LogEntry Schema.
https://redfish.dmtf.org/schemas/v1/LogEntry.v1_5_1.json

(Redfish issue 3854 for those that have access to the repo.)

Does it make more sense to have a Last Updated Time property on the 
event log entry in D-Bus? Then this could map to the Redfish "modified" 
property easier.  This property would get updated when the event log was 
resolved, unresolved, or any other action.

Thanks,
Gunnar

Re: Adding a resolved timestamp to phosphor-logging's event logs

[Matt Spinler]

On 2/25/2020 4:03 PM, Gunnar Mills wrote:
>
> On 2/25/2020 12:58 PM, Matt Spinler wrote:
>> To those that use phosphor-logging's openbmc event logs:
>>
>> I just put up a phosphor-dbus-interfaces change 
>> https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-dbus-interfaces/+/29734
>> to add a new ResolvedTimestamp property to the OpenBMC event log entry.
>>
>> Next I'll update phosphor-logging to set that timestamp when the 
>> Resolved
>> property changes, so that users can know when an error was resolved.
>>
>
> Redfish is adding a "modified" property to the LogEntry Schema.
> https://redfish.dmtf.org/schemas/v1/LogEntry.v1_5_1.json
>
> (Redfish issue 3854 for those that have access to the repo.)
>
> Does it make more sense to have a Last Updated Time property on the 
> event log entry in D-Bus? Then this could map to the Redfish 
> "modified" property easier.  This property would get updated when the 
> event log was resolved, unresolved, or any other action.

The thing about that Redfish property is that as soon as there is more 
than one field that can be updated,
it becomes ambiguous as people wouldn't know what actually changed, and 
so I haven't convinced myself
yet that is the right thing to do in phosphor-logging.  I'll mull on it 
some more,  and I still welcome thoughts
on this from others.



>
> Thanks,
> Gunnar
>