"FILESEXTRAPATHS_append" error in openvswitch_git.bb

"FILESEXTRAPATHS_append" error in openvswitch_git.bb

[Robert P. J. Day]

  this doesn't look right, but i don't know how one wants to resolve
it:

  FILESEXTRAPATHS_append := "${THISDIR}/${PN}-git:"

so i will leave it in your capable hands.

rday

Re: [meta-virtualization] "FILESEXTRAPATHS_append" error in openvswitch_git.bb

[Bruce Ashfield]

On Tue, Apr 6, 2021 at 5:35 AM Robert P. J. Day <rpjday@crashcourse.ca> wrote:
>
>
>   this doesn't look right, but i don't know how one wants to resolve
> it:
>

What part doesn't look right ? I don't see any issues with it.

Bruce

>   FILESEXTRAPATHS_append := "${THISDIR}/${PN}-git:"
>
> so i will leave it in your capable hands.
>
> rday
>
> 
>


-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

Re: [meta-virtualization] "FILESEXTRAPATHS_append" error in openvswitch_git.bb

[Robert P. J. Day]

On Tue, 6 Apr 2021, Bruce Ashfield wrote:

> On Tue, Apr 6, 2021 at 5:35 AM Robert P. J. Day <rpjday@crashcourse.ca> wrote:
> >
> >
> >   this doesn't look right, but i don't know how one wants to resolve
> > it:
> >
>
> What part doesn't look right ? I don't see any issues with it.
>
> Bruce
>
> >   FILESEXTRAPATHS_append := "${THISDIR}/${PN}-git:"

  isn't the colon on the wrong end?

rday

Re: [meta-virtualization] "FILESEXTRAPATHS_append" error in openvswitch_git.bb

[Bruce Ashfield]

On Tue, Apr 6, 2021 at 8:40 AM Robert P. J. Day <rpjday@crashcourse.ca> wrote:
>
> On Tue, 6 Apr 2021, Bruce Ashfield wrote:
>
> > On Tue, Apr 6, 2021 at 5:35 AM Robert P. J. Day <rpjday@crashcourse.ca> wrote:
> > >
> > >
> > >   this doesn't look right, but i don't know how one wants to resolve
> > > it:
> > >
> >
> > What part doesn't look right ? I don't see any issues with it.
> >
> > Bruce
> >
> > >   FILESEXTRAPATHS_append := "${THISDIR}/${PN}-git:"
>
>   isn't the colon on the wrong end?

In a quick scan of other layers, they are all leaving the variable in
the same state (with a trailing colon), whether they are using
_prepend or _append.

So while it does count on the existing variable to end with a colon,
that seems to be no different than other places. I quickly dumped the
environment for an openvswitch build and the default FILESEXTRAPATHS
does end with a colon, so it should be safe. Whether it is perfect
form or not, I can't say, since I've never looked at that in detail
either.

But I very well could be missing something! (I haven't had a coffee yet).

Bruce

>
> rday



-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

Re: [meta-virtualization] "FILESEXTRAPATHS_append" error in openvswitch_git.bb

[Robert P. J. Day]

On Tue, 6 Apr 2021, Bruce Ashfield wrote:

> On Tue, Apr 6, 2021 at 8:40 AM Robert P. J. Day <rpjday@crashcourse.ca> wrote:
> >
> > On Tue, 6 Apr 2021, Bruce Ashfield wrote:
> >
> > > On Tue, Apr 6, 2021 at 5:35 AM Robert P. J. Day <rpjday@crashcourse.ca> wrote:
> > > >
> > > >
> > > >   this doesn't look right, but i don't know how one wants to resolve
> > > > it:
> > > >
> > >
> > > What part doesn't look right ? I don't see any issues with it.
> > >
> > > Bruce
> > >
> > > >   FILESEXTRAPATHS_append := "${THISDIR}/${PN}-git:"
> >
> >   isn't the colon on the wrong end?
>
> In a quick scan of other layers, they are all leaving the variable in
> the same state (with a trailing colon), whether they are using
> _prepend or _append.

  i beg to differ -- here's a single example:

  meta-intel/recipes-core/zlib/zlib-intel_1.2.11.1.jtkv6.3.bb:
    FILESEXTRAPATHS_append = ":${COREBASE}/meta/recipes-core/zlib/zlib"

anyway, i will defer to the community opinion on this.

rday

Re: [meta-virtualization] "FILESEXTRAPATHS_append" error in openvswitch_git.bb

[Bruce Ashfield]

On Tue, Apr 6, 2021 at 9:07 AM Robert P. J. Day <rpjday@crashcourse.ca> wrote:
>
> On Tue, 6 Apr 2021, Bruce Ashfield wrote:
>
> > On Tue, Apr 6, 2021 at 8:40 AM Robert P. J. Day <rpjday@crashcourse.ca> wrote:
> > >
> > > On Tue, 6 Apr 2021, Bruce Ashfield wrote:
> > >
> > > > On Tue, Apr 6, 2021 at 5:35 AM Robert P. J. Day <rpjday@crashcourse.ca> wrote:
> > > > >
> > > > >
> > > > >   this doesn't look right, but i don't know how one wants to resolve
> > > > > it:
> > > > >
> > > >
> > > > What part doesn't look right ? I don't see any issues with it.
> > > >
> > > > Bruce
> > > >
> > > > >   FILESEXTRAPATHS_append := "${THISDIR}/${PN}-git:"
> > >
> > >   isn't the colon on the wrong end?
> >
> > In a quick scan of other layers, they are all leaving the variable in
> > the same state (with a trailing colon), whether they are using
> > _prepend or _append.
>
>   i beg to differ -- here's a single example:
>
>   meta-intel/recipes-core/zlib/zlib-intel_1.2.11.1.jtkv6.3.bb:
>     FILESEXTRAPATHS_append = ":${COREBASE}/meta/recipes-core/zlib/zlib"

Do a build with that. You have a double colon, so you found a bad
example, unless
the double colon is expected.

FILESEXTRAPATHS="__default::/home/poky/meta/recipes-core/zlib/zlib"

Bruce

>
> anyway, i will defer to the community opinion on this.
>
> rday
>


-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

Re: [meta-virtualization] "FILESEXTRAPATHS_append" error in openvswitch_git.bb

[Richard Purdie]

On Tue, 2021-04-06 at 09:13 -0400, Bruce Ashfield wrote:
> On Tue, Apr 6, 2021 at 9:07 AM Robert P. J. Day <rpjday@crashcourse.ca> wrote:
> > 
> > On Tue, 6 Apr 2021, Bruce Ashfield wrote:
> > 
> > > On Tue, Apr 6, 2021 at 8:40 AM Robert P. J. Day <rpjday@crashcourse.ca> wrote:
> > > > 
> > > > On Tue, 6 Apr 2021, Bruce Ashfield wrote:
> > > > 
> > > > > On Tue, Apr 6, 2021 at 5:35 AM Robert P. J. Day <rpjday@crashcourse.ca> wrote:
> > > > > > 
> > > > > > 
> > > > > >   this doesn't look right, but i don't know how one wants to resolve
> > > > > > it:
> > > > > > 
> > > > > 
> > > > > What part doesn't look right ? I don't see any issues with it.
> > > > > 
> > > > > Bruce
> > > > > 
> > > > > >   FILESEXTRAPATHS_append := "${THISDIR}/${PN}-git:"
> > > > 
> > > >   isn't the colon on the wrong end?
> > > 
> > > In a quick scan of other layers, they are all leaving the variable in
> > > the same state (with a trailing colon), whether they are using
> > > _prepend or _append.
> > 
> >   i beg to differ -- here's a single example:
> > 
> >   meta-intel/recipes-core/zlib/zlib-intel_1.2.11.1.jtkv6.3.bb:
> >     FILESEXTRAPATHS_append = ":${COREBASE}/meta/recipes-core/zlib/zlib"
> 
> Do a build with that. You have a double colon, so you found a bad
> example, unless
> the double colon is expected.
> 
> FILESEXTRAPATHS="__default::/home/poky/meta/recipes-core/zlib/zlib"

Anything using append should be adding a leading colon, anything prepending
should be adding a trailing one.

I suspect we need an audit and cleanup of several layers...

Cheers,

Richard

Re: [meta-virtualization] "FILESEXTRAPATHS_append" error in openvswitch_git.bb

[Peter Kjellerstedt]

> -----Original Message-----
> From: meta-virtualization@lists.yoctoproject.org <meta-
> virtualization@lists.yoctoproject.org> On Behalf Of Richard Purdie
> Sent: den 6 april 2021 15:59
> To: Bruce Ashfield <bruce.ashfield@gmail.com>; Robert P. J. Day
> <rpjday@crashcourse.ca>
> Cc: meta-virtualization@lists.yoctoproject.org
> Subject: Re: [meta-virtualization] "FILESEXTRAPATHS_append" error in
> openvswitch_git.bb
> 
> On Tue, 2021-04-06 at 09:13 -0400, Bruce Ashfield wrote:
> > On Tue, Apr 6, 2021 at 9:07 AM Robert P. J. Day <rpjday@crashcourse.ca>
> wrote:
> > >
> > > On Tue, 6 Apr 2021, Bruce Ashfield wrote:
> > >
> > > > On Tue, Apr 6, 2021 at 8:40 AM Robert P. J. Day
> <rpjday@crashcourse.ca> wrote:
> > > > >
> > > > > On Tue, 6 Apr 2021, Bruce Ashfield wrote:
> > > > >
> > > > > > On Tue, Apr 6, 2021 at 5:35 AM Robert P. J. Day
> <rpjday@crashcourse.ca> wrote:
> > > > > > >
> > > > > > >
> > > > > > >   this doesn't look right, but i don't know how one wants to
> resolve
> > > > > > > it:
> > > > > > >
> > > > > >
> > > > > > What part doesn't look right ? I don't see any issues with it.
> > > > > >
> > > > > > Bruce
> > > > > >
> > > > > > >   FILESEXTRAPATHS_append := "${THISDIR}/${PN}-git:"
> > > > >
> > > > >   isn't the colon on the wrong end?
> > > >
> > > > In a quick scan of other layers, they are all leaving the variable
> in
> > > > the same state (with a trailing colon), whether they are using
> > > > _prepend or _append.
> > >
> > >   i beg to differ -- here's a single example:
> > >
> > >   meta-intel/recipes-core/zlib/zlib-intel_1.2.11.1.jtkv6.3.bb:
> > >     FILESEXTRAPATHS_append = ":${COREBASE}/meta/recipes-core/zlib/zlib"
> >
> > Do a build with that. You have a double colon, so you found a bad
> > example, unless the double colon is expected.
> >
> > FILESEXTRAPATHS="__default::/home/poky/meta/recipes-core/zlib/zlib"
> 
> Anything using append should be adding a leading colon, anything
> prepending should be adding a trailing one.
> 
> I suspect we need an audit and cleanup of several layers...
> 
> Cheers,
> 
> Richard

Normally, I would agree with you. However, the definition of FILESEXTRAPATHS in 
meta/conf/bitbake.conf contradicts that:

FILESEXTRAPATHS ?= "__default:"

The benefit of that (I guess) is that the added string looks the same whether 
_prepend or _append is used. At the same time it is a bit confusing since 
this is not the normal pattern for adding to a colon-separated variable.

//Peter

Re: [meta-virtualization] "FILESEXTRAPATHS_append" error in openvswitch_git.bb

[Richard Purdie]

On Fri, 2021-04-09 at 10:04 +0000, Peter Kjellerstedt wrote:
> > -----Original Message-----
> > From: meta-virtualization@lists.yoctoproject.org <meta-
> > virtualization@lists.yoctoproject.org> On Behalf Of Richard Purdie
> > Sent: den 6 april 2021 15:59
> > To: Bruce Ashfield <bruce.ashfield@gmail.com>; Robert P. J. Day
> > <rpjday@crashcourse.ca>
> > Cc: meta-virtualization@lists.yoctoproject.org
> > Subject: Re: [meta-virtualization] "FILESEXTRAPATHS_append" error in
> > openvswitch_git.bb
> > 
> > On Tue, 2021-04-06 at 09:13 -0400, Bruce Ashfield wrote:
> > > On Tue, Apr 6, 2021 at 9:07 AM Robert P. J. Day <rpjday@crashcourse.ca>
> > wrote:
> > > > 
> > > > On Tue, 6 Apr 2021, Bruce Ashfield wrote:
> > > > 
> > > > > On Tue, Apr 6, 2021 at 8:40 AM Robert P. J. Day
> > <rpjday@crashcourse.ca> wrote:
> > > > > > 
> > > > > > On Tue, 6 Apr 2021, Bruce Ashfield wrote:
> > > > > > 
> > > > > > > On Tue, Apr 6, 2021 at 5:35 AM Robert P. J. Day
> > <rpjday@crashcourse.ca> wrote:
> > > > > > > > 
> > > > > > > > 
> > > > > > > >   this doesn't look right, but i don't know how one wants to
> > resolve
> > > > > > > > it:
> > > > > > > > 
> > > > > > > 
> > > > > > > What part doesn't look right ? I don't see any issues with it.
> > > > > > > 
> > > > > > > Bruce
> > > > > > > 
> > > > > > > >   FILESEXTRAPATHS_append := "${THISDIR}/${PN}-git:"
> > > > > > 
> > > > > >   isn't the colon on the wrong end?
> > > > > 
> > > > > In a quick scan of other layers, they are all leaving the variable
> > in
> > > > > the same state (with a trailing colon), whether they are using
> > > > > _prepend or _append.
> > > > 
> > > >   i beg to differ -- here's a single example:
> > > > 
> > > >   meta-intel/recipes-core/zlib/zlib-intel_1.2.11.1.jtkv6.3.bb:
> > > >     FILESEXTRAPATHS_append = ":${COREBASE}/meta/recipes-core/zlib/zlib"
> > > 
> > > Do a build with that. You have a double colon, so you found a bad
> > > example, unless the double colon is expected.
> > > 
> > > FILESEXTRAPATHS="__default::/home/poky/meta/recipes-core/zlib/zlib"
> > 
> > Anything using append should be adding a leading colon, anything
> > prepending should be adding a trailing one.
> > 
> > I suspect we need an audit and cleanup of several layers...
> > 
> > Cheers,
> > 
> > Richard
> 
> Normally, I would agree with you. However, the definition of FILESEXTRAPATHS in 
> meta/conf/bitbake.conf contradicts that:
> 
> FILESEXTRAPATHS ?= "__default:"
> 
> The benefit of that (I guess) is that the added string looks the same whether 
> _prepend or _append is used. At the same time it is a bit confusing since 
> this is not the normal pattern for adding to a colon-separated variable.

It gets worse unfortunately. See the code in classes/utils.bbclass which
handles this and the magic __default: value :/.

It is far from clear what is going on :(

Cheers,

Richard

Re: [meta-virtualization] "FILESEXTRAPATHS_append" error in openvswitch_git.bb

[Robert P. J. Day]

[-- Attachment #1: Type: text/plain, Size: 3211 bytes --]

On Fri, 9 Apr 2021, Richard Purdie wrote:

> On Fri, 2021-04-09 at 10:04 +0000, Peter Kjellerstedt wrote:
> > > -----Original Message-----
> > > From: meta-virtualization@lists.yoctoproject.org <meta-
> > > virtualization@lists.yoctoproject.org> On Behalf Of Richard Purdie
> > > Sent: den 6 april 2021 15:59
> > > To: Bruce Ashfield <bruce.ashfield@gmail.com>; Robert P. J. Day
> > > <rpjday@crashcourse.ca>
> > > Cc: meta-virtualization@lists.yoctoproject.org
> > > Subject: Re: [meta-virtualization] "FILESEXTRAPATHS_append" error in
> > > openvswitch_git.bb
> > >
> > > On Tue, 2021-04-06 at 09:13 -0400, Bruce Ashfield wrote:
> > > > On Tue, Apr 6, 2021 at 9:07 AM Robert P. J. Day <rpjday@crashcourse.ca>
> > > wrote:
> > > > >
> > > > > On Tue, 6 Apr 2021, Bruce Ashfield wrote:
> > > > >
> > > > > > On Tue, Apr 6, 2021 at 8:40 AM Robert P. J. Day
> > > <rpjday@crashcourse.ca> wrote:
> > > > > > >
> > > > > > > On Tue, 6 Apr 2021, Bruce Ashfield wrote:
> > > > > > >
> > > > > > > > On Tue, Apr 6, 2021 at 5:35 AM Robert P. J. Day
> > > <rpjday@crashcourse.ca> wrote:
> > > > > > > > >
> > > > > > > > >
> > > > > > > > >   this doesn't look right, but i don't know how one wants to
> > > resolve
> > > > > > > > > it:
> > > > > > > > >
> > > > > > > >
> > > > > > > > What part doesn't look right ? I don't see any issues with it.
> > > > > > > >
> > > > > > > > Bruce
> > > > > > > >
> > > > > > > > >   FILESEXTRAPATHS_append := "${THISDIR}/${PN}-git:"
> > > > > > >
> > > > > > >   isn't the colon on the wrong end?
> > > > > >
> > > > > > In a quick scan of other layers, they are all leaving the variable
> > > in
> > > > > > the same state (with a trailing colon), whether they are using
> > > > > > _prepend or _append.
> > > > >
> > > > >   i beg to differ -- here's a single example:
> > > > >
> > > > >   meta-intel/recipes-core/zlib/zlib-intel_1.2.11.1.jtkv6.3.bb:
> > > > >     FILESEXTRAPATHS_append = ":${COREBASE}/meta/recipes-core/zlib/zlib"
> > > >
> > > > Do a build with that. You have a double colon, so you found a bad
> > > > example, unless the double colon is expected.
> > > >
> > > > FILESEXTRAPATHS="__default::/home/poky/meta/recipes-core/zlib/zlib"
> > >
> > > Anything using append should be adding a leading colon, anything
> > > prepending should be adding a trailing one.
> > >
> > > I suspect we need an audit and cleanup of several layers...
> > >
> > > Cheers,
> > >
> > > Richard
> >
> > Normally, I would agree with you. However, the definition of FILESEXTRAPATHS in
> > meta/conf/bitbake.conf contradicts that:
> >
> > FILESEXTRAPATHS ?= "__default:"
> >
> > The benefit of that (I guess) is that the added string looks the same whether
> > _prepend or _append is used. At the same time it is a bit confusing since
> > this is not the normal pattern for adding to a colon-separated variable.
>
> It gets worse unfortunately. See the code in classes/utils.bbclass which
> handles this and the magic __default: value :/.
>
> It is far from clear what is going on :(

  well, now that i've released the ferret into the henhouse, i see my
work here is done. :-)

rday

Re: [meta-virtualization] "FILESEXTRAPATHS_append" error in openvswitch_git.bb

[Richard Purdie]

On Fri, 2021-04-09 at 06:38 -0400, Robert P. J. Day wrote:
> On Fri, 9 Apr 2021, Richard Purdie wrote:
> 
> > On Fri, 2021-04-09 at 10:04 +0000, Peter Kjellerstedt wrote:
> > > > -----Original Message-----
> > > > From: meta-virtualization@lists.yoctoproject.org <meta-
> > > > virtualization@lists.yoctoproject.org> On Behalf Of Richard Purdie
> > > > Sent: den 6 april 2021 15:59
> > > > To: Bruce Ashfield <bruce.ashfield@gmail.com>; Robert P. J. Day
> > > > <rpjday@crashcourse.ca>
> > > > Cc: meta-virtualization@lists.yoctoproject.org
> > > > Subject: Re: [meta-virtualization] "FILESEXTRAPATHS_append" error in
> > > > openvswitch_git.bb
> > > > 
> > > > On Tue, 2021-04-06 at 09:13 -0400, Bruce Ashfield wrote:
> > > > > On Tue, Apr 6, 2021 at 9:07 AM Robert P. J. Day <rpjday@crashcourse.ca>
> > > > wrote:
> > > > > > 
> > > > > > On Tue, 6 Apr 2021, Bruce Ashfield wrote:
> > > > > > 
> > > > > > > On Tue, Apr 6, 2021 at 8:40 AM Robert P. J. Day
> > > > <rpjday@crashcourse.ca> wrote:
> > > > > > > > 
> > > > > > > > On Tue, 6 Apr 2021, Bruce Ashfield wrote:
> > > > > > > > 
> > > > > > > > > On Tue, Apr 6, 2021 at 5:35 AM Robert P. J. Day
> > > > <rpjday@crashcourse.ca> wrote:
> > > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > >   this doesn't look right, but i don't know how one wants to
> > > > resolve
> > > > > > > > > > it:
> > > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > What part doesn't look right ? I don't see any issues with it.
> > > > > > > > > 
> > > > > > > > > Bruce
> > > > > > > > > 
> > > > > > > > > >   FILESEXTRAPATHS_append := "${THISDIR}/${PN}-git:"
> > > > > > > > 
> > > > > > > >   isn't the colon on the wrong end?
> > > > > > > 
> > > > > > > In a quick scan of other layers, they are all leaving the variable
> > > > in
> > > > > > > the same state (with a trailing colon), whether they are using
> > > > > > > _prepend or _append.
> > > > > > 
> > > > > >   i beg to differ -- here's a single example:
> > > > > > 
> > > > > >   meta-intel/recipes-core/zlib/zlib-intel_1.2.11.1.jtkv6.3.bb:
> > > > > >     FILESEXTRAPATHS_append = ":${COREBASE}/meta/recipes-core/zlib/zlib"
> > > > > 
> > > > > Do a build with that. You have a double colon, so you found a bad
> > > > > example, unless the double colon is expected.
> > > > > 
> > > > > FILESEXTRAPATHS="__default::/home/poky/meta/recipes-core/zlib/zlib"
> > > > 
> > > > Anything using append should be adding a leading colon, anything
> > > > prepending should be adding a trailing one.
> > > > 
> > > > I suspect we need an audit and cleanup of several layers...
> > > > 
> > > > Cheers,
> > > > 
> > > > Richard
> > > 
> > > Normally, I would agree with you. However, the definition of FILESEXTRAPATHS in
> > > meta/conf/bitbake.conf contradicts that:
> > > 
> > > FILESEXTRAPATHS ?= "__default:"
> > > 
> > > The benefit of that (I guess) is that the added string looks the same whether
> > > _prepend or _append is used. At the same time it is a bit confusing since
> > > this is not the normal pattern for adding to a colon-separated variable.
> > 
> > It gets worse unfortunately. See the code in classes/utils.bbclass which
> > handles this and the magic __default: value :/.
> > 
> > It is far from clear what is going on :(
> 
>   well, now that i've released the ferret into the henhouse, i see my
> work here is done. :-)

Great, we've found some issues but the real challenge is figuring out how 
to improve things and move forward from here. If you really want to help,
the work is just started.

If all these unresolved threads you're leaving are "someone else's problem", 
that effectively means you're just creating work for others and I know that
personally, I have a ton already but thanks for adding to the queue.

Cheers,

Richard

Re: [meta-virtualization] "FILESEXTRAPATHS_append" error in openvswitch_git.bb

[Robert P. J. Day]

[-- Attachment #1: Type: text/plain, Size: 4249 bytes --]

On Fri, 9 Apr 2021, Richard Purdie wrote:

> On Fri, 2021-04-09 at 06:38 -0400, Robert P. J. Day wrote:
> > On Fri, 9 Apr 2021, Richard Purdie wrote:
> >
> > > On Fri, 2021-04-09 at 10:04 +0000, Peter Kjellerstedt wrote:
> > > > > -----Original Message-----
> > > > > From: meta-virtualization@lists.yoctoproject.org <meta-
> > > > > virtualization@lists.yoctoproject.org> On Behalf Of Richard Purdie
> > > > > Sent: den 6 april 2021 15:59
> > > > > To: Bruce Ashfield <bruce.ashfield@gmail.com>; Robert P. J. Day
> > > > > <rpjday@crashcourse.ca>
> > > > > Cc: meta-virtualization@lists.yoctoproject.org
> > > > > Subject: Re: [meta-virtualization] "FILESEXTRAPATHS_append" error in
> > > > > openvswitch_git.bb
> > > > >
> > > > > On Tue, 2021-04-06 at 09:13 -0400, Bruce Ashfield wrote:
> > > > > > On Tue, Apr 6, 2021 at 9:07 AM Robert P. J. Day <rpjday@crashcourse.ca>
> > > > > wrote:
> > > > > > >
> > > > > > > On Tue, 6 Apr 2021, Bruce Ashfield wrote:
> > > > > > >
> > > > > > > > On Tue, Apr 6, 2021 at 8:40 AM Robert P. J. Day
> > > > > <rpjday@crashcourse.ca> wrote:
> > > > > > > > >
> > > > > > > > > On Tue, 6 Apr 2021, Bruce Ashfield wrote:
> > > > > > > > >
> > > > > > > > > > On Tue, Apr 6, 2021 at 5:35 AM Robert P. J. Day
> > > > > <rpjday@crashcourse.ca> wrote:
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > >   this doesn't look right, but i don't know how one wants to
> > > > > resolve
> > > > > > > > > > > it:
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > > What part doesn't look right ? I don't see any issues with it.
> > > > > > > > > >
> > > > > > > > > > Bruce
> > > > > > > > > >
> > > > > > > > > > >   FILESEXTRAPATHS_append := "${THISDIR}/${PN}-git:"
> > > > > > > > >
> > > > > > > > >   isn't the colon on the wrong end?
> > > > > > > >
> > > > > > > > In a quick scan of other layers, they are all leaving the variable
> > > > > in
> > > > > > > > the same state (with a trailing colon), whether they are using
> > > > > > > > _prepend or _append.
> > > > > > >
> > > > > > >   i beg to differ -- here's a single example:
> > > > > > >
> > > > > > >   meta-intel/recipes-core/zlib/zlib-intel_1.2.11.1.jtkv6.3.bb:
> > > > > > >     FILESEXTRAPATHS_append = ":${COREBASE}/meta/recipes-core/zlib/zlib"
> > > > > >
> > > > > > Do a build with that. You have a double colon, so you found a bad
> > > > > > example, unless the double colon is expected.
> > > > > >
> > > > > > FILESEXTRAPATHS="__default::/home/poky/meta/recipes-core/zlib/zlib"
> > > > >
> > > > > Anything using append should be adding a leading colon, anything
> > > > > prepending should be adding a trailing one.
> > > > >
> > > > > I suspect we need an audit and cleanup of several layers...
> > > > >
> > > > > Cheers,
> > > > >
> > > > > Richard
> > > >
> > > > Normally, I would agree with you. However, the definition of FILESEXTRAPATHS in
> > > > meta/conf/bitbake.conf contradicts that:
> > > >
> > > > FILESEXTRAPATHS ?= "__default:"
> > > >
> > > > The benefit of that (I guess) is that the added string looks the same whether
> > > > _prepend or _append is used. At the same time it is a bit confusing since
> > > > this is not the normal pattern for adding to a colon-separated variable.
> > >
> > > It gets worse unfortunately. See the code in classes/utils.bbclass which
> > > handles this and the magic __default: value :/.
> > >
> > > It is far from clear what is going on :(
> >
> >   well, now that i've released the ferret into the henhouse, i see my
> > work here is done. :-)
>
> Great, we've found some issues but the real challenge is figuring
> out how to improve things and move forward from here. If you really
> want to help, the work is just started.
>
> If all these unresolved threads you're leaving are "someone else's
> problem", that effectively means you're just creating work for
> others and I know that personally, I have a ton already but thanks
> for adding to the queue.

  i'm more than happy to submit patches, after i've verified that i
actually understand the problem and someone else verifies that there
*is* a problem.

  patches forthcoming.

rday