All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Peng Fan <peng.fan@nxp.com>,
	"Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"krzysztof.kozlowski+dt@linaro.org" 
	<krzysztof.kozlowski+dt@linaro.org>,
	"sboyd@kernel.org" <sboyd@kernel.org>,
	"mturquette@baylibre.com" <mturquette@baylibre.com>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>
Cc: Aisheng Dong <aisheng.dong@nxp.com>,
	"l.stach@pengutronix.de" <l.stach@pengutronix.de>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"festevam@gmail.com" <festevam@gmail.com>,
	dl-linux-imx <linux-imx@nxp.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V2 1/7] dt-bindings: soc: add i.MX93 SRC
Date: Mon, 30 May 2022 09:40:38 +0200	[thread overview]
Message-ID: <9f40d587-bfaa-a3cd-d261-a10d1740610d@linaro.org> (raw)
In-Reply-To: <DU0PR04MB9417353FE7BA649887E7C5B188DD9@DU0PR04MB9417.eurprd04.prod.outlook.com>

On 30/05/2022 08:57, Peng Fan wrote:
>> Subject: Re: [PATCH V2 1/7] dt-bindings: soc: add i.MX93 SRC
>>
>> On 26/05/2022 14:34, Peng Fan (OSS) wrote:
>>> From: Peng Fan <peng.fan@nxp.com>
>>>
>>> Add bindings for i.MX93 System Reset Controller(SRC). SRC supports
>>> resets and power gating for mixes.
>>>
>>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
>>> ---
>>>  .../bindings/soc/imx/fsl,imx93-src.yaml       | 96
>> +++++++++++++++++++
>>
>> Still wrong location of bindings.
> 
> Although it is called SRC(system reset controller), but actually
> it not functions only as reset controller, it also supports power
> gating of each slice including slice's memory low power control.
> It also includes some system general configuration.
> 
> So follow your suggestion in V1, I rename it as system-controller,
> but I not find a directory for system-controller.

Therefore I propose "power". 2 out of 3 functions (reset controller,
power domain controller) are related to power.

Best regards,
Krzysztof

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Peng Fan <peng.fan@nxp.com>,
	"Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"krzysztof.kozlowski+dt@linaro.org"
	<krzysztof.kozlowski+dt@linaro.org>,
	"sboyd@kernel.org" <sboyd@kernel.org>,
	"mturquette@baylibre.com" <mturquette@baylibre.com>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>
Cc: Aisheng Dong <aisheng.dong@nxp.com>,
	"l.stach@pengutronix.de" <l.stach@pengutronix.de>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"festevam@gmail.com" <festevam@gmail.com>,
	dl-linux-imx <linux-imx@nxp.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V2 1/7] dt-bindings: soc: add i.MX93 SRC
Date: Mon, 30 May 2022 09:40:38 +0200	[thread overview]
Message-ID: <9f40d587-bfaa-a3cd-d261-a10d1740610d@linaro.org> (raw)
In-Reply-To: <DU0PR04MB9417353FE7BA649887E7C5B188DD9@DU0PR04MB9417.eurprd04.prod.outlook.com>

On 30/05/2022 08:57, Peng Fan wrote:
>> Subject: Re: [PATCH V2 1/7] dt-bindings: soc: add i.MX93 SRC
>>
>> On 26/05/2022 14:34, Peng Fan (OSS) wrote:
>>> From: Peng Fan <peng.fan@nxp.com>
>>>
>>> Add bindings for i.MX93 System Reset Controller(SRC). SRC supports
>>> resets and power gating for mixes.
>>>
>>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
>>> ---
>>>  .../bindings/soc/imx/fsl,imx93-src.yaml       | 96
>> +++++++++++++++++++
>>
>> Still wrong location of bindings.
> 
> Although it is called SRC(system reset controller), but actually
> it not functions only as reset controller, it also supports power
> gating of each slice including slice's memory low power control.
> It also includes some system general configuration.
> 
> So follow your suggestion in V1, I rename it as system-controller,
> but I not find a directory for system-controller.

Therefore I propose "power". 2 out of 3 functions (reset controller,
power domain controller) are related to power.

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-05-30  7:40 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-26 12:34 [PATCH V2 0/7] imx: support i.MX93 SRC and mediamix blk ctrl Peng Fan (OSS)
2022-05-26 12:34 ` Peng Fan (OSS)
2022-05-26 12:34 ` [PATCH V2 1/7] dt-bindings: soc: add i.MX93 SRC Peng Fan (OSS)
2022-05-26 12:34   ` Peng Fan (OSS)
2022-05-30  6:43   ` Krzysztof Kozlowski
2022-05-30  6:43     ` Krzysztof Kozlowski
2022-05-30  6:57     ` Peng Fan
2022-05-30  6:57       ` Peng Fan
2022-05-30  7:40       ` Krzysztof Kozlowski [this message]
2022-05-30  7:40         ` Krzysztof Kozlowski
2022-05-26 12:34 ` [PATCH V2 2/7] dt-bindings: soc: add i.MX93 mediamix blk ctrl Peng Fan (OSS)
2022-05-26 12:34   ` Peng Fan (OSS)
2022-05-30  6:45   ` Krzysztof Kozlowski
2022-05-30  6:45     ` Krzysztof Kozlowski
2022-05-26 12:34 ` [PATCH V2 3/7] clk: export of_clk_bulk_get_all Peng Fan (OSS)
2022-05-26 12:34   ` Peng Fan (OSS)
2022-05-26 12:34 ` [PATCH V2 4/7] soc: imx: add i.MX93 SRC power domain driver Peng Fan (OSS)
2022-05-26 12:34   ` Peng Fan (OSS)
2022-05-26 12:34 ` [PATCH V2 5/7] soc: imx: add i.MX93 media blk ctrl driver Peng Fan (OSS)
2022-05-26 12:34   ` Peng Fan (OSS)
2022-05-26 12:34 ` [PATCH V2 6/7] arm64: dts: imx93: add src node Peng Fan (OSS)
2022-05-26 12:34   ` Peng Fan (OSS)
2022-05-26 12:34 ` [PATCH V2 7/7] arm64: dts: imx93: add mediamix blk ctrl node Peng Fan (OSS)
2022-05-26 12:34   ` Peng Fan (OSS)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9f40d587-bfaa-a3cd-d261-a10d1740610d@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=aisheng.dong@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=peng.fan@nxp.com \
    --cc=peng.fan@oss.nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=sboyd@kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.