All of lore.kernel.org
 help / color / mirror / Atom feed
From: <Christian.Gromm@microchip.com>
To: <dan.carpenter@oracle.com>
Cc: <driverdev-devel@linuxdriverproject.org>,
	<gregkh@linuxfoundation.org>, <linux-usb@vger.kernel.org>
Subject: Re: [PATCH v2 1/8] drivers: most: add usb adapter driver
Date: Wed, 20 May 2020 13:54:07 +0000	[thread overview]
Message-ID: <9f448ee4453003f4d92ff854146efa8e8d6b3a67.camel@microchip.com> (raw)
In-Reply-To: <20200520131740.GR2078@kadam>

On Wed, 2020-05-20 at 16:17 +0300, Dan Carpenter wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
> 
> On Thu, May 14, 2020 at 11:52:49AM +0200, Christian Gromm wrote:
> > This patch adds the usb driver source file most_usb.c and
> > modifies the Makefile and Kconfig accordingly.
> > 
> > Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
> > ---
> > v2:
> > Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >       - don't remove usb driver from staging area
> >       - don't touch staging/most/Kconfig
> >       - remove subdirectory for USB driver and put source file into
> >         drivers/most
> > 
> >  drivers/most/Kconfig    |   12 +
> >  drivers/most/Makefile   |    2 +
> >  drivers/most/most_usb.c | 1262
> > +++++++++++++++++++++++++++++++++++++++++++++++
> >  3 files changed, 1276 insertions(+)
> >  create mode 100644 drivers/most/most_usb.c
> > 
> > 

There is already a v3 out there that has some of your concerns
already addressed. I'll take your comments and fix them in the
next version of the patch.

thanks,
Chris





WARNING: multiple messages have this Message-ID (diff)
From: <Christian.Gromm@microchip.com>
To: <dan.carpenter@oracle.com>
Cc: gregkh@linuxfoundation.org,
	driverdev-devel@linuxdriverproject.org,
	linux-usb@vger.kernel.org
Subject: Re: [PATCH v2 1/8] drivers: most: add usb adapter driver
Date: Wed, 20 May 2020 13:54:07 +0000	[thread overview]
Message-ID: <9f448ee4453003f4d92ff854146efa8e8d6b3a67.camel@microchip.com> (raw)
In-Reply-To: <20200520131740.GR2078@kadam>

On Wed, 2020-05-20 at 16:17 +0300, Dan Carpenter wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
> 
> On Thu, May 14, 2020 at 11:52:49AM +0200, Christian Gromm wrote:
> > This patch adds the usb driver source file most_usb.c and
> > modifies the Makefile and Kconfig accordingly.
> > 
> > Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
> > ---
> > v2:
> > Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >       - don't remove usb driver from staging area
> >       - don't touch staging/most/Kconfig
> >       - remove subdirectory for USB driver and put source file into
> >         drivers/most
> > 
> >  drivers/most/Kconfig    |   12 +
> >  drivers/most/Makefile   |    2 +
> >  drivers/most/most_usb.c | 1262
> > +++++++++++++++++++++++++++++++++++++++++++++++
> >  3 files changed, 1276 insertions(+)
> >  create mode 100644 drivers/most/most_usb.c
> > 
> > 

There is already a v3 out there that has some of your concerns
already addressed. I'll take your comments and fix them in the
next version of the patch.

thanks,
Chris




_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  reply	other threads:[~2020-05-20 13:54 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-14  9:52 [PATCH v2 0/8] staging: most: move USB adapter driver to stable branch Christian Gromm
2020-05-14  9:52 ` Christian Gromm
2020-05-14  9:52 ` [PATCH v2 1/8] drivers: most: add usb adapter driver Christian Gromm
2020-05-14  9:52   ` Christian Gromm
2020-05-14 10:25   ` Greg KH
2020-05-14 10:25     ` Greg KH
2020-05-20 13:17   ` Dan Carpenter
2020-05-20 13:17     ` Dan Carpenter
2020-05-20 13:54     ` Christian.Gromm [this message]
2020-05-20 13:54       ` Christian.Gromm
2020-05-14  9:52 ` [PATCH v2 2/8] drivers: most: usb: use dev_*() functions to print messages Christian Gromm
2020-05-14  9:52   ` Christian Gromm
2020-05-19 13:42   ` Dan Carpenter
2020-05-19 13:42     ` Dan Carpenter
2020-05-14  9:52 ` [PATCH v2 3/8] drivers: most: usb: remove reference to USB error codes Christian Gromm
2020-05-14  9:52   ` Christian Gromm
2020-05-14  9:52 ` [PATCH v2 4/8] drivers: most: usb: check number of reported endpoints Christian Gromm
2020-05-14  9:52   ` Christian Gromm
2020-05-14 20:53   ` kbuild test robot
2020-05-14 20:53     ` kbuild test robot
2020-05-14 20:53     ` kbuild test robot
2020-05-14  9:52 ` [PATCH v2 5/8] drivers: most: usb: use dev_dbg function Christian Gromm
2020-05-14  9:52   ` Christian Gromm
2020-05-19 13:43   ` Dan Carpenter
2020-05-19 13:43     ` Dan Carpenter
2020-05-14  9:52 ` [PATCH v2 6/8] drivers: most: fix typo in Kconfig Christian Gromm
2020-05-14  9:52   ` Christian Gromm
2020-05-14  9:52 ` [PATCH v2 7/8] drivers: most: usb: use macro ATTRIBUTE_GROUPS Christian Gromm
2020-05-14  9:52   ` Christian Gromm
2020-05-14  9:52 ` [PATCH v2 8/8] Documentation: ABI: correct sysfs attribute description of MOST driver Christian Gromm
2020-05-14  9:52   ` Christian Gromm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9f448ee4453003f4d92ff854146efa8e8d6b3a67.camel@microchip.com \
    --to=christian.gromm@microchip.com \
    --cc=dan.carpenter@oracle.com \
    --cc=driverdev-devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.