* Re: [Intel-wired-lan] [PATCH 1/1] ice: Add the CEE DCBX support in the comments
2023-01-13 23:19 ` Zhu Yanjun
@ 2023-01-13 10:09 ` Paul Menzel
-1 siblings, 0 replies; 4+ messages in thread
From: Paul Menzel @ 2023-01-13 10:09 UTC (permalink / raw)
To: Zhu Yanjun
Cc: jesse.brandeburg, anthony.l.nguyen, davem, edumazet, kuba,
pabeni, intel-wired-lan, netdev, Zhu Yanjun
Dear Zhu,
Thank you for your patch. (Unfortunately your system time is incorrect,
so the message date is from the future.)
Am 14.01.23 um 00:19 schrieb Zhu Yanjun:
> From: Zhu Yanjun <yanjun.zhu@linux.dev>
Maybe use the following summary/title/subject:
ice: Mention CEE DCBX in code comment
> From the function ice_parse_org_tlv, CEE DCBX TLV is also supported.
> The comments are changed.
…, so update the comment.
> Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
> ---
> drivers/net/ethernet/intel/ice/ice_dcb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
The rest looks good.
[…]
Kind regards,
Paul
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Intel-wired-lan] [PATCH 1/1] ice: Add the CEE DCBX support in the comments
@ 2023-01-13 10:09 ` Paul Menzel
0 siblings, 0 replies; 4+ messages in thread
From: Paul Menzel @ 2023-01-13 10:09 UTC (permalink / raw)
To: Zhu Yanjun
Cc: intel-wired-lan, Zhu Yanjun, jesse.brandeburg, edumazet,
anthony.l.nguyen, netdev, kuba, pabeni, davem
Dear Zhu,
Thank you for your patch. (Unfortunately your system time is incorrect,
so the message date is from the future.)
Am 14.01.23 um 00:19 schrieb Zhu Yanjun:
> From: Zhu Yanjun <yanjun.zhu@linux.dev>
Maybe use the following summary/title/subject:
ice: Mention CEE DCBX in code comment
> From the function ice_parse_org_tlv, CEE DCBX TLV is also supported.
> The comments are changed.
…, so update the comment.
> Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
> ---
> drivers/net/ethernet/intel/ice/ice_dcb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
The rest looks good.
[…]
Kind regards,
Paul
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Intel-wired-lan] [PATCH 1/1] ice: Add the CEE DCBX support in the comments
@ 2023-01-13 23:19 ` Zhu Yanjun
0 siblings, 0 replies; 4+ messages in thread
From: Zhu Yanjun @ 2023-01-13 23:19 UTC (permalink / raw)
To: jesse.brandeburg, anthony.l.nguyen, davem, edumazet, kuba,
pabeni, intel-wired-lan, netdev
Cc: Zhu Yanjun
From: Zhu Yanjun <yanjun.zhu@linux.dev>
From the function ice_parse_org_tlv, CEE DCBX TLV is also supported.
The comments are changed.
Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
---
drivers/net/ethernet/intel/ice/ice_dcb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_dcb.c b/drivers/net/ethernet/intel/ice/ice_dcb.c
index 6be02f9b0b8c..7964405efa77 100644
--- a/drivers/net/ethernet/intel/ice/ice_dcb.c
+++ b/drivers/net/ethernet/intel/ice/ice_dcb.c
@@ -566,7 +566,7 @@ ice_parse_cee_tlv(struct ice_lldp_org_tlv *tlv, struct ice_dcbx_cfg *dcbcfg)
* @tlv: Organization specific TLV
* @dcbcfg: Local store to update ETS REC data
*
- * Currently only IEEE 802.1Qaz TLV is supported, all others
+ * Currently IEEE 802.1Qaz and CEE DCBX TLV are supported, others
* will be returned
*/
static void
@@ -585,7 +585,7 @@ ice_parse_org_tlv(struct ice_lldp_org_tlv *tlv, struct ice_dcbx_cfg *dcbcfg)
ice_parse_cee_tlv(tlv, dcbcfg);
break;
default:
- break;
+ break; /* Other OUIs not supported */
}
}
--
2.27.0
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 1/1] ice: Add the CEE DCBX support in the comments
@ 2023-01-13 23:19 ` Zhu Yanjun
0 siblings, 0 replies; 4+ messages in thread
From: Zhu Yanjun @ 2023-01-13 23:19 UTC (permalink / raw)
To: jesse.brandeburg, anthony.l.nguyen, davem, edumazet, kuba,
pabeni, intel-wired-lan, netdev
Cc: Zhu Yanjun
From: Zhu Yanjun <yanjun.zhu@linux.dev>
From the function ice_parse_org_tlv, CEE DCBX TLV is also supported.
The comments are changed.
Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
---
drivers/net/ethernet/intel/ice/ice_dcb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_dcb.c b/drivers/net/ethernet/intel/ice/ice_dcb.c
index 6be02f9b0b8c..7964405efa77 100644
--- a/drivers/net/ethernet/intel/ice/ice_dcb.c
+++ b/drivers/net/ethernet/intel/ice/ice_dcb.c
@@ -566,7 +566,7 @@ ice_parse_cee_tlv(struct ice_lldp_org_tlv *tlv, struct ice_dcbx_cfg *dcbcfg)
* @tlv: Organization specific TLV
* @dcbcfg: Local store to update ETS REC data
*
- * Currently only IEEE 802.1Qaz TLV is supported, all others
+ * Currently IEEE 802.1Qaz and CEE DCBX TLV are supported, others
* will be returned
*/
static void
@@ -585,7 +585,7 @@ ice_parse_org_tlv(struct ice_lldp_org_tlv *tlv, struct ice_dcbx_cfg *dcbcfg)
ice_parse_cee_tlv(tlv, dcbcfg);
break;
default:
- break;
+ break; /* Other OUIs not supported */
}
}
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-13 10:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-13 23:19 [Intel-wired-lan] [PATCH 1/1] ice: Add the CEE DCBX support in the comments Zhu Yanjun
2023-01-13 23:19 ` Zhu Yanjun
2023-01-13 10:09 ` [Intel-wired-lan] " Paul Menzel
2023-01-13 10:09 ` Paul Menzel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.