From: Johan Jonker <jbx6244@gmail.com>
To: Peter Geis <pgwipeout@gmail.com>
Cc: Heiko Stuebner <heiko@sntech.de>,
Rob Herring <robh+dt@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
bgolaszewski@baylibre.com,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] arm64: dts: rockchip: change gpio nodenames
Date: Tue, 13 Apr 2021 10:55:11 +0200 [thread overview]
Message-ID: <9fa62a53-e4f2-5032-cf1b-267e470af1c9@gmail.com> (raw)
In-Reply-To: <CAMdYzYqTS-qEOaVsnWMSABpj5Z55An_GLCUoOZZg-fjMp9qi8w@mail.gmail.com>
On 4/13/21 1:22 AM, Peter Geis wrote:
> On Mon, Apr 12, 2021 at 6:38 PM Johan Jonker <jbx6244@gmail.com> wrote:
>>
>> Currently all gpio nodenames are sort of identical to there label.
>> Nodenames should be of a generic type, so change them all.
>
> Currently the rockchip pinctrl driver checks np->name against the
> bank->name and if they do not match it does not set the gpio-bank as
> valid.
> The new GPIO driver appears to follow a similar method.
> This will break the driver without a correction.
Given Rob's comment in version 1 maybe combine this serie with yours?
With Heiko's blessing maybe add support both for legacy and for the new
format?
Johan
>
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/pinctrl/pinctrl-rockchip.c?h=next-20210412#n3836
>
>>
>> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
>> ---
WARNING: multiple messages have this Message-ID (diff)
From: Johan Jonker <jbx6244@gmail.com>
To: Peter Geis <pgwipeout@gmail.com>
Cc: Heiko Stuebner <heiko@sntech.de>,
Rob Herring <robh+dt@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
bgolaszewski@baylibre.com,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] arm64: dts: rockchip: change gpio nodenames
Date: Tue, 13 Apr 2021 10:55:11 +0200 [thread overview]
Message-ID: <9fa62a53-e4f2-5032-cf1b-267e470af1c9@gmail.com> (raw)
In-Reply-To: <CAMdYzYqTS-qEOaVsnWMSABpj5Z55An_GLCUoOZZg-fjMp9qi8w@mail.gmail.com>
On 4/13/21 1:22 AM, Peter Geis wrote:
> On Mon, Apr 12, 2021 at 6:38 PM Johan Jonker <jbx6244@gmail.com> wrote:
>>
>> Currently all gpio nodenames are sort of identical to there label.
>> Nodenames should be of a generic type, so change them all.
>
> Currently the rockchip pinctrl driver checks np->name against the
> bank->name and if they do not match it does not set the gpio-bank as
> valid.
> The new GPIO driver appears to follow a similar method.
> This will break the driver without a correction.
Given Rob's comment in version 1 maybe combine this serie with yours?
With Heiko's blessing maybe add support both for legacy and for the new
format?
Johan
>
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/pinctrl/pinctrl-rockchip.c?h=next-20210412#n3836
>
>>
>> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
>> ---
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Johan Jonker <jbx6244@gmail.com>
To: Peter Geis <pgwipeout@gmail.com>
Cc: Heiko Stuebner <heiko@sntech.de>,
Rob Herring <robh+dt@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
bgolaszewski@baylibre.com,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] arm64: dts: rockchip: change gpio nodenames
Date: Tue, 13 Apr 2021 10:55:11 +0200 [thread overview]
Message-ID: <9fa62a53-e4f2-5032-cf1b-267e470af1c9@gmail.com> (raw)
In-Reply-To: <CAMdYzYqTS-qEOaVsnWMSABpj5Z55An_GLCUoOZZg-fjMp9qi8w@mail.gmail.com>
On 4/13/21 1:22 AM, Peter Geis wrote:
> On Mon, Apr 12, 2021 at 6:38 PM Johan Jonker <jbx6244@gmail.com> wrote:
>>
>> Currently all gpio nodenames are sort of identical to there label.
>> Nodenames should be of a generic type, so change them all.
>
> Currently the rockchip pinctrl driver checks np->name against the
> bank->name and if they do not match it does not set the gpio-bank as
> valid.
> The new GPIO driver appears to follow a similar method.
> This will break the driver without a correction.
Given Rob's comment in version 1 maybe combine this serie with yours?
With Heiko's blessing maybe add support both for legacy and for the new
format?
Johan
>
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/pinctrl/pinctrl-rockchip.c?h=next-20210412#n3836
>
>>
>> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
>> ---
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-13 8:55 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 22:36 [PATCH v2 1/3] dt-bindings: gpio: add YAML description for rockchip,gpio-bank Johan Jonker
2021-04-12 22:36 ` [PATCH v2 1/3] dt-bindings: gpio: add YAML description for rockchip, gpio-bank Johan Jonker
2021-04-12 22:36 ` Johan Jonker
2021-04-12 22:36 ` [PATCH v2 2/3] ARM: dts: rockchip: change gpio nodenames Johan Jonker
2021-04-12 22:36 ` Johan Jonker
2021-04-12 22:36 ` Johan Jonker
2021-04-22 0:04 ` Linus Walleij
2021-04-22 0:04 ` Linus Walleij
2021-04-22 0:04 ` Linus Walleij
2021-04-12 22:36 ` [PATCH v2 3/3] arm64: " Johan Jonker
2021-04-12 22:36 ` Johan Jonker
2021-04-12 22:36 ` Johan Jonker
2021-04-12 23:22 ` Peter Geis
2021-04-12 23:22 ` Peter Geis
2021-04-12 23:22 ` Peter Geis
2021-04-13 8:55 ` Johan Jonker [this message]
2021-04-13 8:55 ` Johan Jonker
2021-04-13 8:55 ` Johan Jonker
2021-04-13 15:22 ` [PATCH v2 1/3] dt-bindings: gpio: add YAML description for rockchip, gpio-bank Rob Herring
2021-04-13 15:22 ` Rob Herring
2021-04-13 15:22 ` Rob Herring
2021-04-14 7:12 ` [PATCH v2 1/3] dt-bindings: gpio: add YAML description for rockchip,gpio-bank Linus Walleij
2021-04-14 7:12 ` [PATCH v2 1/3] dt-bindings: gpio: add YAML description for rockchip, gpio-bank Linus Walleij
2021-04-14 7:12 ` Linus Walleij
2021-04-21 15:13 ` [PATCH v2 1/3] dt-bindings: gpio: add YAML description for rockchip,gpio-bank Bartosz Golaszewski
2021-04-21 15:13 ` [PATCH v2 1/3] dt-bindings: gpio: add YAML description for rockchip, gpio-bank Bartosz Golaszewski
2021-04-21 15:13 ` Bartosz Golaszewski
2021-09-30 9:52 [PATCH v2 1/3] dt-bindings: pinctrl: convert rockchip,pinctrl.txt to YAML Johan Jonker
2021-09-30 9:52 ` [PATCH v2 3/3] arm64: dts: rockchip: change gpio nodenames Johan Jonker
2021-09-30 9:52 ` Johan Jonker
2021-09-30 9:52 ` Johan Jonker
2021-09-30 16:17 ` Linus Walleij
2021-09-30 16:17 ` Linus Walleij
2021-09-30 16:17 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fa62a53-e4f2-5032-cf1b-267e470af1c9@gmail.com \
--to=jbx6244@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=pgwipeout@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.