All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mimi Zohar <zohar@linux.ibm.com>
To: Stefan Berger <stefanb@linux.ibm.com>,
	kexec@lists.infradead.org, devicetree@vger.kernel.org,
	linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org
Cc: nayna@linux.ibm.com, nasastry@in.ibm.com, mpe@ellerman.id.au,
	Jarkko Sakkinen <jarkko@kernel.org>,
	Jason Gunthorpe <jgg@ziepe.ca>, Rob Herring <robh+dt@kernel.org>,
	Frank Rowand <frowand.list@gmail.com>
Subject: Re: [PATCH v6 4/6] tpm: of: Make of-tree specific function commonly available
Date: Mon, 11 Jul 2022 18:04:41 -0400	[thread overview]
Message-ID: <9fc4f6dc2ee497a4d4998df17392ac73ebdf3d63.camel@linux.ibm.com> (raw)
In-Reply-To: <20220707172026.831614-5-stefanb@linux.ibm.com>

Hi Stefan,

On Thu, 2022-07-07 at 13:20 -0400, Stefan Berger wrote:
> -       /*
> -        * For both vtpm/tpm, firmware has log addr and log size in big
> -        * endian format. But in case of vtpm, there is a method called
> -        * sml-handover which is run during kernel init even before
> -        * device tree is setup. This sml-handover function takes care
> -        * of endianness and writes to sml-base and sml-size in little
> -        * endian format. For this reason, vtpm doesn't need conversion
> -        * but physical tpm needs the conversion.
> -        */

This comment is dropped.  Perhaps not in such detail, but shouldn't a
comment or function description exist in the new function.

Otherwise,
Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>

thanks,

Mimi


WARNING: multiple messages have this Message-ID (diff)
From: Mimi Zohar <zohar@linux.ibm.com>
To: Stefan Berger <stefanb@linux.ibm.com>,
	kexec@lists.infradead.org, devicetree@vger.kernel.org,
	linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org
Cc: nayna@linux.ibm.com, nasastry@in.ibm.com, mpe@ellerman.id.au,
	Jarkko Sakkinen <jarkko@kernel.org>,
	Jason Gunthorpe <jgg@ziepe.ca>, Rob Herring <robh+dt@kernel.org>,
	Frank Rowand <frowand.list@gmail.com>
Subject: Re: [PATCH v6 4/6] tpm: of: Make of-tree specific function commonly available
Date: Mon, 11 Jul 2022 18:04:41 -0400	[thread overview]
Message-ID: <9fc4f6dc2ee497a4d4998df17392ac73ebdf3d63.camel@linux.ibm.com> (raw)
In-Reply-To: <20220707172026.831614-5-stefanb@linux.ibm.com>

Hi Stefan,

On Thu, 2022-07-07 at 13:20 -0400, Stefan Berger wrote:
> -       /*
> -        * For both vtpm/tpm, firmware has log addr and log size in big
> -        * endian format. But in case of vtpm, there is a method called
> -        * sml-handover which is run during kernel init even before
> -        * device tree is setup. This sml-handover function takes care
> -        * of endianness and writes to sml-base and sml-size in little
> -        * endian format. For this reason, vtpm doesn't need conversion
> -        * but physical tpm needs the conversion.
> -        */

This comment is dropped.  Perhaps not in such detail, but shouldn't a
comment or function description exist in the new function.

Otherwise,
Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>

thanks,

Mimi


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Mimi Zohar <zohar@linux.ibm.com>
To: Stefan Berger <stefanb@linux.ibm.com>,
	kexec@lists.infradead.org, devicetree@vger.kernel.org,
	linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org
Cc: nayna@linux.ibm.com, Jason Gunthorpe <jgg@ziepe.ca>,
	Jarkko Sakkinen <jarkko@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	nasastry@in.ibm.com, Frank Rowand <frowand.list@gmail.com>
Subject: Re: [PATCH v6 4/6] tpm: of: Make of-tree specific function commonly available
Date: Mon, 11 Jul 2022 18:04:41 -0400	[thread overview]
Message-ID: <9fc4f6dc2ee497a4d4998df17392ac73ebdf3d63.camel@linux.ibm.com> (raw)
In-Reply-To: <20220707172026.831614-5-stefanb@linux.ibm.com>

Hi Stefan,

On Thu, 2022-07-07 at 13:20 -0400, Stefan Berger wrote:
> -       /*
> -        * For both vtpm/tpm, firmware has log addr and log size in big
> -        * endian format. But in case of vtpm, there is a method called
> -        * sml-handover which is run during kernel init even before
> -        * device tree is setup. This sml-handover function takes care
> -        * of endianness and writes to sml-base and sml-size in little
> -        * endian format. For this reason, vtpm doesn't need conversion
> -        * but physical tpm needs the conversion.
> -        */

This comment is dropped.  Perhaps not in such detail, but shouldn't a
comment or function description exist in the new function.

Otherwise,
Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>

thanks,

Mimi


  reply	other threads:[~2022-07-11 22:05 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-07 17:20 [PATCH v6 0/6] tpm: Preserve TPM measurement log across kexec (ppc64) Stefan Berger
2022-07-07 17:20 ` Stefan Berger
2022-07-07 17:20 ` Stefan Berger
2022-07-07 17:20 ` [PATCH v6 1/6] of: check previous kernel's ima-kexec-buffer against memory bounds Stefan Berger
2022-07-07 17:20   ` Stefan Berger
2022-07-07 17:20   ` Stefan Berger
2022-07-20 13:41   ` Nageswara R Sastry
2022-07-20 13:41     ` Nageswara R Sastry
2022-07-20 13:41     ` Nageswara R Sastry
2022-07-07 17:20 ` [PATCH v6 2/6] drivers: of: kexec ima: Support 32-bit platforms Stefan Berger
2022-07-07 17:20   ` Stefan Berger
2022-07-07 17:20   ` Stefan Berger
2022-07-20 13:42   ` Nageswara R Sastry
2022-07-20 13:42     ` Nageswara R Sastry
2022-07-20 13:42     ` Nageswara R Sastry
2022-07-07 17:20 ` [PATCH v6 3/6] x86/kexec: Carry forward IMA measurement log on kexec Stefan Berger
2022-07-07 17:20   ` Stefan Berger
2022-07-07 17:20   ` Stefan Berger
2022-07-20 13:44   ` Nageswara R Sastry
2022-07-20 13:44     ` Nageswara R Sastry
2022-07-20 13:44     ` Nageswara R Sastry
2022-07-07 17:20 ` [PATCH v6 4/6] tpm: of: Make of-tree specific function commonly available Stefan Berger
2022-07-07 17:20   ` Stefan Berger
2022-07-07 17:20   ` Stefan Berger
2022-07-11 22:04   ` Mimi Zohar [this message]
2022-07-11 22:04     ` Mimi Zohar
2022-07-11 22:04     ` Mimi Zohar
2022-07-12 13:25     ` Stefan Berger
2022-07-12 13:25       ` Stefan Berger
2022-07-12 13:25       ` Stefan Berger
2022-07-20 13:45   ` Nageswara R Sastry
2022-07-20 13:45     ` Nageswara R Sastry
2022-07-20 13:45     ` Nageswara R Sastry
2022-07-07 17:20 ` [PATCH v6 5/6] of: kexec: Refactor IMA buffer related functions to make them reusable Stefan Berger
2022-07-07 17:20   ` Stefan Berger
2022-07-07 17:20   ` Stefan Berger
2022-07-11 22:05   ` Mimi Zohar
2022-07-11 22:05     ` Mimi Zohar
2022-07-11 22:05     ` Mimi Zohar
2022-07-14 17:21   ` Rob Herring
2022-07-14 17:21     ` Rob Herring
2022-07-14 17:21     ` Rob Herring
2022-07-20 13:47   ` Nageswara R Sastry
2022-07-20 13:47     ` Nageswara R Sastry
2022-07-20 13:47     ` Nageswara R Sastry
2022-07-07 17:20 ` [PATCH v6 6/6] tpm/kexec: Duplicate TPM measurement log in of-tree for kexec Stefan Berger
2022-07-07 17:20   ` Stefan Berger
2022-07-07 17:20   ` Stefan Berger
2022-07-20 13:48   ` Nageswara R Sastry
2022-07-20 13:48     ` Nageswara R Sastry
2022-07-20 13:48     ` Nageswara R Sastry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9fc4f6dc2ee497a4d4998df17392ac73ebdf3d63.camel@linux.ibm.com \
    --to=zohar@linux.ibm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=jarkko@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=kexec@lists.infradead.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=nasastry@in.ibm.com \
    --cc=nayna@linux.ibm.com \
    --cc=robh+dt@kernel.org \
    --cc=stefanb@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.