From: Pascal Bach <pascal.bach@siemens.com>
To: Alexander Kanavin <alexander.kanavin@linux.intel.com>,
Tim Orling <timothy.t.orling@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] bmap-tools: add missing runtime dependencies
Date: Wed, 18 Oct 2017 09:17:55 +0200 [thread overview]
Message-ID: <9fc90bb8-6a8c-def4-3811-c8d2ad797352@siemens.com> (raw)
In-Reply-To: <b6d180ee-6674-5010-dc21-54f88f016d80@linux.intel.com>
On 16.10.2017 12:27, Alexander Kanavin wrote:
> On 10/14/2017 09:11 AM, Tim Orling wrote:
>>
>>> On Oct 13, 2017, at 4:14 AM, Pascal Bach <pascal.bach@siemens.com> wrote:
>>>
>>> When running bmap on a target device the added dependncies are required.
>>>
>>> Signed-off-by: Pascal Bach <pascal.bach@siemens.com>
>>> ---
>>> meta/recipes-support/bmap-tools/bmap-tools_3.4.bb | 12 +++++++++++-
>>> 1 file changed, 11 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/meta/recipes-support/bmap-tools/bmap-tools_3.4.bb b/meta/recipes-support/bmap-tools/bmap-tools_3.4.bb
>>> index 7454f9d..348c9e8 100644
>>> --- a/meta/recipes-support/bmap-tools/bmap-tools_3.4.bb
>>> +++ b/meta/recipes-support/bmap-tools/bmap-tools_3.4.bb
>>> @@ -14,7 +14,17 @@ SRCREV = "9dad724104df265442226972a1e310813f9ffcba"
>>>
>>> S = "${WORKDIR}/git"
>>>
>>> -RDEPENDS_${PN} = "python-core python-compression python-mmap"
>>> +RDEPENDS_${PN} = "\
>>> + python-core \
>>> + python-compression \
>>> + python-argparse \
>>> + python-shell \
>>> + python-fcntl \
>>> + python-threading \
>>> + python-xml \
>>> + python-subprocess \
>>> + python-mmap \
>>> + “
>>>
>>
>> These should all be the python3- version or ${PYTHON_PN}- (e.g. python3-core) should they not? Or is that an artifact of how the python module splitting is happening in oe-core?
>
> That is correct. This was forgotten when the recipe was moved to python3:
> http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/meta/recipes-support/bmap-tools/bmap-tools_3.4.bb?id=04ef46e2b2b753321408db02a2df3753b85ac0dd
>
> Pascal, can you modify everything to python3-*, check that it still works, and resend the patch please?
I will do that and send a new patch.
prev parent reply other threads:[~2017-10-18 7:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 11:14 [PATCH] bmap-tools: add missing runtime dependencies Pascal Bach
2017-10-14 6:11 ` Tim Orling
2017-10-16 10:27 ` Alexander Kanavin
2017-10-18 7:17 ` Pascal Bach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fc90bb8-6a8c-def4-3811-c8d2ad797352@siemens.com \
--to=pascal.bach@siemens.com \
--cc=alexander.kanavin@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=timothy.t.orling@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.