All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] bmap-tools: add missing runtime dependencies
@ 2017-10-13 11:14 Pascal Bach
  2017-10-14  6:11 ` Tim Orling
  0 siblings, 1 reply; 4+ messages in thread
From: Pascal Bach @ 2017-10-13 11:14 UTC (permalink / raw)
  To: openembedded-core

When running bmap on a target device the added dependncies are required.

Signed-off-by: Pascal Bach <pascal.bach@siemens.com>
---
 meta/recipes-support/bmap-tools/bmap-tools_3.4.bb | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-support/bmap-tools/bmap-tools_3.4.bb b/meta/recipes-support/bmap-tools/bmap-tools_3.4.bb
index 7454f9d..348c9e8 100644
--- a/meta/recipes-support/bmap-tools/bmap-tools_3.4.bb
+++ b/meta/recipes-support/bmap-tools/bmap-tools_3.4.bb
@@ -14,7 +14,17 @@ SRCREV = "9dad724104df265442226972a1e310813f9ffcba"
 
 S = "${WORKDIR}/git"
 
-RDEPENDS_${PN} = "python-core python-compression python-mmap"
+RDEPENDS_${PN} = "\
+    python-core \
+    python-compression \
+    python-argparse \
+    python-shell \
+    python-fcntl \
+    python-threading \
+    python-xml \
+    python-subprocess \
+    python-mmap \
+    "
 
 inherit python3native
 inherit setuptools3
-- 
2.1.4



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] bmap-tools: add missing runtime dependencies
  2017-10-13 11:14 [PATCH] bmap-tools: add missing runtime dependencies Pascal Bach
@ 2017-10-14  6:11 ` Tim Orling
  2017-10-16 10:27   ` Alexander Kanavin
  0 siblings, 1 reply; 4+ messages in thread
From: Tim Orling @ 2017-10-14  6:11 UTC (permalink / raw)
  To: Pascal Bach; +Cc: openembedded-core


> On Oct 13, 2017, at 4:14 AM, Pascal Bach <pascal.bach@siemens.com> wrote:
> 
> When running bmap on a target device the added dependncies are required.
> 
> Signed-off-by: Pascal Bach <pascal.bach@siemens.com>
> ---
> meta/recipes-support/bmap-tools/bmap-tools_3.4.bb | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-support/bmap-tools/bmap-tools_3.4.bb b/meta/recipes-support/bmap-tools/bmap-tools_3.4.bb
> index 7454f9d..348c9e8 100644
> --- a/meta/recipes-support/bmap-tools/bmap-tools_3.4.bb
> +++ b/meta/recipes-support/bmap-tools/bmap-tools_3.4.bb
> @@ -14,7 +14,17 @@ SRCREV = "9dad724104df265442226972a1e310813f9ffcba"
> 
> S = "${WORKDIR}/git"
> 
> -RDEPENDS_${PN} = "python-core python-compression python-mmap"
> +RDEPENDS_${PN} = "\
> +    python-core \
> +    python-compression \
> +    python-argparse \
> +    python-shell \
> +    python-fcntl \
> +    python-threading \
> +    python-xml \
> +    python-subprocess \
> +    python-mmap \
> +    “
> 

These should all be the python3- version or ${PYTHON_PN}- (e.g. python3-core) should they not? Or is that an artifact of how the python module splitting is happening in oe-core?

> inherit python3native
> inherit setuptools3
> -- 
> 2.1.4
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] bmap-tools: add missing runtime dependencies
  2017-10-14  6:11 ` Tim Orling
@ 2017-10-16 10:27   ` Alexander Kanavin
  2017-10-18  7:17     ` Pascal Bach
  0 siblings, 1 reply; 4+ messages in thread
From: Alexander Kanavin @ 2017-10-16 10:27 UTC (permalink / raw)
  To: Tim Orling, Pascal Bach; +Cc: openembedded-core

On 10/14/2017 09:11 AM, Tim Orling wrote:
> 
>> On Oct 13, 2017, at 4:14 AM, Pascal Bach <pascal.bach@siemens.com> wrote:
>>
>> When running bmap on a target device the added dependncies are required.
>>
>> Signed-off-by: Pascal Bach <pascal.bach@siemens.com>
>> ---
>> meta/recipes-support/bmap-tools/bmap-tools_3.4.bb | 12 +++++++++++-
>> 1 file changed, 11 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-support/bmap-tools/bmap-tools_3.4.bb b/meta/recipes-support/bmap-tools/bmap-tools_3.4.bb
>> index 7454f9d..348c9e8 100644
>> --- a/meta/recipes-support/bmap-tools/bmap-tools_3.4.bb
>> +++ b/meta/recipes-support/bmap-tools/bmap-tools_3.4.bb
>> @@ -14,7 +14,17 @@ SRCREV = "9dad724104df265442226972a1e310813f9ffcba"
>>
>> S = "${WORKDIR}/git"
>>
>> -RDEPENDS_${PN} = "python-core python-compression python-mmap"
>> +RDEPENDS_${PN} = "\
>> +    python-core \
>> +    python-compression \
>> +    python-argparse \
>> +    python-shell \
>> +    python-fcntl \
>> +    python-threading \
>> +    python-xml \
>> +    python-subprocess \
>> +    python-mmap \
>> +    “
>>
> 
> These should all be the python3- version or ${PYTHON_PN}- (e.g. python3-core) should they not? Or is that an artifact of how the python module splitting is happening in oe-core?

That is correct. This was forgotten when the recipe was moved to python3:
http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/meta/recipes-support/bmap-tools/bmap-tools_3.4.bb?id=04ef46e2b2b753321408db02a2df3753b85ac0dd

Pascal, can you modify everything to python3-*, check that it still 
works, and resend the patch please?

Alex


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] bmap-tools: add missing runtime dependencies
  2017-10-16 10:27   ` Alexander Kanavin
@ 2017-10-18  7:17     ` Pascal Bach
  0 siblings, 0 replies; 4+ messages in thread
From: Pascal Bach @ 2017-10-18  7:17 UTC (permalink / raw)
  To: Alexander Kanavin, Tim Orling; +Cc: openembedded-core

On 16.10.2017 12:27, Alexander Kanavin wrote:
> On 10/14/2017 09:11 AM, Tim Orling wrote:
>>
>>> On Oct 13, 2017, at 4:14 AM, Pascal Bach <pascal.bach@siemens.com> wrote:
>>>
>>> When running bmap on a target device the added dependncies are required.
>>>
>>> Signed-off-by: Pascal Bach <pascal.bach@siemens.com>
>>> ---
>>> meta/recipes-support/bmap-tools/bmap-tools_3.4.bb | 12 +++++++++++-
>>> 1 file changed, 11 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/meta/recipes-support/bmap-tools/bmap-tools_3.4.bb b/meta/recipes-support/bmap-tools/bmap-tools_3.4.bb
>>> index 7454f9d..348c9e8 100644
>>> --- a/meta/recipes-support/bmap-tools/bmap-tools_3.4.bb
>>> +++ b/meta/recipes-support/bmap-tools/bmap-tools_3.4.bb
>>> @@ -14,7 +14,17 @@ SRCREV = "9dad724104df265442226972a1e310813f9ffcba"
>>>
>>> S = "${WORKDIR}/git"
>>>
>>> -RDEPENDS_${PN} = "python-core python-compression python-mmap"
>>> +RDEPENDS_${PN} = "\
>>> +    python-core \
>>> +    python-compression \
>>> +    python-argparse \
>>> +    python-shell \
>>> +    python-fcntl \
>>> +    python-threading \
>>> +    python-xml \
>>> +    python-subprocess \
>>> +    python-mmap \
>>> +    “
>>>
>>
>> These should all be the python3- version or ${PYTHON_PN}- (e.g. python3-core) should they not? Or is that an artifact of how the python module splitting is happening in oe-core?
>
> That is correct. This was forgotten when the recipe was moved to python3:
> http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/meta/recipes-support/bmap-tools/bmap-tools_3.4.bb?id=04ef46e2b2b753321408db02a2df3753b85ac0dd
>
> Pascal, can you modify everything to python3-*, check that it still works, and resend the patch please?

I will do that and send a new patch.



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-10-18  7:17 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-13 11:14 [PATCH] bmap-tools: add missing runtime dependencies Pascal Bach
2017-10-14  6:11 ` Tim Orling
2017-10-16 10:27   ` Alexander Kanavin
2017-10-18  7:17     ` Pascal Bach

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.