* [MPTCP] Re: [PATCH v2 0/4] mptcp: switch mptcp_poll to use parent sock wait queue
@ 2019-10-23 15:07 Paolo Abeni
0 siblings, 0 replies; 6+ messages in thread
From: Paolo Abeni @ 2019-10-23 15:07 UTC (permalink / raw)
To: mptcp
[-- Attachment #1: Type: text/plain, Size: 1741 bytes --]
On Wed, 2019-10-23 at 16:23 +0200, Florian Westphal wrote:
> No major changes, except the rebase on current export branch.
> Selftest still passes.
>
> This series is needed for sendmsg refactor, without it we can't
> make mptcp sendmsg wait on the mptcp socket wait queue because we don't
> get the needed wakeup events from the subflow layer.
>
> The following changes since commit 85c93de446d3fd90e47605ba8ff161bef7558f09:
>
> mptcp: Implement basic path manager (2019-10-23 01:31:04 +0000)
>
> are available in the Git repository at:
>
> git://git.breakpoint.cc/fw/mptcp-next.git mptcp_poll_07
>
> for you to fetch changes up to 864dd47df1293e4b8bfc70be0d459286b6dddc3a:
>
> mptcp: switch mptcp_poll to mptcp socket wait queue (2019-10-23 15:20:28 +0200)
>
> ----------------------------------------------------------------
> Florian Westphal (4):
> mptcp: add and use subflow_write_space
> subflow: wake parent mptcp socket on subflow state change
> net: tcp: add __tcp_poll helper
> mptcp: switch mptcp_poll to mptcp socket wait queue
>
> include/net/tcp.h | 1 +
> net/ipv4/tcp.c | 12 ++++++++----
> net/mptcp/protocol.c | 4 +++-
> net/mptcp/subflow.c | 34 ++++++++++++++++++++++++++++++++++
> 4 files changed, 46 insertions(+), 5 deletions(-)
>
> _______________________________________________
> mptcp mailing list -- mptcp(a)lists.01.org
> To unsubscribe send an email to mptcp-leave(a)lists.01.org
Series LGTM
I think we could include patch 3/4 in the "first chunk"/preparatory
patches - e.g. apply just after "tcp, ulp: Add clone operation to
tcp_ulp_ops" - and squash 4/4 in "mptcp: add mptcp_poll"
WDYT?
Thanks,
Paolo
^ permalink raw reply [flat|nested] 6+ messages in thread
* [MPTCP] Re: [PATCH v2 0/4] mptcp: switch mptcp_poll to use parent sock wait queue
@ 2019-10-25 15:55 Matthieu Baerts
0 siblings, 0 replies; 6+ messages in thread
From: Matthieu Baerts @ 2019-10-25 15:55 UTC (permalink / raw)
To: mptcp
[-- Attachment #1: Type: text/plain, Size: 1615 bytes --]
Hi Florian,
On 25/10/2019 17:34, Florian Westphal wrote:
> Matthieu Baerts <matthieu.baerts(a)tessares.net> wrote:
>>>>
>>>> I think we could include patch 3/4 in the "first chunk"/preparatory
>>>> patches - e.g. apply just after "tcp, ulp: Add clone operation to
>>>> tcp_ulp_ops" - and squash 4/4 in "mptcp: add mptcp_poll"
>>>>
>>>> WDYT?
>>>
>>> Seems good, yes.
>>
>> Where can I apply patch 1/4 and 2/4? At the end?
>
> 1 could probably be squashed with "mptcp: Implement MPTCP receive path",
> given that patch adds sk_data_ready for subflows.
>
> Patch 2 I'd add at the end, we might be able to revert it eventually.
Thank you for the patches and the quick reply!
And thank you Paolo and Mat for the reviews!
- af383a1b6937: "squashed" patch 1/4 in "mptcp: Implement MPTCP receive
path"
- 8e678a61f7b7: "Signed-off-by" + "Co-developed-by"
- 77cf55a4b1f1: conflict in
t/mptcp-Add-handling-of-outgoing-MP_JOIN-requests
- 789fc73cc101..c9ae282e1e87: result
- f0d0353bc148: patch 2 added at the end
- c9ae282e1e87..590467e30328: result
- 67590165a990: patch 3 added between "tcp, ulp: Add clone operation to
tcp_ulp_ops" and "mptcp: Add MPTCP to skb extensions"
- 590467e30328..555678057b0c: result
- b52d7b74d906: "squashed" patch 4/4 in "mptcp: add mptcp_poll"
- 555678057b0c..460e610b3ca4: result
Tests are in progress, verifying that each commit can still compile.
Cheers,
Matt
--
Matthieu Baerts | R&D Engineer
matthieu.baerts(a)tessares.net
Tessares SA | Hybrid Access Solutions
www.tessares.net
1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium
^ permalink raw reply [flat|nested] 6+ messages in thread
* [MPTCP] Re: [PATCH v2 0/4] mptcp: switch mptcp_poll to use parent sock wait queue
@ 2019-10-25 15:34 Florian Westphal
0 siblings, 0 replies; 6+ messages in thread
From: Florian Westphal @ 2019-10-25 15:34 UTC (permalink / raw)
To: mptcp
[-- Attachment #1: Type: text/plain, Size: 580 bytes --]
Matthieu Baerts <matthieu.baerts(a)tessares.net> wrote:
> > >
> > > I think we could include patch 3/4 in the "first chunk"/preparatory
> > > patches - e.g. apply just after "tcp, ulp: Add clone operation to
> > > tcp_ulp_ops" - and squash 4/4 in "mptcp: add mptcp_poll"
> > >
> > > WDYT?
> >
> > Seems good, yes.
>
> Where can I apply patch 1/4 and 2/4? At the end?
1 could probably be squashed with "mptcp: Implement MPTCP receive path",
given that patch adds sk_data_ready for subflows.
Patch 2 I'd add at the end, we might be able to revert it eventually.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [MPTCP] Re: [PATCH v2 0/4] mptcp: switch mptcp_poll to use parent sock wait queue
@ 2019-10-25 15:26 Matthieu Baerts
0 siblings, 0 replies; 6+ messages in thread
From: Matthieu Baerts @ 2019-10-25 15:26 UTC (permalink / raw)
To: mptcp
[-- Attachment #1: Type: text/plain, Size: 2200 bytes --]
Hi Paolo, Florian,
On 23/10/2019 17:42, Florian Westphal wrote:
> Paolo Abeni <pabeni(a)redhat.com> wrote:
>> On Wed, 2019-10-23 at 16:23 +0200, Florian Westphal wrote:
>>> No major changes, except the rebase on current export branch.
>>> Selftest still passes.
>>>
>>> This series is needed for sendmsg refactor, without it we can't
>>> make mptcp sendmsg wait on the mptcp socket wait queue because we don't
>>> get the needed wakeup events from the subflow layer.
>>>
>>> The following changes since commit 85c93de446d3fd90e47605ba8ff161bef7558f09:
>>>
>>> mptcp: Implement basic path manager (2019-10-23 01:31:04 +0000)
>>>
>>> are available in the Git repository at:
>>>
>>> git://git.breakpoint.cc/fw/mptcp-next.git mptcp_poll_07
>>>
>>> for you to fetch changes up to 864dd47df1293e4b8bfc70be0d459286b6dddc3a:
>>>
>>> mptcp: switch mptcp_poll to mptcp socket wait queue (2019-10-23 15:20:28 +0200)
>>>
>>> ----------------------------------------------------------------
>>> Florian Westphal (4):
>>> mptcp: add and use subflow_write_space
>>> subflow: wake parent mptcp socket on subflow state change
>>> net: tcp: add __tcp_poll helper
>>> mptcp: switch mptcp_poll to mptcp socket wait queue
>>>
>>> include/net/tcp.h | 1 +
>>> net/ipv4/tcp.c | 12 ++++++++----
>>> net/mptcp/protocol.c | 4 +++-
>>> net/mptcp/subflow.c | 34 ++++++++++++++++++++++++++++++++++
>>> 4 files changed, 46 insertions(+), 5 deletions(-)
>>>
>>> _______________________________________________
>>> mptcp mailing list -- mptcp(a)lists.01.org
>>> To unsubscribe send an email to mptcp-leave(a)lists.01.org
>>
>> Series LGTM
>>
>> I think we could include patch 3/4 in the "first chunk"/preparatory
>> patches - e.g. apply just after "tcp, ulp: Add clone operation to
>> tcp_ulp_ops" - and squash 4/4 in "mptcp: add mptcp_poll"
>>
>> WDYT?
>
> Seems good, yes.
Where can I apply patch 1/4 and 2/4? At the end?
Cheers,
Matt
--
Matthieu Baerts | R&D Engineer
matthieu.baerts(a)tessares.net
Tessares SA | Hybrid Access Solutions
www.tessares.net
1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium
^ permalink raw reply [flat|nested] 6+ messages in thread
* [MPTCP] Re: [PATCH v2 0/4] mptcp: switch mptcp_poll to use parent sock wait queue
@ 2019-10-23 22:01 Mat Martineau
0 siblings, 0 replies; 6+ messages in thread
From: Mat Martineau @ 2019-10-23 22:01 UTC (permalink / raw)
To: mptcp
[-- Attachment #1: Type: text/plain, Size: 1390 bytes --]
On Wed, 23 Oct 2019, Florian Westphal wrote:
> No major changes, except the rebase on current export branch.
> Selftest still passes.
>
> This series is needed for sendmsg refactor, without it we can't
> make mptcp sendmsg wait on the mptcp socket wait queue because we don't
> get the needed wakeup events from the subflow layer.
>
> The following changes since commit 85c93de446d3fd90e47605ba8ff161bef7558f09:
>
> mptcp: Implement basic path manager (2019-10-23 01:31:04 +0000)
>
> are available in the Git repository at:
>
> git://git.breakpoint.cc/fw/mptcp-next.git mptcp_poll_07
>
> for you to fetch changes up to 864dd47df1293e4b8bfc70be0d459286b6dddc3a:
>
> mptcp: switch mptcp_poll to mptcp socket wait queue (2019-10-23 15:20:28 +0200)
>
> ----------------------------------------------------------------
> Florian Westphal (4):
> mptcp: add and use subflow_write_space
> subflow: wake parent mptcp socket on subflow state change
> net: tcp: add __tcp_poll helper
> mptcp: switch mptcp_poll to mptcp socket wait queue
>
> include/net/tcp.h | 1 +
> net/ipv4/tcp.c | 12 ++++++++----
> net/mptcp/protocol.c | 4 +++-
> net/mptcp/subflow.c | 34 ++++++++++++++++++++++++++++++++++
> 4 files changed, 46 insertions(+), 5 deletions(-)
>
This series looks ready to merge. Thanks, Florian!
--
Mat Martineau
Intel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [MPTCP] Re: [PATCH v2 0/4] mptcp: switch mptcp_poll to use parent sock wait queue
@ 2019-10-23 15:42 Florian Westphal
0 siblings, 0 replies; 6+ messages in thread
From: Florian Westphal @ 2019-10-23 15:42 UTC (permalink / raw)
To: mptcp
[-- Attachment #1: Type: text/plain, Size: 1869 bytes --]
Paolo Abeni <pabeni(a)redhat.com> wrote:
> On Wed, 2019-10-23 at 16:23 +0200, Florian Westphal wrote:
> > No major changes, except the rebase on current export branch.
> > Selftest still passes.
> >
> > This series is needed for sendmsg refactor, without it we can't
> > make mptcp sendmsg wait on the mptcp socket wait queue because we don't
> > get the needed wakeup events from the subflow layer.
> >
> > The following changes since commit 85c93de446d3fd90e47605ba8ff161bef7558f09:
> >
> > mptcp: Implement basic path manager (2019-10-23 01:31:04 +0000)
> >
> > are available in the Git repository at:
> >
> > git://git.breakpoint.cc/fw/mptcp-next.git mptcp_poll_07
> >
> > for you to fetch changes up to 864dd47df1293e4b8bfc70be0d459286b6dddc3a:
> >
> > mptcp: switch mptcp_poll to mptcp socket wait queue (2019-10-23 15:20:28 +0200)
> >
> > ----------------------------------------------------------------
> > Florian Westphal (4):
> > mptcp: add and use subflow_write_space
> > subflow: wake parent mptcp socket on subflow state change
> > net: tcp: add __tcp_poll helper
> > mptcp: switch mptcp_poll to mptcp socket wait queue
> >
> > include/net/tcp.h | 1 +
> > net/ipv4/tcp.c | 12 ++++++++----
> > net/mptcp/protocol.c | 4 +++-
> > net/mptcp/subflow.c | 34 ++++++++++++++++++++++++++++++++++
> > 4 files changed, 46 insertions(+), 5 deletions(-)
> >
> > _______________________________________________
> > mptcp mailing list -- mptcp(a)lists.01.org
> > To unsubscribe send an email to mptcp-leave(a)lists.01.org
>
> Series LGTM
>
> I think we could include patch 3/4 in the "first chunk"/preparatory
> patches - e.g. apply just after "tcp, ulp: Add clone operation to
> tcp_ulp_ops" - and squash 4/4 in "mptcp: add mptcp_poll"
>
> WDYT?
Seems good, yes.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-10-25 15:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-23 15:07 [MPTCP] Re: [PATCH v2 0/4] mptcp: switch mptcp_poll to use parent sock wait queue Paolo Abeni
2019-10-23 15:42 Florian Westphal
2019-10-23 22:01 Mat Martineau
2019-10-25 15:26 Matthieu Baerts
2019-10-25 15:34 Florian Westphal
2019-10-25 15:55 Matthieu Baerts
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.