All of lore.kernel.org
 help / color / mirror / Atom feed
From: Qu Wenruo <wqu@suse.de>
To: dsterba@suse.cz, Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 0/6] btrfs: qgroup: Delay subtree scan to reduce overhead
Date: Fri, 19 Oct 2018 21:47:24 +0800	[thread overview]
Message-ID: <9fd0eec9-10b2-d81c-3c9d-99213fb6f9d7@suse.de> (raw)
In-Reply-To: <20181019134230.GH16290@twin.jikos.cz>


[-- Attachment #1.1: Type: text/plain, Size: 1442 bytes --]



On 2018/10/19 下午9:42, David Sterba wrote:
> On Thu, Oct 18, 2018 at 07:17:23PM +0800, Qu Wenruo wrote:
>> This patchset can be fetched from github:
>> https://github.com/adam900710/linux/tree/qgroup_balance_skip_trees
>>
>> Which is still based on v4.19-rc1, but with previous submitted patches
>> as dependency.
> 
> Please rebase this patchset on top of misc-4.20, this should not change
> as it's going to be the 1st pull.
> 
> I tried to pull the git branch and rebase but there were several
> conflicts and some of the paches appeared duplicated so the rebase did
> not recognize the changes as identical.

Yes, the branch has submitted qgroup patches as dependency, and it's
still based on v4.19-rc1, so conflicts are expected.

> 
> Applying patches from mails causes other sort of conflicts and I can't
> seem to get a compilable version.

I'll look into it.

> 
> This is not urgent as I want to put the patchset to a topic branch and
> give it some testing before it goes to for-next. Thanks.

OK, however this patchset may still need extra polish, especially for
the 2nd patch.
As you can see in the benchmark part, it reduces nearly half of dirty
qgroup extents but only cuts about 25% relocation time, that's mostly
caused by that 2nd patch, and that 2nd patch could impact balance
performance even for quota disabled case.

So I'm not eager to push it soon either.

Thanks,
Qu



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2018-10-19 13:47 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-18 11:17 [PATCH 0/6] btrfs: qgroup: Delay subtree scan to reduce overhead Qu Wenruo
2018-10-18 11:17 ` [PATCH 1/6] btrfs: qgroup: Allow btrfs_qgroup_extent_record::old_roots unpopulated at insert time Qu Wenruo
2018-10-18 11:17 ` [PATCH 2/6] btrfs: relocation: Commit transaction before dropping btrfs_root::reloc_root Qu Wenruo
2018-10-18 11:17 ` [PATCH 3/6] btrfs: qgroup: Refactor btrfs_qgroup_trace_subtree_swap() Qu Wenruo
2018-10-18 11:17 ` [PATCH 4/6] btrfs: qgroup: Introduce per-root swapped blocks infrastructure Qu Wenruo
2018-10-18 16:20   ` David Sterba
2018-10-18 23:29     ` Qu Wenruo
2018-10-19  9:15       ` David Sterba
2018-10-19  9:46         ` Qu Wenruo
2018-10-19 10:04           ` David Sterba
2018-10-19 13:03             ` Qu Wenruo
2018-10-18 11:17 ` [PATCH 5/6] btrfs: qgroup: Use delayed subtree rescan for balance Qu Wenruo
2018-10-19 13:12   ` David Sterba
2018-10-19 13:19     ` David Sterba
2018-10-18 11:17 ` [PATCH 6/6] btrfs: qgroup: Cleanup old subtree swap code Qu Wenruo
2018-10-19 13:42 ` [PATCH 0/6] btrfs: qgroup: Delay subtree scan to reduce overhead David Sterba
2018-10-19 13:47   ` Qu Wenruo [this message]
2018-10-19 14:51   ` Qu Wenruo
2018-10-19 14:54     ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9fd0eec9-10b2-d81c-3c9d-99213fb6f9d7@suse.de \
    --to=wqu@suse.de \
    --cc=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.